Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-05-01T10:50:58Z

Nkapadi: /* Test Plan */

''' Regulate changing of rubrics while projects are in progress '''

Expertiza is a web application through which students can submit and peer-review learning objects (articles, code, web sites, etc). It consists of multiple features, one such feature is the ability to setup an assignment by an instructor. While setting up an assignment, the instructor would be asked to choose different kinds of rubrics. Any of these rubrics can later be edited or changed to a different rubric. A problem arises when an assignment is underway (students have already started reviewing) and a rubric is edited or changed. Some students who had started reviewing with the old rubric are not notified of the change. Only the rest of the students who had not started a review will be presented with the updated rubric.

The goal of this project is two-fold:

1. If a rubric is replaced, or the items/questions are changed, then all the responses to that rubric need to be redone.

2. The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

However, if the change does not involve an addition/deletion of questions, it is termed as a minor change. If the change is deemed as a minor change, the refactoring should not make any changes to the current implementation

=='''Setting up and Building the Project'''==
Follow the Guidelines mentioned in the [https://github.com/expertiza/expertiza/blob/master/README.md read me] page of the project's Wiki Page for building the Project in a Local Environment.

=='''Project Description'''==
===Current Scenario===
Currently, when an instructor updates a questionnaire rubric of an ongoing assignment, the reviews are not reset and moreover, no notifications are sent to reviewers to update them of the changes made. As of status quo, the instructor, post making changes, would have to individually inform each reviewer of the changes made and ask them to change the reviews accordingly.

===Expected Solution===
The project aims to resolve the two main issue arising from the problems mentioned above:

* If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone
* The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

Further descriptions about how the project will be implemented and what files will be changed are mentioned in subsequent sections.

=='''Design Diagrams'''==
===Use case Diagram===

[[File:UseCase_rubric.png|Use Case Diagram]]

===Data Flow Diagram===

[[File:dfd_4.png]]

The main function of the code is to change the rubric questionnaire. There are three main functions to change the rubric of a questionnaire: add, remove or edit questions. Editing a question is considered a minor change as it does not change the general format(i.e. number of questions or their types) of the rubric. The two major changes are highlighted, they are adding or removing a question.

In case of a minor change the question in the database is simply updated, no other action/notification is required.

In case of a major change, the reviews given for that question need to be deleted in case the question has been removed and the consequent changes need to be relayed to the appropriate databases. Moreover, the reviewers, whose reviews have been removed, need to be informed about the changes made and be asked to update the reviews via email. The email-ids for these users have to be queried from the Users database.

=='''Proposed Solution'''==
The solution is divided into 2 phases viz. Identification of edit and Notification.

===Identification of edit===
The primary metric for identification of a major change is when the ids of questions associated to a questionnaire change.
When a rubric is submitted after an edit, the update method is called. The current rubric is made such that the question type (Radio/Checkbox/True or False) is not editable, however, the wording of the question can be edited. As per the definition of a major change, it is obvious that there is no change in the question ids(records/objects) associated with the questionnaire. Hence this would be a minor change.

The questions can be deleted and/or added. We term an edit as major edit if the change involves addition or deletion of a question because it entails a change in the objects associated with the questionnaire. The params passed to the controller also includes a tag/identifier if a new question was added. We are using this tag to identify there was a new question added and hence major change.
[[File:edit_questionnaire_page.png|Edit questionnaire page]]
In the diagram shown above, the "Save teammate review questionnaire" would result in a minor change. Clicking on the highlighted add and remove would result in a change of the questions and is therefore a major change.

===E-mail Notification===
Once this solution finds that the rubric has major edits and there exists some user who has started the response (corresponding records exist), email notification module is initiated. In this phase, these records are pulled from the ActiveRecord and sent to the user through email. Once the email is sent successfully, records are deleted from the DB.

At this stage, the user has all the details already added by them and when they click on "Review", the questions now correspond to the new rubric. This lets the user respond to the new rubric without losing data for any question. One of the motives behind sending these responses as email is that the first few questions in the review may be similar across rubrics and the user may re-use the same responses when prompted with the new rubric.

=='''Code Changes'''==
Firstly, we need to check if there has been a change in the questionnaire, i.e if any question has been added or deleted. For this we use the tags in the params. The view has been coded such that it adds a tag called ":add_new_questions" whenever there is a post method to add a new question. We have used this tag to identify a major change and redirected to necessary helper methods. This is indicated in the image below:

[[File:new_question_added.jpg|identification of major change]]

Similarly, we have identified when a question is deleted and redirected again to helper methods.

The next step, is to look iterate through answers database and group the answers for the edited questionnaire per user/reviewer. The below UML diagram would assist in understanding the flow of information and the relation between the models.

[[File:UML_diagram.png|UML diagram showing the relationship between necessary models]]

Please note that FK stands for foreign key in the above diagram.

Using the question ids returned from view, we obtained the response id from the answer database. We tracked this response id through the response, response_map and user models to arrive at the user id. This has been achieved using the code shown below:

[[File:reviewer_answer_mapping.jpg|grouping of answers per reviewer]]

Once we have identified the answers, user mail id and other associated information, this has to be mailed to the user and then the records deleted. This has been achieved using the code shown below:

[[File:mailer_function.jpg|Mailer function and deleting of associated records]]

=='''Test Plan'''==
The current rspec file describes various contexts for testing such as adding new questions if attributes weren't correctly entered etc. As stated in the earlier sections, the update method of the questionnaire controller would be edited to identify major changes and trigger emails and deletions of records of responses. A context corresponding to this in the spec file for questionnaire controller under the describe block for update would be added.

Currently, we have added two tests:
#To verify whether a new question has been added or not and check whether the corresponding answers in the questionnaire have been appropriately deleted.
#To verify whether a question has been deleted or not and check whether the corresponding answers in the questionnaire have been appropriately deleted.

=='''Team members'''==
1. Aishwarya Tirumala 
2. Nilay Kapadia 
3. Nitin Nataraj Kuncham 
4. Suraj Siddharudh 

=='''References'''==
#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://www.rubyguides.com/2018/07/rspec-tutorial/ rpec tutorial]
#[https://www.stackoverflow.com/ Stackoverflow]

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-05-01T09:04:21Z

Nkapadi: /* Test Plan */

''' Regulate changing of rubrics while projects are in progress '''

Expertiza is a web application through which students can submit and peer-review learning objects (articles, code, web sites, etc). It consists of multiple features, one such feature is the ability to setup an assignment by an instructor. While setting up an assignment, the instructor would be asked to choose different kinds of rubrics. Any of these rubrics can later be edited or changed to a different rubric. A problem arises when an assignment is underway (students have already started reviewing) and a rubric is edited or changed. Some students who had started reviewing with the old rubric are not notified of the change. Only the rest of the students who had not started a review will be presented with the updated rubric.

The goal of this project is two-fold:

1. If a rubric is replaced, or the items/questions are changed, then all the responses to that rubric need to be redone.

2. The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

However, if the change does not involve an addition/deletion of questions, it is termed as a minor change. If the change is deemed as a minor change, the refactoring should not make any changes to the current implementation

=='''Setting up and Building the Project'''==
Follow the Guidelines mentioned in the [https://github.com/expertiza/expertiza/blob/master/README.md read me] page of the project's Wiki Page for building the Project in a Local Environment.

=='''Project Description'''==
===Current Scenario===
Currently, when an instructor updates a questionnaire rubric of an ongoing assignment, the reviews are not reset and moreover, no notifications are sent to reviewers to update them of the changes made. As of status quo, the instructor, post making changes, would have to individually inform each reviewer of the changes made and ask them to change the reviews accordingly.

===Expected Solution===
The project aims to resolve the two main issue arising from the problems mentioned above:

* If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone
* The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

Further descriptions about how the project will be implemented and what files will be changed are mentioned in subsequent sections.

=='''Design Diagrams'''==
===Use case Diagram===

[[File:UseCase_rubric.png|Use Case Diagram]]

===Data Flow Diagram===

[[File:dfd_4.png]]

The main function of the code is to change the rubric questionnaire. There are three main functions to change the rubric of a questionnaire: add, remove or edit questions. Editing a question is considered a minor change as it does not change the general format(i.e. number of questions or their types) of the rubric. The two major changes are highlighted, they are adding or removing a question.

In case of a minor change the question in the database is simply updated, no other action/notification is required.

In case of a major change, the reviews given for that question need to be deleted in case the question has been removed and the consequent changes need to be relayed to the appropriate databases. Moreover, the reviewers, whose reviews have been removed, need to be informed about the changes made and be asked to update the reviews via email. The email-ids for these users have to be queried from the Users database.

=='''Proposed Solution'''==
The solution is divided into 2 phases viz. Identification of edit and Notification.

===Identification of edit===
The primary metric for identification of a major change is when the ids of questions associated to a questionnaire change.
When a rubric is submitted after an edit, the update method is called. The current rubric is made such that the question type (Radio/Checkbox/True or False) is not editable, however, the wording of the question can be edited. As per the definition of a major change, it is obvious that there is no change in the question ids(records/objects) associated with the questionnaire. Hence this would be a minor change.

The questions can be deleted and/or added. We term an edit as major edit if the change involves addition or deletion of a question because it entails a change in the objects associated with the questionnaire. The params passed to the controller also includes a tag/identifier if a new question was added. We are using this tag to identify there was a new question added and hence major change.
[[File:edit_questionnaire_page.png|Edit questionnaire page]]
In the diagram shown above, the "Save teammate review questionnaire" would result in a minor change. Clicking on the highlighted add and remove would result in a change of the questions and is therefore a major change.

===E-mail Notification===
Once this solution finds that the rubric has major edits and there exists some user who has started the response (corresponding records exist), email notification module is initiated. In this phase, these records are pulled from the ActiveRecord and sent to the user through email. Once the email is sent successfully, records are deleted from the DB.

At this stage, the user has all the details already added by them and when they click on "Review", the questions now correspond to the new rubric. This lets the user respond to the new rubric without losing data for any question. One of the motives behind sending these responses as email is that the first few questions in the review may be similar across rubrics and the user may re-use the same responses when prompted with the new rubric.

=='''Code Changes'''==
Firstly, we need to check if there has been a change in the questionnaire, i.e if any question has been added or deleted. For this we use the tags in the params. The view has been coded such that it adds a tag called ":add_new_questions" whenever there is a post method to add a new question. We have used this tag to identify a major change and redirected to necessary helper methods. This is indicated in the image below:

[[File:new_question_added.jpg|identification of major change]]

Similarly, we have identified when a question is deleted and redirected again to helper methods.

The next step, is to look iterate through answers database and group the answers for the edited questionnaire per user/reviewer. The below UML diagram would assist in understanding the flow of information and the relation between the models.

[[File:UML_diagram.png|UML diagram showing the relationship between necessary models]]

Please note that FK stands for foreign key in the above diagram.

Using the question ids returned from view, we obtained the response id from the answer database. We tracked this response id through the response, response_map and user models to arrive at the user id. This has been achieved using the code shown below:

[[File:reviewer_answer_mapping.jpg|grouping of answers per reviewer]]

Once we have identified the answers, user mail id and other associated information, this has to be mailed to the user and then the records deleted. This has been achieved using the code shown below:

[[File:mailer_function.jpg|Mailer function and deleting of associated records]]

=='''Test Plan'''==
The current rspec file describes various contexts for testing such as adding new questions if attributes weren't correctly entered etc. As stated in the earlier sections, the update method of the questionnaire controller would be edited to identify major changes and trigger emails and deletions of records of responses. A context corresponding to this in the spec file for questionnaire controller under the describe block for update would be added.

Currently, we have added a test to verify whether a new question has been added or not and check whether the corresponding answers in the questionnaire have been appropriately deleted.

=='''Team members'''==
1. Aishwarya Tirumala 
2. Nilay Kapadia 
3. Nitin Nataraj Kuncham 
4. Suraj Siddharudh 

=='''References'''==
#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://www.rubyguides.com/2018/07/rspec-tutorial/ rpec tutorial]
#[https://www.stackoverflow.com/ Stackoverflow]

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-05-01T09:04:12Z

Nkapadi: /* Test Plan */

''' Regulate changing of rubrics while projects are in progress '''

Expertiza is a web application through which students can submit and peer-review learning objects (articles, code, web sites, etc). It consists of multiple features, one such feature is the ability to setup an assignment by an instructor. While setting up an assignment, the instructor would be asked to choose different kinds of rubrics. Any of these rubrics can later be edited or changed to a different rubric. A problem arises when an assignment is underway (students have already started reviewing) and a rubric is edited or changed. Some students who had started reviewing with the old rubric are not notified of the change. Only the rest of the students who had not started a review will be presented with the updated rubric.

The goal of this project is two-fold:

1. If a rubric is replaced, or the items/questions are changed, then all the responses to that rubric need to be redone.

2. The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

However, if the change does not involve an addition/deletion of questions, it is termed as a minor change. If the change is deemed as a minor change, the refactoring should not make any changes to the current implementation

=='''Setting up and Building the Project'''==
Follow the Guidelines mentioned in the [https://github.com/expertiza/expertiza/blob/master/README.md read me] page of the project's Wiki Page for building the Project in a Local Environment.

=='''Project Description'''==
===Current Scenario===
Currently, when an instructor updates a questionnaire rubric of an ongoing assignment, the reviews are not reset and moreover, no notifications are sent to reviewers to update them of the changes made. As of status quo, the instructor, post making changes, would have to individually inform each reviewer of the changes made and ask them to change the reviews accordingly.

===Expected Solution===
The project aims to resolve the two main issue arising from the problems mentioned above:

* If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone
* The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

Further descriptions about how the project will be implemented and what files will be changed are mentioned in subsequent sections.

=='''Design Diagrams'''==
===Use case Diagram===

[[File:UseCase_rubric.png|Use Case Diagram]]

===Data Flow Diagram===

[[File:dfd_4.png]]

The main function of the code is to change the rubric questionnaire. There are three main functions to change the rubric of a questionnaire: add, remove or edit questions. Editing a question is considered a minor change as it does not change the general format(i.e. number of questions or their types) of the rubric. The two major changes are highlighted, they are adding or removing a question.

In case of a minor change the question in the database is simply updated, no other action/notification is required.

In case of a major change, the reviews given for that question need to be deleted in case the question has been removed and the consequent changes need to be relayed to the appropriate databases. Moreover, the reviewers, whose reviews have been removed, need to be informed about the changes made and be asked to update the reviews via email. The email-ids for these users have to be queried from the Users database.

=='''Proposed Solution'''==
The solution is divided into 2 phases viz. Identification of edit and Notification.

===Identification of edit===
The primary metric for identification of a major change is when the ids of questions associated to a questionnaire change.
When a rubric is submitted after an edit, the update method is called. The current rubric is made such that the question type (Radio/Checkbox/True or False) is not editable, however, the wording of the question can be edited. As per the definition of a major change, it is obvious that there is no change in the question ids(records/objects) associated with the questionnaire. Hence this would be a minor change.

The questions can be deleted and/or added. We term an edit as major edit if the change involves addition or deletion of a question because it entails a change in the objects associated with the questionnaire. The params passed to the controller also includes a tag/identifier if a new question was added. We are using this tag to identify there was a new question added and hence major change.
[[File:edit_questionnaire_page.png|Edit questionnaire page]]
In the diagram shown above, the "Save teammate review questionnaire" would result in a minor change. Clicking on the highlighted add and remove would result in a change of the questions and is therefore a major change.

===E-mail Notification===
Once this solution finds that the rubric has major edits and there exists some user who has started the response (corresponding records exist), email notification module is initiated. In this phase, these records are pulled from the ActiveRecord and sent to the user through email. Once the email is sent successfully, records are deleted from the DB.

At this stage, the user has all the details already added by them and when they click on "Review", the questions now correspond to the new rubric. This lets the user respond to the new rubric without losing data for any question. One of the motives behind sending these responses as email is that the first few questions in the review may be similar across rubrics and the user may re-use the same responses when prompted with the new rubric.

=='''Code Changes'''==
Firstly, we need to check if there has been a change in the questionnaire, i.e if any question has been added or deleted. For this we use the tags in the params. The view has been coded such that it adds a tag called ":add_new_questions" whenever there is a post method to add a new question. We have used this tag to identify a major change and redirected to necessary helper methods. This is indicated in the image below:

[[File:new_question_added.jpg|identification of major change]]

Similarly, we have identified when a question is deleted and redirected again to helper methods.

The next step, is to look iterate through answers database and group the answers for the edited questionnaire per user/reviewer. The below UML diagram would assist in understanding the flow of information and the relation between the models.

[[File:UML_diagram.png|UML diagram showing the relationship between necessary models]]

Please note that FK stands for foreign key in the above diagram.

Using the question ids returned from view, we obtained the response id from the answer database. We tracked this response id through the response, response_map and user models to arrive at the user id. This has been achieved using the code shown below:

[[File:reviewer_answer_mapping.jpg|grouping of answers per reviewer]]

Once we have identified the answers, user mail id and other associated information, this has to be mailed to the user and then the records deleted. This has been achieved using the code shown below:

[[File:mailer_function.jpg|Mailer function and deleting of associated records]]

=='''Test Plan'''==
The current rspec file describes various contexts for testing such as adding new questions if attributes weren't correctly entered etc. As stated in the earlier sections, the update method of the questionnaire controller would be edited to identify major changes and trigger emails and deletions of records of responses. A context corresponding to this in the spec file for questionnaire controller under the describe block for update would be added.

#Currently, we have added a test to verify whether a new question has been added or not and check whether the corresponding answers in the questionnaire have been appropriately deleted.

=='''Team members'''==
1. Aishwarya Tirumala 
2. Nilay Kapadia 
3. Nitin Nataraj Kuncham 
4. Suraj Siddharudh 

=='''References'''==
#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://www.rubyguides.com/2018/07/rspec-tutorial/ rpec tutorial]
#[https://www.stackoverflow.com/ Stackoverflow]

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-04-13T00:49:12Z

Nkapadi: /* Data Flow Diagram */

''' Regulate changing of rubrics while projects are in progress '''

Expertiza is a web application through which students can submit and peer-review learning objects (articles, code, web sites, etc). It consists of multiple features, one such feature is the ability to setup an assignment by an instructor. While setting up an assignment, the instructor would be asked to choose different kinds of rubrics. Any of these rubrics can later be edited or changed to a different rubric. A problem arises when an assignment is underway (students have already started reviewing) and a rubric is edited or changed. Some students started reviewing with the old rubric and the rest of the students who had not started a review will be presented with the updated rubric. This usually happens when an assignment is copied from a previous year and the rubrics are not updated to match the current topic. It could be at a later point that the instructor/TA realizes this and changes it. The goal of this project is two-fold: One, If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone and two, the system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects. If the change does not involve an addition/deletion of questions, it is termed as a minor change. If the change is deemed as a minor change, the refactoring should not make any changes to the current implementation

=='''Setting up and Building the Project'''==
Follow the Guidelines mentioned in the [https://github.com/expertiza/expertiza/blob/master/README.md read me] page of the project's Wiki Page for building the Project in a Local Environment.

=='''Project Description'''==
===Current Scenario===
Currently, when an instructor updates a questionnaire rubric of an ongoing assignment, the reviews are not reset and moreover, no notifications are sent to reviewers to update them of the changes made. Moreover, the instructor, post making changes, would have to individually inform each reviewer of the changes made and ask them to change the reviews accordingly.

===Expected Solution===
The project aims to resolve the two main issue arising from the problems mentioned above:

* If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone
* The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

Further descriptions about how the project will be implemented and what files will be changed are mentioned in subsequent sections.

=='''Design Diagrams'''==
===Use case Diagram===

[[File:UseCase_rubric.png|Use Case Diagram]]

===Data Flow Diagram===

[[File:dfd_4.png]]

The main function of the code is to change the rubric questionnaire. There are three main functions to change the rubric of a questionnaire: add, remove or edit questions. Editing a question is considered a minor change as it does not change the general format(i.e. number of questions or their types) of the rubric. The two major changes are highlighted, they are adding or removing a question.

In case of a minor change the question in the database is simply updated, no other action/notification is required.

In case of a major change, the reviews given for that question need to be deleted in case the question has been removed and the consequent changes need to be relayed to the appropriate databases. Moreover, the reviewers, whose reviews have been removed, need to be informed about the changes made and be asked to update the reviews via email. The email-ids for these users have to be queried from the Users database.

=='''Proposed Solution'''==
The solution is divided into 2 phases viz. Identification of edit and Notification.

===Identification of edit===
When a rubric is submitted after an edit, the update method is called. The current rubric is made such that the question type (Radio/Checkbox/True or False) is not editable, however, the wording of the question can be edited. The questions can be deleted and/or added. We term an edit as major edit if the change involves addition or deletion of a question and a minor edit corresponds to editing any existing questions. The params passed to the controller also includes a tag/identifier if a new question was added. We plan on using this identifier along with the number of questions to identify it the changes made were major or minor.

===E-mail Notification===
Once this solution finds that the rubric has major edits and there exists some user who has started the response (corresponding records exist), email notification module is initiated. In this phase, these records are pulled from the ActiveRecord and sent to the user through email. Once the email is sent successfully, records are deleted from the DB.

At this stage, the user has all the details already added by them and when they click on "Review", the questions now correspond to the new rubric. This lets the user to edit on the new rubric without losing data for any question. One of the motives behind sending these responses as email is that the first few questions in the review may be similar across rubrics and the user may re-use the same responses when prompted with the new rubric.

=='''Proposed Code Changes'''==
Firstly, we need to check if there has been a change in the questionnaire, i.e if any question has been added or deleted. For this we pull out the records from the active database of the questions and compare it with the number of question entries in the view. We get the number of questions from the code snippet as shown below from questionnare_controller.rb.

[[File:code2.png|Code]]

Now, we come across two cases.
In the first scenario, If there is a change in the number of questions we do the necessary changes. We delete all the response objects and answers and mail the changes to the user.

In the second scenario, If there is no change in the number of questions then there can be two possible cases. Either there really has been no change in the questions and we leave it as it is. Else, there has been equal number of additions and deletions and to detect this we check if the parameter add_new_questions is present. If it is, then there has been an update and we again do the required changes as discussed above. We check this through the code snippet below of the update method in questionnare_controller.rb.

[[File:code1.png|Code]]

=='''Test Plan'''==
The current rspec file describes various contexts for testing such as adding new questions if attributes weren't correctly entered etc. As stated in the earlier sections, the update method of the questionnaire controller would be edited to identify major changes and trigger emails and deletions of records of responses. A context corresponding to this in the spec file for questionnaire controller under the describe block for update would be added.

At this moment we are thinking of at least 2 new test cases, both these cases correspond to editing a rubric:
# If there is no new question added and the question id's match with the ones in the record - validate the existence of the record
# If there is a new question added - assert if the email was sent

=='''Team members'''==
1. Aishwarya Tirumala 
2. Nilay Kapadia 
3. Nitin Nataraj Kuncham 
4. Suraj Siddharudh 

=='''References'''==
#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://www.rubyguides.com/2018/07/rspec-tutorial/ rpec tutorial]
#[https://www.stackoverflow.com/ Stackoverflow]

File:Dfd 4.png

2019-04-09T02:33:17Z

Nkapadi: uploaded a new version of "File:Dfd 4.png"

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-04-09T02:32:39Z

Nkapadi: /* Data Flow Diagram */

''' Regulate changing of rubrics while projects are in progress '''

Expertiza is a web application through which students can submit and peer-review learning objects (articles, code, web sites, etc). It consists of multiple features, one such feature is the ability to setup an assignment by an instructor. While setting up an assignment, the instructor would be asked to choose different kinds of rubrics. Any of these rubrics can later be edited or changed to a different rubric. A problem arises when an assignment is underway (students have already started reviewing) and a rubric is edited or changed. Some students started reviewing with the old rubric and the rest of the students who had not started a review will be presented with the updated rubric. This usually happens when an assignment is copied from a previous year and the rubrics are not updated to match the current topic. It could be at a later point that the instructor/TA realizes this and changes it. The goal of this project is two-fold: One, If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone and two, the system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

=='''Setting up and Building the Project'''==
Follow the Guidelines mentioned in the [https://github.com/expertiza/expertiza/blob/master/README.md read me] page of the project's Wiki Page for building the Project in a Local Environment.

=='''Project Description'''==
===Current Scenario===
Currently, when an instructor updates a questionnaire rubric of an ongoing assignment, the reviews are not reset and moreover, no notifications are sent to reviewers to update them of the changes made. Moreover, the instructor, post making changes, would have to individually inform each reviewer of the changes made and ask them to change the reviews accordingly.

===Expected Solution===
The project aims to resolve the two main issue arising from the problems mentioned above:

* If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone
* The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

Further descriptions about how the project will be implemented and what files will be changed are mentioned in subsequent sections.

=='''Design Diagrams'''==
===Use case Diagram===

[[File:UseCase_rubric.png|Use Case Diagram]]

===Data Flow Diagram===

[[File:dfd_4.png]]

=='''Proposed Solution'''==
The solution is divided into 2 phases viz. Identification of edit and Notification.

===Identification of edit===
When a rubric is submitted after an edit, the update method is called. The current rubric is made such that the question type (Radio/Checkbox/True or False) is not editable, however, the wording of the question can be edited. The questions can be deleted and/or added. We term an edit as major edit if the change involves addition or deletion of a question and a minor edit corresponds to editing any existing questions. The params passed to the controller also includes a tag/identifier if a new question was added. We plan on using this identifier along with the number of questions to identify it the changes made were major or minor.

===E-mail Notification===
Once this solution finds that the rubric has major edits and there exists some user who has started the response (corresponding records exist), email notification module is initiated. In this phase, these records are pulled from the ActiveRecord and sent to the user through email. Once the email is sent successfully, records are deleted from the DB.

At this stage, the user has all the details already added by them and when they click on "Review", the questions now correspond to the new rubric. This lets the user to edit on the new rubric without losing data for any question. One of the motives behind sending these responses as email is that the first few questions in the review may be similar across rubrics and the user may re-use the same responses when prompted with the new rubric.

=='''Proposed Code Changes'''==
Firstly, we need to check if there has been a change in the questionnaire, i.e if any question has been added or deleted. For this we pull out the records from the active database of the questions and compare it with the number of question entries in the view. We get the number of questions from the code snippet as shown below from questionnare_controller.rb.

[[File:code2.png|Code]]

Now, we come across two cases.
In the first scenario, If there is a change in the number of questions we do the necessary changes. We delete all the response objects and answers and mail the changes to the user.

In the second scenario, If there is no change in the number of questions then there can be two possible cases. Either there really has been no change in the questions and we leave it as it is. Else, there has been equal number of additions and deletions and to detect this we check if the parameter add_new_questions is present. If it is, then there has been an update and we again do the required changes as discussed above. We check this through the code snippet below of the update method in questionnare_controller.rb.

[[File:code1.png|Code]]

=='''Test Plan'''==
The current rspec file describes various contexts for testing such as adding new questions if attributes weren't correctly entered etc. As stated in the earlier sections, the update method of the questionnaire controller would be edited to identify major changes and trigger emails and deletions of records of responses. A context corresponding to this in the spec file for questionnaire controller under the describe block for update would be added.

At this moment we are thinking of at least 2 new test cases, both these cases correspond to editing a rubric:
# If there is no new question added and the question id's match with the ones in the record - validate the existence of the record
# If there is a new question added - assert if the email was sent

File:Dfd 4.png

2019-04-09T02:32:11Z

Nkapadi:

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-04-09T02:30:02Z

Nkapadi: /* Data Flow Diagram */

''' Regulate changing of rubrics while projects are in progress '''

Expertiza is a web application through which students can submit and peer-review learning objects (articles, code, web sites, etc). It consists of multiple features, one such feature is the ability to setup an assignment by an instructor. While setting up an assignment, the instructor would be asked to choose different kinds of rubrics. Any of these rubrics can later be edited or changed to a different rubric. A problem arises when an assignment is underway (students have already started reviewing) and a rubric is edited or changed. Some students started reviewing with the old rubric and the rest of the students who had not started a review will be presented with the updated rubric. This usually happens when an assignment is copied from a previous year and the rubrics are not updated to match the current topic. It could be at a later point that the instructor/TA realizes this and changes it. The goal of this project is two-fold: One, If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone and two, the system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

=='''Setting up and Building the Project'''==
Follow the Guidelines mentioned in the [https://github.com/expertiza/expertiza/blob/master/README.md read me] page of the project's Wiki Page for building the Project in a Local Environment.

=='''Project Description'''==
===Current Scenario===
Currently, when an instructor updates a questionnaire rubric of an ongoing assignment, the reviews are not reset and moreover, no notifications are sent to reviewers to update them of the changes made. Moreover, the instructor, post making changes, would have to individually inform each reviewer of the changes made and ask them to change the reviews accordingly.

===Expected Solution===
The project aims to resolve the two main issue arising from the problems mentioned above:

* If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone
* The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

Further descriptions about how the project will be implemented and what files will be changed are mentioned in subsequent sections.

=='''Design Diagrams'''==
===Use case Diagram===

[[File:UseCase_rubric.png|Use Case Diagram]]

===Data Flow Diagram===

[[File:dfd_2.png]]

=='''Proposed Solution'''==
The solution is divided into 2 phases viz. Identification of edit and Notification.

===Identification of edit===
When a rubric is submitted after an edit, the update method is called. The current rubric is made such that the question type (Radio/Checkbox/True or False) is not editable, however, the wording of the question can be edited. The questions can be deleted and/or added. We term an edit as major edit if the change involves addition or deletion of a question and a minor edit corresponds to editing any existing questions. The params passed to the controller also includes a tag/identifier if a new question was added. We plan on using this identifier along with the number of questions to identify it the changes made were major or minor.

===E-mail Notification===
Once this solution finds that the rubric has major edits and there exists some user who has started the response (corresponding records exist), email notification module is initiated. In this phase, these records are pulled from the ActiveRecord and sent to the user through email. Once the email is sent successfully, records are deleted from the DB.

At this stage, the user has all the details already added by them and when they click on "Review", the questions now correspond to the new rubric. This lets the user to edit on the new rubric without losing data for any question. One of the motives behind sending these responses as email is that the first few questions in the review may be similar across rubrics and the user may re-use the same responses when prompted with the new rubric.

=='''Proposed Code Changes'''==
Firstly, we need to check if there has been a change in the questionnaire, i.e if any question has been added or deleted. For this we pull out the records from the active database of the questions and compare it with the number of question entries in the view. We get the number of questions from the code snippet as shown below from questionnare_controller.rb.

[[File:code2.png|Code]]

Now, we come across two cases.
In the first scenario, If there is a change in the number of questions we do the necessary changes. We delete all the response objects and answers and mail the changes to the user.

In the second scenario, If there is no change in the number of questions then there can be two possible cases. Either there really has been no change in the questions and we leave it as it is. Else, there has been equal number of additions and deletions and to detect this we check if the parameter add_new_questions is present. If it is, then there has been an update and we again do the required changes as discussed above. We check this through the code snippet below of the update method in questionnare_controller.rb.

[[File:code1.png|Code]]

=='''Test Plan'''==
The current rspec file describes various contexts for testing such as adding new questions if attributes weren't correctly entered etc. As stated in the earlier sections, the update method of the questionnaire controller would be edited to identify major changes and trigger emails and deletions of records of responses. A context corresponding to this in the spec file for questionnaire controller under the describe block for update would be added.

At this moment we are thinking of at least 2 new test cases, both these cases correspond to editing a rubric:
# If there is no new question added and the question id's match with the ones in the record - validate the existence of the record
# If there is a new question added - assert if the email was sent

File:Dfd 2.png

2019-04-09T02:29:33Z

Nkapadi:

File:Dfd.png

2019-04-09T02:27:37Z

Nkapadi:

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-04-09T02:27:24Z

Nkapadi: /* Design Diagrams */

''' Regulate changing of rubrics while projects are in progress '''

Expertiza is a web application through which students can submit and peer-review learning objects (articles, code, web sites, etc). It consists of multiple features, one such feature is the ability to setup an assignment by an instructor. While setting up an assignment, the instructor would be asked to choose different kinds of rubrics. Any of these rubrics can later be edited or changed to a different rubric. A problem arises when an assignment is underway (students have already started reviewing) and a rubric is edited or changed. Some students started reviewing with the old rubric and the rest of the students who had not started a review will be presented with the updated rubric. This usually happens when an assignment is copied from a previous year and the rubrics are not updated to match the current topic. It could be at a later point that the instructor/TA realizes this and changes it. The goal of this project is two-fold: One, If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone and two, the system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

=='''Setting up and Building the Project'''==
Follow the Guidelines mentioned in the [https://github.com/expertiza/expertiza/blob/master/README.md read me] page of the project's Wiki Page for building the Project in a Local Environment.

=='''Project Description'''==
===Current Scenario===
Currently, when an instructor updates a questionnaire rubric of an ongoing assignment, the reviews are not reset and moreover, no notifications are sent to reviewers to update them of the changes made. Moreover, the instructor, post making changes, would have to individually inform each reviewer of the changes made and ask them to change the reviews accordingly.

===Expected Solution===
The project aims to resolve the two main issue arising from the problems mentioned above:

* If a rubric is replaced, or the items/questions are changed, then all the reviews that have been done need to be redone
* The system should then email the previously done reviews to the reviewer and delete the response object and all associated answer objects.

Further descriptions about how the project will be implemented and what files will be changed are mentioned in subsequent sections.

=='''Design Diagrams'''==
===Use case Diagram===

[[File:UseCase_rubric.png|Use Case Diagram]]

===Data Flow Diagram===

=='''Proposed Solution'''==
The solution is divided into 2 phases viz. Identification of edit and Notification.

===Identification of edit===
When a rubric is submitted after an edit, the update method is called. The current rubric is made such that the question type (Radio/Checkbox/True or False) is not editable, however, the wording of the question can be edited. The questions can be deleted and/or added. We term an edit as major edit if the change involves addition or deletion of a question and a minor edit corresponds to editing any existing questions. The params passed to the controller also includes a tag/identifier if a new question was added. We plan on using this identifier along with the number of questions to identify it the changes made were major or minor.

===E-mail Notification===
Once this solution finds that the rubric has major edits and there exists some user who has started the response (corresponding records exist), email notification module is initiated. In this phase, these records are pulled from the ActiveRecord and sent to the user through email. Once the email is sent successfully, records are deleted from the DB.

At this stage, the user has all the details already added by them and when they click on "Review", the questions now correspond to the new rubric. This lets the user to edit on the new rubric without losing data for any question. One of the motives behind sending these responses as email is that the first few questions in the review may be similar across rubrics and the user may re-use the same responses when prompted with the new rubric.

=='''Proposed Code Changes'''==
Firstly, we need to check if there has been a change in the questionnaire, i.e if any question has been added or deleted. For this we pull out the records from the active database of the questions and compare it with the number of question entries in the view. We get the number of questions from the code snippet as shown below from questionnare_controller.rb.

[[File:code2.png|Code]]

Now, we come across two cases.
In the first scenario, If there is a change in the number of questions we do the necessary changes. We delete all the response objects and answers and mail the changes to the user.

In the second scenario, If there is no change in the number of questions then there can be two possible cases. Either there really has been no change in the questions and we leave it as it is. Else, there has been equal number of additions and deletions and to detect this we check if the parameter add_new_questions is present. If it is, then there has been an update and we again do the required changes as discussed above. We check this through the code snippet below of the update method in questionnare_controller.rb.

[[File:code1.png|Code]]

=='''Test Plan'''==
The current rspec file describes various contexts for testing such as adding new questions if attributes weren't correctly entered etc. As stated in the earlier sections, the update method of the questionnaire controller would be edited to identify major changes and trigger emails and deletions of records of responses. A context corresponding to this in the spec file for questionnaire controller under the describe block for update would be added.

At this moment we are thinking of at least 2 new test cases, both these cases correspond to editing a rubric:
# If there is no new question added and the question id's match with the ones in the record - validate the existence of the record
# If there is a new question added - assert if the email was sent

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-04-08T08:21:52Z

Nkapadi:

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-04-08T08:21:21Z

Nkapadi: /* Expected Solution */

CSC/ECE 517 Spring 2019 - Project E1924. Regulate changing of rubrics while projects are in progress

2019-04-08T08:20:32Z

Nkapadi:

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:55:14Z

Nkapadi: /* Implementation */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===
[[File:Time zone and out of condition.png]]

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

[[File:Issue_5.png]]

===Issue - Favor unless over if for negative conditions.===

[[File:Issue_10.png]]

===Issue - Parameters should be whitelisted for mass assignment.===
[[File:Whitelist_and_update_attributes.png]]
=== Avoid using update_attribute because it skips validations===

The method update_attribute will skip validation. Should use update_attributes instead.

[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Line is too long.===
Code climate will complain when a line is too long.

[[File:Line too long.png]]

===Issue - Similar blocks of code found in 3 locations. Consider refactoring===

[[File:Issue_21.png]]

===Issue - User controlled method execution===

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:52:53Z

Nkapadi: /* Implementation */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===
[[File:Time zone and out of condition.png]]

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

[[File:Issue_5.png]]

===Issue - Favor unless over if for negative conditions.===

[[File:Issue_10.png]]

===Issue - Parameters should be whitelisted for mass assignment.===
[[File:Whitelist_and_update_attributes.png]]
=== Avoid using update_attribute because it skips validations===

The method update_attribute will skip validation. Should use update_attributes instead.

[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Line is too long.===
Code climate will complain when a line is too long.

[[File:Line too long.png]]

===Issue - Similar blocks of code found in 3 locations. Consider refactoring===

[[File:Issue_21.png]]

===Issue - User controlled method execution===

===Issue - Prefer each over for===

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:48:32Z

Nkapadi: /* Implementation */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===
[[File:Time zone and out of condition.png]]

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

[[File:Issue_5.png]]

===Issue - Favor unless over if for negative conditions.===

[[File:Issue_10.png]]

===Issue - Parameters should be whitelisted for mass assignment.===
[[File:Whitelist_and_update_attributes.png]]
=== Avoid using update_attribute because it skips validations===

The method update_attribute will skip validation. Should use update_attributes instead.

[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Line is too long.===
Code climate will complain when a line is too long.

[[File:Line too long.png]]

===Issue - Similar blocks of code found in 3 locations. Consider refactoring===

[[File:Issue_21.png]]

===Issue - User controlled method execution===

===Issue - Use empty lines between method definitions.===

===Issue - Prefer each over for===

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:41:21Z

Nkapadi: /* Issue - Similar blocks of code found in 3 locations. Consider refactoring */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===
[[File:Time zone and out of condition.png]]

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

[[File:Issue_5.png]]

===Issue - Favor unless over if for negative conditions.===

[[File:Issue_10.png]]

===Issue - Parameters should be whitelisted for mass assignment.===
[[File:Whitelist_and_update_attributes.png]]
=== Avoid using update_attribute because it skips validations===

The method update_attribute will skip validation. Should use update_attributes instead.

[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Line is too long.===
Code climate will complain when a line is too long.

[[File:Line too long.png]]

===Issue - Similar blocks of code found in 3 locations. Consider refactoring===

[[File:Issue_21.png]]

===Issue - User controlled method execution===

===Issue - Extra blank line detected===

===Issue - Use empty lines between method definitions.===

===Issue - Prefer each over for===

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:40:57Z

Nkapadi: /* Implementation */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===
[[File:Time zone and out of condition.png]]

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

[[File:Issue_5.png]]

===Issue - Favor unless over if for negative conditions.===

[[File:Issue_10.png]]

===Issue - Parameters should be whitelisted for mass assignment.===
[[File:Whitelist_and_update_attributes.png]]
=== Avoid using update_attribute because it skips validations===

The method update_attribute will skip validation. Should use update_attributes instead.

[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Line is too long.===
Code climate will complain when a line is too long.

[[File:Line too long.png]]

===Issue - Similar blocks of code found in 3 locations. Consider refactoring===

===Issue - User controlled method execution===

===Issue - Extra blank line detected===

===Issue - Use empty lines between method definitions.===

===Issue - Prefer each over for===

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

File:Issue 21.png

2019-03-26T01:39:07Z

Nkapadi:

File:Issue 10.png

2019-03-26T01:31:55Z

Nkapadi: uploaded a new version of "File:Issue 10.png"

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:31:22Z

Nkapadi: /* Issue - Favor unless over if for negative conditions. */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===
[[File:Time zone and out of condition.png]]

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

[[File:Issue_5.png]]

===Issue - Favor unless over if for negative conditions.===

[[File:Issue_10.png]]

===Issue - Parameters should be whitelisted for mass assignment / Avoid using update_attribute because it skips validations===
[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Line is too long.===
[[File:Line too long.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

File:Issue 10.png

2019-03-26T01:30:59Z

Nkapadi:

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:27:37Z

Nkapadi: /* Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===
[[File:Time zone and out of condition.png]]

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

[[File:Issue_5.png]]

===Issue - Favor unless over if for negative conditions.===

===Issue - Parameters should be whitelisted for mass assignment / Avoid using update_attribute because it skips validations===
[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Line is too long.===
[[File:Line too long.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

File:Issue 5.png

2019-03-26T01:27:17Z

Nkapadi:

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:23:01Z

Nkapadi: /* Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead. */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===
[[File:Time zone and out of condition.png]]

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Parameters should be whitelisted for mass assignment / Avoid using update_attribute because it skips validations===
[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:19:26Z

Nkapadi: /* Issue - Use a guard clause instead of wrapping the code inside a conditional expression. */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
Used a return/unless combination to return in case the condition is false.

[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Parameters should be whitelisted for mass assignment.===
===Issue - Avoid using update_attribute because it skips validations.===
[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:11:34Z

Nkapadi: /* Issue - Unprotected Mass Assignment */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Unprotected mass assignment 2.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Parameters should be whitelisted for mass assignment.===
[[File:Whitelist_and_update_attributes.png]]

===Issue - Unsafe reflection method const_get called with parameter value===
[[File:Unsafe const_get.png]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

File:Unprotected mass assignment 2.png

2019-03-26T01:11:09Z

Nkapadi: uploaded a new version of "File:Unprotected mass assignment 2.png"

File:Unprotected mass assignment 2.png

2019-03-26T01:09:21Z

Nkapadi: uploaded a new version of "File:Unprotected mass assignment 2.png"

File:Unprotected mass assignment 2.png

2019-03-26T01:07:51Z

Nkapadi: uploaded a new version of "File:Unprotected mass assignment 2.png"

File:Unprotected mass assignment 2.png

2019-03-26T01:07:20Z

Nkapadi:

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:05:28Z

Nkapadi: /* Issue - Do not place comments on the same line as the end keyword. */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Mass_Assignment_Issue.png]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png|center]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png|center]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Unsafe reflection method const_get called with parameter value===

[[File:Unsafe const_get.png|center]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
Adding comments at the last the line of the code is considered a bad coding practice according to rubocop standards.

[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:03:23Z

Nkapadi: /* Issue - Put one space between the method name and the first argument. */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Mass_Assignment_Issue.png|center]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png|center]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png|center]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Unsafe reflection method const_get called with parameter value===

[[File:Unsafe const_get.png|center]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
Space has been added between method name and the first argument to make the code easily readable.

[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:02:46Z

Nkapadi: /* Issue - Space missing after colon */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Mass_Assignment_Issue.png|center]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png|center]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png|center]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Unsafe reflection method const_get called with parameter value===

[[File:Unsafe const_get.png|center]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
Space has been added after colon to make the code easily readable.

[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:01:59Z

Nkapadi: /* Issue - Use the new Ruby 1.9 hash syntax */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Mass_Assignment_Issue.png|center]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png|center]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png|center]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Unsafe reflection method const_get called with parameter value===

[[File:Unsafe const_get.png|center]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
This ruby syntax has been deprecated as of the current ruby version(2.3.7) used in expertiza.

[[File:Issue_33.png]]

===Issue - Space missing after colon===
[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T01:01:20Z

Nkapadi: /* Issue - show, edit, update, destroy are not explicitly defined on the controller. */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Mass_Assignment_Issue.png|center]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png|center]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png|center]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Unsafe reflection method const_get called with parameter value===

[[File:Unsafe const_get.png|center]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
Show, edit, update and destroy have been explicitly defined to avoid confusion among filters between different controllers.

[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
[[File:Issue_33.png]]

===Issue - Space missing after colon===
[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T00:57:44Z

Nkapadi: /* Issue - Rename is_user_ta? to user_ta? */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Mass_Assignment_Issue.png|center]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png|center]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png|center]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Unsafe reflection method const_get called with parameter value===

[[File:Unsafe const_get.png|center]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.

[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
[[File:Issue_33.png]]

===Issue - Space missing after colon===
[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T00:57:36Z

Nkapadi: /* Issue - Rename is_user_ta? to user_ta? */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Mass_Assignment_Issue.png|center]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png|center]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png|center]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Unsafe reflection method const_get called with parameter value===

[[File:Unsafe const_get.png|center]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
Renamed is_user_ta? to user_ta? to follow naming conventions enforced by Rubocop.
[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
[[File:Issue_33.png]]

===Issue - Space missing after colon===
[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T00:54:31Z

Nkapadi: /* Implementation */

== '''About Expertiza''' ==
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages[1].

== '''Code Climate Issues and Problem Statements''' ==

Codeclimate is a command line interface for the Code Climate analysis platform [2]. It can detect code smells which violate ruby/rails best practices. The task is to fix certain code climate issues detected by Code Climate analysis platform in controllers with the name beginning with P through Z. These issues includes unsafe use of methods, inappropriate syntax, non-optimal code structure which violates the DRY principle and so on. There are 37 different types of issues fixed in this project.

====List of Issues====

*Unprotected mass assignment
*Use a guard clause instead of wrapping the code inside a conditional expression
*Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead
*Move redirect_to "/" out of the conditional.
*Block has too many lines
*Useless assignment to variable - initheader.
*Replace class var @@assignment_id with a class instance var
*Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead
*Identical blocks of code found in 2 locations. Consider refactoring.
*Favor unless over if for negative conditions.
*Operator = should be surrounded by a single space.
*Line is too long
*Extra empty line detected at method body beginning.
*Unnecessary spacing detected.
*Parameters should be whitelisted for mass assignment
*Avoid using update_attribute because it skips validations.
*end at 44, 4 is not aligned with def at 39, 2.
*Unsafe reflection method const_get called with parameter value
*TODO found
*Convert if nested inside else to elsif
*Similar blocks of code found in 3 locations. Consider refactoring
*User controlled method execution
*Extra blank line detected
*Use empty lines between method definitions.
*Prefer each over for
*Prefer Date or Time over DateTime.
*Omit parentheses for ternary conditions
*Do not place comments on the same line as the end keyword.
*Useless assignment to variable - controllers. Did you mean controller?
*end at 135, 2 is not aligned with class at 1, 0
*Put one space between the method name and the first argument.
*Space missing after colon.
*Use the new Ruby 1.9 hash syntax
*show, edit, update, destroy are not explicitly defined on the controller.
*Rename is_user_ta? to user_ta?
*Avoid comma after the last item of an array
*Move redirect_to view_student_teams_path student_id: student.id out of the conditional

== '''Implementation''' ==

There are many minor issues such as unnecessary spacing, extra blank line detected, extra parentheses used and so on. We're not going to show all these minor fixing in this section. The focus would be on some of the important issues listed above that we fixed.

===Issue - Unprotected Mass Assignment===
Mass assignment is a feature of Rails which allows an application to create a record from the values of a hash. Protection for mass assignment is on by default. Query parameters must be explicitly whitelisted via permit in order to be used in mass assignment.This issue appears in different controller files. An example of how we fixed it in questions_controller.rb is shown below:
[[File:Mass_Assignment_Issue.png|center]]

===Issue - Use a guard clause instead of wrapping the code inside a conditional expression.===
[[File:Guard clause.png|center]]

===Issue - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.===

===Issue - Move redirect_to "/" out of the conditional.===

[[File:Time_zone_and_out_of_condition.png|center]]

===Issue - Avoid comparing a variable with multiple items in a conditional, use Array#include? Instead ===

===Issue - Favor unless over if for negative conditions.===

===Issue - Unsafe reflection method const_get called with parameter value===

[[File:Unsafe const_get.png|center]]

===Issue - Avoid comma after the last item of an array===
[[File:Issue_36.png]]

===Issue - Rename is_user_ta? to user_ta?===
[[File:Issue_35.png]]

===Issue - show, edit, update, destroy are not explicitly defined on the controller.===
[[File:Issue_32.png]]

===Issue - Use the new Ruby 1.9 hash syntax===
[[File:Issue_33.png]]

===Issue - Space missing after colon===
[[File:Issue_30.png]]

===Issue - Put one space between the method name and the first argument.===
[[File:Issue_31.png]]

===Issue - Do not place comments on the same line as the end keyword.===
[[File:Issue_27.png]]

== '''Testing''' ==

The Expertiza project provides 77 rspec tests under expertiza/spec and 8 of them are related to our controllers files. After modifying those 28 files, we want to make sure these tests could still pass. We passed all the Rspec tests except for "response_controller". However, we were not requirement to fix the issues for this controllers.

[[File:Testing pass.png]]

[[File:One_failure_testing.png]]

===Reference===
*1:http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2017/E1784_Fix_mass_assignments_reported_by_Brakeman.rb
*2: https://github.com/codeclimate/codeclimate/blob/master/README.md
*The Class GitHub Repository: https://github.com/expertiza/expertiza
*The Class Code Climate:https://codeclimate.com/github/expertiza/expertiza

File:Issue 31.png

2019-03-26T00:50:15Z

Nkapadi:

File:Issue 27.png

2019-03-26T00:49:39Z

Nkapadi:

File:Issue 30.png

2019-03-26T00:49:23Z

Nkapadi:

File:Issue 33.png

2019-03-26T00:49:13Z

Nkapadi:

File:Issue 32.png

2019-03-26T00:49:01Z

Nkapadi:

File:Issue 35.png

2019-03-26T00:48:48Z

Nkapadi:

CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z

2019-03-26T00:21:47Z

Nkapadi: /* Issue - Unprotected Mass Assignment */

File:Issue 36.png

2019-03-26T00:20:25Z

Nkapadi: