Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-12-02T23:28:07Z

Msardar: /* Implementation */

== '''Introduction to Expertiza''' ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc. The existing rubrics creation page is shown in the Figure below.

[[File:OldRubricPage.PNG|frame|upright|center|Old Rubric Creation Page]]

As mentioned before, the above shown page is not very intuitive. Also the instructor has no idea how the page would appear to a student unless he logs in as a student, create submissions, etc. which is very time consuming. Hence a better design would be to create a rubrics page that would appear the same to the instructors and the students.

We need to implement a WYSIWYG (What You See Is What You Get) UI for the rubric page to create rubrics which supports the following expertiza's question types:

* Criterion
* Checkbox
* TextField
* Dropdown
* TextArea
* UploadFile
* SectionHeader
* TableHeader
* ColumnHeader
* Scale

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin]. The 'jquery-rails' gem is already present in the Gemfile, so we only need to initialize the formBuilder plugin.

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

The above screenshot consists of two sections: main area to the left and the control section to the right. The control section consists of the various form fields which can be dragged and dropped to the main area. In the main area, the parameters to the fields can be configured including field length, options, values, etc. Hence the drag and drop interface will provide a very intuitive way for the instructor/TA to create rubrics and also view how the page would appear to a student. Moreover it provides the option to edit the field information when we create the individual fields. For example, in case of dropdown we can specify the options of the dropdown. A sample screenshot of text area creation is shown below.

[[File:text_area.PNG|frame|upright|center|Text Area Creation]]

In the above screenshot, we can see that we are creating a text area. There is an edit option at the top right corner of the field, clicking on which we get a form through which the options can be given. In the above case of creating a text area, we can specify the label, value, number of rows, the maximum length of the characters, placeholder, help text, etc. We can also specify if the field is mandatory by checking the required checkbox given at the top of the form. In a similar way configuration options are available to all the form fields that can be created.

== '''Files to be modified''' ==
This project only involves modifying the UI for instructors to create new rubrics. The rubric configurations stored in the database and the views from the student side will remain the same. Hence, no modifications need to be made to the questionnaire model or controller.

All types of rubrics (Review, Metareview, Author Feedback, Teammate review, Survey, Course Evaluation etc.) are created and modified using the same views. These views exist in views/questionnaires folder. Hence the files to be modified to incorporate the new UI design will be:

# view/questionnaires/new.html.erb
# view/questionnaires/edit.html.erb
# view/questionnaires/view.html.erb

The modifications made to the above files will be significant since the new rubric creation interface will be entirely different form the existing one. A lot of the code will have to be written from scratch.
== '''Implementation''' ==
To implement the drag-and-drop interface, we need to incorporate the source code from [https://github.com/kevinchappell/formBuilder/ GitHub] into our existing Expertiza project by adding them in "/vendor/assets/" folder.

To intialize the jQuery formBuilder plugin, a file needs to be added under "/app/assets/javascripts/" folder named "form-init.js". Within this file we need to specify the options to match our required form for rubric creation. The code for this is as follows :

fbOptions = {
dataType: 'json',
sortableControls: false,
editOnAdd: false,
stickyControls: true,
sortableControls: false,
disableFields: ['autocomplete', 'button','paragraph', 'number', 'checkbox-group', 'date', 'file', 'hidden', 'header'],
editOnAdd: false,
showActionButtons: true,
defaultFields: defaultFields, // edit will load the fields from db
fieldRemoveWarn: true,
typeUserEvents: {
'checkbox': onAddHandler,
'header': onAddHandler,
'radio-group': onAddHandler,
'select': onAddHandler,
'text': onAddHandler,
'textarea': onAddHandler
}
};
var formBuilder = $(buildWrap).formBuilder(fbOptions).data('formBuilder')

We also need to make sure that data entered into the new interface is stored into the existing database in the same format as the current one.

After implementation of the above code, the final UI for rubric creations looks like :
[[File:New1.png|frame|upright|center|Sample Form using JQuery formBuilder]]

Instructors can select field type on the right and drop it into the container. Then select different options for each field type such as labels, values, length etc.

== '''Testing Plan''' ==

[[File:inst-flow.png | frame | upright | center | Instructor Flow Diagram]]

# Login as instructor (username: instructor6, password:password).
# Click on 'Questionnaires' tab present in the Manage section.
# Click on 'New public item' to go to the 'Create ReviewQuestionnaire" page.
# Click on 'Create' icon which will forward you to "form Builder" page.
# Now you can create a sample rubrics by dragging and dropping the form fields and configuring the field parameters.

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-12-02T23:23:01Z

Msardar: /* Implementation */

== '''Introduction to Expertiza''' ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc. The existing rubrics creation page is shown in the Figure below.

[[File:OldRubricPage.PNG|frame|upright|center|Old Rubric Creation Page]]

As mentioned before, the above shown page is not very intuitive. Also the instructor has no idea how the page would appear to a student unless he logs in as a student, create submissions, etc. which is very time consuming. Hence a better design would be to create a rubrics page that would appear the same to the instructors and the students.

We need to implement a WYSIWYG (What You See Is What You Get) UI for the rubric page to create rubrics which supports the following expertiza's question types:

* Criterion
* Checkbox
* TextField
* Dropdown
* TextArea
* UploadFile
* SectionHeader
* TableHeader
* ColumnHeader
* Scale

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin]. The 'jquery-rails' gem is already present in the Gemfile, so we only need to initialize the formBuilder plugin.

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

The above screenshot consists of two sections: main area to the left and the control section to the right. The control section consists of the various form fields which can be dragged and dropped to the main area. In the main area, the parameters to the fields can be configured including field length, options, values, etc. Hence the drag and drop interface will provide a very intuitive way for the instructor/TA to create rubrics and also view how the page would appear to a student. Moreover it provides the option to edit the field information when we create the individual fields. For example, in case of dropdown we can specify the options of the dropdown. A sample screenshot of text area creation is shown below.

[[File:text_area.PNG|frame|upright|center|Text Area Creation]]

In the above screenshot, we can see that we are creating a text area. There is an edit option at the top right corner of the field, clicking on which we get a form through which the options can be given. In the above case of creating a text area, we can specify the label, value, number of rows, the maximum length of the characters, placeholder, help text, etc. We can also specify if the field is mandatory by checking the required checkbox given at the top of the form. In a similar way configuration options are available to all the form fields that can be created.

== '''Files to be modified''' ==
This project only involves modifying the UI for instructors to create new rubrics. The rubric configurations stored in the database and the views from the student side will remain the same. Hence, no modifications need to be made to the questionnaire model or controller.

All types of rubrics (Review, Metareview, Author Feedback, Teammate review, Survey, Course Evaluation etc.) are created and modified using the same views. These views exist in views/questionnaires folder. Hence the files to be modified to incorporate the new UI design will be:

# view/questionnaires/new.html.erb
# view/questionnaires/edit.html.erb
# view/questionnaires/view.html.erb

The modifications made to the above files will be significant since the new rubric creation interface will be entirely different form the existing one. A lot of the code will have to be written from scratch.
== '''Implementation''' ==
To implement the drag-and-drop interface, we need to incorporate the source code from [https://github.com/kevinchappell/formBuilder/ GitHub] into our existing Expertiza project by adding them in "/vendor/assets/" folder.

To intialize the jQuery formBuilder plugin, a file needs to be added under "/app/assets/javascripts/" folder named "form-init.js". Within this file we need to specify the options to match our required form for rubric creation. The code for this is as follows :

fbOptions = {
dataType: 'json',
sortableControls: false,
editOnAdd: false,
stickyControls: true,
sortableControls: false,
disableFields: ['autocomplete', 'button','paragraph', 'number', 'checkbox-group', 'date', 'file', 'hidden', 'header'],
editOnAdd: false,
showActionButtons: true,
defaultFields: defaultFields, // edit will load the fields from db
fieldRemoveWarn: true,
typeUserEvents: {
'checkbox': onAddHandler,
'header': onAddHandler,
'radio-group': onAddHandler,
'select': onAddHandler,
'text': onAddHandler,
'textarea': onAddHandler
}
};
var formBuilder = $(buildWrap).formBuilder(fbOptions).data('formBuilder')

We also need to make sure that data entered into the new interface is stored into the existing database in the same format as the current one.

After implementation of the above code, the final UI for rubric creations looks like :
[[File:New1.png|frame|upright|center|Sample Form using JQuery formBuilder]]

== '''Testing Plan''' ==

[[File:inst-flow.png | frame | upright | center | Instructor Flow Diagram]]

# Login as instructor (username: instructor6, password:password).
# Click on 'Questionnaires' tab present in the Manage section.
# Click on 'New public item' to go to the 'Create ReviewQuestionnaire" page.
# Click on 'Create' icon which will forward you to "form Builder" page.
# Now you can create a sample rubrics by dragging and dropping the form fields and configuring the field parameters.

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-12-02T23:09:06Z

Msardar: /* Implementation */

== '''Introduction to Expertiza''' ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc. The existing rubrics creation page is shown in the Figure below.

[[File:OldRubricPage.PNG|frame|upright|center|Old Rubric Creation Page]]

As mentioned before, the above shown page is not very intuitive. Also the instructor has no idea how the page would appear to a student unless he logs in as a student, create submissions, etc. which is very time consuming. Hence a better design would be to create a rubrics page that would appear the same to the instructors and the students.

We need to implement a WYSIWYG (What You See Is What You Get) UI for the rubric page to create rubrics which supports the following expertiza's question types:

* Criterion
* Checkbox
* TextField
* Dropdown
* TextArea
* UploadFile
* SectionHeader
* TableHeader
* ColumnHeader
* Scale

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin]. The 'jquery-rails' gem is already present in the Gemfile, so we only need to initialize the formBuilder plugin.

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

The above screenshot consists of two sections: main area to the left and the control section to the right. The control section consists of the various form fields which can be dragged and dropped to the main area. In the main area, the parameters to the fields can be configured including field length, options, values, etc. Hence the drag and drop interface will provide a very intuitive way for the instructor/TA to create rubrics and also view how the page would appear to a student. Moreover it provides the option to edit the field information when we create the individual fields. For example, in case of dropdown we can specify the options of the dropdown. A sample screenshot of text area creation is shown below.

[[File:text_area.PNG|frame|upright|center|Text Area Creation]]

In the above screenshot, we can see that we are creating a text area. There is an edit option at the top right corner of the field, clicking on which we get a form through which the options can be given. In the above case of creating a text area, we can specify the label, value, number of rows, the maximum length of the characters, placeholder, help text, etc. We can also specify if the field is mandatory by checking the required checkbox given at the top of the form. In a similar way configuration options are available to all the form fields that can be created.

== '''Files to be modified''' ==
This project only involves modifying the UI for instructors to create new rubrics. The rubric configurations stored in the database and the views from the student side will remain the same. Hence, no modifications need to be made to the questionnaire model or controller.

All types of rubrics (Review, Metareview, Author Feedback, Teammate review, Survey, Course Evaluation etc.) are created and modified using the same views. These views exist in views/questionnaires folder. Hence the files to be modified to incorporate the new UI design will be:

# view/questionnaires/new.html.erb
# view/questionnaires/edit.html.erb
# view/questionnaires/view.html.erb

The modifications made to the above files will be significant since the new rubric creation interface will be entirely different form the existing one. A lot of the code will have to be written from scratch.
== '''Implementation''' ==
To implement the drag-and-drop interface, we need to incorporate the source code from [https://github.com/kevinchappell/formBuilder/ GitHub] into our existing Expertiza project by adding them in "/vendor/assets/" folder.

To intialize the jQuery formBuilder plugin, a file needs to be added under "/app/assets/javascripts/" folder named "form-init.js". Within this file we need to specify the options to match our required form for rubric creation. The code for this is as follows :

fbOptions = {
dataType: 'json',
sortableControls: false,
editOnAdd: false,
stickyControls: true,
sortableControls: false,
disableFields: ['autocomplete', 'button','paragraph', 'number', 'checkbox-group', 'date', 'file', 'hidden', 'header'],
editOnAdd: false,
showActionButtons: true,
defaultFields: defaultFields, // edit will load the fields from db
fieldRemoveWarn: true,
typeUserEvents: {
'checkbox': onAddHandler,
'header': onAddHandler,
'radio-group': onAddHandler,
'select': onAddHandler,
'text': onAddHandler,
'textarea': onAddHandler
}
};
var formBuilder = $(buildWrap).formBuilder(fbOptions).data('formBuilder')

The final UI for rubric creations looks like :
[[File:Form.png|frame|upright|center|Sample Form using JQuery formBuilder]]

== '''Testing Plan''' ==

[[File:inst-flow.png | frame | upright | center | Instructor Flow Diagram]]

# Login as instructor (username: instructor6, password:password).
# Click on 'Questionnaires' tab present in the Manage section.
# Click on 'New public item' to go to the 'Create ReviewQuestionnaire" page.
# Click on 'Create' icon which will forward you to "form Builder" page.
# Now you can create a sample rubrics by dragging and dropping the form fields and configuring the field parameters.

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-12-02T23:08:02Z

Msardar: /* Implementation */

== '''Introduction to Expertiza''' ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc. The existing rubrics creation page is shown in the Figure below.

[[File:OldRubricPage.PNG|frame|upright|center|Old Rubric Creation Page]]

As mentioned before, the above shown page is not very intuitive. Also the instructor has no idea how the page would appear to a student unless he logs in as a student, create submissions, etc. which is very time consuming. Hence a better design would be to create a rubrics page that would appear the same to the instructors and the students.

We need to implement a WYSIWYG (What You See Is What You Get) UI for the rubric page to create rubrics which supports the following expertiza's question types:

* Criterion
* Checkbox
* TextField
* Dropdown
* TextArea
* UploadFile
* SectionHeader
* TableHeader
* ColumnHeader
* Scale

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin]. The 'jquery-rails' gem is already present in the Gemfile, so we only need to initialize the formBuilder plugin.

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

The above screenshot consists of two sections: main area to the left and the control section to the right. The control section consists of the various form fields which can be dragged and dropped to the main area. In the main area, the parameters to the fields can be configured including field length, options, values, etc. Hence the drag and drop interface will provide a very intuitive way for the instructor/TA to create rubrics and also view how the page would appear to a student. Moreover it provides the option to edit the field information when we create the individual fields. For example, in case of dropdown we can specify the options of the dropdown. A sample screenshot of text area creation is shown below.

[[File:text_area.PNG|frame|upright|center|Text Area Creation]]

In the above screenshot, we can see that we are creating a text area. There is an edit option at the top right corner of the field, clicking on which we get a form through which the options can be given. In the above case of creating a text area, we can specify the label, value, number of rows, the maximum length of the characters, placeholder, help text, etc. We can also specify if the field is mandatory by checking the required checkbox given at the top of the form. In a similar way configuration options are available to all the form fields that can be created.

== '''Files to be modified''' ==
This project only involves modifying the UI for instructors to create new rubrics. The rubric configurations stored in the database and the views from the student side will remain the same. Hence, no modifications need to be made to the questionnaire model or controller.

All types of rubrics (Review, Metareview, Author Feedback, Teammate review, Survey, Course Evaluation etc.) are created and modified using the same views. These views exist in views/questionnaires folder. Hence the files to be modified to incorporate the new UI design will be:

# view/questionnaires/new.html.erb
# view/questionnaires/edit.html.erb
# view/questionnaires/view.html.erb

The modifications made to the above files will be significant since the new rubric creation interface will be entirely different form the existing one. A lot of the code will have to be written from scratch.
== '''Implementation''' ==
To implement the drag-and-drop interface, we need to incorporate the source code from [https://github.com/kevinchappell/formBuilder/ GitHub] into our existing Expertiza project by adding them in "/vendor/assets/" folder.

To intialize the jQuery formBuilder plugin, a file needs to be added under "/app/assets/javascripts/" folder named "form-init.js". Within this file we need to specify the options to match our required form for rubric creation. The code for this is as follows :

fbOptions = {
dataType: 'json',
sortableControls: false,
editOnAdd: false,
stickyControls: true,
sortableControls: false,
disableFields: ['autocomplete', 'button','paragraph', 'number', 'checkbox-group', 'date', 'file', 'hidden', 'header'],
editOnAdd: false,
showActionButtons: true,
defaultFields: defaultFields, // edit will load the fields from db
fieldRemoveWarn: true,
typeUserEvents: {
'checkbox': onAddHandler,
'header': onAddHandler,
'radio-group': onAddHandler,
'select': onAddHandler,
'text': onAddHandler,
'textarea': onAddHandler
}
};
var formBuilder = $(buildWrap).formBuilder(fbOptions).data('formBuilder')

[[File:Form.png|frame|upright|center|Sample Form using JQuery formBuilder]]

== '''Testing Plan''' ==

[[File:inst-flow.png | frame | upright | center | Instructor Flow Diagram]]

# Login as instructor (username: instructor6, password:password).
# Click on 'Questionnaires' tab present in the Manage section.
# Click on 'New public item' to go to the 'Create ReviewQuestionnaire" page.
# Click on 'Create' icon which will forward you to "form Builder" page.
# Now you can create a sample rubrics by dragging and dropping the form fields and configuring the field parameters.

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-12-02T22:51:40Z

Msardar: /* Implementation */

== '''Introduction to Expertiza''' ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc. The existing rubrics creation page is shown in the Figure below.

[[File:OldRubricPage.PNG|frame|upright|center|Old Rubric Creation Page]]

As mentioned before, the above shown page is not very intuitive. Also the instructor has no idea how the page would appear to a student unless he logs in as a student, create submissions, etc. which is very time consuming. Hence a better design would be to create a rubrics page that would appear the same to the instructors and the students.

We need to implement a WYSIWYG (What You See Is What You Get) UI for the rubric page to create rubrics which supports the following expertiza's question types:

* Criterion
* Checkbox
* TextField
* Dropdown
* TextArea
* UploadFile
* SectionHeader
* TableHeader
* ColumnHeader
* Scale

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin]. The 'jquery-rails' gem is already present in the Gemfile, so we only need to initialize the formBuilder plugin.

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

The above screenshot consists of two sections: main area to the left and the control section to the right. The control section consists of the various form fields which can be dragged and dropped to the main area. In the main area, the parameters to the fields can be configured including field length, options, values, etc. Hence the drag and drop interface will provide a very intuitive way for the instructor/TA to create rubrics and also view how the page would appear to a student. Moreover it provides the option to edit the field information when we create the individual fields. For example, in case of dropdown we can specify the options of the dropdown. A sample screenshot of text area creation is shown below.

[[File:text_area.PNG|frame|upright|center|Text Area Creation]]

In the above screenshot, we can see that we are creating a text area. There is an edit option at the top right corner of the field, clicking on which we get a form through which the options can be given. In the above case of creating a text area, we can specify the label, value, number of rows, the maximum of the characters, placeholder, help text, etc. We can also specify if the field is mandatory by checking the required checkbox given at the top of the form. In a similar way configuration options are available to all the form fields that can be created.

== '''Files to be modified''' ==
This project only involves modifying the UI for instructors to create new rubrics. The rubric configurations stored in the database and the views from the student side will remain the same. Hence, no modifications need to be made to the questionnaire model or controller.

All types of rubrics (Review, Metareview, Author Feedback, Teammate review, Survey, Course Evaluation etc.) are created and modified using the same views. These views exist in views/questionnaires folder. Hence the files to be modified to incorporate the new UI design will be:

# view/questionnaires/new.html.erb
# view/questionnaires/edit.html.erb
# view/questionnaires/view.html.erb

The modifications made to the above files will be significant since the new rubric creation interface will be entirely different form the existing one. A lot of the code will have to be written from scratch.
== '''Implementation''' ==
To implement the drag-and-drop interface, we need to incorporate the source code from [https://github.com/kevinchappell/formBuilder/ GitHub] into our existing Expertiza project by adding them in "/vendor/assets/" folder.

To intialize the jQuery formBuilder plugin, a file needs to be added under "/app/assets/javascripts/" folder named "form-init.js". Within this file we need to specify the options to match our required form for rubric creation. The code for this is as follows :

fbOptions = {
dataType: 'json',
sortableControls: false,
editOnAdd: false,
stickyControls: true,
sortableControls: false,
disableFields: ['autocomplete', 'button','paragraph', 'number', 'checkbox-group', 'date', 'file', 'hidden', 'header'],
editOnAdd: false,
showActionButtons: true,
defaultFields: defaultFields, // edit will load the fields from db
fieldRemoveWarn: true,
typeUserEvents: {
'checkbox': onAddHandler,
'header': onAddHandler,
'radio-group': onAddHandler,
'select': onAddHandler,
'text': onAddHandler,
'textarea': onAddHandler
}
};
var formBuilder = $(buildWrap).formBuilder(fbOptions).data('formBuilder')

== '''Testing Plan''' ==

[[File:inst-flow.png | frame | upright | center | Instructor Flow Diagram]]

# Login as instructor (username: instructor6, password:password).
# Click on 'Questionnaires' tab present in the Manage section.
# Click on 'New public item' to go to the 'Create ReviewQuestionnaire" page.
# Click on 'Create' icon which will forward you to "form Builder" page.
# Now you can create a sample rubrics by dragging and dropping the form fields and configuring the field parameters.

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-12-02T22:50:57Z

Msardar: /* Implementation */

== '''Introduction to Expertiza''' ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc. The existing rubrics creation page is shown in the Figure below.

[[File:OldRubricPage.PNG|frame|upright|center|Old Rubric Creation Page]]

As mentioned before, the above shown page is not very intuitive. Also the instructor has no idea how the page would appear to a student unless he logs in as a student, create submissions, etc. which is very time consuming. Hence a better design would be to create a rubrics page that would appear the same to the instructors and the students.

We need to implement a WYSIWYG (What You See Is What You Get) UI for the rubric page to create rubrics which supports the following expertiza's question types:

* Criterion
* Checkbox
* TextField
* Dropdown
* TextArea
* UploadFile
* SectionHeader
* TableHeader
* ColumnHeader
* Scale

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin]. The 'jquery-rails' gem is already present in the Gemfile, so we only need to initialize the formBuilder plugin.

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

The above screenshot consists of two sections: main area to the left and the control section to the right. The control section consists of the various form fields which can be dragged and dropped to the main area. In the main area, the parameters to the fields can be configured including field length, options, values, etc. Hence the drag and drop interface will provide a very intuitive way for the instructor/TA to create rubrics and also view how the page would appear to a student. Moreover it provides the option to edit the field information when we create the individual fields. For example, in case of dropdown we can specify the options of the dropdown. A sample screenshot of text area creation is shown below.

[[File:text_area.PNG|frame|upright|center|Text Area Creation]]

In the above screenshot, we can see that we are creating a text area. There is an edit option at the top right corner of the field, clicking on which we get a form through which the options can be given. In the above case of creating a text area, we can specify the label, value, number of rows, the maximum of the characters, placeholder, help text, etc. We can also specify if the field is mandatory by checking the required checkbox given at the top of the form. In a similar way configuration options are available to all the form fields that can be created.

== '''Files to be modified''' ==
This project only involves modifying the UI for instructors to create new rubrics. The rubric configurations stored in the database and the views from the student side will remain the same. Hence, no modifications need to be made to the questionnaire model or controller.

All types of rubrics (Review, Metareview, Author Feedback, Teammate review, Survey, Course Evaluation etc.) are created and modified using the same views. These views exist in views/questionnaires folder. Hence the files to be modified to incorporate the new UI design will be:

# view/questionnaires/new.html.erb
# view/questionnaires/edit.html.erb
# view/questionnaires/view.html.erb

The modifications made to the above files will be significant since the new rubric creation interface will be entirely different form the existing one. A lot of the code will have to be written from scratch.
== '''Implementation''' ==
To implement the drag-and-drop interface, we need to incorporate the source code from [https://github.com/kevinchappell/formBuilder/] into our existing Expertiza project by adding them in "/vendor/assets/" folder.

To intialize the jQuery formBuilder plugin, a file needs to be added under "/app/assets/javascripts/" folder named "form-init.js". Within this file we need to specify the options to match our required form for rubric creation. The code for this is as follows :

fbOptions = {
dataType: 'json',
sortableControls: false,
editOnAdd: false,
stickyControls: true,
sortableControls: false,
disableFields: ['autocomplete', 'button','paragraph', 'number', 'checkbox-group', 'date', 'file', 'hidden', 'header'],
editOnAdd: false,
showActionButtons: true,
defaultFields: defaultFields, // edit will load the fields from db
fieldRemoveWarn: true,
typeUserEvents: {
'checkbox': onAddHandler,
'header': onAddHandler,
'radio-group': onAddHandler,
'select': onAddHandler,
'text': onAddHandler,
'textarea': onAddHandler
}
};
var formBuilder = $(buildWrap).formBuilder(fbOptions).data('formBuilder')

== '''Testing Plan''' ==

[[File:inst-flow.png | frame | upright | center | Instructor Flow Diagram]]

# Login as instructor (username: instructor6, password:password).
# Click on 'Questionnaires' tab present in the Manage section.
# Click on 'New public item' to go to the 'Create ReviewQuestionnaire" page.
# Click on 'Create' icon which will forward you to "form Builder" page.
# Now you can create a sample rubrics by dragging and dropping the form fields and configuring the field parameters.

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-12-02T22:44:40Z

Msardar: /* Implementation */

== '''Introduction to Expertiza''' ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc. The existing rubrics creation page is shown in the Figure below.

[[File:OldRubricPage.PNG|frame|upright|center|Old Rubric Creation Page]]

As mentioned before, the above shown page is not very intuitive. Also the instructor has no idea how the page would appear to a student unless he logs in as a student, create submissions, etc. which is very time consuming. Hence a better design would be to create a rubrics page that would appear the same to the instructors and the students.

We need to implement a WYSIWYG (What You See Is What You Get) UI for the rubric page to create rubrics which supports the following expertiza's question types:

* Criterion
* Checkbox
* TextField
* Dropdown
* TextArea
* UploadFile
* SectionHeader
* TableHeader
* ColumnHeader
* Scale

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin]. The 'jquery-rails' gem is already present in the Gemfile, so we only need to initialize the formBuilder plugin.

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

The above screenshot consists of two sections: main area to the left and the control section to the right. The control section consists of the various form fields which can be dragged and dropped to the main area. In the main area, the parameters to the fields can be configured including field length, options, values, etc. Hence the drag and drop interface will provide a very intuitive way for the instructor/TA to create rubrics and also view how the page would appear to a student. Moreover it provides the option to edit the field information when we create the individual fields. For example, in case of dropdown we can specify the options of the dropdown. A sample screenshot of text area creation is shown below.

[[File:text_area.PNG|frame|upright|center|Text Area Creation]]

In the above screenshot, we can see that we are creating a text area. There is an edit option at the top right corner of the field, clicking on which we get a form through which the options can be given. In the above case of creating a text area, we can specify the label, value, number of rows, the maximum of the characters, placeholder, help text, etc. We can also specify if the field is mandatory by checking the required checkbox given at the top of the form. In a similar way configuration options are available to all the form fields that can be created.

== '''Files to be modified''' ==
This project only involves modifying the UI for instructors to create new rubrics. The rubric configurations stored in the database and the views from the student side will remain the same. Hence, no modifications need to be made to the questionnaire model or controller.

All types of rubrics (Review, Metareview, Author Feedback, Teammate review, Survey, Course Evaluation etc.) are created and modified using the same views. These views exist in views/questionnaires folder. Hence the files to be modified to incorporate the new UI design will be:

# view/questionnaires/new.html.erb
# view/questionnaires/edit.html.erb
# view/questionnaires/view.html.erb

The modifications made to the above files will be significant since the new rubric creation interface will be entirely different form the existing one. A lot of the code will have to be written from scratch.
== '''Implementation''' ==
To intialize the jQuery formBuilder plugin, a file needs to be added under "app/assets/javascripts" folder named "form-init.js". Within this file we need to specify the options to match our required form for rubric creation. The code for this is as follows :

fbOptions = {
dataType: 'json',
sortableControls: false,
editOnAdd: false,
stickyControls: true,
sortableControls: false,
disableFields: ['autocomplete', 'button','paragraph', 'number', 'checkbox-group', 'date', 'file', 'hidden', 'header'],
editOnAdd: false,
showActionButtons: true,
defaultFields: defaultFields, // edit will load the fields from db
fieldRemoveWarn: true,
typeUserEvents: {
'checkbox': onAddHandler,
'header': onAddHandler,
'radio-group': onAddHandler,
'select': onAddHandler,
'text': onAddHandler,
'textarea': onAddHandler
}
};
var formBuilder = $(buildWrap).formBuilder(fbOptions).data('formBuilder')

== '''Testing Plan''' ==

[[File:inst-flow.png | frame | upright | center | Instructor Flow Diagram]]

# Login as instructor (username: instructor6, password:password).
# Click on 'Questionnaires' tab present in the Manage section.
# Click on 'New public item' to go to the 'Create ReviewQuestionnaire" page.
# Click on 'Create' icon which will forward you to "form Builder" page.
# Now you can create a sample rubrics by dragging and dropping the form fields and configuring the field parameters.

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-12-02T22:43:52Z

Msardar: /* Implementation */

== '''Introduction to Expertiza''' ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc. The existing rubrics creation page is shown in the Figure below.

[[File:OldRubricPage.PNG|frame|upright|center|Old Rubric Creation Page]]

As mentioned before, the above shown page is not very intuitive. Also the instructor has no idea how the page would appear to a student unless he logs in as a student, create submissions, etc. which is very time consuming. Hence a better design would be to create a rubrics page that would appear the same to the instructors and the students.

We need to implement a WYSIWYG (What You See Is What You Get) UI for the rubric page to create rubrics which supports the following expertiza's question types:

* Criterion
* Checkbox
* TextField
* Dropdown
* TextArea
* UploadFile
* SectionHeader
* TableHeader
* ColumnHeader
* Scale

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin]. The 'jquery-rails' gem is already present in the Gemfile, so we only need to initialize the formBuilder plugin.

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

The above screenshot consists of two sections: main area to the left and the control section to the right. The control section consists of the various form fields which can be dragged and dropped to the main area. In the main area, the parameters to the fields can be configured including field length, options, values, etc. Hence the drag and drop interface will provide a very intuitive way for the instructor/TA to create rubrics and also view how the page would appear to a student. Moreover it provides the option to edit the field information when we create the individual fields. For example, in case of dropdown we can specify the options of the dropdown. A sample screenshot of text area creation is shown below.

[[File:text_area.PNG|frame|upright|center|Text Area Creation]]

In the above screenshot, we can see that we are creating a text area. There is an edit option at the top right corner of the field, clicking on which we get a form through which the options can be given. In the above case of creating a text area, we can specify the label, value, number of rows, the maximum of the characters, placeholder, help text, etc. We can also specify if the field is mandatory by checking the required checkbox given at the top of the form. In a similar way configuration options are available to all the form fields that can be created.

== '''Files to be modified''' ==
This project only involves modifying the UI for instructors to create new rubrics. The rubric configurations stored in the database and the views from the student side will remain the same. Hence, no modifications need to be made to the questionnaire model or controller.

All types of rubrics (Review, Metareview, Author Feedback, Teammate review, Survey, Course Evaluation etc.) are created and modified using the same views. These views exist in views/questionnaires folder. Hence the files to be modified to incorporate the new UI design will be:

# view/questionnaires/new.html.erb
# view/questionnaires/edit.html.erb
# view/questionnaires/view.html.erb

The modifications made to the above files will be significant since the new rubric creation interface will be entirely different form the existing one. A lot of the code will have to be written from scratch.
== '''Implementation''' ==
To intialize the jQuery formBuilder plugin, a file needs to be added under "app/assets/javascripts" folder named "form-init.js". Within this file we need to specify the options to match our required form for rubrics. The code for this is as follows :

fbOptions = {
dataType: 'json',
sortableControls: false,
editOnAdd: false,
stickyControls: true,
sortableControls: false,
disableFields: ['autocomplete', 'button','paragraph', 'number', 'checkbox-group', 'date', 'file', 'hidden', 'header'],
editOnAdd: false,
showActionButtons: true,
defaultFields: defaultFields, // edit will load the fields from db
fieldRemoveWarn: true,
typeUserEvents: {
'checkbox': onAddHandler,
'header': onAddHandler,
'radio-group': onAddHandler,
'select': onAddHandler,
'text': onAddHandler,
'textarea': onAddHandler
}
};
var formBuilder = $(buildWrap).formBuilder(fbOptions).data('formBuilder')

== '''Testing Plan''' ==

[[File:inst-flow.png | frame | upright | center | Instructor Flow Diagram]]

# Login as instructor (username: instructor6, password:password).
# Click on 'Questionnaires' tab present in the Manage section.
# Click on 'New public item' to go to the 'Create ReviewQuestionnaire" page.
# Click on 'Create' icon which will forward you to "form Builder" page.
# Now you can create a sample rubrics by dragging and dropping the form fields and configuring the field parameters.

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T22:55:02Z

Msardar: /* Files to be modified */

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T22:48:02Z

Msardar: /* Design */

File:Text area.PNG

2016-11-14T22:46:56Z

Msardar:

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T22:41:48Z

Msardar: /* Design */

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T22:41:03Z

Msardar: /* Design */

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T22:34:06Z

Msardar: /* Problem Statement */

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T22:33:21Z

Msardar: /* Problem Statement */

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T22:32:31Z

Msardar: /* Problem Statement */

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T22:31:12Z

Msardar: /* Problem Statement */

File:OldRubricPage.PNG

2016-11-14T22:30:35Z

Msardar:

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T21:55:04Z

Msardar: /* Files to be modified */

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-14T21:48:12Z

Msardar: files to be modified

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-08T21:29:31Z

Msardar:

== Introduction to Expertiza ==
Expertiza is an online system that is used by students to view/submit assignments and review others' work. Expertiza also provides tools to visualize the scores and gauge the improvements made during the course semester. It also facilitates and monitors team projects. It is targeted at educational and non-profit organizations.

Expertiza is an open-source project with the source code available as a public repository on GitHub. It is developed using Ruby on Rails and is increasingly becoming robust thanks to the innumerable bugs being fixed by the community. The project has a micro-blog on SourceForge where the developer community report bugs and document updates.

=='''Problem Statement'''==

The existing interface for defining rubric is not very user friendly. The instructors or TAs are required to define the type of the field, the dimension of the fields (length, height), and possibly the content of the widget e.g., available options for a combo box. Unfortunately, after they are done with the design phase, to see the final result of the rubric that is going to be presented to the students, they have to impersonate students, create a fake submissions, move the due dates etc.

== '''Design''' ==
To create the drag-and-drop interface, we can use the [https://formbuilder.online jQuery formBuilder plugin].

The advantages of using this plugin are:

* 100% client-side plugin that gives users the power to create forms using an intuitive drag and drop interface.
* Customization - enable only the fields you need, use your own notifications append or prepend content and more.
* Bootstrap ready but not dependent

A mockup for an example form is given below:

[[File:JQuery.png|frame|upright|center|Sample Form using JQuery formBuilder]]

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-08T21:12:54Z

Msardar: /* Design */

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-08T21:11:46Z

Msardar: /* Design */ advantages

CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics

2016-11-08T21:06:56Z

Msardar: /* Design */ jQuery link

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:56:02Z

Msardar: /* Changes to GUI */

'''E1644: Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to View ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

To test that while creating an assignment team, the inherit teams section should be displayed, we login as instructor got to list page and click on Create Team Link. On this page we test that it should contain the string 'Inherit Teams From Course'.

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

To test that while creating a course team, the inherit teams section should not be displayed, we do same steps as previous case but finally we test that the page does NOT contain 'Inherit Teams from Course'

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

Similiarly, for creating a team for an assignment without a course, we test that the page does not contain 'Inherit Teams From Course'. For this particular test case, we added a new factory object for that defined an assignment with course set to nil.

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

This test checks that after creating an assignment team the count in the teams table increase by 1.

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end
it "redirects to the list page" do
end
end
end

The same test for a course team as well

context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end
end

===Testing Delete Method===

context "with an assignment team " do
it "deletes an assignment team" do
@assignment = create(:assignment)
@a_team = create(:assignment_team)
expect{ @a_team.delete }.to change(Team, :count).by(-1)
end
end

context "with a course team " do
it "deletes a course team" do
@course = create(:course)
@c_team = create(:course_team)
expect{ @c_team.delete }.to change(Team, :count).by(-1)
end
end

===Testing List Method===

describe 'List Team' do

it 'should list all team nodes' do
create(:assignment)
create(:assignment_node)
assignment_team = create(:assignment_team)
team_user = create(:team_user)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
page.all('#theTable tr').each do |tr|
expect(tr).to have_content?(assignment_team.name)
end
end
end

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:54:53Z

Msardar: /* Testing Create Method */

'''E1644: Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to GUI ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

To test that while creating an assignment team, the inherit teams section should be displayed, we login as instructor got to list page and click on Create Team Link. On this page we test that it should contain the string 'Inherit Teams From Course'.

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

To test that while creating a course team, the inherit teams section should not be displayed, we do same steps as previous case but finally we test that the page does NOT contain 'Inherit Teams from Course'

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

Similiarly, for creating a team for an assignment without a course, we test that the page does not contain 'Inherit Teams From Course'. For this particular test case, we added a new factory object for that defined an assignment with course set to nil.

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

This test checks that after creating an assignment team the count in the teams table increase by 1.

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end
it "redirects to the list page" do
end
end
end

The same test for a course team as well

context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end
end

===Testing Delete Method===

context "with an assignment team " do
it "deletes an assignment team" do
@assignment = create(:assignment)
@a_team = create(:assignment_team)
expect{ @a_team.delete }.to change(Team, :count).by(-1)
end
end

context "with a course team " do
it "deletes a course team" do
@course = create(:course)
@c_team = create(:course_team)
expect{ @c_team.delete }.to change(Team, :count).by(-1)
end
end

===Testing List Method===

describe 'List Team' do

it 'should list all team nodes' do
create(:assignment)
create(:assignment_node)
assignment_team = create(:assignment_team)
team_user = create(:team_user)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
page.all('#theTable tr').each do |tr|
expect(tr).to have_content?(assignment_team.name)
end
end
end

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:50:53Z

Msardar: /* Testing Inherit Method */

'''E1644: Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to GUI ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

To test that while creating an assignment team, the inherit teams section should be displayed, we login as instructor got to list page and click on Create Team Link. On this page we test that it should contain the string 'Inherit Teams From Course'.

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

To test that while creating a course team, the inherit teams section should not be displayed, we do same steps as previous case but finally we test that the page does NOT contain 'Inherit Teams from Course'

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

Similiarly, for creating a team for an assignment without a course, we test that the page does not contain 'Inherit Teams From Course'. For this particular test case, we added a new factory object for that defined an assignment with course set to nil.

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end
it "redirects to the list page" do
end
end
end

context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end
end

===Testing Delete Method===

context "with an assignment team " do
it "deletes an assignment team" do
@assignment = create(:assignment)
@a_team = create(:assignment_team)
expect{ @a_team.delete }.to change(Team, :count).by(-1)
end
end

context "with a course team " do
it "deletes a course team" do
@course = create(:course)
@c_team = create(:course_team)
expect{ @c_team.delete }.to change(Team, :count).by(-1)
end
end

===Testing List Method===

describe 'List Team' do

it 'should list all team nodes' do
create(:assignment)
create(:assignment_node)
assignment_team = create(:assignment_team)
team_user = create(:team_user)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
page.all('#theTable tr').each do |tr|
expect(tr).to have_content?(assignment_team.name)
end
end
end

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:21:45Z

Msardar:

'''E1644: Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to GUI ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end
it "redirects to the list page" do
end
end
end

context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end
end

===Testing Delete Method===

context "with an assignment team " do
it "deletes an assignment team" do
@assignment = create(:assignment)
@a_team = create(:assignment_team)
expect{ @a_team.delete }.to change(Team, :count).by(-1)
end
end

context "with a course team " do
it "deletes a course team" do
@course = create(:course)
@c_team = create(:course_team)
expect{ @c_team.delete }.to change(Team, :count).by(-1)
end
end

===Testing List Method===

describe 'List Team' do

it 'should list all team nodes' do
create(:assignment)
create(:assignment_node)
assignment_team = create(:assignment_team)
team_user = create(:team_user)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
page.all('#theTable tr').each do |tr|
expect(tr).to have_content?(assignment_team.name)
end
end
end

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:20:53Z

Msardar: /* Testing List Method */

'''E1644. Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to GUI ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end
it "redirects to the list page" do
end
end
end

context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end
end

===Testing Delete Method===

context "with an assignment team " do
it "deletes an assignment team" do
@assignment = create(:assignment)
@a_team = create(:assignment_team)
expect{ @a_team.delete }.to change(Team, :count).by(-1)
end
end

context "with a course team " do
it "deletes a course team" do
@course = create(:course)
@c_team = create(:course_team)
expect{ @c_team.delete }.to change(Team, :count).by(-1)
end
end

===Testing List Method===

describe 'List Team' do

it 'should list all team nodes' do
create(:assignment)
create(:assignment_node)
assignment_team = create(:assignment_team)
team_user = create(:team_user)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
page.all('#theTable tr').each do |tr|
expect(tr).to have_content?(assignment_team.name)
end
end
end

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:18:05Z

Msardar: /* Testing Delete Method */

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:17:32Z

Msardar: /* Testing Delete Method */

'''E1644. Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to GUI ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end
it "redirects to the list page" do
end
end
end

context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end
end

===Testing Delete Method===

context "with an assignment team " do
it "deletes an assignment team" do
@assignment = create(:assignment)
@a_team = create(:assignment_team)

expect{ @a_team.delete }.to change(Team, :count).by(-1)
end
end

context "with a course team " do
it "deletes a course team" do
@course = create(:course)
@c_team = create(:course_team)

expect{ @c_team.delete }.to change(Team, :count).by(-1)
end
end

===Testing List Method===

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:16:56Z

Msardar: /* Testing Create Method */

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:15:52Z

Msardar: /* Testing Create Method */

'''E1644. Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to GUI ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end
it "redirects to the list page" do
end
end

context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end
end

===Testing Delete Method===

===Testing List Method===

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:15:18Z

Msardar: /* Testing Create Method */

'''E1644. Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to GUI ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end
it "redirects to the list page" do
end
end
context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end
end

===Testing Delete Method===

===Testing List Method===

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T03:14:42Z

Msardar: /* Testing Create Method */

'''E1644. Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

== Changes to GUI ==
To fix the view for ''inherit teams'' functionality, changes to the view were made.

Initially, the code was:

Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>
<%= submit_tag "Inherit" %>

Which was changed to:

<% if not @parent.instance_of?(Course) and not @parent.course.nil? %>
Inherit Teams From Course
Use the teams that are currently defined for the course.
<%= form_tag :action => 'inherit' do %>
<%= hidden_field_tag 'id', @parent.id %>

<%= submit_tag "Inherit" %>
<% end %>

To fix the view, in the ''new.html.erb'' file of teams, we enclose the inherit teams section in an ''if condition'' that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

describe "POST #create" do
context "with an assignment team" do
it "increases count by 1" do
expect{create :assignment_team, assignment: @assignment}.to change(Team,:count).by(1)
end

it "redirects to the list page" do
end
end

context "with a course team" do
it "increases the count by 1" do
expect{create :course_team, course: @course}.to change(Team,:count).by(1)
end

end

===Testing Delete Method===

===Testing List Method===

==References==

CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller

2016-10-29T02:38:20Z

Msardar: /* Refactoring */

'''E1644. Refactor and Test 'Teams_Controller' Controller'''<ref>Project Description document https://google.com</ref>

This page provides a brief description of the '''Expertiza''' project. The project is aimed at refactoring and testing the 'Teams_Controller' Controller, which contains the methods to create new teams, list the existing teams, create new teams by inheriting existing teams, deleting existing teams and creating multiple teams at once by assigning them random topics. The project entailed, refactoring some part of the controller to improve the readability of code and then creating test cases in [https://en.wikipedia.org/wiki/RSpec RSpec] to verify the methods it possesses.

==Introduction to Expertiza==
[http://expertiza.ncsu.edu/ Expertiza] is a peer review based system which provides incremental learning from the class. This project has been developed together by faculty and students using [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create, edit and delete assignments, create new assignment topics, assign them to a particular class or selected students, have students work on teams and then review each other's assignments at the end. For the students, they can signup for topics, form teams, and submit their projects and assignments.
Students then review the work done by other students and give suggestions to improve. Teams after reviews are allotted scores and they can refer to the peer comments to further improve their work. It also supports submission of different file types for assignments, including the URLs and wiki pages.

== Project Description ==
'''Teams_Controller''' primarily handles the team creation, deletion and other behaviours. Most of those are called from the instructor’s view. When manual testing is done, most of the methods can be called by clicking the “Create teams” icon from both assignments and courses.
The following tasks have been performed as per the requirements.

As a part of the project, some GUI's changes had to be made because they did not work the way they should have, some minor issues in the code were fixed and tests were written in '''RSpec''' for the methods delete, create, create teams, list and inherit.

===Create Method===
The method '''Create''' is called when an instructor tries to create a team manually. This works for both, creating ''assignment teams'' and ''course teams''. Assignment teams are teams made to do a particular assignment together and ''Course Teams'' are teams which are made for the whole course.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to create course teams.

* To verify that the Instructor is able to create assignment teams.

===Delete Method===
The method '''Delete''' is called when an instructor tries to delete a team manually. This works for both, deleting ''assignment teams'' and ''course teams''.

Following Test Cases were written and executed in RSpec to test this method:

* To verify that the Instructor is able to delete course teams.

* To verify that the Instructor is able to delete assignment teams.

===List Method===
The method '''List''' lists all the team nodes and the instructor is able to expand each team node to see the user nodes as well.

Following Test Cases were written and executed in RSpec to test this method:

* To check that all teams are being listed in the view.

===Inherit Method===
The method '''Inherit''' inherits teams from course to assignments, but the “Inherit Teams From Course” option should not display when either 1) we are editing a course object or 2) the current assignment object does not have a course associated with it.

Following Test Cases were written and executed in RSpec to test this method:

* To check that ''inherit teams'' is displayed while creating an assignment team.

* To check that ''inherit teams'' is not displayed while creating a course team.

* To check that ''inherit teams'' is not displayed while creating teams for an assignment without a course.

== Refactoring ==
'''Refactoring'''<ref>Refactoring https://en.wikipedia.org/wiki/Code_refactoring</ref> is restructuring of code without the need of changing any external behavior. It reduces complexity and improves readability. It also becomes easy to extend the application with respect to different modules and their functionalities.
Some common techniques to refactor are:

* Moving methods to appropriate modules
* Breaking methods into more meaningful functionality
* Creating more generalized code.
* Renaming methods and variable.
* Inheritance

As the part of the project, the variable ''@signUps'' in the delete method in the teams_controller was changed to snake case, tp improve readability of code.

Changes in UI, to fix view for inherit team
In the new.html.erb file of teams, we enclose the inherit teams section in an if condition that checks that the parent of the team is not a Course and it is not an Assignment whose course is nil.

== Testing the Teams_Controller ==

===Testing Inherit Method===

it 'should display inherit teams while creating an assignment team' do
create(:assignment)
create(:assignment_node)
create(:assignment_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating a course team' do
create(:course)
create(:course_node)
create(:course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Course'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

it 'should not display inherit teams while creating team for an assignment without a course' do
create(:assignment_without_course)
create(:assignment_without_course_node)
create(:assignment_without_course_team)
login_as("instructor6")
visit '/teams/list?id=1&type=Assignment'
click_link 'Create Team'
expect(page).to have_no_content('Inherit Teams From Course')
end

===Testing Create Method===

===Testing Delete Method===

===Testing Inherit Method===

===Testing List Method===