Expertiza_Wiki - User contributions [en]

User:Lsanche

2015-12-18T06:17:19Z

Lsanche: Created page with "Edit Assignment"

[[Edit Assignment]]

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-11-01T04:07:33Z

Lsanche: /* Refactor get_content */

= E1551. Refactoring response_controller.rb =
== Expertiza ==

'''About Expertiza'''
Expertiza is an open source project accomplished by NCState students. It was developed in Ruby on Rails. It has general features like forming teams, registering for topics in a project, uploading the final deliveries. After completing the project there is an option for submitting reviews as well and updating the reviews. There is an option for submitting new quizzes as well.

== ResponseController ==
'''What it does''': response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
;Solution summary
:Renamed <code>latestResponseVersion</code> to <code>set_all_responses</code>.
==== Solution ====
Examining <code>latestResponseVersion</code> we were able to determine that it did the following two things:
# Set the <code>@prev</code> variable to a relation of responses that correspond to the map id of the current response being created or edited.
# Set the <code>@review_scores</code> variable to an Array version if the contents of <code>@prev</code>.
Since the purpose of the code seemed to be to set variables, we renamed it to <code>set_all_responses</code>.
We also simplified the method by using ActiveRecord::Relation's <code>to_a</code> to convert the relation to an array.
There was some duplicate code in the <code>scores</code> function which we replaced with a call the <code>set_all_responses</code>.

=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
'''Solution summary'''
: The method <code>get_scores</code> was renamed to <code>scores</code>.

=== Delete rereview method ===
;Problem definition
:The 100+-line method <code>rereview</code> does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.
;Solution summary
: The method <code>rereview</code> was deleted.

=== DRY create and update ===
;Problem definition
:<code>create</code> and <code>update</code> use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
;Solution summary
:There was not much actual overlap in these two methods. Minimal changes.
The ResponseController controller has an overall problem in that it knows too much about the subclasses of <code>ResponseMap</code>. There is some major refactoring that needs to occur to clean up this controller's coupling with <code>ResponseMap</code>'s subclasses. We made an attempt to do this, but it was just to large a change to accomplish in the time allotted.

=== Consistent authorization ===
;Problem definition
:Authorization needs to be checked in the <code>action_allowed</code> method instead of in <code>redirect_when_disallowed</code> at the bottom of the file.
;Solution summary
:So the functionality is moved from <code>redirect_when_disallowed</code> to <code>action_allowed</code>. And also it is made sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it and then removed the <code>redirect_when_disallowed</code> method.
:Code before changing

<code>
def action_allowed?
current_user
end

def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end

</code>
: Code after changing

<code>
def action_allowed?
case params[:action]
when 'view','edit','delete','update'
response = Response.find(params[:id])
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
current_user_id?(response.map.reviewer.user_id)
else
current_user
end
end
</code>

=== Refactor get_content ===
;Problem definition
:<code>get_content</code> is a complex method. It should be renamed to <code>content</code> and simplified. Comments should be added explaining what it does.
;Solution summary
:The <code>get_content</code> method was renamed <code>set_content</code>, simplified, and documented with comments.
A review of the <code>get_content</code> method showed that it's purpose was to '''set''' various variables for use by the response views. As such, we renamed this method <code>set_content</code> to help clarify it's intent.
We also extracted methods for the more complicated variables into their own methods, making the <code>set_content</code> method easy to understand at a glance.

=== Remove SQL queries ===
;Problem definition
:This class contains SQL queries. Please change them to Active Record commands.
;Solution summary
:No SQL queries were identified. No changes.

==Comparison of Original and Refactored Code==

Major refactoring revolved around changing method names according to rails convention, using helper methods for avoiding duplication of code in controller methods.

:Duplications in Code
::Original duplications : 172
::Post Refactoring : 21

Code Complexity (Compared on Code Climate)

'''Original ResponseController'''<ref name="originalresponsecontroller>''Original responseController'' https://github.com/expertiza/expertiza</ref>
 

[[File:Code_climate_response.png]]

'''Refactored Responsecontroller''' <ref name="Refactoredresponsecontroller>''Refactored responseController'' https://github.com/viswaraavi/expertiza</ref>
 

[[File:Code_climate_expertiza.png]]

== Tests ==
Some functional tests are written for this class using Rspec and Factorygirls.
;To check these tests.
*clone the github repository link provided above
*run the command rspec spec/controllers/response_controller_spec.rb

==References==
<references>

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-11-01T04:02:58Z

Lsanche: /* DRY create and update */

= E1551. Refactoring response_controller.rb =
== Expertiza ==

'''About Expertiza'''
Expertiza is an open source project accomplished by NCState students. It was developed in Ruby on Rails. It has general features like forming teams, registering for topics in a project, uploading the final deliveries. After completing the project there is an option for submitting reviews as well and updating the reviews. There is an option for submitting new quizzes as well.

== ResponseController ==
'''What it does''': response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
;Solution summary
:Renamed <code>latestResponseVersion</code> to <code>set_all_responses</code>.
==== Solution ====
Examining <code>latestResponseVersion</code> we were able to determine that it did the following two things:
# Set the <code>@prev</code> variable to a relation of responses that correspond to the map id of the current response being created or edited.
# Set the <code>@review_scores</code> variable to an Array version if the contents of <code>@prev</code>.
Since the purpose of the code seemed to be to set variables, we renamed it to <code>set_all_responses</code>.
We also simplified the method by using ActiveRecord::Relation's <code>to_a</code> to convert the relation to an array.
There was some duplicate code in the <code>scores</code> function which we replaced with a call the <code>set_all_responses</code>.

=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
'''Solution summary'''
: The method <code>get_scores</code> was renamed to <code>scores</code>.

=== Delete rereview method ===
;Problem definition
:The 100+-line method <code>rereview</code> does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.
;Solution summary
: The method <code>rereview</code> was deleted.

=== DRY create and update ===
;Problem definition
:<code>create</code> and <code>update</code> use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
;Solution summary
:There was not much actual overlap in these two methods. Minimal changes.
The ResponseController controller has an overall problem in that it knows too much about the subclasses of <code>ResponseMap</code>. There is some major refactoring that needs to occur to clean up this controller's coupling with <code>ResponseMap</code>'s subclasses. We made an attempt to do this, but it was just to large a change to accomplish in the time allotted.

=== Consistent authorization ===
;Problem definition
:Authorization needs to be checked in the <code>action_allowed</code> method instead of in <code>redirect_when_disallowed</code> at the bottom of the file.
;Solution summary
:So the functionality is moved from <code>redirect_when_disallowed</code> to <code>action_allowed</code>. And also it is made sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it and then removed the <code>redirect_when_disallowed</code> method.
:Code before changing

<code>
def action_allowed?
current_user
end

def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end

</code>
: Code after changing

<code>
def action_allowed?
case params[:action]
when 'view','edit','delete','update'
response = Response.find(params[:id])
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
current_user_id?(response.map.reviewer.user_id)
else
current_user
end
end
</code>

=== Refactor get_content ===
;Problem definition
:<code>get_content</code> is a complex method. It should be renamed to <code>content</code> and simplified. Comments should be added explaining what it does.
;Solution summary
:The <code>get_content</code> method was renamed <code>set_content</code>, simplified, and documented with comments.
=== Remove SQL queries ===
;Problem definition
:This class contains SQL queries. Please change them to Active Record commands.
;Solution summary
:No SQL queries were identified. No changes.

==Comparison of Original and Refactored Code==

Major refactoring revolved around changing method names according to rails convention, using helper methods for avoiding duplication of code in controller methods.

:Duplications in Code
::Original duplications : 172
::Post Refactoring : 21

Code Complexity (Compared on Code Climate)

'''Original ResponseController'''<ref name="originalresponsecontroller>''Original responseController'' https://github.com/expertiza/expertiza</ref>
 

[[File:Code_climate_response.png]]

'''Refactored Responsecontroller''' <ref name="Refactoredresponsecontroller>''Refactored responseController'' https://github.com/viswaraavi/expertiza</ref>
 

[[File:Code_climate_expertiza.png]]

== Tests ==
Some functional tests are written for this class using Rspec and Factorygirls.
;To check these tests.
*clone the github repository link provided above
*run the command rspec spec/controllers/response_controller_spec.rb

==References==
<references>

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-11-01T03:59:48Z

Lsanche: /* Refactor latestResponseVersion method */

= E1551. Refactoring response_controller.rb =
== Expertiza ==

'''About Expertiza'''
Expertiza is an open source project accomplished by NCState students. It was developed in Ruby on Rails. It has general features like forming teams, registering for topics in a project, uploading the final deliveries. After completing the project there is an option for submitting reviews as well and updating the reviews. There is an option for submitting new quizzes as well.

== ResponseController ==
'''What it does''': response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
;Solution summary
:Renamed <code>latestResponseVersion</code> to <code>set_all_responses</code>.
==== Solution ====
Examining <code>latestResponseVersion</code> we were able to determine that it did the following two things:
# Set the <code>@prev</code> variable to a relation of responses that correspond to the map id of the current response being created or edited.
# Set the <code>@review_scores</code> variable to an Array version if the contents of <code>@prev</code>.
Since the purpose of the code seemed to be to set variables, we renamed it to <code>set_all_responses</code>.
We also simplified the method by using ActiveRecord::Relation's <code>to_a</code> to convert the relation to an array.
There was some duplicate code in the <code>scores</code> function which we replaced with a call the <code>set_all_responses</code>.

=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
'''Solution summary'''
: The method <code>get_scores</code> was renamed to <code>scores</code>.

=== Delete rereview method ===
;Problem definition
:The 100+-line method <code>rereview</code> does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.
;Solution summary
: The method <code>rereview</code> was deleted.

=== DRY create and update ===
;Problem definition
:<code>create</code> and <code>update</code> use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
;Solution summary
:There was not much actual overlap in these two methods. Minimal changes.
=== Consistent authorization ===
;Problem definition
:Authorization needs to be checked in the <code>action_allowed</code> method instead of in <code>redirect_when_disallowed</code> at the bottom of the file.
;Solution summary
:So the functionality is moved from <code>redirect_when_disallowed</code> to <code>action_allowed</code>. And also it is made sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it and then removed the <code>redirect_when_disallowed</code> method.
:Code before changing

<code>
def action_allowed?
current_user
end

def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end

</code>
: Code after changing

<code>
def action_allowed?
case params[:action]
when 'view','edit','delete','update'
response = Response.find(params[:id])
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
current_user_id?(response.map.reviewer.user_id)
else
current_user
end
end
</code>

=== Refactor get_content ===
;Problem definition
:<code>get_content</code> is a complex method. It should be renamed to <code>content</code> and simplified. Comments should be added explaining what it does.
;Solution summary
:The <code>get_content</code> method was renamed <code>set_content</code>, simplified, and documented with comments.
=== Remove SQL queries ===
;Problem definition
:This class contains SQL queries. Please change them to Active Record commands.
;Solution summary
:No SQL queries were identified. No changes.

==Comparison of Original and Refactored Code==

Major refactoring revolved around changing method names according to rails convention, using helper methods for avoiding duplication of code in controller methods.

:Duplications in Code
::Original duplications : 172
::Post Refactoring : 21

Code Complexity (Compared on Code Climate)

'''Original ResponseController'''<ref name="originalresponsecontroller>''Original responseController'' https://github.com/expertiza/expertiza</ref>
 

[[File:Code_climate_response.png]]

'''Refactored Responsecontroller''' <ref name="Refactoredresponsecontroller>''Refactored responseController'' https://github.com/viswaraavi/expertiza</ref>
 

[[File:Code_climate_expertiza.png]]

== Tests ==
Some functional tests are written for this class using Rspec and Factorygirls.
;To check these tests.
*clone the github repository link provided above
*run the command rspec spec/controllers/response_controller_spec.rb

==References==
<references>

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T20:11:15Z

Lsanche: /* Changes */

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
The ResponseController manages Responses.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
=== Delete rereview method ===
;Problem definition
:The 100+-line method <code>rearview</code> does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.
;Solution summary
: The method <code>rearview</code> was deleted.
=== DRY create and update ===
;Problem definition
:<code>create</code> and <code>update</code> use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
;Solution summary
:There was not much actual overlap in these two methods. Minimal changes.
=== Consistent authorization ===
;Problem definition
:Authorization needs to be checked in the <code>action_allowed</code> method instead of in <code>redirect_when_disallowed</code> at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the <code>redirect_when_disallowed</code> method.
;Solution summary
:
=== Refactor get_content ===
;Problem definition
:<code>get_content</code> is a complex method. It should be renamed to <code>content</code> and simplified. Comments should be added explaining what it does.
;Solution summary
:The <code>get_content</code> method was renamed <code>set_content</code>, simplified, and documented with comments.
=== Remove SQL queries ===
;Problem definition
:This class contains SQL queries. Please change them to Active Record commands.
;Solution summary
:No SQL queries were identified. No changes.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:

Please write some functional tests for this class.

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T20:07:30Z

Lsanche: /* Refactor get_content */

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
The ResponseController manages Responses.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
=== Delete rereview method ===
The 100+-line method <code>rearview</code> does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.

=== DRY create and update ===
<code>create</code> and <code>update</code> use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.

=== Consistent authorization ===
Authorization needs to be checked in the <code>action_allowed</code> method instead of in <code>redirect_when_disallowed</code> at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the <code>redirect_when_disallowed</code> method.

=== Refactor get_content ===
<code>get_content</code> is a complex method. It should be renamed to <code>content</code> and simplified. Comments should be added explaining what it does.

=== Remove SQL queries ===
This class contains SQL queries. Please change them to Active Record commands.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:

Please write some functional tests for this class.

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T20:06:05Z

Lsanche: /* Consistent authorization */

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
The ResponseController manages Responses.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
=== Delete rereview method ===
The 100+-line method <code>rearview</code> does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.

=== DRY create and update ===
<code>create</code> and <code>update</code> use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.

=== Consistent authorization ===
Authorization needs to be checked in the <code>action_allowed</code> method instead of in <code>redirect_when_disallowed</code> at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the <code>redirect_when_disallowed</code> method.

=== Refactor get_content ===
get_content is a complex method. It should be renamed to content and simplified. Comments should be added explaining what it does.
=== Remove SQL queries ===
This class contains SQL queries. Please change them to Active Record commands.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:

Please write some functional tests for this class.

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T20:05:35Z

Lsanche: /* DRY create and update */

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
The ResponseController manages Responses.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
=== Delete rereview method ===
The 100+-line method <code>rearview</code> does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.

=== DRY create and update ===
<code>create</code> and <code>update</code> use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.

=== Consistent authorization ===
Authorization needs to be checked in the action_allowed method instead of in redirect_when_disallowed at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the redirect_when_disallowed method.
=== Refactor get_content ===
get_content is a complex method. It should be renamed to content and simplified. Comments should be added explaining what it does.
=== Remove SQL queries ===
This class contains SQL queries. Please change them to Active Record commands.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:

Please write some functional tests for this class.

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T20:05:07Z

Lsanche: /* Delete rereview method */

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
The ResponseController manages Responses.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
=== Delete rereview method ===
The 100+-line method <code>rearview</code> does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.

=== DRY create and update ===
create and update use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
=== Consistent authorization ===
Authorization needs to be checked in the action_allowed method instead of in redirect_when_disallowed at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the redirect_when_disallowed method.
=== Refactor get_content ===
get_content is a complex method. It should be renamed to content and simplified. Comments should be added explaining what it does.
=== Remove SQL queries ===
This class contains SQL queries. Please change them to Active Record commands.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:

Please write some functional tests for this class.

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T20:03:28Z

Lsanche: /* Changes */

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
The ResponseController manages Responses.

== Changes ==
=== Refactor latestResponseVersion method ===
;Problem definition
:<code>latestResponseVersion</code> is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
=== Rename get_scores ===
;Problem definition
:<code>get_scores</code> has a Java-like name. It should just be <code>scores</code>.
=== Delete rereview method ===
The 100+-line method rereview does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.
=== DRY create and update ===
create and update use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
=== Consistent authorization ===
Authorization needs to be checked in the action_allowed method instead of in redirect_when_disallowed at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the redirect_when_disallowed method.
=== Refactor get_content ===
get_content is a complex method. It should be renamed to content and simplified. Comments should be added explaining what it does.
=== Remove SQL queries ===
This class contains SQL queries. Please change them to Active Record commands.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:

Please write some functional tests for this class.

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T19:57:14Z

Lsanche:

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
The ResponseController manages Responses.

== Changes ==
=== Refactor latestResponseVersion method ===
latestResponseVersion is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
get_scores has a Java-like name. It should just be scores.
=== Delete rereview method ===
The 100+-line method rereview does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.
=== DRY create and update ===
create and update use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
=== Consistent authorization ===
Authorization needs to be checked in the action_allowed method instead of in redirect_when_disallowed at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the redirect_when_disallowed method.
=== Refactor get_content ===
get_content is a complex method. It should be renamed to content and simplified. Comments should be added explaining what it does.
=== Remove SQL queries ===
This class contains SQL queries. Please change them to Active Record commands.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:

Please write some functional tests for this class.

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T19:54:18Z

Lsanche: /* ResponseController */

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
The ResponseController manages Responses.

== Changes ==

=== Remove SQL queries ===
This class contains SQL queries. Please change them to Active Record commands.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:
latestResponseVersion is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
get_scores has a Java-like name. It should just be scores.
The 100+-line method rereview does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.
create and update use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
Authorization needs to be checked in the action_allowed method instead of in redirect_when_disallowed at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the redirect_when_disallowed method.
get_content is a complex method. It should be renamed to content and simplified. Comments should be added explaining what it does.
Please write some functional tests for this class.

CSC/ECE 517 Fall 2015/oss E1551 RGS

2015-10-30T19:53:10Z

Lsanche: Created page with "= E1551. Refactoring response_controller.rb = == Expertiza == == ResponseController == == Changes == === Remove SQL queries === This class contains SQL queries. Please change t..."

= E1551. Refactoring response_controller.rb =
== Expertiza ==
== ResponseController ==
== Changes ==

=== Remove SQL queries ===
This class contains SQL queries. Please change them to Active Record commands.

== Tests ==
Contact: Ed Gehringer, efg@ncsu.edu
What it does: response_controller.rb manages Responses. A Response is what is generated any time a user fills out a rubric--any rubric. This includes review rubrics, author-feedback rubrics, teammate-review rubrics, quizzes, and surveys.
Responses come in versions. Any time an author revises work, and the reviewer comes back to review it, a new Response object is generated. This Response object points to a particular ReponseMap, which tells who the reviewer is, which team is the reviewee, and what the reviewed entity is.
What needs to be done:
latestResponseVersion is misnamed. It returns all versions of a response, and anyway, the method name should use underscores, not camelcase.
get_scores has a Java-like name. It should just be scores.
The 100+-line method rereview does not seem to be used anymore. The second-round review can be invoked in the same way as the first-round review. Remove it.
create and update use completely different code. Factor the common parts out into a partial, thereby simplifying the methods.
Authorization needs to be checked in the action_allowed method instead of in redirect_when_disallowed at the bottom of the file. After you move the functionality, check to make sure that no one other than the author of a review (or another team member, in the case of author feedback) can edit it, then remove the redirect_when_disallowed method.
get_content is a complex method. It should be renamed to content and simplified. Comments should be added explaining what it does.
Please write some functional tests for this class.

CSC/ECE 517 Fall 2015

2015-10-30T19:20:30Z

Lsanche: /* Writing Assignment 2 */

==Writing Assignment 2==
*[[CSC/ECE_517_Fall_2015/sample_page]]
*[[CSC/ECE_517_Fall_2015/ossE1558BGJ]]
*[[CSC/ECE 517 Fall 2015/oss/M1502/AAAASS]]
*[[CSC/ECE 517 Fall 2015/oss/M1503/IntegrateXMLParser]]
*[[CSC/ECE_517_Fall_2015/ossE1568BZHXJS]]
*[[CSC/ECE_517_Fall_2015/ossE1572VGA]]
*[[CSC/ECE_517_Fall_2015/oss_E1573_sap]]
*[[CSC/ECE 517 Fall 2015/oss E1559 rrz]]
*[[CSC/ECE 517 Fall 2015/oss E1570 avr]]
*[[CSC/ECE 517 Fall 2015/oss E1556 CHM]]
*[[CSC/ECE 517 Fall 2015/oss M1504 JJD]]
*[[CSC/ECE 517 Fall 2015/oss E1562 APS]]
*[[CSC/ECE 517 Fall 2015/oss M1501 GSN]]
*[[CSC/ECE 517 Fall 2015/oss M1501 GSN]]
*[[CSC/ECE 517 Fall 2015/oss E1551 RGS]]
*[[CSC/ECE 517 Fall 2015/oss E1555 GMR]]
*[[CSC/ECE 517 Fall 2015/oss E1552 NRR]]
*[[CSC/ECE 517 Fall 2015/oss E1565 AAJ]]
*[[CSC/ECE 517 Fall 2015/oss E1561 WZL]]