https://wiki.expertiza.ncsu.edu/api.php?action=feedcontributions&feedformat=atom&user=Lpatel 2026-05-22T07:32:39Z User contributions MediaWiki 1.41.0 https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2024_-_E2407_Refactor_review_mapping_controller.rb&diff=153054 2024-03-23T03:11:56Z

<p>Lpatel: /* Tasks */</p> <hr /> <div>This wiki page describes changes made under the E2407 OODD assignment for Spring 2024, CSC/ECE 517.<br /> == Expertiza Background==<br /> <br /> Expertiza is an open-source initiative that educators and students at NCSU create and manage. It contains several features that facilitate teacher-student interactions and is built on the Ruby on Rails architecture. Teachers can set homework and grade student submissions. Students organize into groups, turn in assignments, and evaluate the work of their colleagues.<br /> <br /> <br /> [ Link to the Pull Request Submitted] &lt;br/&gt;<br /> [ Link to the deployed project] &lt;br/&gt;<br /> [ Link to the Repository] &lt;br/&gt;<br /> <br /> == Functionality of review_mapping_controller ==<br /> Review_mapping_controller's function is to supply reviewer and assignment mapping. In essence, the controller manages the assignment of reviews, such as peer and self-reviews, to several teams or to a single student user. Following assignment policy, this controller is also in charge of responding to requests from students for additional bonus evaluations.<br /> <br /> <br /> == Problem Statement ==<br /> <br /> The review_mapping_controller is a long and complex file. Most of the methods are sparsely commented on. Some methods are way too long to understand, please break them down into pieces for better understanding. Also, the few instances of code duplication that exist should also be removed.<br /> <br /> == Tasks ==<br /> -Refactor the long methods in review_mapping_controller.rb like assign_reviewer_dynamically, add_reviewer, automatic_review_mapping, peer_review_strategy, etc.<br /> -Rename variable names to convey what they are used for.&lt;br/&gt;<br /> -Replace switch statements with subclasses methods.&lt;br/&gt;<br /> -Create models for the subclasses.&lt;br/&gt;<br /> -Remove hardcoded parameters.&lt;br/&gt;<br /> -Add meaningful comments and edit/remove/do not unnecessary comments.&lt;br/&gt;<br /> -Try to increase the test coverage.&lt;br/&gt;<br /> <br /> == Design Pattern ==<br /> <br /> We followed several design patterns while refactoring our code. One of the most common ones is the “Extract Method.” There were several instances where the method was too long and complex. We moved some of the functionality to a different method to make it more readable. This way, it became easier and clearer to understand what the method achieved. <br /> Another issue we observed with the code was that it had too many conditional statements. We used the “Refactoring conditionals” design pattern, which aims to place the block of code in the conditional statement in a different method and call that method. This improves the readability of our code.</div>

Lpatel https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2024_-_E2407_Refactor_review_mapping_controller.rb&diff=153053 2024-03-23T03:11:48Z

<p>Lpatel: </p> <hr /> <div>This wiki page describes changes made under the E2407 OODD assignment for Spring 2024, CSC/ECE 517.<br /> == Expertiza Background==<br /> <br /> Expertiza is an open-source initiative that educators and students at NCSU create and manage. It contains several features that facilitate teacher-student interactions and is built on the Ruby on Rails architecture. Teachers can set homework and grade student submissions. Students organize into groups, turn in assignments, and evaluate the work of their colleagues.<br /> <br /> <br /> [ Link to the Pull Request Submitted] &lt;br/&gt;<br /> [ Link to the deployed project] &lt;br/&gt;<br /> [ Link to the Repository] &lt;br/&gt;<br /> <br /> == Functionality of review_mapping_controller ==<br /> Review_mapping_controller's function is to supply reviewer and assignment mapping. In essence, the controller manages the assignment of reviews, such as peer and self-reviews, to several teams or to a single student user. Following assignment policy, this controller is also in charge of responding to requests from students for additional bonus evaluations.<br /> <br /> <br /> == Problem Statement ==<br /> <br /> The review_mapping_controller is a long and complex file. Most of the methods are sparsely commented on. Some methods are way too long to understand, please break them down into pieces for better understanding. Also, the few instances of code duplication that exist should also be removed.<br /> <br /> == Tasks ==<br /> -Refactor the long methods in review_mapping_controller.rb like assign_reviewer_dynamically, add_reviewer, automatic_review_mapping, peer_review_strategy, etc.<br /> -Rename variable names to convey what they are used for.&lt;br/&gt;<br /> -Replace switch statements with subclasses methods.&lt;br/&gt;<br /> -Create models for the subclasses.&lt;br/&gt;<br /> -Remove hardcoded parameters.&lt;br/&gt;<br /> -Add meaningful comments and edit/remove/do not unnecessary comments.&lt;br/&gt;<br /> -Try to increase the test coverage.&lt;br/&gt;<br /> -<br /> <br /> == Design Pattern ==<br /> <br /> We followed several design patterns while refactoring our code. One of the most common ones is the “Extract Method.” There were several instances where the method was too long and complex. We moved some of the functionality to a different method to make it more readable. This way, it became easier and clearer to understand what the method achieved. <br /> Another issue we observed with the code was that it had too many conditional statements. We used the “Refactoring conditionals” design pattern, which aims to place the block of code in the conditional statement in a different method and call that method. This improves the readability of our code.</div>

Lpatel https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2024_-_E2407_Refactor_review_mapping_controller.rb&diff=153052 2024-03-23T03:09:35Z

<p>Lpatel: </p> <hr /> <div>This wiki page describes changes made under the E2407 OODD assignment for Spring 2024, CSC/ECE 517.<br /> == Expertiza Background==<br /> <br /> Expertiza is an open-source initiative that educators and students at NCSU create and manage. It contains several features that facilitate teacher-student interactions and is built on the Ruby on Rails architecture. Teachers can set homework and grade student submissions. Students organize into groups, turn in assignments, and evaluate the work of their colleagues.<br /> <br /> <br /> [ Link to the Pull Request Submitted] &lt;br/&gt;<br /> [ Link to the deployed project] &lt;br/&gt;<br /> [ Link to the Repository] &lt;br/&gt;<br /> <br /> == Functionality of review_mapping_controller ==<br /> Review_mapping_controller's function is to supply reviewer and assignment mapping. In essence, the controller manages the assignment of reviews, such as peer and self-reviews, to several teams or to a single student user. Following assignment policy, this controller is also in charge of responding to requests from students for additional bonus evaluations.<br /> <br /> <br /> == Problem Statement ==<br /> <br /> The review_mapping_controller is a long and complex file. Most of the methods are sparsely commented on. Some methods are way too long to understand, please break them down into pieces for better understanding. Also, the few instances of code duplication that exist should also be removed.<br /> <br /> == Tasks ==<br /> -Refactor the long methods in review_mapping_controller.rb &lt;br/&gt;<br /> -Rename variable names such as student_review_num, submission_review_num, calibrated_artifacts_num, participants_hash to convey what they are actually used for&lt;br/&gt;<br /> -Replace switch statements with subclasses methods &lt;br/&gt;<br /> -Create models for the subclasses&lt;br/&gt;<br /> -Remove hardcoded parameters&lt;br/&gt;<br /> <br /> == Design Pattern ==<br /> <br /> We followed several design patterns while refactoring our code. One of the most common ones is the “Extract Method.” There were several instances where the method was too long and complex. We moved some of the functionality to a different method to make it more readable. This way, it became easier and clearer to understand what the method achieved. <br /> Another issue we observed with the code was that it had too many conditional statements. We used the “Refactoring conditionals” design pattern, which aims to place the block of code in the conditional statement in a different method and call that method. This improves the readability of our code.</div>

Lpatel https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2024_-_E2407_Refactor_review_mapping_controller.rb&diff=153050 2024-03-23T03:00:36Z

<p>Lpatel: </p> <hr /> <div>This wiki page describes changes made under the E2407 OODD assignment for Spring 2024, CSC/ECE 517.<br /> == Expertiza Background==<br /> <br /> Expertiza is an open-source initiative that educators and students at NCSU create and manage. It contains several features that facilitate teacher-student interactions and is built on the Ruby on Rails architecture. Teachers can set homework and grade student submissions. Students organize into groups, turn in assignments, and evaluate the work of their colleagues.<br /> <br /> <br /> == Description of the project ==<br /> The review_mapping_controller is a long and complex file. Most of the methods are sparsely commented on. Some methods are way too long to understand, please break them down into pieces for better understanding. Also, the few instances of code duplication that exist should be removed. &lt;br/&gt; &lt;br/&gt;<br /> [https://github.com/expertiza/expertiza/pull/2303 Link to the Pull Request Submitted] &lt;br/&gt;<br /> [http://152.7.98.87:8080/ Link to the deployed project] &lt;br/&gt;<br /> [https://github.com/SriPallaviDamuluri/expertiza Link to the Repository] &lt;br/&gt;<br /> <br /> == Functionality of review_mapping_controller ==<br /> The functionality of review_mapping_controller is to provide mapping for reviewer and assignment. Basically, the controller handles assignment of reviews to different teams or single student user, such as the event of peer review and self review. Also, this controller is responsible to respond student user request for extra bonus reviews based on assignment policy.<br /> <br /> == Problem Statement ==<br /> <br /> The review_mapping_controller is a long and complex file. Most of the methods are sparsely commented on. Some methods are way too long to understand, please break them down into pieces for better understanding. Also, the few instances of code duplication that exist should also be removed.<br /> <br /> == Tasks ==<br /> -Refactor the long methods in review_mapping_controller.rb &lt;br/&gt;<br /> -Rename variable names such as student_review_num, submission_review_num, calibrated_artifacts_num, participants_hash to convey what they are actually used for&lt;br/&gt;<br /> -Replace switch statements with subclasses methods &lt;br/&gt;<br /> -Create models for the subclasses&lt;br/&gt;<br /> -Remove hardcoded parameters&lt;br/&gt;<br /> <br /> == Design Pattern ==<br /> <br /> We followed several design patterns while refactoring our code. One of the most common ones is the “Extract Method.” There were several instances where the method was too long and complex. We moved some of the functionality to a different method to make it more readable. This way, it became easier and clearer to understand what the method achieved. <br /> Another issue we observed with the code was that it had too many conditional statements. We used the “Refactoring conditionals” design pattern, which aims to place the block of code in the conditional statement in a different method and call that method. This improves the readability of our code.</div>

Lpatel https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2024_-_E2407_Refactor_review_mapping_controller.rb&diff=153049 2024-03-23T02:22:33Z

<p>Lpatel: </p> <hr /> <div>This wiki page describes changes made under the E2407 OODD assignment for Spring 2024, CSC/ECE 517.</div>

Lpatel https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2024_-_E2407_Refactor_review_mapping_controller.rb&diff=153048 2024-03-23T02:21:45Z

<p>Lpatel: Created page with &quot;hello&quot;</p> <hr /> <div>hello</div>

Lpatel https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2024&diff=153047 2024-03-23T02:21:29Z

<p>Lpatel: </p> <hr /> <div>* [[CSC/ECE 517 Spring 2024 - E2407 Refactor review_mapping_controller.rb]]<br /> * [[CSC/ECE 517 Spring 2024 - E2428 Replicate Roles and Institution UIs ReactJS]]<br /> * [[CSC/ECE 517 Spring 2024 - E2429 Reimplement student_task list]]<br /> * [[CSC/ECE 517 Spring 2024 - E2414 Grading Audit Trail]]<br /> * [[CSC/ECE 517 Spring 2024 - ‬NTNX-2‬‭ : Snapshot Functionality for provisioned databases]]<br /> * [[CSC/ECE 517 Spring 2024 - E2411 : Fix &quot;Back&quot; link on “New Late Policy” page]]<br /> * [[CSC/ECE 517 Spring 2024 - E2420. Reimplement student_quizzes_controller]]</div>

Lpatel https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2024&diff=153046 2024-03-23T02:20:45Z

<p>Lpatel: </p> <hr /> <div>* [[CSC/ECE 517 Spring 2024 - E2407 Refactor review_mapping_controller.rb<br /> * [[CSC/ECE 517 Spring 2024 - E2428 Replicate Roles and Institution UIs ReactJS]]<br /> * [[CSC/ECE 517 Spring 2024 - E2429 Reimplement student_task list]]<br /> * [[CSC/ECE 517 Spring 2024 - E2414 Grading Audit Trail]]<br /> * [[CSC/ECE 517 Spring 2024 - ‬NTNX-2‬‭ : Snapshot Functionality for provisioned databases]]<br /> * [[CSC/ECE 517 Spring 2024 - E2411 : Fix &quot;Back&quot; link on “New Late Policy” page]]<br /> * [[CSC/ECE 517 Spring 2024 - E2420. Reimplement student_quizzes_controller]]</div>

Lpatel