Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-28T05:36:55Z

Kbisht: /* Issue 2 */

This wiki page is for the description of changes made under E1792 OSS Visualizations for instructors.

__TOC__

== About Expertiza ==

[http://expertiza.ncsu.edu/ Expertiza] is an open source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Instructors can also use Expertiza for interactive views of class performances and reviews.

== Introduction ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== Problem Statement ==
:* Issue 1: The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.
:* Issue 2: Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.
:*Issue 3:The table is presorted by teams in the page View Scores, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.
:*Issue 4: An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show the instructors what they need to focus more attention on.

== UML Diagram ==
 [[File:uml_g_b_1.jpg]] 

== Solutions Implemented ==
===Issue 1===
'''Description:'''The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach:''' Here the color coding is blue to green and also it changes randomly which one color in one graph may represent some other score in the next graph. To fix this issue, we have redefined the highchart_colors data structure to contain the colors defined in the grades.scss file (already defined earlier) as suggested by the Professor. This way no matter what scale is being used it will always have appropriate color coding. Also, the color legend is now appropriate to explain correctly the color-code used.

highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")

 Related screenshot [[File:graph_g_b_1.jpg]] 

===Issue 2===
'''Description:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach:''' Here the problem was that the data was represented rubric-wise, that is, if there are 5 rubrics, there would be 5 graphs. A graph for a particular rubric would show the performance of a team in that rubric in all rounds of submissions. This is fine when the rubrics are same for all the rounds. But, since rubric 1 of round 1 may not be same as rubric 1 of round 2, therefore this representation seems illogical. In our approach, the graphs are rendered submission-wise, the performance of a team in all rubrics in a particular round are shown in one graph pertaining to that round of submission.

We create an array called chart_data to hold the information for creating the highchart stack charts.
Data is now stored in the highchart in form of hash-maps which contain the score as key and score pertaining to different rounds of reviews as value. Earlier, data was stored in the hash map in a way that in the value scores pertaining to different rubrics were getting stored. Our process facilitates the graph/chart formation submission/round-wise instead of rubric-wise (earlier approach). This guarantees the data is represented logically. In the earlier approach, data was represented rubric-wise. A graph for a particular rubric would show the performance of a team in that rubric in all rounds. But, since rubric 1 of round 1 may not be same as rubric 1 of round 2, therefore this representation seems illogical. Now, the graphs are submission-wise, the performance of a team in all rubrics in a particular round are shown in one graph pertaining to that round of submission. This addresses the problem of varying rubric by round. We can now have different number of rubrics in different rounds without affecting the visualizations for instructors.

def get_highchart_data(team_data, assignment, min, max, number_of_review_questions)
chart_data = {} # @chart_data is supposed to hold the general information for creating the highchart stack charts
for i in 1..number_of_review_questions
chart_data[i] = Hash[(min..max).map {|score| [score, Array.new(assignment.rounds_of_reviews, 0)] }]
end
team_data.each do |team|
team.each do |vm|
next if vm.round.nil?
j = 1
vm.list_of_rows.each do |row|
row.score_row.each do |score|
unless score.score_value.nil?
#chart_data[vm.round][score.score_value][j] += 1
chart_data[j][score.score_value][vm.round-1] += 1
end
end
j += 1
end
end
end
chart_data
end

vm is an object of the model 'VmQuestionResponse' (was already defined earlier).
It contains the following information:

@list_of_rows = []
@list_of_reviewers = []
@list_of_reviews = []
@list_of_team_participants = []
@max_score = questionnaire.max_question_score
@questionnaire_type = questionnaire.type
@questionnaire_display_type = questionnaire.display_type
@rounds = rounds
@round = round
@name = questionnaire.name

Here we build the 'series' array which is used by the highchart object to render the graph.
This array holds the actual data for the chart along with the legend name.
By introducing the counter count_rounds corresponding to the counter for rounds, we are able to compress the legends of highchart to a standard form, showing only what is required.
Also, we have redefined the highchart_colors data structure to contain the colors defined in the grades.scss file (already defined earlier) as suggested by the Professor.

def generate_highchart(chart_data, min, max, number_of_review_questions, assignment, team_data)
# Here we actually build the 'series' array which will be used directly in the highchart Object in the _team_charts view file
# This array holds the actual data of our chart with legend name
highchart_series_data = []

count_rounds=0
chart_data.each do |round, scores|
scores.to_a.reverse.to_h.each do |score, rubric_distribution|
if count_rounds == 0
highchart_series_data.push(name: "Score #{score}", data: rubric_distribution, stack: "S#{round}")
else
highchart_series_data.push(linkedTo: "previous",name: "Rubric #{round} - Score #{score}", data: rubric_distribution, stack: "S#{round}")
end
end
count_rounds = count_rounds + 1
end
# Here we dynamically creates the categories which will be used later in the highchart Object
highchart_categories = []
for i in 1..@assignment.rounds_of_reviews
highchart_categories.push("Submission #{i}")
end
# Here we dynamically create an array of the colors which the highchart uses to show the stack charts.
# Currently we create 6 different colors based on the assumption that we always have scores from 0 to 5.
highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")
[highchart_series_data, highchart_categories, highchart_colors]
end

Related screenshot [[File:graph_g_b_2.jpg]] 

===Issue 3===
'''Description''': The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

Approach: Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

Related screenshot [[File:graph_g_b_4.jpg]] 

===Issue 4===
'''Description:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach:''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.Scores will be color coded for each of the rubrics in each of the submissions. When hovered over the graph , for each score, the instructor should see the number of students , the percentage of students that has scored that particular point in that rubric in that submission.

The code snippet used to fix Issue 4 is same as that used to fix Issue 2. The graphs that we are rendering by making use of highcharts addresses this Issue.

Related screenshot [[File:graph_g_b_3.jpg]] 

== Test Plan ==
===Issue 1:Check if color coding from red to green for a range of score===
*1) Login as instructor
*2) Create a dummy assignment and come dummy reviews for the same.Log out.
*3) Login as a student. Attempt the assignment. Log out.
*4) Login as another student and repeat step 3.
*5) Login as either student and attempt the review. Logout.
*6) Login as instructor. Go to Review grades page and check the table. If color code ranges from red ( for least score) to green ( for highest score), then test passed.

===Issue 2:Check if different graph visible for different review submission===
*1) Login as instructor.
*2) Create an assignment. Select 2 reviews. Also select different rubrics for both reviews.
*3) Login as a student ("A") and submit the assignment. Repeat this for another student("B").
*4) Login as student A and perform review. Do this for student B too.
*5) Now resubmit assignment as student A and B again.
*6) Resubmit reviews as student A and B again. This time the rubrics will be different from the previous round.
*7) Now login as instructor and see the visualization of the reviews. You can see the different graphs for different submissions.

===Issue 3:Check if the table is sorted with appropriate column alphabetically===
*1) Login as instructor
*2) Create a dummy assignment with some teams. Logout.
*3) Login as a student and attempt the assignment and logout.
*4) Repeat step 3 for all dummy teams.
*5) Login as instructor.
*6) Go to View Scores page. Check the grade table.
*7) Click on a column header and check if data in it is getting sorted alphabetically. If yes, then the test passed.

===Issue 4:Check if graph in Issue 3 shows how a class performed on selected rubric criteria===
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

== References ==
*[https://github.com/expertiza/expertiza Expertiza repo]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[https://api.highcharts.com/highcharts Highcharts API]

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-28T05:33:36Z

Kbisht: /* Issue 4 */

This wiki page is for the description of changes made under E1792 OSS Visualizations for instructors.

__TOC__

== About Expertiza ==

[http://expertiza.ncsu.edu/ Expertiza] is an open source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Instructors can also use Expertiza for interactive views of class performances and reviews.

== Introduction ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== Problem Statement ==
:* Issue 1: The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.
:* Issue 2: Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.
:*Issue 3:The table is presorted by teams in the page View Scores, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.
:*Issue 4: An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show the instructors what they need to focus more attention on.

== UML Diagram ==
 [[File:uml_g_b_1.jpg]] 

== Solutions Implemented ==
===Issue 1===
'''Description:'''The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach:''' Here the color coding is blue to green and also it changes randomly which one color in one graph may represent some other score in the next graph. To fix this issue, we have redefined the highchart_colors data structure to contain the colors defined in the grades.scss file (already defined earlier) as suggested by the Professor. This way no matter what scale is being used it will always have appropriate color coding. Also, the color legend is now appropriate to explain correctly the color-code used.

highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")

 Related screenshot [[File:graph_g_b_1.jpg]] 

===Issue 2===
'''Description:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach:''' Here the problem was that the data was represented rubric-wise, that is, if there are 5 rubrics, there would be 5 graphs. A graph for a particular rubric would show the performance of a team in that rubric in all rounds of submissions. This is fine when the rubrics are same for all the rounds. But, since rubric 1 of round 1 may not be same as rubric 1 of round 2, therefore this representation seems illogical. In our approach, the graphs are rendered submission-wise, the performance of a team in all rubrics in a particular round are shown in one graph pertaining to that round of submission.

We create an array called chart_data to hold the information for creating the highchart stack charts.

def get_highchart_data(team_data, assignment, min, max, number_of_review_questions)
chart_data = {} # @chart_data is supposed to hold the general information for creating the highchart stack charts
for i in 1..number_of_review_questions
chart_data[i] = Hash[(min..max).map {|score| [score, Array.new(assignment.rounds_of_reviews, 0)] }]
end
team_data.each do |team|
team.each do |vm|
next if vm.round.nil?
j = 1
vm.list_of_rows.each do |row|
row.score_row.each do |score|
unless score.score_value.nil?
#chart_data[vm.round][score.score_value][j] += 1
chart_data[j][score.score_value][vm.round-1] += 1
end
end
j += 1
end
end
end
chart_data
end

vm is an object of the model 'VmQuestionResponse' (was already defined earlier).
It contains the following information:

@list_of_rows = []
@list_of_reviewers = []
@list_of_reviews = []
@list_of_team_participants = []
@max_score = questionnaire.max_question_score
@questionnaire_type = questionnaire.type
@questionnaire_display_type = questionnaire.display_type
@rounds = rounds
@round = round
@name = questionnaire.name

Data is now stored in the highchart in form of hash-maps which contain the score as key and score pertaining to different rounds of reviews as value. Earlier, data was stored in the hash map in a way that in the value scores pertaining to different rubrics were getting stored. Our process facilitates the graph/chart formation submission/round-wise instead of rubric-wise (earlier approach). This guarantees the data is represented logically. In the earlier approach, data was represented rubric-wise. A graph for a particular rubric would show the performance of a team in that rubric in all rounds. But, since rubric 1 of round 1 may not be same as rubric 1 of round 2, therefore this representation seems illogical. Now, the graphs are submission-wise, the performance of a team in all rubrics in a particular round are shown in one graph pertaining to that round of submission. This addresses the problem of varying rubric by round. We can now have different number of rubrics in different rounds without affecting the visualizations for instructors.

def generate_highchart(chart_data, min, max, number_of_review_questions, assignment, team_data)
# Here we actually build the 'series' array which will be used directly in the highchart Object in the _team_charts view file
# This array holds the actual data of our chart with legend name
highchart_series_data = []

count_rounds=0
chart_data.each do |round, scores|
scores.to_a.reverse.to_h.each do |score, rubric_distribution|
if count_rounds == 0
highchart_series_data.push(name: "Score #{score}", data: rubric_distribution, stack: "S#{round}")
else
highchart_series_data.push(linkedTo: "previous",name: "Rubric #{round} - Score #{score}", data: rubric_distribution, stack: "S#{round}")
end
end
count_rounds = count_rounds + 1
end
# Here we dynamically creates the categories which will be used later in the highchart Object
highchart_categories = []
for i in 1..@assignment.rounds_of_reviews
highchart_categories.push("Submission #{i}")
end
# Here we dynamically create an array of the colors which the highchart uses to show the stack charts.
# Currently we create 6 different colors based on the assumption that we always have scores from 0 to 5.
highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")
[highchart_series_data, highchart_categories, highchart_colors]
end

Here we build the 'series' array which is used by the highchart object to render the graph.
This array holds the actual data for the chart along with the legend name.
By introducing the counter count_rounds corresponding to the counter for rounds, we are able to compress the legends of highchart to a standard form, showing only what is required.
Also, we have redefined the highchart_colors data structure to contain the colors defined in the grades.scss file (already defined earlier) as suggested by the Professor.

Related screenshot [[File:graph_g_b_2.jpg]] 

===Issue 3===
'''Description''': The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

Approach: Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

Related screenshot [[File:graph_g_b_4.jpg]] 

===Issue 4===
'''Description:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach:''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.Scores will be color coded for each of the rubrics in each of the submissions. When hovered over the graph , for each score, the instructor should see the number of students , the percentage of students that has scored that particular point in that rubric in that submission.

The code snippet used to fix Issue 4 is same as that used to fix Issue 2. The graphs that we are rendering by making use of highcharts addresses this Issue.

Related screenshot [[File:graph_g_b_3.jpg]] 

== Test Plan ==
===Issue 1:Check if color coding from red to green for a range of score===
*1) Login as instructor
*2) Create a dummy assignment and come dummy reviews for the same.Log out.
*3) Login as a student. Attempt the assignment. Log out.
*4) Login as another student and repeat step 3.
*5) Login as either student and attempt the review. Logout.
*6) Login as instructor. Go to Review grades page and check the table. If color code ranges from red ( for least score) to green ( for highest score), then test passed.

===Issue 2:Check if different graph visible for different review submission===
*1) Login as instructor.
*2) Create an assignment. Select 2 reviews. Also select different rubrics for both reviews.
*3) Login as a student ("A") and submit the assignment. Repeat this for another student("B").
*4) Login as student A and perform review. Do this for student B too.
*5) Now resubmit assignment as student A and B again.
*6) Resubmit reviews as student A and B again. This time the rubrics will be different from the previous round.
*7) Now login as instructor and see the visualization of the reviews. You can see the different graphs for different submissions.

===Issue 3:Check if the table is sorted with appropriate column alphabetically===
*1) Login as instructor
*2) Create a dummy assignment with some teams. Logout.
*3) Login as a student and attempt the assignment and logout.
*4) Repeat step 3 for all dummy teams.
*5) Login as instructor.
*6) Go to View Scores page. Check the grade table.
*7) Click on a column header and check if data in it is getting sorted alphabetically. If yes, then the test passed.

===Issue 4:Check if graph in Issue 3 shows how a class performed on selected rubric criteria===
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

== References ==
*[https://github.com/expertiza/expertiza Expertiza repo]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[https://api.highcharts.com/highcharts Highcharts API]

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-28T05:30:54Z

Kbisht: /* Issue 2 */

This wiki page is for the description of changes made under E1792 OSS Visualizations for instructors.

__TOC__

== About Expertiza ==

[http://expertiza.ncsu.edu/ Expertiza] is an open source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Instructors can also use Expertiza for interactive views of class performances and reviews.

== Introduction ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== Problem Statement ==
:* Issue 1: The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.
:* Issue 2: Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.
:*Issue 3:The table is presorted by teams in the page View Scores, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.
:*Issue 4: An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show the instructors what they need to focus more attention on.

== UML Diagram ==
 [[File:uml_g_b_1.jpg]] 

== Solutions Implemented ==
===Issue 1===
'''Description:'''The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach:''' Here the color coding is blue to green and also it changes randomly which one color in one graph may represent some other score in the next graph. To fix this issue, we have redefined the highchart_colors data structure to contain the colors defined in the grades.scss file (already defined earlier) as suggested by the Professor. This way no matter what scale is being used it will always have appropriate color coding. Also, the color legend is now appropriate to explain correctly the color-code used.

highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")

 Related screenshot [[File:graph_g_b_1.jpg]] 

===Issue 2===
'''Description:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach:''' Here the problem was that the data was represented rubric-wise, that is, if there are 5 rubrics, there would be 5 graphs. A graph for a particular rubric would show the performance of a team in that rubric in all rounds of submissions. This is fine when the rubrics are same for all the rounds. But, since rubric 1 of round 1 may not be same as rubric 1 of round 2, therefore this representation seems illogical. In our approach, the graphs are rendered submission-wise, the performance of a team in all rubrics in a particular round are shown in one graph pertaining to that round of submission.

We create an array called chart_data to hold the information for creating the highchart stack charts.

def get_highchart_data(team_data, assignment, min, max, number_of_review_questions)
chart_data = {} # @chart_data is supposed to hold the general information for creating the highchart stack charts
for i in 1..number_of_review_questions
chart_data[i] = Hash[(min..max).map {|score| [score, Array.new(assignment.rounds_of_reviews, 0)] }]
end
team_data.each do |team|
team.each do |vm|
next if vm.round.nil?
j = 1
vm.list_of_rows.each do |row|
row.score_row.each do |score|
unless score.score_value.nil?
#chart_data[vm.round][score.score_value][j] += 1
chart_data[j][score.score_value][vm.round-1] += 1
end
end
j += 1
end
end
end
chart_data
end

vm is an object of the model 'VmQuestionResponse' (was already defined earlier).
It contains the following information:

@list_of_rows = []
@list_of_reviewers = []
@list_of_reviews = []
@list_of_team_participants = []
@max_score = questionnaire.max_question_score
@questionnaire_type = questionnaire.type
@questionnaire_display_type = questionnaire.display_type
@rounds = rounds
@round = round
@name = questionnaire.name

Data is now stored in the highchart in form of hash-maps which contain the score as key and score pertaining to different rounds of reviews as value. Earlier, data was stored in the hash map in a way that in the value scores pertaining to different rubrics were getting stored. Our process facilitates the graph/chart formation submission/round-wise instead of rubric-wise (earlier approach). This guarantees the data is represented logically. In the earlier approach, data was represented rubric-wise. A graph for a particular rubric would show the performance of a team in that rubric in all rounds. But, since rubric 1 of round 1 may not be same as rubric 1 of round 2, therefore this representation seems illogical. Now, the graphs are submission-wise, the performance of a team in all rubrics in a particular round are shown in one graph pertaining to that round of submission. This addresses the problem of varying rubric by round. We can now have different number of rubrics in different rounds without affecting the visualizations for instructors.

def generate_highchart(chart_data, min, max, number_of_review_questions, assignment, team_data)
# Here we actually build the 'series' array which will be used directly in the highchart Object in the _team_charts view file
# This array holds the actual data of our chart with legend name
highchart_series_data = []

count_rounds=0
chart_data.each do |round, scores|
scores.to_a.reverse.to_h.each do |score, rubric_distribution|
if count_rounds == 0
highchart_series_data.push(name: "Score #{score}", data: rubric_distribution, stack: "S#{round}")
else
highchart_series_data.push(linkedTo: "previous",name: "Rubric #{round} - Score #{score}", data: rubric_distribution, stack: "S#{round}")
end
end
count_rounds = count_rounds + 1
end
# Here we dynamically creates the categories which will be used later in the highchart Object
highchart_categories = []
for i in 1..@assignment.rounds_of_reviews
highchart_categories.push("Submission #{i}")
end
# Here we dynamically create an array of the colors which the highchart uses to show the stack charts.
# Currently we create 6 different colors based on the assumption that we always have scores from 0 to 5.
highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")
[highchart_series_data, highchart_categories, highchart_colors]
end

Here we build the 'series' array which is used by the highchart object to render the graph.
This array holds the actual data for the chart along with the legend name.
By introducing the counter count_rounds corresponding to the counter for rounds, we are able to compress the legends of highchart to a standard form, showing only what is required.
Also, we have redefined the highchart_colors data structure to contain the colors defined in the grades.scss file (already defined earlier) as suggested by the Professor.

Related screenshot [[File:graph_g_b_2.jpg]] 

===Issue 3===
'''Description''': The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

Approach: Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

Related screenshot [[File:graph_g_b_4.jpg]] 

===Issue 4===
'''Description:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach:''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.Scores will be color coded for each of the rubrics in each of the submissions. When hovered over the graph , for each score, the instructor should see the number of students , the percentage of students that has scored that particular point in that rubric in that submission.

Related screenshot [[File:graph_g_b_3.jpg]] 

== Test Plan ==
===Issue 1:Check if color coding from red to green for a range of score===
*1) Login as instructor
*2) Create a dummy assignment and come dummy reviews for the same.Log out.
*3) Login as a student. Attempt the assignment. Log out.
*4) Login as another student and repeat step 3.
*5) Login as either student and attempt the review. Logout.
*6) Login as instructor. Go to Review grades page and check the table. If color code ranges from red ( for least score) to green ( for highest score), then test passed.

===Issue 2:Check if different graph visible for different review submission===
*1) Login as instructor.
*2) Create an assignment. Select 2 reviews. Also select different rubrics for both reviews.
*3) Login as a student ("A") and submit the assignment. Repeat this for another student("B").
*4) Login as student A and perform review. Do this for student B too.
*5) Now resubmit assignment as student A and B again.
*6) Resubmit reviews as student A and B again. This time the rubrics will be different from the previous round.
*7) Now login as instructor and see the visualization of the reviews. You can see the different graphs for different submissions.

===Issue 3:Check if the table is sorted with appropriate column alphabetically===
*1) Login as instructor
*2) Create a dummy assignment with some teams. Logout.
*3) Login as a student and attempt the assignment and logout.
*4) Repeat step 3 for all dummy teams.
*5) Login as instructor.
*6) Go to View Scores page. Check the grade table.
*7) Click on a column header and check if data in it is getting sorted alphabetically. If yes, then the test passed.

===Issue 4:Check if graph in Issue 3 shows how a class performed on selected rubric criteria===
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

== References ==
*[https://github.com/expertiza/expertiza Expertiza repo]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[https://api.highcharts.com/highcharts Highcharts API]

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-28T05:19:44Z

Kbisht: /* Issue 2 */

This wiki page is for the description of changes made under E1792 OSS Visualizations for instructors.

__TOC__

== About Expertiza ==

[http://expertiza.ncsu.edu/ Expertiza] is an open source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Instructors can also use Expertiza for interactive views of class performances and reviews.

== Introduction ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== Problem Statement ==
:* Issue 1: The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.
:* Issue 2: Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.
:*Issue 3:The table is presorted by teams in the page View Scores, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.
:*Issue 4: An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show the instructors what they need to focus more attention on.

== UML Diagram ==
 [[File:uml_g_b_1.jpg]] 

== Solutions Implemented ==
===Issue 1===
'''Description:'''The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach:''' Here the color coding is blue to green and also it changes randomly which one color in one graph may represent some other score in the next graph. To fix this issue, we have redefined the highchart_colors data structure to contain the colors defined in the grades.scss file (already defined earlier) as suggested by the Professor. This way no matter what scale is being used it will always have appropriate color coding. Also, the color legend is now appropriate to explain correctly the color-code used.

highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")

 Related screenshot [[File:graph_g_b_1.jpg]] 

===Issue 2===
'''Description:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach:''' Here The problem is that the the review responses show in a grid format that shows all the reviews from round 1 to round n. But this is ok when the rubrics is same for all the rounds. But when the rubric is different from round to round this view doesn't make sense. So what we are thinking is creating different grid for each review round. That will solve the problem for when the rubric is different as well as when the rubric is same.

def get_highchart_data(team_data, assignment, min, max, number_of_review_questions)
chart_data = {} # @chart_data is supposed to hold the general information for creating the highchart stack charts
for i in 1..number_of_review_questions
chart_data[i] = Hash[(min..max).map {|score| [score, Array.new(assignment.rounds_of_reviews, 0)] }]
end
team_data.each do |team|
team.each do |vm|
next if vm.round.nil?
j = 1
vm.list_of_rows.each do |row|
row.score_row.each do |score|
unless score.score_value.nil?
#chart_data[vm.round][score.score_value][j] += 1
chart_data[j][score.score_value][vm.round-1] += 1
end
end
j += 1
end
end
end
chart_data
end

@list_of_rows = []
@list_of_reviewers = []
@list_of_reviews = []
@list_of_team_participants = []
@max_score = questionnaire.max_question_score
@questionnaire_type = questionnaire.type
@questionnaire_display_type = questionnaire.display_type
@rounds = rounds
@round = round
@name = questionnaire.name

def generate_highchart(chart_data, min, max, number_of_review_questions, assignment, team_data)
# Here we actually build the 'series' array which will be used directly in the highchart Object in the _team_charts view file
# This array holds the actual data of our chart with legend name
highchart_series_data = []

count_rounds=0
chart_data.each do |round, scores|
scores.to_a.reverse.to_h.each do |score, rubric_distribution|
if count_rounds == 0
highchart_series_data.push(name: "Score #{score}", data: rubric_distribution, stack: "S#{round}")
else
highchart_series_data.push(linkedTo: "previous",name: "Rubric #{round} - Score #{score}", data: rubric_distribution, stack: "S#{round}")
end
end
count_rounds = count_rounds + 1
end
# Here we dynamically creates the categories which will be used later in the highchart Object
highchart_categories = []
for i in 1..@assignment.rounds_of_reviews
highchart_categories.push("Submission #{i}")
end
# Here we dynamically create an array of the colors which the highchart uses to show the stack charts.
# Currently we create 6 different colors based on the assumption that we always have scores from 0 to 5.
highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")
[highchart_series_data, highchart_categories, highchart_colors]
end

Related screenshot [[File:graph_g_b_2.jpg]] 

===Issue 3===
'''Description''': The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

Approach: Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

Related screenshot [[File:graph_g_b_4.jpg]] 

===Issue 4===
'''Description:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach:''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.Scores will be color coded for each of the rubrics in each of the submissions. When hovered over the graph , for each score, the instructor should see the number of students , the percentage of students that has scored that particular point in that rubric in that submission.

Related screenshot [[File:graph_g_b_3.jpg]] 

== Test Plan ==
===Issue 1:Check if color coding from red to green for a range of score===
*1) Login as instructor
*2) Create a dummy assignment and come dummy reviews for the same.Log out.
*3) Login as a student. Attempt the assignment. Log out.
*4) Login as another student and repeat step 3.
*5) Login as either student and attempt the review. Logout.
*6) Login as instructor. Go to Review grades page and check the table. If color code ranges from red ( for least score) to green ( for highest score), then test passed.

===Issue 2:Check if different graph visible for different review submission===
*1) Login as instructor.
*2) Create an assignment. Select 2 reviews. Also select different rubrics for both reviews.
*3) Login as a student ("A") and submit the assignment. Repeat this for another student("B").
*4) Login as student A and perform review. Do this for student B too.
*5) Now resubmit assignment as student A and B again.
*6) Resubmit reviews as student A and B again. This time the rubrics will be different from the previous round.
*7) Now login as instructor and see the visualization of the reviews. You can see the different graphs for different submissions.

===Issue 3:Check if the table is sorted with appropriate column alphabetically===
*1) Login as instructor
*2) Create a dummy assignment with some teams. Logout.
*3) Login as a student and attempt the assignment and logout.
*4) Repeat step 3 for all dummy teams.
*5) Login as instructor.
*6) Go to View Scores page. Check the grade table.
*7) Click on a column header and check if data in it is getting sorted alphabetically. If yes, then the test passed.

===Issue 4:Check if graph in Issue 3 shows how a class performed on selected rubric criteria===
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

== References ==
*[https://github.com/expertiza/expertiza Expertiza repo]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[https://api.highcharts.com/highcharts Highcharts API]

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-28T05:18:17Z

Kbisht: /* Issue 2 */

This wiki page is for the description of changes made under E1792 OSS Visualizations for instructors.

__TOC__

== About Expertiza ==

[http://expertiza.ncsu.edu/ Expertiza] is an open source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Instructors can also use Expertiza for interactive views of class performances and reviews.

== Introduction ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== Problem Statement ==
:* Issue 1: The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.
:* Issue 2: Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.
:*Issue 3:The table is presorted by teams in the page View Scores, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.
:*Issue 4: An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show the instructors what they need to focus more attention on.

== UML Diagram ==
 [[File:uml_g_b_1.jpg]] 

== Solutions Implemented ==
===Issue 1===
'''Description:'''The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach:''' Here the color coding is blue to green and also it changes randomly which one color in one graph may represent some other score in the next graph. To fix this issue, we have redefined the highchart_colors data structure to contain the colors defined in the grades.scss file (already defined earlier) as suggested by the Professor. This way no matter what scale is being used it will always have appropriate color coding. Also, the color legend is now appropriate to explain correctly the color-code used.

highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")

 Related screenshot [[File:graph_g_b_1.jpg]] 

===Issue 2===
'''Description:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach:''' Here The problem is that the the review responses show in a grid format that shows all the reviews from round 1 to round n. But this is ok when the rubrics is same for all the rounds. But when the rubric is different from round to round this view doesn't make sense. So what we are thinking is creating different grid for each review round. That will solve the problem for when the rubric is different as well as when the rubric is same.

def get_highchart_data(team_data, assignment, min, max, number_of_review_questions)
chart_data = {} # @chart_data is supposed to hold the general information for creating the highchart stack charts
for i in 1..number_of_review_questions
chart_data[i] = Hash[(min..max).map {|score| [score, Array.new(assignment.rounds_of_reviews, 0)] }]
end
team_data.each do |team|
team.each do |vm|
next if vm.round.nil?
j = 1
vm.list_of_rows.each do |row|
row.score_row.each do |score|
unless score.score_value.nil?
#chart_data[vm.round][score.score_value][j] += 1
chart_data[j][score.score_value][vm.round-1] += 1
end
end
j += 1
end
end
end
chart_data
end

@list_of_rows = []
@list_of_reviewers = []
@list_of_reviews = []
@list_of_team_participants = []
@max_score = questionnaire.max_question_score
@questionnaire_type = questionnaire.type
@questionnaire_display_type = questionnaire.display_type
@rounds = rounds
@round = round
@name = questionnaire.name

def generate_highchart(chart_data, min, max, number_of_review_questions, assignment, team_data)
# Here we actually build the 'series' array which will be used directly in the highchart Object in the _team_charts view file
# This array holds the actual data of our chart with legend name
highchart_series_data = []

count_rounds=0
chart_data.each do |round, scores|
scores.to_a.reverse.to_h.each do |score, rubric_distribution|
if count_rounds == 0
highchart_series_data.push(name: "Score #{score}", data: rubric_distribution, stack: "S#{round}")
else
highchart_series_data.push(linkedTo: "previous",name: "Rubric #{round} - Score #{score}", data: rubric_distribution, stack: "S#{round}")
end
end
count_rounds = count_rounds + 1
end

# Here we dynamically creates the categories which will be used later in the highchart Object
highchart_categories = []
for i in 1..@assignment.rounds_of_reviews
highchart_categories.push("Submission #{i}")
end

# Here we dynamically create an array of the colors which the highchart uses to show the stack charts.
# Currently we create 6 different colors based on the assumption that we always have scores from 0 to 5.

highchart_colors = []
highchart_colors.push("#2DE636")
highchart_colors.push("#BCED91")
highchart_colors.push("#FFEC8B")
highchart_colors.push("#FD992D")
highchart_colors.push("#ff8080")
highchart_colors.push("#FD422D")

[highchart_series_data, highchart_categories, highchart_colors]
end

Related screenshot [[File:graph_g_b_2.jpg]] 

===Issue 3===
'''Description''': The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

Approach: Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

Related screenshot [[File:graph_g_b_4.jpg]] 

===Issue 4===
'''Description:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach:''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.Scores will be color coded for each of the rubrics in each of the submissions. When hovered over the graph , for each score, the instructor should see the number of students , the percentage of students that has scored that particular point in that rubric in that submission.

Related screenshot [[File:graph_g_b_3.jpg]] 

== Test Plan ==
===Issue 1:Check if color coding from red to green for a range of score===
*1) Login as instructor
*2) Create a dummy assignment and come dummy reviews for the same.Log out.
*3) Login as a student. Attempt the assignment. Log out.
*4) Login as another student and repeat step 3.
*5) Login as either student and attempt the review. Logout.
*6) Login as instructor. Go to Review grades page and check the table. If color code ranges from red ( for least score) to green ( for highest score), then test passed.

===Issue 2:Check if different graph visible for different review submission===
*1) Login as instructor.
*2) Create an assignment. Select 2 reviews. Also select different rubrics for both reviews.
*3) Login as a student ("A") and submit the assignment. Repeat this for another student("B").
*4) Login as student A and perform review. Do this for student B too.
*5) Now resubmit assignment as student A and B again.
*6) Resubmit reviews as student A and B again. This time the rubrics will be different from the previous round.
*7) Now login as instructor and see the visualization of the reviews. You can see the different graphs for different submissions.

===Issue 3:Check if the table is sorted with appropriate column alphabetically===
*1) Login as instructor
*2) Create a dummy assignment with some teams. Logout.
*3) Login as a student and attempt the assignment and logout.
*4) Repeat step 3 for all dummy teams.
*5) Login as instructor.
*6) Go to View Scores page. Check the grade table.
*7) Click on a column header and check if data in it is getting sorted alphabetically. If yes, then the test passed.

===Issue 4:Check if graph in Issue 3 shows how a class performed on selected rubric criteria===
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

== References ==
*[https://github.com/expertiza/expertiza Expertiza repo]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[https://api.highcharts.com/highcharts Highcharts API]

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-28T02:14:39Z

Kbisht:

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-16T20:52:16Z

Kbisht: /* Test Plan */

This page provides a description of the expertiza based project for Fall 2017.

__TOC__

== '''Introduction''' ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== '''Problem Statement''' ==

'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Issue 4:''' The table is presorted by teams in the page View Scores, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show the instructors what they need to focus more attention on.

'''Issue 6:''' Integration of review performance- The basic aim of this implementation is to somehow combine an author’s feedback on a review and the corresponding review of a reviewer, to build a method for grading the reviewers.

Basic rubrics to be considered: 
-Number of reviews completed 
-Length of reviews 
-Summary of reviews 
-Whether reviewers added a file or link to their review 
-The average ratings they received from the author. 
A graph or table is prefered for easing this change. 

== '''Approach to be followed to fix the issues''' ==
'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Approach to solve issue 1:''' The issue is about the cell contains link to different pages in expertiza, but there is no way to know which cell is linked to which page. So user don't know the destination page when he/she clicks on some page. So we know that there is link in each cell, so we will show a hover over text displaying the link of the destination page.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach to solve issue 2:''' Here the color coding is blue to green and also it changes randomly. So we will use RBG color coding to make it red to green. We will use percentage to decide color coding. For example if it between 0 - 20% then make it red and so on. This way no matter what scale is being used it will always have appropriate color coding.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach to solve issue 3:''' Here The problem is that the the review responses show in a grid format that shows all the reviews from round 1 to round n. But this is ok when the rubrics is same for all the rounds. But when the rubric is different from round to round this view doesn't make sense. So what we are thinking is creating different grid for each review round. That will solve the problem for when the rubric is different as well as when the rubric is same.

'''Issue 4:''' The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Approach to solve issue 4:''' Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach to solve issue 5 :''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.A proposed solution may be use the below logic of calculating average grade for each student on all assignments in a particular course from the controller assessment360_controller.rb

[[File:scr2.PNG]] 
The average grades of each student can be pulled and then used to plot a bar graph as shown below ( This has been created by using a dummy data ) :- 
[[File:Dummydata.PNG]] 
Graph for class performance on Assignment 1 :- 
[[File:Assignment1.PNG]] 
Graph for class performance on Assignment 2 :- 
[[File:Assignment2.PNG]] 
Graph for class performance on Assignment 3 :- 
[[File:Assignment3.PNG]] 
Graph for class performance on Assignment 4 :- 
[[File:Assignment4.PNG]] 
Graph for class performance on Assignment 5 :- 
[[File:Assignment5.PNG]] 
Graph for class performance on Average Class performance :- 
[[File:Average.PNG]] 
The work flow can be approximately like the below diagram :- 
[[File:Workflow.PNG]] 

'''Issue 6:''' Integration of review performance- The basic aim of this implementation is to somehow combine an author’s feedback on a review and the corresponding review of a reviewer, to build a method for grading the reviewers.
Basic rubrics to be considered: 
-Number of reviews completed 
-Length of reviews 
-Summary of reviews 
-Whether reviewers added a file or link to their review 
-The average ratings they received from the author. 
-A graph or table is prefered for easing this change. 

'''Approach to solve issue 6:''' The entire focus is on to what extent a review could help the author. The latter’s feedback is always available in the form of numerical scores. We intend to capture the author’s score of the review topic-wise like that of tone of review, plausible solutions to problems suggested by reviewer and the rate of how much it helped the author to improve(scored by himself). 
-In each round of review done, the author’s feedback is noted topic-wise as suggested in the previous step and ''possibly generate a graph comparing the “n” rounds of reviews''. 
-If reviewer added ''a legit file or link to their review'', then we propose to add a few extra credits to the reviewer that can be added to their final grade.
The author’s feedback in the form of an average number can be taken and if that value exceeds that of a threshold , then the reviews were really meaningful. 

For example -
Consider author’s feedback as follows for 2 rounds of reviews:

 
[[File:ExampleTableForAuthorFeedback.PNG]] 

Observations: Mean score of round 1 is 3 and Mean score of round 2 is 1.9. 
Suppose , we take into account that Round of 1 has more importance than the second one because it helps a reviewer improve, and also that every reviewer should atleast provide 2 suggestions or comments that help authors improve. Then the threshold value is considered to be 2 and the Mean score of round 1 > threshold. 
Therefore, the reviews were meaningful and deserves a credit in the higher range of grades. If the mean score of round 1 < threshold then the mean score of round 2 is compared with the threshold. 
''Overall : Mean round 1> threshold : Higher range of grade to reviewer. 
Mean round 1<threshold : Check if Mean round 2 > threshold 
If true , Medium range of grade to reviewer. 
Else , lower range of grades. ''
Now once it’s decided in what range a reviewer deserves credit, The other factors like ''summary of review'' and ''length of review'' are taken into account by the instructors and graded according to the effectiveness of concepts explained in it. Also if a reviewer misses the second round of review then only the first round is taken into consideration. ''The instructor should believe that all but the last round of reviews are crucial to improve a document.'' 
'''Graphs:'''Can be generated for comparing the effectiveness of the “n” rounds of reviews for the authors depending on the author’s score. 

In this case - (only an example visualization)

 
[[File:ExampleGraph.PNG]] 
Observations: The graph and table together suggest that round 1 of the review actually had an impact on the author.

----

== '''Test Plan''' ==
'''Issue 1:''' Check the link matches to the hover over text
*1) Login as instructor
*2) Go to View Scores page. Hover over a cell.
*3) You will see a link being displayed upon hovering. Click on the cell.
*4) If the system directs you to the link that was displayed upon hovering, then the test passed.

'''Issue 2:''' Check the color coding when different number is given in different scale.
*1) Login as instructor
*2) Create a dummy assignment and come dummy reviews for the same.Log out.
*3) Login as a student. Attempt the assignment. Log out.
*4) Login as another student and repeat step 3.
*5) Login as either student and attempt the review. Logout.
*6) Login as instructor. Go to Review grades page and check the table. If color code ranges from red ( for least score) to green ( for highest score), then test passed.

'''Issue 3:''' Enter multiple reviews with different rubric and check different table/grid shows for each review round separately.
*1) Login as instructor.
*2) Create an assignment. Select 2 reviews. Also select different rubrics for both reviews.
*3) Login as a student ("A") and submit the assignment. Repeat this for another student("B").
*4) Login as student A and perform review. Do this for student B too.
*5) Now resubmit assignment as student A and B again.
*6) Resubmit reviews as student A and B again. This time the rubrics will be different from the previous round.
*7) Now login as instructor and see the visualization of the reviews. You can see the different graphs for different submissions.

'''Issue 4:''' Check if the table is sorted with appropriate column alphabetically
*1) Login as instructor
*2) Create a dummy assignment with some teams. Logout.
*3) Login as a student and attempt the assignment and logout.
*4) Repeat step 3 for all dummy teams.
*5) Login as instructor.
*6) Go to View Scores page. Check the grade table.
*7) Click on a column header and check if data in it is getting sorted alphabetically. If yes, then the test passed.

'''Issue 5:'''
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

'''Issue 6:''' Since it is a new algorithm being proposed, we intend to test it first manually using dummy datasets. Later on, automated test cases can be added for the same.
*1) Login as an instructor and create a dummy assignment with 2 rounds of review submissions. Assign 2 teams to that assignment of 1 student each. Also, put the deadline of first review as "1 hour". Log out
*2) Login as a student and submit some data for the assignment. Log out.
*3) Login as the second student and submit the same assignment using dummy data. Log out.
All the above steps will help us reach towards the section of reviews.
*4) Login as the first student and go to "Other's work" and request for a review document.By default, you will be assigned the document of the second student to review. Once assigned, complete that review with dummy scores. Log out.
*5) Login as the second student. Check the review in "Your scores" page and click on the section "Show review". There you can provide scored feedback to the reviewer. Definitely take into account the tone, solutions suggested and how it will help you. Log out.
*6) Login as the first student after the deadline for the first review completes. Go to "Other's work" and request for a new submission. You will be assigned the same document of the other student to review for the second round. Follow step 4.
*7) Login as the second student and follow step 5.
*8) The system has the data related to author's feedback and the reviewer's data and will calculate the scores of the reviewer according to the ''range of credits'' ( lower range, medium range and higher range) set by the instructor.

*Edge cases - May include options like ''adding a link in the review document by the reviewer'' and seeing how the grade is increased.
May also take into account the situation when author's feedback isn't available and the score of the reviewer would solely depend on the latter's reviews adn the instructor's jurisdiction because the algorithm in this case would fail.

== '''References''' ==
*Expertiza repo : https://github.com/expertiza/expertiza

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-13T23:00:38Z

Kbisht:

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-13T22:55:33Z

Kbisht:

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-13T22:54:43Z

Kbisht:

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-13T22:54:13Z

Kbisht:

This page provides a description of the expertiza based project for Fall 2017.

__TOC__

== '''Introduction''' ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== '''Problem Statement''' ==

'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Issue 4:''' The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Issue 6:''' Integration of review performance- The basic aim of this implementation is to somehow combine an author’s feedback on a review and the corresponding review of a reviewer, to build a method for grading the reviewers.

Basic rubrics to be considered: 
-Number of reviews completed 
-Length of reviews 
-Summary of reviews 
-Whether reviewers added a file or link to their review 
-The average ratings they received from the author. 
A graph or table is prefered for easing this change. 

== '''Issue Statements & Approach to be followed''' ==
'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Approach to solve issue 1:''' The issue is about the cell contains link to different pages in expertiza, but there is no way to know which cell is linked to which page. So user don't know the destination page when he/she clicks on some page. So we know that there is link in each cell, so we will show a hover over text displaying the link of the destination page.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach to solve issue 2:''' Here the color coding is blue to green and also it changes randomly. So we will use RBG color coding to make it red to green. We will use percentage to decide color coding. For example if it between 0 - 20% then make it red and so on. This way no matter what scale is being used it will always have appropriate color coding.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach to solve issue 3:''' Here The problem is that the the review responses show in a grid format that shows all the reviews from round 1 to round n. But this is ok when the rubrics is same for all the rounds. But when the rubric is different from round to round this view doesn't make sense. So what we are thinking is creating different grid for each review round. That will solve the problem for when the rubric is different as well as when the rubric is same.

'''Issue 4:''' The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Approach to solve issue 4:''' Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach to solve issue 5 :''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.A proposed solution may be use the below logic of calculating average grade for each student on all assignments in a particular course from the controller assessment360_controller.rb

[[File:scr2.PNG]] 
The average grades of each student can be pulled and then used to plot a bar graph as shown below ( This has been created by using a dummy data ) :- 
[[File:Dummydata.PNG]] 
Graph for class performance on Assignment 1 :- 
[[File:Assignment1.PNG]] 
Graph for class performance on Assignment 2 :- 
[[File:Assignment2.PNG]] 
Graph for class performance on Assignment 3 :- 
[[File:Assignment3.PNG]] 
Graph for class performance on Assignment 4 :- 
[[File:Assignment4.PNG]] 
Graph for class performance on Assignment 5 :- 
[[File:Assignment5.PNG]] 
Graph for class performance on Average Class performance :- 
[[File:Average.PNG]] 
The work flow can be approximately like the below diagram :- 
[[File:Workflow.PNG]] 

'''Issue 6:''' Integration of review performance- The basic aim of this implementation is to somehow combine an author’s feedback on a review and the corresponding review of a reviewer, to build a method for grading the reviewers.
Basic rubrics to be considered: 
-Number of reviews completed 
-Length of reviews 
-Summary of reviews 
-Whether reviewers added a file or link to their review 
-The average ratings they received from the author. 
-A graph or table is prefered for easing this change. 

'''Approach to solve issue 9:''' The entire focus is on to what extent a review could help the author. The latter’s feedback is always available in the form of numerical scores. We intend to capture the author’s score of the review topic-wise like that of tone of review, plausible solutions to problems suggested by reviewer and the rate of how much it helped the author to improve(scored by himself). 
-In each round of review done, the author’s feedback is noted topic-wise as suggested in the previous step and ''possibly generate a graph comparing the “n” rounds of reviews''. 
-If reviewer added ''a legit file or link to their review'', then we propose to add a few extra credits to the reviewer that can be added to their final grade.
The author’s feedback in the form of an average number can be taken and if that value exceeds that of a threshold , then the reviews were really meaningful. 

For example -
Consider author’s feedback as follows for 2 rounds of reviews:

 
[[File:ExampleTableForAuthorFeedback.PNG]] 

Observations: Mean score of round 1 is 3 and Mean score of round 2 is 1.9. 
Suppose , we take into account that Round of 1 has more importance than the second one because it helps a reviewer improve, and also that every reviewer should atleast provide 2 suggestions or comments that help authors improve. Then the threshold value is considered to be 2 and the Mean score of round 1 > threshold. 
Therefore, the reviews were meaningful and deserves a credit in the higher range of grades. If the mean score of round 1 < threshold then the mean score of round 2 is compared with the threshold. 
''Overall : Mean round 1> threshold : Higher range of grade to reviewer. 
Mean round 1<threshold : Check if Mean round 2 > threshold 
If true , Medium range of grade to reviewer. 
Else , lower range of grades. ''
Now once it’s decided in what range a reviewer deserves credit, The other factors like ''summary of review'' and ''length of review'' are taken into account by the instructors and graded according to the effectiveness of concepts explained in it. Also if a reviewer misses the second round of review then only the first round is taken into consideration. ''The instructor should believe that all but the last round of reviews are crucial to improve a document.'' 
'''Graphs:'''Can be generated for comparing the effectiveness of the “n” rounds of reviews for the authors depending on the author’s score. 

In this case - (only an example visualization)

 
[[File:ExampleGraph.PNG]] 
Observations: The graph and table together suggest that round 1 of the review actually had an impact on the author.

----

== '''Test Plan''' ==
'''Issue 1:''' Check the link matches to the hover over text

'''Issue 2:''' Check the color coding when different number is given in different scale.

'''Issue 3:''' Enter multiple reviews with different rubric and check different table/grid shows for each review round separately.

'''Issue 4:''' Check if the table is sorted with appropriate column alphabetically

'''Issue 5:'''
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

'''Issue 6:'''
*1) Login as an instructor.
*2) Go to the 'Review Summary' page for an assignment.
*3) The instructor will now be able to see the name of the assignment as a heading. Also, the name of students will now be displayed beside their student id.

'''Issue 7:'''
*1) Login as instructor.
*2) Go to the 'Review Summary' page for an assignment.
*3) Click on the reputation scores.
*4) The instructor will now be able to see individual reputation scores of the students for that assignment as well as a graphical representation of the reputation scores of all the students enrolled in the exercise.

'''Issue 8:'''
*1) Login as instructor and create an assignment with 3 rounds of submissions. Enroll few students in the assignment.
*2) Impersonate at least three students.
*3) For first student, say 'A', just submit for the first round.
*4) For second student, say 'B', submit the assignment for first round and then resubmit it for second round.
*5) For third student, say 'C', submit the assignment for the first round, second round and third round.
*6) Now, login again as instructor and go to the review submissions page to view submissions of students. You can now see that for 'A', the submission link appears in black font with no background color, for 'B', the submission link appears with a red background color of 50% intensity, and for 'C', the submission link appears with a red background color of 100% intensity.
*7) Also, the color code is mentioned at the end of the page which clearly indicates the usage of background color-code to represent the number of times the project was submitted all together by any student.

'''Issue 9:''' Since it is a new algorithm being proposed, we intend to test it first manually using dummy datasets. Later on, automated test cases can be added for the same.
*1) Login as an instructor and create a dummy assignment with 2 rounds of review submissions. Assign 2 teams to that assignment of 1 student each. Also, put the deadline of first review as "1 hour". Log out
*2) Login as a student and submit some data for the assignment. Log out.
*3) Login as the second student and submit the same assignment using dummy data. Log out.
All the above steps will help us reach towards the section of reviews.
*4) Login as the first student and go to "Other's work" and request for a review document.By default, you will be assigned the document of the second student to review. Once assigned, complete that review with dummy scores. Log out.
*5) Login as the second student. Check the review in "Your scores" page and click on the section "Show review". There you can provide scored feedback to the reviewer. Definitely take into account the tone, solutions suggested and how it will help you. Log out.
*6) Login as the first student after the deadline for the first review completes. Go to "Other's work" and request for a new submission. You will be assigned the same document of the other student to review for the second round. Follow step 4.
*7) Login as the second student and follow step 5.
*8) The system has the data related to author's feedback and the reviewer's data and will calculate the scores of the reviewer according to the ''range of credits'' ( lower range, medium range and higher range) set by the instructor.

*Edge cases - May include options like ''adding a link in the review document by the reviewer'' and seeing how the grade is increased.
May also take into account the situation when author's feedback isn't available and the score of the reviewer would solely depend on the latter's reviews adn the instructor's jurisdiction because the algorithm in this case would fail.

== '''References''' ==
*Expertiza repo : https://github.com/expertiza/expertiza

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-13T22:51:39Z

Kbisht:

This page provides a description of the expertiza based project for Fall 2017.

__TOC__

== '''Introduction''' ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== '''Problem Statement''' ==

'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Issue 4:''' The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Issue 6:''' Integration of review performance- The basic aim of this implementation is to somehow combine an author’s feedback on a review and the corresponding review of a reviewer, to build a method for grading the reviewers.

Basic rubrics to be considered: 
-Number of reviews completed 
-Length of reviews 
-Summary of reviews 
-Whether reviewers added a file or link to their review 
-The average ratings they received from the author. 
A graph or table is prefered for easing this change. 

== '''Issue Statements & Approach to be followed''' ==
'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Approach to solve issue 1:''' The issue is about the cell contains link to different pages in expertiza, but there is no way to know which cell is linked to which page. So user don't know the destination page when he/she clicks on some page. So we know that there is link in each cell, so we will show a hover over text displaying the link of the destination page.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach to solve issue 2:''' Here the color coding is blue to green and also it changes randomly. So we will use RBG color coding to make it red to green. We will use percentage to decide color coding. For example if it between 0 - 20% then make it red and so on. This way no matter what scale is being used it will always have appropriate color coding.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach to solve issue 3:''' Here The problem is that the the review responses show in a grid format that shows all the reviews from round 1 to round n. But this is ok when the rubrics is same for all the rounds. But when the rubric is different from round to round this view doesn't make sense. So what we are thinking is creating different grid for each review round. That will solve the problem for when the rubric is different as well as when the rubric is same.

'''Issue 4:''' The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Approach to solve issue 4:''' Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach to solve issue 5 :''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.A proposed solution may be use the below logic of calculating average grade for each student on all assignments in a particular course from the controller assessment360_controller.rb

[[File:scr2.PNG]] 
The average grades of each student can be pulled and then used to plot a bar graph as shown below ( This has been created by using a dummy data ) :- 
[[File:Dummydata.PNG]] 
Graph for class performance on Assignment 1 :- 
[[File:Assignment1.PNG]] 
Graph for class performance on Assignment 2 :- 
[[File:Assignment2.PNG]] 
Graph for class performance on Assignment 3 :- 
[[File:Assignment3.PNG]] 
Graph for class performance on Assignment 4 :- 
[[File:Assignment4.PNG]] 
Graph for class performance on Assignment 5 :- 
[[File:Assignment5.PNG]] 
Graph for class performance on Average Class performance :- 
[[File:Average.PNG]] 
The work flow can be approximately like the below diagram :- 
[[File:Workflow.PNG]] 

'''Issue 6:''' In the 'Review Summary' page for an assignment, currently there is no header indicating the name of the assignment. Also the page has review information for enrolled students. Currently, only student ids are displayed, which make it difficult to make out which student the information corresponds to. Extra white-space around checkboxes.

'''Approach to solve issue 6:''' We will modify the view to show the heading for the assignment. Also, we will include the student name along with their id. We will use a method to truncate extra white-spaces around checkboxes before rendering the view.

'''Issue 7:''' Currently, the reputation scores are not set. They show up as 0.0 for all students.

'''Approach to solve issue 7:''' The method to calculate the reputation scores is not being called. We will call that method in the corresponding controller and deliver the computed reputation score(s) to a view where it can be displayed. Also, once we have this data, we will display the reputation scores of all students for an assignment graphically to enable easy visualization for the instructor. This view can be accessed by a link/button (which we will add) on the ‘review summary’ page.

'''Issue 8:''' Currently, the instructor doesn't come to know which submission has not been updated since the previous review.

'''Approach to solve issue 8:''' For n rounds of submissions, we can take a color (say red) as a background highlighter, and vary (say increase) it's intensity by a percentage of 100/(n-1) on every submission update. And this color code will be mentioned on the corresponding view. This will enable the instructor to quickly make out whether a student has updated/resubmitted the submission.
For example, if a project has 3 rounds of submissions, then n=3. Initially there will be no background color. When a student submits for the first time, the submission link will be shown in black font with no background color. After round 1 reviews, there will be time for second submission, in which the students can resubmit the updated version of their project based on the reviews. If a student resubmits the project, the submission link will now have a red background color of 50% intensity. The submission link for the students who did not resubmit/update their submission would remain as it was earlier, that is, without any background color. After this, there will be another round of reviews. After round 2 reviews, it will be time for third submission (which is the final submission in this case). If a student resubmits the project, the submission link will now have a background color of 100% intensity. The submission link for the students who did not resubmit/update their submission would remain as it was earlier. That is, for students who submitted the project only once and did not resubmit thereafter, there will be no background color of the submission link. For students, who resubmitted the project only once after the first submission, the background color of the submission link will have 50% intensity and for the students who resubmitted the project twice (as was expected) will have 100% intensity.

Pseudocode:

Let n be total rounds of submission for the project
For i from 2 to n
Increase the intensity of background color red (R,0,0) by 100/(n-1) percent

'''Issue 9:''' Integration of review performance- The basic aim of this implementation is to somehow combine an author’s feedback on a review and the corresponding review of a reviewer, to build a method for grading the reviewers.
Basic rubrics to be considered: 
-Number of reviews completed 
-Length of reviews 
-Summary of reviews 
-Whether reviewers added a file or link to their review 
-The average ratings they received from the author. 
-A graph or table is prefered for easing this change. 

'''Approach to solve issue 9:''' The entire focus is on to what extent a review could help the author. The latter’s feedback is always available in the form of numerical scores. We intend to capture the author’s score of the review topic-wise like that of tone of review, plausible solutions to problems suggested by reviewer and the rate of how much it helped the author to improve(scored by himself). 
-In each round of review done, the author’s feedback is noted topic-wise as suggested in the previous step and ''possibly generate a graph comparing the “n” rounds of reviews''. 
-If reviewer added ''a legit file or link to their review'', then we propose to add a few extra credits to the reviewer that can be added to their final grade.
The author’s feedback in the form of an average number can be taken and if that value exceeds that of a threshold , then the reviews were really meaningful. 

For example -
Consider author’s feedback as follows for 2 rounds of reviews:

 
[[File:ExampleTableForAuthorFeedback.PNG]] 

Observations: Mean score of round 1 is 3 and Mean score of round 2 is 1.9. 
Suppose , we take into account that Round of 1 has more importance than the second one because it helps a reviewer improve, and also that every reviewer should atleast provide 2 suggestions or comments that help authors improve. Then the threshold value is considered to be 2 and the Mean score of round 1 > threshold. 
Therefore, the reviews were meaningful and deserves a credit in the higher range of grades. If the mean score of round 1 < threshold then the mean score of round 2 is compared with the threshold. 
''Overall : Mean round 1> threshold : Higher range of grade to reviewer. 
Mean round 1<threshold : Check if Mean round 2 > threshold 
If true , Medium range of grade to reviewer. 
Else , lower range of grades. ''
Now once it’s decided in what range a reviewer deserves credit, The other factors like ''summary of review'' and ''length of review'' are taken into account by the instructors and graded according to the effectiveness of concepts explained in it. Also if a reviewer misses the second round of review then only the first round is taken into consideration. ''The instructor should believe that all but the last round of reviews are crucial to improve a document.'' 
'''Graphs:'''Can be generated for comparing the effectiveness of the “n” rounds of reviews for the authors depending on the author’s score. 

In this case - (only an example visualization)

 
[[File:ExampleGraph.PNG]] 
Observations: The graph and table together suggest that round 1 of the review actually had an impact on the author.

----

== '''Test Plan''' ==
'''Issue 1:''' Check the link matches to the hover over text

'''Issue 2:''' Check the color coding when different number is given in different scale.

'''Issue 3:''' Enter multiple reviews with different rubric and check different table/grid shows for each review round separately.

'''Issue 4:''' Check if the table is sorted with appropriate column alphabetically

'''Issue 5:'''
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

'''Issue 6:'''
*1) Login as an instructor.
*2) Go to the 'Review Summary' page for an assignment.
*3) The instructor will now be able to see the name of the assignment as a heading. Also, the name of students will now be displayed beside their student id.

'''Issue 7:'''
*1) Login as instructor.
*2) Go to the 'Review Summary' page for an assignment.
*3) Click on the reputation scores.
*4) The instructor will now be able to see individual reputation scores of the students for that assignment as well as a graphical representation of the reputation scores of all the students enrolled in the exercise.

'''Issue 8:'''
*1) Login as instructor and create an assignment with 3 rounds of submissions. Enroll few students in the assignment.
*2) Impersonate at least three students.
*3) For first student, say 'A', just submit for the first round.
*4) For second student, say 'B', submit the assignment for first round and then resubmit it for second round.
*5) For third student, say 'C', submit the assignment for the first round, second round and third round.
*6) Now, login again as instructor and go to the review submissions page to view submissions of students. You can now see that for 'A', the submission link appears in black font with no background color, for 'B', the submission link appears with a red background color of 50% intensity, and for 'C', the submission link appears with a red background color of 100% intensity.
*7) Also, the color code is mentioned at the end of the page which clearly indicates the usage of background color-code to represent the number of times the project was submitted all together by any student.

'''Issue 9:''' Since it is a new algorithm being proposed, we intend to test it first manually using dummy datasets. Later on, automated test cases can be added for the same.
*1) Login as an instructor and create a dummy assignment with 2 rounds of review submissions. Assign 2 teams to that assignment of 1 student each. Also, put the deadline of first review as "1 hour". Log out
*2) Login as a student and submit some data for the assignment. Log out.
*3) Login as the second student and submit the same assignment using dummy data. Log out.
All the above steps will help us reach towards the section of reviews.
*4) Login as the first student and go to "Other's work" and request for a review document.By default, you will be assigned the document of the second student to review. Once assigned, complete that review with dummy scores. Log out.
*5) Login as the second student. Check the review in "Your scores" page and click on the section "Show review". There you can provide scored feedback to the reviewer. Definitely take into account the tone, solutions suggested and how it will help you. Log out.
*6) Login as the first student after the deadline for the first review completes. Go to "Other's work" and request for a new submission. You will be assigned the same document of the other student to review for the second round. Follow step 4.
*7) Login as the second student and follow step 5.
*8) The system has the data related to author's feedback and the reviewer's data and will calculate the scores of the reviewer according to the ''range of credits'' ( lower range, medium range and higher range) set by the instructor.

*Edge cases - May include options like ''adding a link in the review document by the reviewer'' and seeing how the grade is increased.
May also take into account the situation when author's feedback isn't available and the score of the reviewer would solely depend on the latter's reviews adn the instructor's jurisdiction because the algorithm in this case would fail.

== '''References''' ==
*Expertiza repo : https://github.com/expertiza/expertiza

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-13T22:50:16Z

Kbisht:

This page provides a description of the expertiza based project for Fall 2017.

__TOC__

== '''Introduction''' ==
This project aims to improve the visualizations of certain pages related to reviews and feedback in Expertiza in the instructor's view. This would aid the instructors to judge outcomes of reviews and class performance in assignments via graphs and tables, which in turn would ease the process of grading the reviews.

== '''Problem Statement''' ==

'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Issue 4:''' The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Issue 6:''' Integration of review performance- The basic aim of this implementation is to somehow combine an author’s feedback on a review and the corresponding review of a reviewer, to build a method for grading the reviewers.

Basic rubrics to be considered: 
-Number of reviews completed 
-Length of reviews 
-Summary of reviews 
-Whether reviewers added a file or link to their review 
The average ratings they received from the author. 
A graph or table is prefered for easing this change. 

== '''Issue Statements & Approach to be followed''' ==
'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Approach to solve issue 1:''' The issue is about the cell contains link to different pages in expertiza, but there is no way to know which cell is linked to which page. So user don't know the destination page when he/she clicks on some page. So we know that there is link in each cell, so we will show a hover over text displaying the link of the destination page.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach to solve issue 2:''' Here the color coding is blue to green and also it changes randomly. So we will use RBG color coding to make it red to green. We will use percentage to decide color coding. For example if it between 0 - 20% then make it red and so on. This way no matter what scale is being used it will always have appropriate color coding.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach to solve issue 3:''' Here The problem is that the the review responses show in a grid format that shows all the reviews from round 1 to round n. But this is ok when the rubrics is same for all the rounds. But when the rubric is different from round to round this view doesn't make sense. So what we are thinking is creating different grid for each review round. That will solve the problem for when the rubric is different as well as when the rubric is same.

'''Issue 4:''' The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Approach to solve issue 4:''' Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach to solve issue 5 :''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.A proposed solution may be use the below logic of calculating average grade for each student on all assignments in a particular course from the controller assessment360_controller.rb

[[File:scr2.PNG]] 
The average grades of each student can be pulled and then used to plot a bar graph as shown below ( This has been created by using a dummy data ) :- 
[[File:Dummydata.PNG]] 
Graph for class performance on Assignment 1 :- 
[[File:Assignment1.PNG]] 
Graph for class performance on Assignment 2 :- 
[[File:Assignment2.PNG]] 
Graph for class performance on Assignment 3 :- 
[[File:Assignment3.PNG]] 
Graph for class performance on Assignment 4 :- 
[[File:Assignment4.PNG]] 
Graph for class performance on Assignment 5 :- 
[[File:Assignment5.PNG]] 
Graph for class performance on Average Class performance :- 
[[File:Average.PNG]] 
The work flow can be approximately like the below diagram :- 
[[File:Workflow.PNG]] 

'''Issue 6:''' In the 'Review Summary' page for an assignment, currently there is no header indicating the name of the assignment. Also the page has review information for enrolled students. Currently, only student ids are displayed, which make it difficult to make out which student the information corresponds to. Extra white-space around checkboxes.

'''Approach to solve issue 6:''' We will modify the view to show the heading for the assignment. Also, we will include the student name along with their id. We will use a method to truncate extra white-spaces around checkboxes before rendering the view.

'''Issue 7:''' Currently, the reputation scores are not set. They show up as 0.0 for all students.

'''Approach to solve issue 7:''' The method to calculate the reputation scores is not being called. We will call that method in the corresponding controller and deliver the computed reputation score(s) to a view where it can be displayed. Also, once we have this data, we will display the reputation scores of all students for an assignment graphically to enable easy visualization for the instructor. This view can be accessed by a link/button (which we will add) on the ‘review summary’ page.

'''Issue 8:''' Currently, the instructor doesn't come to know which submission has not been updated since the previous review.

'''Approach to solve issue 8:''' For n rounds of submissions, we can take a color (say red) as a background highlighter, and vary (say increase) it's intensity by a percentage of 100/(n-1) on every submission update. And this color code will be mentioned on the corresponding view. This will enable the instructor to quickly make out whether a student has updated/resubmitted the submission.
For example, if a project has 3 rounds of submissions, then n=3. Initially there will be no background color. When a student submits for the first time, the submission link will be shown in black font with no background color. After round 1 reviews, there will be time for second submission, in which the students can resubmit the updated version of their project based on the reviews. If a student resubmits the project, the submission link will now have a red background color of 50% intensity. The submission link for the students who did not resubmit/update their submission would remain as it was earlier, that is, without any background color. After this, there will be another round of reviews. After round 2 reviews, it will be time for third submission (which is the final submission in this case). If a student resubmits the project, the submission link will now have a background color of 100% intensity. The submission link for the students who did not resubmit/update their submission would remain as it was earlier. That is, for students who submitted the project only once and did not resubmit thereafter, there will be no background color of the submission link. For students, who resubmitted the project only once after the first submission, the background color of the submission link will have 50% intensity and for the students who resubmitted the project twice (as was expected) will have 100% intensity.

Pseudocode:

Let n be total rounds of submission for the project
For i from 2 to n
Increase the intensity of background color red (R,0,0) by 100/(n-1) percent

'''Issue 9:''' Integration of review performance- The basic aim of this implementation is to somehow combine an author’s feedback on a review and the corresponding review of a reviewer, to build a method for grading the reviewers.
Basic rubrics to be considered: 
-Number of reviews completed 
-Length of reviews 
-Summary of reviews 
-Whether reviewers added a file or link to their review 
-The average ratings they received from the author. 
-A graph or table is prefered for easing this change. 

'''Approach to solve issue 9:''' The entire focus is on to what extent a review could help the author. The latter’s feedback is always available in the form of numerical scores. We intend to capture the author’s score of the review topic-wise like that of tone of review, plausible solutions to problems suggested by reviewer and the rate of how much it helped the author to improve(scored by himself). 
-In each round of review done, the author’s feedback is noted topic-wise as suggested in the previous step and ''possibly generate a graph comparing the “n” rounds of reviews''. 
-If reviewer added ''a legit file or link to their review'', then we propose to add a few extra credits to the reviewer that can be added to their final grade.
The author’s feedback in the form of an average number can be taken and if that value exceeds that of a threshold , then the reviews were really meaningful. 

For example -
Consider author’s feedback as follows for 2 rounds of reviews:

 
[[File:ExampleTableForAuthorFeedback.PNG]] 

Observations: Mean score of round 1 is 3 and Mean score of round 2 is 1.9. 
Suppose , we take into account that Round of 1 has more importance than the second one because it helps a reviewer improve, and also that every reviewer should atleast provide 2 suggestions or comments that help authors improve. Then the threshold value is considered to be 2 and the Mean score of round 1 > threshold. 
Therefore, the reviews were meaningful and deserves a credit in the higher range of grades. If the mean score of round 1 < threshold then the mean score of round 2 is compared with the threshold. 
''Overall : Mean round 1> threshold : Higher range of grade to reviewer. 
Mean round 1<threshold : Check if Mean round 2 > threshold 
If true , Medium range of grade to reviewer. 
Else , lower range of grades. ''
Now once it’s decided in what range a reviewer deserves credit, The other factors like ''summary of review'' and ''length of review'' are taken into account by the instructors and graded according to the effectiveness of concepts explained in it. Also if a reviewer misses the second round of review then only the first round is taken into consideration. ''The instructor should believe that all but the last round of reviews are crucial to improve a document.'' 
'''Graphs:'''Can be generated for comparing the effectiveness of the “n” rounds of reviews for the authors depending on the author’s score. 

In this case - (only an example visualization)

 
[[File:ExampleGraph.PNG]] 
Observations: The graph and table together suggest that round 1 of the review actually had an impact on the author.

----

== '''Test Plan''' ==
'''Issue 1:''' Check the link matches to the hover over text

'''Issue 2:''' Check the color coding when different number is given in different scale.

'''Issue 3:''' Enter multiple reviews with different rubric and check different table/grid shows for each review round separately.

'''Issue 4:''' Check if the table is sorted with appropriate column alphabetically

'''Issue 5:'''
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

'''Issue 6:'''
*1) Login as an instructor.
*2) Go to the 'Review Summary' page for an assignment.
*3) The instructor will now be able to see the name of the assignment as a heading. Also, the name of students will now be displayed beside their student id.

'''Issue 7:'''
*1) Login as instructor.
*2) Go to the 'Review Summary' page for an assignment.
*3) Click on the reputation scores.
*4) The instructor will now be able to see individual reputation scores of the students for that assignment as well as a graphical representation of the reputation scores of all the students enrolled in the exercise.

'''Issue 8:'''
*1) Login as instructor and create an assignment with 3 rounds of submissions. Enroll few students in the assignment.
*2) Impersonate at least three students.
*3) For first student, say 'A', just submit for the first round.
*4) For second student, say 'B', submit the assignment for first round and then resubmit it for second round.
*5) For third student, say 'C', submit the assignment for the first round, second round and third round.
*6) Now, login again as instructor and go to the review submissions page to view submissions of students. You can now see that for 'A', the submission link appears in black font with no background color, for 'B', the submission link appears with a red background color of 50% intensity, and for 'C', the submission link appears with a red background color of 100% intensity.
*7) Also, the color code is mentioned at the end of the page which clearly indicates the usage of background color-code to represent the number of times the project was submitted all together by any student.

'''Issue 9:''' Since it is a new algorithm being proposed, we intend to test it first manually using dummy datasets. Later on, automated test cases can be added for the same.
*1) Login as an instructor and create a dummy assignment with 2 rounds of review submissions. Assign 2 teams to that assignment of 1 student each. Also, put the deadline of first review as "1 hour". Log out
*2) Login as a student and submit some data for the assignment. Log out.
*3) Login as the second student and submit the same assignment using dummy data. Log out.
All the above steps will help us reach towards the section of reviews.
*4) Login as the first student and go to "Other's work" and request for a review document.By default, you will be assigned the document of the second student to review. Once assigned, complete that review with dummy scores. Log out.
*5) Login as the second student. Check the review in "Your scores" page and click on the section "Show review". There you can provide scored feedback to the reviewer. Definitely take into account the tone, solutions suggested and how it will help you. Log out.
*6) Login as the first student after the deadline for the first review completes. Go to "Other's work" and request for a new submission. You will be assigned the same document of the other student to review for the second round. Follow step 4.
*7) Login as the second student and follow step 5.
*8) The system has the data related to author's feedback and the reviewer's data and will calculate the scores of the reviewer according to the ''range of credits'' ( lower range, medium range and higher range) set by the instructor.

*Edge cases - May include options like ''adding a link in the review document by the reviewer'' and seeing how the grade is increased.
May also take into account the situation when author's feedback isn't available and the score of the reviewer would solely depend on the latter's reviews adn the instructor's jurisdiction because the algorithm in this case would fail.

== '''References''' ==
*Expertiza repo : https://github.com/expertiza/expertiza

CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors

2017-11-07T06:52:32Z

Kbisht:

= Visualisations for instructors =

----

== '''Issue Statement & Approach followed:''' ==
'''Issue 1:''' For links in each cell. We are not sure what will happen if we click the link and which page will open.

'''Approach to solve issue 1:''' The issue is about the cell contains link to different pages in expertiza, but there is no way to know which cell is linked to which page. So user don't know the destination page when he/she clicks on some page. So we know that there is link in each cell, so we will show a hover over text displaying the link of the destination page.

'''Issue 2:''' The scale is blue to green, which does not make sense. And colors will change randomly each time loading the page. It will be better to scale from red to green.

'''Approach to solve issue 2:''' Here the color coding is blue to green and also it changes randomly. So we will use RBG color coding to make it red to green. We will use percentage to decide color coding. For example if it between 0 - 20% then make it red and so on. This way no matter what scale is being used it will always have appropriate color coding.

'''Issue 3:''' Two adjacent bar represents the response in round 1 to round k. It makes sense only if the rubrics in all review rounds are all the same. If the instructor implements the vary-rubric-by-round mechanism, this visualization will not make sense.

'''Approach to solve issue 3:''' Here The problem is that the the review responses show in a grid format that shows all the reviews from round 1 to round n. But this is ok when the rubrics is same for all the rounds. But when the rubric is different from round to round this view doesn't make sense. So what we are thinking is creating different grid for each review round. That will solve the problem for when the rubric is different as well as when the rubric is same.

'''Issue 4:''' The table is presorted by teams, but you can now also sort alphabetically. The cell view looks way too long, and should be divided into partials.

'''Approach to solve issue 4:''' Here we can sort the select query with appropriate column alphabetically, or we can sort the table automatically according to user criteria using dynamic table format. And the long view issue can be solved by using paging.

'''Issue 5:''' An interactive visualization or table that shows how a class performed on selected rubric criteria would be immensely helpful. It would show me what I need to focus more attention on.

'''Approach to solve issue 5 :''' The issue is about getting the performance of the entire class graded using the 5 rubrics criteria.A proposed solution may be use the below logic of calculating average grade for each student on all assignments in a particular course from the controller assessment360_controller.rb
[[File:scr2.PNG]] 
The average grades of each student can be pulled and then used to plot a bar graph as shown below ( This has been created by using a dummy data ) :- 
[[File:Dummydata.PNG]] 
Graph for class performance on Assignment 1 :- 
[[File:Assignment1.PNG]] 
Graph for class performance on Assignment 2 :- 
[[File:Assignment2.PNG]] 
Graph for class performance on Assignment 3 :- 
[[File:Assignment3.PNG]] 
Graph for class performance on Assignment 4 :- 
[[File:Assignment4.PNG]] 
Graph for class performance on Assignment 5 :- 
[[File:Assignment5.PNG]] 
Graph for class performance on Average Class performance :- 
[[File:Average.PNG]] 
The work flow can be approximately like the below diagram :- 
[[File:Workflow.PNG]] 

'''Issue 6:''' In the 'Review Summary' page for an assignment, currently there is no header indicating the name of the assignment. Also the page has review information for enrolled students. Currently, only student ids are displayed, which make it difficult to make out which student the information corresponds to. Extra white-space around checkboxes.

'''Approach to solve issue 6:''' We will modify the view to show the heading for the assignment. Also, we will include the student name along with their id. We will use a method to truncate extra white-spaces around checkboxes before rendering the view.

'''Issue 7:''' Currently, the reputation scores are not set. They show up as 0.0 for all students.

'''Approach to solve issue 7:''' The method to calculate the reputation scores is not being called. We will call that method in the corresponding controller and deliver the computed reputation score(s) to a view where it can be displayed. Also, once we have this data, we will display the reputation scores of all students for an assignment graphically to enable easy visualization for the instructor. This view can be accessed by a link/button (which we will add) on the ‘review summary’ page.

'''Issue 8:''' Currently, the instructor doesn't come to know which submission has not been updated since the previous review.

'''Approach to solve issue 8:''' For n rounds of submissions, we can take a color (say red) as a background highlighter, and vary (say increase) it's intensity by a percentage of 100/(n-1) on every submission update. And this color code will be mentioned on the corresponding view. This will enable the instructor to quickly make out whether a student has updated/resubmitted the submission.
For example, if a project has 3 rounds of submissions, then n=3. Initially there will be no background color. When a student submits for the first time, the submission link will be shown in black font with no background color. After round 1 reviews, there will be time for second submission, in which the students can resubmit the updated version of their project based on the reviews. If a student resubmits the project, the submission link will now have a red background color of 50% intensity. The submission link for the students who did not resubmit/update their submission would remain as it was earlier, that is, without any background color. After this, there will be another round of reviews. After round 2 reviews, it will be time for third submission (which is the final submission in this case). If a student resubmits the project, the submission link will now have a background color of 100% intensity. The submission link for the students who did not resubmit/update their submission would remain as it was earlier. That is, for students who submitted the project only once and did not resubmit thereafter, there will be no background color of the submission link. For students, who resubmitted the project only once after the first submission, the background color of the submission link will have 50% intensity and for the students who resubmitted the project twice (as was expected) will have 100% intensity.

Pseudocode:

Let n be total rounds of submission for the project
For i from 2 to n
Increase the intensity of background color red (R,0,0) by 100/(n-1) percent

----

== Test Plan: ==
'''Issue 1:''' Check the link matches to the hover over text

'''Issue 2:''' Check the color coding when different number is given in different scale.

'''Issue 3:''' Enter multiple reviews with different rubric and check different table/grid shows for each review round separately.

'''Issue 4:''' Check if the table is sorted with appropriate column alphabetically

'''Issue 5:'''
*1) Login as the instructor
*2) Click on the button to compute graphs
*3) Compare the bar graphs with separate scores of students in each assignments.

'''Issue 6:'''
*1) Login as an instructor.
*2) Go to the 'Review Summary' page for an assignment.
*3) The instructor will now be able to see the name of the assignment as a heading. Also, the name of students will now be displayed beside their student id.

'''Issue 7:'''
*1) Login as instructor.
*2) Go to the 'Review Summary' page for an assignment.
*3) Click on the reputation scores.
*4) The instructor will now be able to see individual reputation scores of the students for that assignment as well as a graphical representation of the reputation scores of all the students enrolled in the exercise.

'''Issue 8:'''
*1) Login as instructor and create an assignment with 3 rounds of submissions. Enroll few students in the assignment.
*2) Impersonate at least three students.
*3) For first student, say 'A', just submit for the first round.
*4) For second student, say 'B', submit the assignment for first round and then resubmit it for second round.
*5) For third student, say 'C', submit the assignment for the first round, second round and third round.
*6) Now, login again as instructor and go to the review submissions page to view submissions of students. You can now see that for 'A', the submission link appears in black font with no background color, for 'B', the submission link appears with a red background color of 50% intensity, and for 'C', the submission link appears with a red background color of 100% intensity.
*7) Also, the color code is mentioned at the end of the page which clearly indicates the usage of background color-code to represent the number of times the project was submitted all together by any student.

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-11-07T06:38:39Z

Kbisht: /* Issue #311 */

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Issues as described by the problem statement:

Fix Issue #311: When one responds to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : If user 'A' got a topic and user 'B' got no topic, then if A join B’s team, A’s topic is dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) app/models/sign_up_sheet.rb

2) app/helpers/student_teams_helper.rb

3) app/views/sign_up_sheet/_table_line.html.erb

4) app/views/student_teams/view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic, can advertise for more team members. When another user goes on the 'your team' link, who is enrolled in the same assignment but doesn't have a team and topic yet, he will be able to see the team advertisements by other teams. He can respond to any of the available advertisements. As soon as he responds to an advertisement, an entry is created in the "join_team_requests" table and the "status" attribute of the corresponding tuple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively for that entry.

If there is an entry in the "join_team_requests" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of (user_id, assignment_id), and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corresponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users
rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''Test Plan'''==

Automated tests cannot be written for this project. Automated tests will only be able to test the functionality of Rails and not the functionality of the amended files.
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
1) On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
2) On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
3)Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
4)Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
5)Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
6)The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
7)On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
8)Showing all added participants.
----
[[File:add the students.jpg ]]
----
9)The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
10)The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
11)The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
12)After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
13)The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
14)The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
15)After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
16)This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg ]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-11-01T01:48:08Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Issues as described by the problem statement:

Fix Issue #311: When one responds to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : If user 'A' got a topic and user 'B' got no topic, then if A join B’s team, A’s topic is dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) app/models/sign_up_sheet.rb

2) app/helpers/student_teams_helper.rb

3) app/views/sign_up_sheet/_table_line.html.erb

4) app/views/student_teams/view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic, can advertise for more team members. When another user goes on the 'your team' link, who is enrolled in the same assignment but doesn't have a team and topic yet, he will be able to see the team advertisements by other teams. He can respond to any of the available advertisements. As soon as he responds to an advertisement, an entry is created in the "join_team_requests" table and the "status" attribute of the corresponding tuple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively for that entry.

If there is an entry in the "join_team_requests" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of (user_id, assignment_id), and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users
rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''Test Plan'''==

Automated tests cannot be written for this project. Automated tests will only be able to test the functionality of Rails and not the functionality of the amended files.
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
1) On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
2) On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
3)Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
4)Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
5)Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
6)The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
7)On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
8)Showing all added participants.
----
[[File:add the students.jpg ]]
----
9)The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
10)The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
11)The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
12)After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
13)The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
14)The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
15)After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
16)This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg ]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-11-01T01:22:59Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Issues as described by the problem statement:

Fix Issue #311: When one responds to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : If user 'A' got a topic and user 'B' got no topic, then if A join B’s team, A’s topic is dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) app/models/sign_up_sheet.rb

2) app/helpers/student_teams_helper.rb

3) app/views/sign_up_sheet/_table_line.html.erb

4) app/views/student_teams/view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic, can advertise for more team members. When another user goes on the 'your team' link, who is enrolled in the same assignment but doesn't have a team and topic yet, he will be able to see the team advertisements by other teams. He can respond to any of the available advertisements. As soon as he responds to an advertisement, an entry is created in the "join_team_requests" table and the "status" attribute of the corresponding tuple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively for that entry.

If there is an entry in the "join_team_requests" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of (user_id, assignment_id), and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''Test Plan'''==

Automated tests cannot be written for this project. Automated tests will only be able to test the functionality of Rails and not the functionality of the amended files.
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
1) On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
2) On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
3)Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
4)Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
5)Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
6)The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
7)On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
8)Showing all added participants.
----
[[File:add the students.jpg ]]
----
9)The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
10)The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
11)The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
12)After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
13)The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
14)The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
15)After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
16)This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg ]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-11-01T01:05:30Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Issues as described by the problem statement:

Fix Issue #311: When one responds to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : If user 'A' got a topic and user 'B' got no topic, then if A join B’s team, A’s topic is dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) app/models/sign_up_sheet.rb

2) app/helpers/student_teams_helper.rb

3) app/views/sign_up_sheet/_table_line.html.erb

4) app/views/student_teams/view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic, can advertise for more team members. When another user goes on the 'your team' link, who is enrolled in the same assignment but doesn't have a team and topic yet, he will be able to see the team advertisements by other teams. He can respond to any of the available advertisements. As soon as he responds to an advertisement, an entry is created in the "join_team_requests" table and the "status" attribute of the corresponding tuple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively for that entry.

If there is an entry in the "join_team_requests" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of (user_id, assignment_id), and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''Test Plan'''==
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
1) On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
2) On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
3)Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
4)Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
5)Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
6)The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
7)On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
8)Showing all added participants.
----
[[File:add the students.jpg ]]
----
9)The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
10)The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
11)The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
12)After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
13)The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
14)The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
15)After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
16)This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg ]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-11-01T01:04:22Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Issues as described by the problem statement:

Fix Issue #311: When one responds to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : If user 'A' got a topic and user 'B' got no topic, then if A join B’s team, A’s topic is dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) app/models/sign_up_sheet.rb

2) app/helpers/student_teams_helper.rb

3) app/views/sign_up_sheet/_table_line.html.erb

4) app/views/student_teams/view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic, can advertise for more team members. When another user goes on the 'your team' link, who is enrolled in the same assignment but doesn't have a team and topic yet, he will be able to see the team advertisements by other teams. He can respond to any of the available advertisements. As soon as he responds to an advertisement, an entry is created in the "join_team_requests" table and the "status" attribute of the corresponding tuple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively for that entry.

If there is an entry in the "join_team_requests" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of (user_id, assignment_id), and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
1) On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
2) On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
3)Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
4)Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
5)Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
6)The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
7)On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
8)Showing all added participants.
----
[[File:add the students.jpg ]]
----
9)The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
10)The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
11)The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
12)After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
13)The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
14)The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
15)After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
16)This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg ]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-11-01T00:25:01Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) app/models/sign_up_sheet.rb

2) app/helpers/student_teams_helper.rb

3) app/views/sign_up_sheet/_table_line.html.erb

4) app/views/student_teams/view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
1) On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
2) On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
3)Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
4)Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
5)Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
6)The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
7)On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
8)Showing all added participants.
----
[[File:add the students.jpg ]]
----
9)The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
10)The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
11)The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
12)After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
13)The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
14)The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
15)After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
16)This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg ]]
----

File:See the topic.jpg

2017-10-25T04:07:32Z

Kbisht: uploaded a new version of "File:See the topic.jpg"

File:Add the students.jpg

2017-10-25T04:07:01Z

Kbisht: uploaded a new version of "File:Add the students.jpg"

File:Completed setup for assignment with topic.jpg

2017-10-25T04:06:07Z

Kbisht: uploaded a new version of "File:Completed setup for assignment with topic.jpg"

File:Create setup4.jpg

2017-10-25T04:03:44Z

Kbisht: uploaded a new version of "File:Create setup4.jpg"

File:Create setup4.jpg

2017-10-25T04:03:24Z

Kbisht: uploaded a new version of "File:Create setup4.jpg"

File:Create setup3.jpg

2017-10-25T04:01:42Z

Kbisht: uploaded a new version of "File:Create setup3.jpg"

File:Create setup2.jpg

2017-10-25T04:01:04Z

Kbisht: uploaded a new version of "File:Create setup2.jpg"

File:Create setup1.jpg

2017-10-25T04:00:36Z

Kbisht: uploaded a new version of "File:Create setup1.jpg"

File:Create public assignment.jpg

2017-10-25T04:00:13Z

Kbisht: uploaded a new version of "File:Create public assignment.jpg"

File:Select topic.jpg

2017-10-25T03:59:45Z

Kbisht: uploaded a new version of "File:Select topic.jpg"

File:See ad.jpg

2017-10-25T03:58:53Z

Kbisht: uploaded a new version of "File:See ad.jpg"

File:See the ad.jpg

2017-10-25T03:58:14Z

Kbisht: uploaded a new version of "File:See the ad.jpg"

File:Respond to ad.jpg

2017-10-25T03:57:36Z

Kbisht: uploaded a new version of "File:Respond to ad.jpg"

File:Cant see any more ad.jpg

2017-10-25T03:56:58Z

Kbisht: uploaded a new version of "File:Cant see any more ad.jpg"

File:Request to join.jpg

2017-10-25T03:55:16Z

Kbisht: uploaded a new version of "File:Request to join.jpg"

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:39:05Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
1) On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
2) On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
3)Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
4)Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
5)Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
6)The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
7)On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
8)Showing all added participants.
----
[[File:add the students.jpg ]]
----
9)The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
10)The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
11)The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
12)After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
13)The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
14)The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
15)After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
16)This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg |frame|upright=0.6|center|width:10px|Request to Join ]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:34:15Z

Kbisht: /* How to test */

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
'''This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.'''
----
[[File:request to join.jpg ]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:33:52Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
https://mymediasite.online.ncsu.edu/online/Play/31dcb783510c4322bcfbc894c71fbdd01d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
'''This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.'''
----
[[File:request to join.jpg ]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:32:39Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==
----
https://mymediasite.online.ncsu.edu/online/Play/3b649b16e7f7448d9d1ee79ee1448b221d
----
==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
'''This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.'''
----
[[File:request to join.jpg ]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:24:13Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
'''This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.'''
----
[[File:request to join.jpg ]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:23:05Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
'''This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.'''
----
[[File:request to join.jpg |center|]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:20:44Z

Kbisht:

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:18:46Z

Kbisht:

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:18:15Z

Kbisht:

[[File:bug2.jpg]]

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
'''This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.'''
----
[[File:request to join.jpg|Width:100px|Height:100px]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:15:54Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
'''This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.'''
----
[[File:request to join.jpg|Width:100px|Height:100px]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:12:51Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg|Width:100px|Height:100px]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:11:31Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg|Size Width:100px Height:100px]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:10:43Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg|Size Width=100px Height=100px]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:08:54Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg|Size Width 200px Height 100px]]
----

CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team

2017-10-25T03:05:39Z

Kbisht:

==Introduction==
==='''Problem Statement'''===
In Expertiza, there are teammate advertisement, invitation and join team request features which facilitate students to form teams. Teammate advertisement works only for assignments with topics. The topic holders can create advertisement and a trumpet icon will show on the signup sheet page. If one respond to the advertisement, a join team request will be created and the topic holder can see it on “Your team” page. After a student gets a team and the team is not full, (s)he should also be able to send invitations to others.
----
=='''Issues to be fixed'''==

Fix Issue #311: when one respond to an advertisement, (s)he should only be able to respond once. When a team advertises for new members, someone who responds to an ad should only be allowed to respond once. Currently, after someone responds to an ad, they can respond again an unlimited number of times.

Fix Issue #227 : if user A got a topic and user B got no topic, then A join B’s team, A’s topic be dropped and A and B end up with a new team with no topic. This issue should be handle carefully because we cannot simply add B to A’s team (imagine, if A has teammate X and B has teammate Y...). One of a potential fix is that, for assignment w/ topics, one cannot not post an ad unless (s)he holds a topic, similarly, one cannot sent invitations unless (s)he holds a topic.

----

=='''Modified Files'''==

1) sign_up_sheet.rb

2) student_teams_helper.rb

3) _table_line.html.erb

4) view.html.erb

----

=='''Approach taken to resolve the issues'''==

==='''Issue #311 '''===

A user who is enrolled in an assignment and has a topic can advertise for more team members. When another user, who is enrolled in the same assignment but doesn't have a team and topic yet, can see the team advertisements by other teams. He can respond to any advertisement. As soon as he responds to an advertisement, an entry is created in the "" table and the "status" attribute of the corressponding tupple holds "P" value signifying pending status. This request goes to the team who had posted that advertisement. The request can be approved or denied by the team members. In either of the case, the "status" changes to "A" or "D" respectively.

If there is an entry in the "" table for a user, then (s)he can only see advertisements if the corresponding "status" is "D", which implies that this user is not yet part of a team. This can be checked by querying for participant_id, which is unique for each combination of user_id, assignment_id, and then checking the "status" corresponding to that participant_id.

Pseudocode representing the logic we have used to modify sign_up_sheet.rb:

Respond_To_Ads(user_id, assignment_id)
p_id=Fetch participant_id corressponding to (user_id, assignment_id)
Check entries for p_id in table join_team_request_table where status is either "A" or "P"
count=number of such entries
return count

Pseudocode representing the logic we have used to modify view.html.erb:

If Sign Up Sheet has topics for a particular assignment()
If Respond_To_Ads(user_id, assignment_id) is equal to 0
Show Trumpet icon which is a link to the Ads

==='''Issue #227 '''===

If a user has an assignment and a topic only then (s)he will be able to advertise for team members to join their team. If a user doesn't have a topic (s)he won't be able to advertise.
The scenario in which A, B were two users, A with a topic, B without a topic, A joins B's team but A's topic gets dropped; A,B become a team but with no topic. Such cases are now avoided as we have ensured that without first selecting a topic a user cannot advertise for team members nor can he send invitations to other users to join his team. This is done by quering in the database using inner join between tables-SignUpTopic, signed_up_teams, team_users; and checking if the user has a topic for a particular assignment. If (s)he has a topic then he'll be able to see the option for advertising for teammates.
If the assignment doesn't have a topic then the user will be able to send out team invitations.
Pseudocode representing the logic we have used to modify student_teams_helper.rb:

StudentTeamsHelper
If the concerned assignment has topics
return false if their are topics
else return true

User_Has_Topic(user_id, assignment_id)
Query the database using inner joins between SignUpTopic, signed_up_teams, team_users rows= number of rows returned by the above query
If rows>0
return true
else
return false
Pseudocode representing the logic we have used to modify view.html.erb:

If concerned assignment does not have topics OR User_Has_Topic is true
Make Invite link visible

----

=='''How to test'''==

==='''Issue #311'''===

1)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, add topics for the assignment, enroll users(students) in the assignment.

2)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

3)Since A doesn't have a topic yet, so you won't be able to see the advertise link.

4)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members.

5)Post an advertisement-"Need team-members who know Ruby."

6)Login as another user(Student) or impersonate another student, say student B, whom you have enrolled in the assignment.

7)Since B doesn't have a topic yet, so you won't be able to see the advertise link.

8)Go to the sign-up sheet for the assignment, you'll be able to see a trumpet icon next to the topic that has an ad posted.

9)Click on the icon, you'll see the ad posted by A. Click on request to join A's team.

10)On doing so an entry is created on the table "" and status holds value "P" signifying a pending request.

11)Now if you go on the sign-up sheet again, you will no longer see the trumpet icon through which you can access the ads since you have already responded to an ad and the request is in pending state.

12)Login as user A or impersonate A, now you'll be able to see the team join request sent by user B.

13) Now, you can either approve it or decline it. Suppose you approve it, B will become a part of your team, and the status will change to "A". And now if you login as B or impersonate B, you will no longer be able to access the trumpet icon which is a link to all ads pertaining to topics the concerned assignment.

14)Had user A declined User Bs join request, the status in the table "" would change to "D", that means user B still doesn't have a team. So, now if you login as B or impersonate, you'll be able to see the ads again.

==='''Issue #227'''===

1)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment.

2)You should be able to see the assignment now in the Assignment section. Since A doesn't have a topic yet, so you won't be able to see the advertise link.

3)Go to the sign-up sheet for the assignment, select a topic. A now has a topic, so now A can advertise for team-members. Post an advertisement-"Need team-members who know Ruby."

4)This ensures that for an assignment with topics, a user can send out advertisements only if (s)he has a topic.

5)Login as Admin, create an assignment with all the necessary details like maximum no of users per team, do not add topics for the assignment, enroll users(students) in the assignment.

6)Login as user(Student) or impersonate a student, say student A, whom you have enrolled in the assignment. You should be able to see the assignment now in the Assignment section.

7)Since the assignment doesn't have any topics, therefore, you will be able to see the advertise link. You won't see a sign-up sheet since the assignment has no topics. You can advertise for teammates.

==='''Screenshots from conducted Test '''===
On clicking on 'Manage Content' the following screen is rendered which lists the existing assignments.
----
[[File:create public assignment.jpg ]]
----
On clicking on 'New Public Assignment' the following form is displayed in which assignment details can be entered.
----
[[File:create setup1.jpg ]]
----
Editing the created assignment.
----
[[File:create setup2.jpg ]]
----
Click on 'Topics' to add topics for the assignment.
----
[[File:create setup3.jpg ]]
----
Click on 'Rubrics' to setup assignment rubrics.
----
[[File:create setup4.jpg ]]
----
The following screenshot shows the completed setup.
----
[[File:completed setup for assignment with topic.jpg]]
----
On clicking on the image-link for adding participants for an assignment, the following screen is rendered.
----
[[File:adding student to assignmet.jpg ]]
----
Showing all added participants.
----
[[File:add the students.jpg ]]
----
The following screen is rendered when a student who is a participant in the current assignment clicks on it's sign-up sheet.
----
[[File:see the topic.jpg ]]
----
The following screen is rendered when a participant clicks on the sign-up sheet for the assignment. link.
----
[[File:select topic.jpg ]]
----
The following screen is rendered when a participant chooses a topic and then clicks on 'create advertisement'.
----
[[File:create ad.jpg ]]
----
After creating an ad, user can now see a horn icon which is a link to display the advertisements corresponding to that topic in that assignment.
----
[[File:see ad.jpg ]]
----
The following screen is rendered after clicking on the horn icon.
----
[[File:see the ad.jpg ]]
----
The following screen is rendered after clicking on the link 'Request invitation'.
----
[[File:respond to ad.jpg ]]
----
After sending a request to join a team (via ad), the user will no longer see the link for the ads unless the request is denied by the receiver.
----
[[File:cant see any more ad.jpg ]]
----
This is the screen of the user who had created the ad. He is now able to see any join requests that he can approve/decline.
----
[[File:request to join.jpg Width 200px Height 100px]]
----