Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-07T03:05:19Z

Jjjagtap: /* Automated Test Cases for new late policy validations */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message.

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.

'''File created:''' spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end
#validaes penalty per unit field
describe 'validate penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

#validates max_penalty field
describe 'validate max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

#validates penalty unit field
describe 'validate penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe 'validate times_used backgorund field' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

#validates policy_name field
describe 'validate policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end

</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id. This session variable gets overwritten every time whenever an edit page for the new assignment is opened. So the bug in the back link is fixed.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

==== Click on Create button without entering any details ====
[[File:Case-1.png]]

==== Enter the policy name which already exists. You can find it out on list of policies page. ====
[[File:Case-2.png]]

==== Enter alphabet or string in penalty per unit field ====
[[File:Case-3.png]]

==== Max Penalty cannot be greater than or equal to 50. Try entering a larger number ====
[[File:Case-4.png]]

==== Enter valid data in all fields. ====
[[File:Case-5.png]]

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

====Test Case log after running rspec file====
[[File:Testrspec.PNG]]

==== Test Cases for back link ====
There are three different cases covered under the back link testing on the new late policy page.

===== Test Case 1: Back Link directly from new late policy page =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Back.

It is redirected to the due dates tab of that assignment.

===== Test Case 2: Back Link after error on validation =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Click on create without Entering values -> Back.

An error message is shown regarding the validations when the create button is clicked. When the Back button is clicked at this stage, it is
redirected to the due dates tab of that assignment.

===== Test Case 3: Back Link after visiting the index page =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Submit a policy -> Create New policy -> Back

Once a policy is created we are redirected to the index page of the policies which lists all the policies available. Now if we try to create a new policy from here and click on the Back button after that, we are redirected to the due dates tab of that assignment.

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==
27.125%

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-07T03:03:46Z

Jjjagtap: /* Automated Test Cases for new late policy validations */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message.

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.

'''File created:''' spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end
#validaes penalty per unit field
describe 'validate penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

#validates max_penalty field
describe 'validate max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

#validates penalty unit field
describe 'validate penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe 'validate times_used backgorund field' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

#validates policy_name field
describe 'validate policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end

</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id. This session variable gets overwritten every time whenever an edit page for the new assignment is opened. So the bug in the back link is fixed.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

==== Click on Create button without entering any details ====
[[File:Case-1.png]]

==== Enter the policy name which already exists. You can find it out on list of policies page. ====
[[File:Case-2.png]]

==== Enter alphabet or string in penalty per unit field ====
[[File:Case-3.png]]

==== Max Penalty cannot be greater than or equal to 50. Try entering a larger number ====
[[File:Case-4.png]]

==== Enter valid data in all fields. ====
[[File:Case-5.png]]

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

[[File:Testrspec.PNG]]

==== Test Cases for back link ====
There are three different cases covered under the back link testing on the new late policy page.

===== Test Case 1: Back Link directly from new late policy page =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Back.

It is redirected to the due dates tab of that assignment.

===== Test Case 2: Back Link after error on validation =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Click on create without Entering values -> Back.

An error message is shown regarding the validations when the create button is clicked. When the Back button is clicked at this stage, it is
redirected to the due dates tab of that assignment.

===== Test Case 3: Back Link after visiting the index page =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Submit a policy -> Create New policy -> Back

Once a policy is created we are redirected to the index page of the policies which lists all the policies available. Now if we try to create a new policy from here and click on the Back button after that, we are redirected to the due dates tab of that assignment.

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==
27.125%

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-07T03:02:13Z

Jjjagtap: /* Automated Test Cases for new late policy validations */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message.

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.

'''File created:''' spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end
#validaes penalty per unit field
describe 'validate penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

#validates max_penalty field
describe 'validate max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

#validates penalty unit field
describe 'validate penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe 'validate times_used backgorund field' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

#validates policy_name field
describe 'validate policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end

</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id. This session variable gets overwritten every time whenever an edit page for the new assignment is opened. So the bug in the back link is fixed.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

==== Click on Create button without entering any details ====
[[File:Case-1.png]]

==== Enter the policy name which already exists. You can find it out on list of policies page. ====
[[File:Case-2.png]]

==== Enter alphabet or string in penalty per unit field ====
[[File:Case-3.png]]

==== Max Penalty cannot be greater than or equal to 50. Try entering a larger number ====
[[File:Case-4.png]]

==== Enter valid data in all fields. ====
[[File:Case-5.png]]

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

[[File:Testrspec.png]]

==== Test Cases for back link ====
There are three different cases covered under the back link testing on the new late policy page.

===== Test Case 1: Back Link directly from new late policy page =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Back.

It is redirected to the due dates tab of that assignment.

===== Test Case 2: Back Link after error on validation =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Click on create without Entering values -> Back.

An error message is shown regarding the validations when the create button is clicked. When the Back button is clicked at this stage, it is
redirected to the due dates tab of that assignment.

===== Test Case 3: Back Link after visiting the index page =====
Flow: Assignments -> Edit Button -> Due Dates Tab -> New Late Policy -> Submit a policy -> Create New policy -> Back

Once a policy is created we are redirected to the index page of the policies which lists all the policies available. Now if we try to create a new policy from here and click on the Back button after that, we are redirected to the due dates tab of that assignment.

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==
27.125%

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

File:Testrspec.PNG

2019-11-07T02:59:47Z

Jjjagtap:

File:Testrspec.png

2019-11-07T02:58:05Z

Jjjagtap:

File:Rspec.png

2019-11-07T02:57:16Z

Jjjagtap: uploaded a new version of "File:Rspec.png"

testing rspec file

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T01:31:27Z

Jjjagtap: /* Solutions to Problems in Current Implementation */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.

'''File created:''' spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end
#validaes penalty per unit field
describe 'validate penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

#validates max_penalty field
describe 'validate max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

#validates penalty unit field
describe 'validate penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe 'validate times_used backgorund field' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

#validates policy_name field
describe 'validate policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end

</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id. This session variable get overwritten every time whenever an edit page for new assignment is opened. So the bug in the back link is fixed.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T01:05:21Z

Jjjagtap: /* Automated Test Cases for new late policy validations */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.

'''File created:''' spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T01:04:43Z

Jjjagtap: /* Solutions to Problems in Current Implementation */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.

'''File created:''' spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T01:04:24Z

Jjjagtap: /* Solutions to Problems in Current Implementation */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.
'''File created:''' spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T01:04:00Z

Jjjagtap: /* Project Description */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.
'''File created:'''spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T01:03:29Z

Jjjagtap: /* Solutions to Problems in Current Implementation */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection. A new late policy must not be created if any of these validations fail.
'''File created:'''spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T01:02:48Z

Jjjagtap: /* Solutions to Problems in Current Implementation */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the Test Plan subsection.
'''File created:'''spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T01:01:24Z

Jjjagtap: /* Problem 1: Failure to create a new policy */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

The test cases have been mentioned in Test Plan section automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

A new Rspec File has been written to carry out the automatic testing. All the test cases have been mentioned in the [[Media:Example.ogg]]

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:56:32Z

Jjjagtap: /* Problem 1: Failure to create a new policy */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

'''Updated File:''' app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:56:12Z

Jjjagtap: /* Problem 2: Back link redirects to the wrong page */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

Updated File: app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''

We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:56:01Z

Jjjagtap: /* Problem 2: Back link redirects to the wrong page */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

Updated File: app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

'''Solution'''
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:55:36Z

Jjjagtap: /* Problem 1: Failure to create a new policy */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
'''Solution'''

There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

Updated File: app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:52:51Z

Jjjagtap: /* Problem 1: Failure to create a new policy */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
Solution:
There was no provision to handle the validations of the form in the new late_policy page.
A new late policy would not be created if any of the validations fail and the user would be notified of the errors by a flash error message

Updated File: app/views/late_policies/new.html.erb

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<% flash[:error] = @late_policy.errors.full_messages.join("<br/>").html_safe %>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:45:37Z

Jjjagtap: /* Team Information: */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:45:24Z

Jjjagtap: /* Code Coverage: */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:44:49Z

Jjjagtap: /* Tasks Accomplished: */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:43:56Z

Jjjagtap: /* Test Plan */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

====Manual Testing via UI====

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

====Automated Test Cases for new late policy validations====

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:43:19Z

Jjjagtap: /* Solutions to Problems in Current Implementation */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

====Problem 1: Failure to create a new policy====
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

''' update method at app/controllers/assignments_controller.rb '''
<pre> session[:assignment_id] = @assignment_form.assignment.id </pre>

'''app/views/late_policies/new.html.erb'''
<pre>
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => session[:assignment_id] , :anchor => "tabs-5" %>
</pre>

'''app/controllers/late_policies_controller.rb'''
<pre> redirect_to action: 'index', id: params[:late_policy][:assign_id] </pre>

''' app/views/late_policies/index.html.erb'''
<pre> <%= link_to 'New late policy', :action => 'new', :id => params[:id]%> </pre>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Manual Testing via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

'''Automated Test Cases for new late policy validations:'''

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:42:17Z

Jjjagtap: /* Problems in Current Implementation */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Manual Testing via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

'''Automated Test Cases for new late policy validations:'''

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:42:01Z

Jjjagtap: /* Problems in Current Implementation */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
====Problem 1: Failure to create a new policy====
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

====Problem 2: Back link redirects to the wrong page====
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Manual Testing via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

'''Automated Test Cases for new late policy validations:'''

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:41:26Z

Jjjagtap: /* Project Description */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Manual Testing via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

'''Automated Test Cases for new late policy validations:'''

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-02T00:40:53Z

Jjjagtap: /* Problem Statement */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

==Project Description==

===='''Problem Statement'''====
E1960. Create new late policy successfully and fixing "Back" link

===='''Background'''====

: An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

===='''Issue 1:'''====
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

===='''Issue 2:'''====
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Manual Testing via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

'''Automated Test Cases for new late policy validations:'''

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

File:Newpolicy1.png

2019-11-01T22:24:56Z

Jjjagtap:

File:New late policy test1.png

2019-11-01T22:20:53Z

Jjjagtap:

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T22:10:06Z

Jjjagtap: /* Test Plan */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

== Problem Statement ==
'''E1960. Create new late policy successfully and fixing "Back" link'''

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

'''Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Manual Testing via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

'''Automated Test Cases for new late policy validations:'''

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T22:09:13Z

Jjjagtap: /* Test Plan */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

== Problem Statement ==
'''E1960. Create new late policy successfully and fixing "Back" link'''

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

'''Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Manual Testing via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

'''Test Cases for new late policy validations:'''

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T22:08:45Z

Jjjagtap: /* Test Plan */

== About Expertiza ==

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

== Problem Statement ==
'''E1960. Create new late policy successfully and fixing "Back" link'''

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

'''Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

== Problems in Current Implementation ==
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

== Solutions to Problems in Current Implementation ==

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

<pre>
<% if @late_policy.errors.any? %>
<div id="error_explanation">
<h2>
<%= pluralize(@late_policy.errors.count, "error") %>
prohibited this post from being saved:
</h2>

<ul>
<% @late_policy.errors.full_messages.each do |msg| %>
<li><%= msg %></li>
<% end %>
</ul>
</div>
<% end %>
</pre>

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page

Step 2: Redirected to the Due Dates tab of the assignment page it came from

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy

Step 2: Click Back

Step 3: Redirected to the due dates tab of assignment page it came from

==Test Plan==

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Manual Testing via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy!

'''Test Cases for new late policy validations:'''

A new late policy must not be created if any of these validations fail.

<ol>
<li> Late Policy Name
<ol>
<li>Late Policy Name must not be blank</li>
<li>Late Policy must be unique</li>
</ol>
</li>
<li>Penalty Points per unit
<ol>
<li>Penalty points must not be blank</li>
<li>Penalty points must be a number</li>
<li>penalty points must be less than total penalty points</li>
</ol>
</li>
<li>Maximum Penalty
<ol>
<li>Maximum Penalty must not be blank</li>
<li>Maximum Penalty must be less than 50</li>
</ol>
</li>
</ol>

All these test cases have been automatically tested by writing a new RSpec file: spec/models/late_policy_spec.rb

<pre>
describe LatePolicy do
let(:policy) do
LatePolicy.new penalty_per_unit: 10.0, max_penalty: 30, penalty_unit: "Day", times_used: 0, instructor_id: 6, policy_name: 'rspectest'
end

describe '#penalty_per_unit' do
it 'returns the penalty_per_unit' do
expect(policy.penalty_per_unit).to eq(10.0)
end

it 'Validate presence of penalty_per_unit which cannot be blank' do
policy.penalty_per_unit = nil
expect(policy).not_to be_valid
end
it 'Validate if penalty_per_unit is less than max_penalty' do
policy.max_penalty = 20
policy.penalty_per_unit = 30
expect(policy).not_to be_valid
end
end

describe '#max_penalty' do
it 'returns the max_penalty' do
expect(policy.max_penalty).to eq(30)
end
it 'Validate presence of max_penalty which cannot be blank' do
policy.max_penalty = nil
expect(policy).not_to be_valid
end
it 'Validate if max_penalty is less tha 50' do
policy.max_penalty = 60
expect(policy).not_to be_valid
end
end

describe '#penalty_unit' do
it 'returns the penalty_unit' do
expect(policy.penalty_unit).to eq('Day')
end
it 'Validate presence of penalty_unit which cannot be blank' do
policy.penalty_unit = nil
expect(policy).not_to be_valid
end
end

describe '#times_used' do
it 'returns times_used' do
expect(policy.times_used).to eq(0)
end
end

describe '#policy_name' do
it 'returns the policy name' do
expect(policy.policy_name).to eq('rspectest')
end
it 'Validate presence of policy name which cannot be blank' do
policy.policy_name = nil
expect(policy).not_to be_valid
end
end
end
</pre>

==Tasks Accomplished:==
Following tasks were accomplished in this project:

1. Corrected the code for the late_policies controller and new late_policy page.

2. Improved the code for the Back button inside the new late_policy page.

3. Added RSPEC test cases for testing changes done in late_policies Controller.

==Code Coverage:==

== Team Information: ==

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

== References ==

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link/ Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T22:06:26Z

Jjjagtap: /* Test Plan */

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T21:06:42Z

Jjjagtap:

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:59:46Z

Jjjagtap:

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:58:31Z

Jjjagtap:

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:54:39Z

Jjjagtap:

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:54:07Z

Jjjagtap:

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:53:12Z

Jjjagtap:

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:52:24Z

Jjjagtap:

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:49:52Z

Jjjagtap:

=== About Expertiza ===

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

=== Peer Review Information ===

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Navigation to test via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy !

=== Problem Statement ===
'''E1960. Create new late policy successfully and fixing "Back" link'''

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

'''Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

=== Current Implementation ===
'''Functionality:'''
An Instructor has the option to create new late policies to be applied to the assignments.
An Instructor can choose to go back to the previous page from the create new policy page.

=== Problems in Current Implementation ===
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

=== Solutions to Problems in Current Implementation ===

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page
[[File:Back-1.1.png]]
Step 2: Redirected to the Due Dates tab of the assignment page it came from
[[File:Back-1.2.png]]

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy
[[File:Back-2.1.png]]

Step 2: Click Back
[[File:Back-2.2d.png]]

Step 3: Redirected to the due dates tab of assignment page it came from
[[File:Back-2.3.png]]

'''Test Plan'''
abs

'''Tasks Accomplished:'''
Following tasks were accomplished in this project:
1. Corrected the code for the late_policies controller and new late_policy page.
2. Improved the code for the Back button inside the new late_policy page.
3. Added RSPEC test cases for testing changes done in late_policies Controller.

=== Team Information: ===

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

=== References ===

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link| Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:48:41Z

Jjjagtap:

=== About Expertiza ===

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

=== Peer Review Information ===

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Navigation to test via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy !

=== Problem Statement ===
'''E1960. Create new late policy successfully and fixing "Back" link'''

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

'''Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

=== Current Implementation ===
'''Functionality:'''
An Instructor has the option to create new late policies to be applied to the assignments.
An Instructor can choose to go back to the previous page from the create new policy page.

=== Problems in Current Implementation ===
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

=== Solutions to Problems in Current Implementation ===

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page
[[File:Back-1.1.png]]
Step 2: Redirected to the Due Dates tab of the assignment page it came from
[[File:Back-1.2.png]]

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy
[[File:Back-2.1.png]]

Step 2: Click Back
[[File:Back-2.2d.png]]

Step 3: Redirected to the due dates tab of assignment page it came from
[[File:Back-2.3.png]]

'''Tasks Accomplished:'''
Following tasks were accomplished in this project:
1. Corrected the code for the late_policies controller and new late_policy page.
2. Improved the code for the Back button inside the new late_policy page.
3. Added RSPEC test cases for testing changes done in late_policies Controller.

=== Team Information: ===

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

=== References ===

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link| Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:47:05Z

Jjjagtap: /* Team Information: */

=== About Expertiza ===

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

=== Peer Review Information ===

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Navigation to test via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy !

=== Problem Statement ===
'''E1960. Create new late policy successfully and fixing "Back" link'''

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

'''Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

=== Current Implementation ===
'''Functionality:'''
An Instructor has the option to create new late policies to be applied to the assignments.
An Instructor can choose to go back to the previous page from the create new policy page.

=== Problems in Current Implementation ===
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

=== Solutions to Problems in Current Implementation ===

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page
[[File:Back-1.1.png]]
Step 2: Redirected to the Due Dates tab of the assignment page it came from
[[File:Back-1.2.png]]

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy
[[File:Back-2.1.png]]

Step 2: Click Back
[[File:Back-2.2d.png]]

Step 3: Redirected to the due dates tab of assignment page it came from
[[File:Back-2.3.png]]

'''Tasks Accomplished:'''
Following tasks were accomplished in this project:
Corrected the code for the late_policies controller and new late_policy page.
Improved the code for the Back button inside the new late_policy page.
Added RSPEC test cases for testing changes done in late_policies Controller.

=== Team Information: ===

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

=== References ===

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link| Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:44:36Z

Jjjagtap: /* Problem Statement */

=== About Expertiza ===

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

=== Peer Review Information ===

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Navigation to test via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy !

=== Problem Statement ===
'''E1960. Create new late policy successfully and fixing "Back" link'''

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''

'''Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

=== Current Implementation ===
'''Functionality:'''
An Instructor has the option to create new late policies to be applied to the assignments.
An Instructor can choose to go back to the previous page from the create new policy page.

=== Problems in Current Implementation ===
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

=== Solutions to Problems in Current Implementation ===

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

[[File:Case-1.png]]

[[File:Case-2.png]]

[[File:Case-3.png]]

[[File:Case-4.png]]

[[File:Case-5.png]]

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page
[[File:Back-1.1.png]]
Step 2: Redirected to the Due Dates tab of the assignment page it came from
[[File:Back-1.2.png]]

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy
[[File:Back-2.1.png]]

Step 2: Click Back
[[File:Back-2.2d.png]]

Step 3: Redirected to the due dates tab of assignment page it came from
[[File:Back-2.3.png]]

'''Tasks Accomplished:'''
Following tasks were accomplished in this project:
Corrected the code for the late_policies controller and new late_policy page.
Improved the code for the Back button inside the new late_policy page.
Added RSPEC test cases for testing changes done in late_policies Controller.

=== Team Information: ===

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

=== References ===

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link| Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:43:42Z

Jjjagtap: /* Solutions to Problems in Current Implementation */

=== About Expertiza ===

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

=== Peer Review Information ===

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Navigation to test via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy !

=== Problem Statement ===
'''E1960. Create new late policy successfully and fixing "Back" link'''

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''
Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

=== Current Implementation ===
'''Functionality:'''
An Instructor has the option to create new late policies to be applied to the assignments.
An Instructor can choose to go back to the previous page from the create new policy page.

=== Problems in Current Implementation ===
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

=== Solutions to Problems in Current Implementation ===

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

[[File:Case-1.png]]

[[File:Case-2.png]]

[[File:Case-3.png]]

[[File:Case-4.png]]

[[File:Case-5.png]]

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page
[[File:Back-1.1.png]]
Step 2: Redirected to the Due Dates tab of the assignment page it came from
[[File:Back-1.2.png]]

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy
[[File:Back-2.1.png]]

Step 2: Click Back
[[File:Back-2.2d.png]]

Step 3: Redirected to the due dates tab of assignment page it came from
[[File:Back-2.3.png]]

'''Tasks Accomplished:'''
Following tasks were accomplished in this project:
Corrected the code for the late_policies controller and new late_policy page.
Improved the code for the Back button inside the new late_policy page.
Added RSPEC test cases for testing changes done in late_policies Controller.

=== Team Information: ===

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

=== References ===

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link| Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:40:47Z

Jjjagtap: /* Peer Review Information */

=== About Expertiza ===

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

=== Peer Review Information ===

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Navigation to test via UI''':

1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy !

=== Problem Statement ===
'''E1960. Create new late policy successfully and fixing "Back" link'''

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''
Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

=== Current Implementation ===
'''Functionality:'''
An Instructor has the option to create new late policies to be applied to the assignments.
An Instructor can choose to go back to the previous page from the create new policy page.

=== Problems in Current Implementation ===
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

=== Solutions to Problems in Current Implementation ===

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

[[File:Case-1.png]]

[[File:Case-2.png]]

[[File:Case-3.png]]

[[File:Case-4.png]]

[[File:Case-5.png]]

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page
[[File:Back-1.1.png]]
Step 2: Redirected to the Due Dates tab of the assignment page it came from
[[File:Back-1.2.png]]

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy
[[File:Back-2.1.png]]

Step 2: Click Back
[[File:Back-2.2d.png]]

Step 3: Redirected to the due dates tab of assignment page it came from
[[File:Back-2.3.png]]

'''Tasks Accomplished:'''
Following tasks were accomplished in this project:
Corrected the code for the late_policies controller and new late_policy page.
Improved the code for the Back button inside the new late_policy page.
Added RSPEC test cases for testing changes done in late_policies Controller.

=== Team Information: ===

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

=== References ===

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link| Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:40:34Z

Jjjagtap: /* Peer Review Information */

=== About Expertiza ===

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

=== Peer Review Information ===

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Navigation to test via UI''':
1. Login to expertiza using the above credentials.

2. Click on Assignments under Manage Notifications.

3. Click on Edit icon under any of the Assignments.

4. Navigate to Due Dates Tab.

5. Scroll Down and click on "New Late Policy".

6. Create/test new Late Policy !

=== Problem Statement ===
'''E1960. Create new late policy successfully and fixing "Back" link'''

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''
Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

=== Current Implementation ===
'''Functionality:'''
An Instructor has the option to create new late policies to be applied to the assignments.
An Instructor can choose to go back to the previous page from the create new policy page.

=== Problems in Current Implementation ===
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

=== Solutions to Problems in Current Implementation ===

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

[[File:Case-1.png]]

[[File:Case-2.png]]

[[File:Case-3.png]]

[[File:Case-4.png]]

[[File:Case-5.png]]

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page
[[File:Back-1.1.png]]
Step 2: Redirected to the Due Dates tab of the assignment page it came from
[[File:Back-1.2.png]]

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy
[[File:Back-2.1.png]]

Step 2: Click Back
[[File:Back-2.2d.png]]

Step 3: Redirected to the due dates tab of assignment page it came from
[[File:Back-2.3.png]]

'''Tasks Accomplished:'''
Following tasks were accomplished in this project:
Corrected the code for the late_policies controller and new late_policy page.
Improved the code for the Back button inside the new late_policy page.
Added RSPEC test cases for testing changes done in late_policies Controller.

=== Team Information: ===

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

=== References ===

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link| Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link

2019-11-01T20:39:46Z

Jjjagtap: /* Peer Review Information */

=== About Expertiza ===

Expertiza is an open-source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages

=== Peer Review Information ===

For users intending to view the deployed Expertiza associated with this assignment, the credentials are below:
Instructor Login: username -> instructor6, password -> password

'''Navigation to test via UI''':
1. Login to expertiza using the above credentials.
2. Click on Assignments under Manage Notifications.
3. Click on Edit icon under any of the Assignments.
4. Navigate to Due Dates Tab.
5. Scroll Down and click on "New Late Policy".
6. Create and test new Late Policy !

=== Problem Statement ===
'''E1960. Create new late policy successfully and fixing "Back" link'''

Mentor: Yashad Trivedi (ytrived@ncsu.edu)

'''Background''': An instructor can create late policies for any assignment, wherein the instructor can specify the points per unit and the maximum penalty that can be applied for any assignment submission.
'''
Issue 1:'''
If an instructor while creating a policy, clicks on “Create” (Step 5), following error message is displayed on the top of the page “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Issue 2:'''
If an instructor, while creating a policy, clicks on "Back" link (Step 6) and wants to go back to the previous page, (s)he is directed to the list of policies instead of “Due Date” tab of assignment edit page (Step 2 above).

=== Current Implementation ===
'''Functionality:'''
An Instructor has the option to create new late policies to be applied to the assignments.
An Instructor can choose to go back to the previous page from the create new policy page.

=== Problems in Current Implementation ===
'''Problem 1: Failure to create a new policy'''
The create button on the new page of late_policy is not working.
Whenever the data for the form is filled and submitted by clicking on the Create button, an error message is shown saying “The following error occurred while saving the penalty policy:” and the policy is not created and added to the list of policies.

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When the Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the index page of late policies.

=== Solutions to Problems in Current Implementation ===

'''Problem 1: Failure to create a new policy'''
Solution:
There was no provision to handle the validations of the form in the new late_policy page.

[[File:Case-1.png]]

[[File:Case-2.png]]

[[File:Case-3.png]]

[[File:Case-4.png]]

[[File:Case-5.png]]

'''Problem 2: Back link redirects to the wrong page'''
An instructor can choose to go back to the previous page from the create new policy page.
When Back button on the create new late policy is clicked, it should be redirected to the Due Date tab of the assignment it came from but it is redirected to the list of late policies page

Solution:
We tried to store the assignment id of the page from where the create new policy was clicked. This way when we have to redirect after the back button,
we can send it to this particular assignment with the help of assignment id.

'''app/views/late_policies/new.html.erb'''
<%= f.hidden_field :assign_id, value: params[:id] %>
<%= link_to 'Back', :controller => 'assignments', :action => 'edit', :id => params[:id], :anchor => "tabs-5" %>

'''app/controllers/late_policies_controller.rb'''
redirect_to action: 'index', id: params[:late_policy][:assign_id]

''' app/views/late_policies/index.html.erb'''
<%= link_to 'New late policy', :action => 'new', :id => params[:id]%>

'''Back Case - 1'''
Step 1: Click Back on Create New Policy page
[[File:Back-1.1.png]]
Step 2: Redirected to the Due Dates tab of the assignment page it came from
[[File:Back-1.2.png]]

'''Back Case - 2'''
Step 1: On Index Page of Late Policies. Click Create New Policy
[[File:Back-2.1.png]]

Step 2: Click Back
[[File:Back-2.2d.png]]

Step 3: Redirected to the due dates tab of assignment page it came from
[[File:Back-2.3.png]]

'''Tasks Accomplished:'''
Following tasks were accomplished in this project:
Corrected the code for the late_policies controller and new late_policy page.
Improved the code for the Back button inside the new late_policy page.
Added RSPEC test cases for testing changes done in late_policies Controller.

=== Team Information: ===

Devarsh Shah

Jay Jagtap

Ritesh Ghorse

=== References ===

1.[https://github.com/expertiza/expertiza/ Expertiza on GitHub]

2.[https://github.com/jayjagtap/expertiza/ GitHub Project Repository Fork]

3.[http://expertiza.ncsu.edu/ Live Expertiza website]

4.[http://152.46.17.218:8080/ Demo Link]

5.[http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1960._Create_new_late_policy_successfully_and_fixing_%22Back%22_link| Expertiza project documentation wiki]

6.[https://relishapp.com/rspec Rspec Documentation]

7.Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin