Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T23:48:58Z

Hzhang62: /* Step 1: create a review link for staff(TA/Instructor) */

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T23:48:27Z

Hzhang62: /* Step 1: create a review link for staff(TA/Instructor) */

File:E2086 begin review.png

2020-11-16T23:47:45Z

Hzhang62:

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T23:37:07Z

Hzhang62: /* Rspec Test Cases */

File:E2086rspec.png

2020-11-16T23:36:11Z

Hzhang62:

File:Rspec.png

2020-11-16T23:34:27Z

Hzhang62: Hzhang62 uploaded a new version of File:Rspec.png

testing rspec file

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T23:32:09Z

Hzhang62: /* Step 5: Allow students to identify that their submission has been reviewed by staff */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we created a function called "find_team_member" and moved the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fixed this small issue.
 
[[File:Step2 3.png]]
 
Third, we found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses''' and let student review and staff review share one common template. We created a symbol variable ''':reviewer_role''' in order to identify the role of performing review. The shared template locates in app/view/shared/responses folder.
 
[[File:Step2 4.png]]
 
=== Step 3: create shared view for response_action ===
In this file, student review and staff review share one template. We use '''reviewer_role''' to identify the role of the reviewer and render the different views for this reviewer. The page will show different review action base on the current stage and if the review did this review before (For example: if the current stage Finished and no previous review, the page will show "Begin review").
 
[[File:Step2 5.png]]
 
=== Step 4: refactor response controller ===
Before modification, the normal review could only be done by students. When the student finished the review and clicked “Submit”, the page seemed to redirect from the students' review. Since we newly added staff to review, the location of redirect should also be modified accordingly.
 
[[File:Step4.png]]
 
=== Step 5: Allow students to identify that their submission has been reviewed by staff ===
A simple check is made to determine if the reviewer is a TA or Instructor. app/assets/images/staff.png is displayed to make an instructor performed review stand out from other reviews.
First, in order to determine if a review was completed by a staff participant (either a TA or an instructor), we create a function in app/models/review_response_map.rb.
 
[[File:Step5 1.png]]
 
If the mouse hovers over the icon a tooltip appears saying "Icon indicates this review was done by course staff"
 
[[File:Step icon.png]]
 
 
[[File:Step6.png]]
 

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step icon.png

2020-11-16T23:31:46Z

Hzhang62:

File:Step6.png

2020-11-16T23:28:53Z

Hzhang62: Hzhang62 uploaded a new version of File:Step6.png

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T23:24:29Z

Hzhang62: /* Implementation */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we created a function called "find_team_member" and moved the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fixed this small issue.
 
[[File:Step2 3.png]]
 
Third, we found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses''' and let student review and staff review share one common template. We created a symbol variable ''':reviewer_role''' in order to identify the role of performing review. The shared template locates in app/view/shared/responses folder.
 
[[File:Step2 4.png]]
 
=== Step 3: create shared view for response_action ===
In this file, student review and staff review share one template. We use '''reviewer_role''' to identify the role of the reviewer and render the different views for this reviewer. The page will show different review action base on the current stage and if the review did this review before (For example: if the current stage Finished and no previous review, the page will show "Begin review").
 
[[File:Step2 5.png]]
 
=== Step 4: refactor response controller ===
Before modification, the normal review could only be done by students. When the student finished the review and clicked “Submit”, the page seemed to redirect from the students' review. Since we newly added staff to review, the location of redirect should also be modified accordingly.
 
[[File:Step4.png]]
 
=== Step 5: Allow students to identify that their submission has been reviewed by staff ===
A simple check is made to determine if the reviewer is a TA or Instructor. app/assets/images/staff.png is displayed to make an instructor performed review stand out from other reviews.
First, in order to determine if a review was completed by a staff participant (either a TA or an instructor), we create a function in app/models/review_response_map.rb.
 
[[File:Step5 1.png]]
 

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step5 1.png

2020-11-16T23:24:05Z

Hzhang62:

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T23:16:59Z

Hzhang62: /* Implementation */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we created a function called "find_team_member" and moved the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fixed this small issue.
 
[[File:Step2 3.png]]
 
Third, we found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses''' and let student review and staff review share one common template. We created a symbol variable ''':reviewer_role''' in order to identify the role of performing review. The shared template locates in app/view/shared/responses folder.
 
[[File:Step2 4.png]]

=== Step 3: create shared view for response_action ===
In this file, student review and staff review share one template. We use '''reviewer_role''' to identify the role of the reviewer and render the different views for this reviewer. The page will show different review action base on the current stage and if the review did this review before (For example: if the current stage Finished and no previous review, the page will show "Begin review").
 
[[File:Step2 5.png]]

=== Step 4: refactor response controller ===
Before modification, the normal review could only be done by students. When the student finished the review and clicked “Submit”, the page seemed to redirect from the students' review. Since we newly added staff to review, the location of redirect should also be modified accordingly.
 
[[File:Step4.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step4.png

2020-11-16T23:16:53Z

Hzhang62: Hzhang62 uploaded a new version of File:Step4.png

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T23:08:52Z

Hzhang62: /* Step 3: create shared view for response_action */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we created a function called "find_team_member" and moved the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fixed this small issue.
 
[[File:Step2 3.png]]
 
Third, we found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses''' and let student review and staff review share one common template. We created a symbol variable ''':reviewer_role''' in order to identify the role of performing review. The shared template locates in app/view/shared/responses folder.
 
[[File:Step2 4.png]]

=== Step 3: create shared view for response_action ===
In this file, student review and staff review share one template. We use '''reviewer_role''' to identify the role of the reviewer and render the different views for this reviewer. The page will show different review action base on the current stage and if the review did this review before (For example: if the current stage Finished and no previous review, the page will show "Begin review").
 
[[File:Step2 5.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step2 5.png

2020-11-16T23:08:22Z

Hzhang62: Hzhang62 uploaded a new version of File:Step2 5.png

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T23:05:46Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we created a function called "find_team_member" and moved the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fixed this small issue.
 
[[File:Step2 3.png]]
 
Third, we found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses''' and let student review and staff review share one common template. We created a symbol variable ''':reviewer_role''' in order to identify the role of performing review. The shared template locates in app/view/shared/responses folder.
 
[[File:Step2 4.png]]

=== Step 3: create shared view for response_action ===
In this file, student review and staff review share one template. We use '''reviewer_role''' to identify the role of the reviewer and render the different views for this reviewer. The page will show different review action base on the current stage and if the review did this review before (For example: if the current stage Finished and no previous review, the page will show "Begin review")
[[File:Step2 5.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step2 5.png

2020-11-16T23:03:04Z

Hzhang62:

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:53:40Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we created a function called "find_team_member" and moved the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fixed this small issue.
 
[[File:Step2 3.png]]
 
Third, we found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses''' and let student review and staff review share one common template. We created a symbol variable ''':reviewer_role''' in order to identify the role of performing review. The shared template locates in app/view/shared/responses folder.
 
[[File:Step2 4.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step2 4.png

2020-11-16T22:53:31Z

Hzhang62:

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:48:13Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we created a function called "find_team_member" and moved the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fixed this small issue.
 
[[File:Step2 3.png]]

We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:47:52Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we create a function called "find_team_member" and move the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fixed this small issue.
 
[[File:Step2 3.png]]

We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:46:40Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we create a function called "find_team_member" and move the code into '''response_map'''.
 
[[File:Step2 1.png]]
 
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fix this small issue.
 
[[File:Step2 3.png]]

We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:46:18Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we create a function called "find_team_member" and move the code into '''response_map'''.
[[File:Step2 1.png]]
[[File:Step2 2.png]]
 
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fix this small issue.
[[File:Step2 3.png]]

We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:45:44Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we create a function called "find_team_member" and move the code into '''response_map'''.
[[File:Step2 1.png]]
[[File:Step2 2.png]]
Second, we found it is better to use '''unless''' instead of using ''' if ! ''' in ruby on rails. So we fix this small issue.
[[File:Step2 3.png]]

We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step2 3.png

2020-11-16T22:45:38Z

Hzhang62:

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:39:11Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we create a function called "find_team_member" and move the code into '''response_map'''.
[[File:Step2 1.png]]
[[File:Step2 2.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step2 2.png

2020-11-16T22:39:02Z

Hzhang62:

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:37:55Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we create a function called "find_team_member" and move the code into '''response_map'''.
[[File:Step2 1.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:37:22Z

Hzhang62: /* Step 2: refactor the view part of the review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we create a function called "find_team_member" into '''response_map'''.
[[File:Step2 1.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step2 1.png

2020-11-16T22:37:03Z

Hzhang62:

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:35:53Z

Hzhang62: /* Implementation */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]
=== Step 2: refactor the view part of the review ===
We found that the student review and the staff review have a lot of common code. So we refactor the '''student_review/_responses'''.
first, we found some code in the '''student_review/_responses''' should not show here. The purpose of the code from line 5 to line 12 is to find team members. This action relates to response_map. So we create a function called "find_team_member" into '''response_map'''.

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:24:04Z

Hzhang62: /* Step 1: create a review link for staff(TA/Instructor) */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage becomes "Finished", we show the "Assign Grade" link. We use function '''current_user_is_assignment_participant''' to check if the current user have access to perform review. If the current user does not have the access to this assignment. No link will be shown.
[[File:Step1.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:21:16Z

Hzhang62: /* Step 1: create a review link for staff(TA/Instructor) */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
We create a link "Begin review" in '''list_submissions.html.erb''' in order to let staff(TA/Instructor) perform review before the review deadline. And if the current stage become "Finished", we show "Assign Grade" link.
[[File:Step1.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:17:26Z

Hzhang62: /* Step 1: create */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create a review link for staff(TA/Instructor) ===
[[File:Step1.png]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:16:35Z

Hzhang62: /* Test Plan */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Implementation ==
=== Step 1: create===
[[File:Step1.png]]
== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Step1.png

2020-11-16T22:16:21Z

Hzhang62: Hzhang62 uploaded a new version of File:Step1.png

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:09:13Z

Hzhang62: /* Perform review */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Begin review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Begin review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:07:35Z

Hzhang62: /* Rspec Test Cases */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Perform review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Perform review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]
== Demo ==
The video [https://youtu.be/FyBfWrdX5Dk] demonstrates the functionalities implemented in this project.

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:05:17Z

Hzhang62: /* Rspec Test Cases */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Perform review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Perform review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Travis-pass.png

2020-11-16T22:04:14Z

Hzhang62: Hzhang62 uploaded a new version of File:Travis-pass.png

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T22:00:57Z

Hzhang62: /* Rspec Test Cases */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Perform review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Perform review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.PNG]]

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

File:Travis-pass.png

2020-11-16T22:00:19Z

Hzhang62: Hzhang62 uploaded a new version of File:Travis-pass.png

File:Travis-pass.png

2020-11-16T21:59:36Z

Hzhang62:

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T21:59:21Z

Hzhang62: /* Rspec Test Cases */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Perform review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Perform review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>
 
All Rspec tests are passing for this implementation as is evident by the Travis CI.
 
[[File:Travis-pass.png]]

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T18:38:24Z

Hzhang62: /* Project Index */

== Project Index ==
* Deployment Link:
http://152.7.98.249:8080/
* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Perform review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Perform review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T16:32:23Z

Hzhang62: /* Files Involved */

== Project Index ==
* Deployment Link:

* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Edited ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Perform review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Perform review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T16:27:35Z

Hzhang62: /* Rspec Test Cases */

== Project Index ==
* Deployment Link:

* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Involved ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Perform review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Perform review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
<pre>
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end
</pre>

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T16:26:08Z

Hzhang62: /* Rspec Test Cases */

== Project Index ==
* Deployment Link:

* Github Repository:
https://github.com/MayoNaizz/expertiza
* Github Pull Request:
https://github.com/expertiza/expertiza/pull/1834
* Youtube Video Link:
https://youtu.be/FyBfWrdX5Dk

== Project Background ==

* Expertiza Project - E2086 : Let course staff as well as students do reviews

=== Why This Project ===

Peer review is a great way for students to learn about how well they have developed their application. However, sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development. By letting course staff perform reviews as well, the reviewer and the reviewee both benefit, improving the overall learning experience. Currently, there exists no method for the instructor/TA to perform reviews of assignments submitted by the students. Hence this is what this project aims at, allowing instructor/TA to perform reviews.

=== Primary Goal of this Project===

This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews

=== Files Involved ===
'''Controller: '''
app/controllers/response_controller.rb
'''Model: '''
app/models/review_response_map.rb
app/models/response_map.rb
'''View:'''
app/views/student_review/_responses.html.erb
app/views/shared/responses/_response_actions.html.erb
app/views/grades/view_team.html.erb
app/views/grades/_add_icon_to_name.html.erb
app/views/assignments/list_submissions.html.erb
app/views/assignments/_responses.html.erb

=== Project Team Member===

* Chenwei Zhou (czhou6)
* Tianrui Wang (twang33)
* Zhuolin Li(zli82)
* Hao Zhang (hzhang62)

== Project Design Philosophy ==
Our project aims at enabling the instructor/TA to review the submissions using the same form that a student uses while peer-reviewing. For this, our implementation has been divided into 3 parts, and can be described as follows:
<ol>
<li>The first part involves the primary functionality of letting the staff perform a review on students submission.</li>
<li>The second part involves allowing the students to identify from their end, which review has been performed by an instructor/TA. This will help students improve their project as the opinions presented by a staff member would be valid.</li>
<li>Third, we plan to enable the instructor/TA to do review instead of assign grade in the review round. After the review Round, the review review session will be closed and replaced with assigning grade interface</li>
</ol>

== Design Flowchart ==

*Functions that were included
[[File:E2086 flowchart2.png]]

== Issue ==
=== Plan of Work ===
*In the assignment page of the Expertiza, If an instructor or a TA is a participant in an assignment, then the instructor should be able to review any team that has submitted the assignment.
*In order to see who is participating in the assignment, click on the “Add participants” icon (the one with the + sign and a picture of a person). That will bring up a list of participants and allow you to add more participants.
*Make the instructor and/or TAs participants, and then they should be allowed to do reviews.
[[File:E2086 assignment.png|900px]]

*Then, to perform reviews, the instructor/TA would click on the clipboard-like “View submissions” icon, as shown below.
[[File:E2086 view submission.png|900px]]

*A list of submissions would be pulled up:
[[File:E2086 submission.png|900px]]
*If the last due date for the assignment has not passed, then the “Assign grade” link should be changed to “Perform review”, and when clicked on, it should pull up a review page for the team, showing their submitted work at the top, as a review page normally does.
* We will add the review link in <code>views/assignments/list_submissions.html.erb</code> and once instructor/TA click that link. Controller <code> response </code> will be called. Once the <code> get_current_stage() </code> change to "Finished" it means the due day of the review round is over. The review link will be replaced by the grade link.

*Also, it would be more clear if we could mark the instructor's review with something special on the reviews page, as shown below.
*We will add an icon in <code>views/grades/view_team.html.erb</code> and <code>app/views/response/view.html.erb</code> if these review is made by instructor or TA.
This function will be implemented in <code> helpers/grades_helper.rb </code>
[[File:E2086 review.png|700px]]

== Test Plan ==
The basic idea of this project is to change the 'Assign Grade' link to 'Perform review' if the deadline of a assignment has not passed. Thus, to test the functionality of this part, we plan to test it at the frontend

=== Configuration ===
<ol>

<li> Click 'Manage' -> 'Assignments' to go to assignment page.</li>
<li> Add a new assignment for a course that the current account has registered. Make sure the due date of the assignment is after the the time to perform the review as an instructor.</li>
<li> Click 'Add participants' icon in the new created assignment row, and 'Copy participants from course' to add all students registered to this course. Then add the current instructor account to this assignment through 'Enter a user login:' input space.</li>
<li> Impersonate as one of the students to simulate the submission of work.</li>
</ol>

=== Perform review ===
<ol>
<li> Click 'Manage' -> 'Assignments' to go to assignment page as instructor.</li>
<li> Click 'View submission' icon in the new created assignment row. Now the 'Perform review' link show be under participants name if the due date has not passed.</li>
<li> Click one of the 'Perform review' link to do the review for a certain submission by using the same templet of student peer review.</li>
<li> Impersonate the student that was previously reviewed by instructor. Check score for the assignment, and the review from the instructor should be recognizable from other student reviews.</li>
</ol>

== Refactor & Code Modification ==

== Running Tests ==
<pre>
rspec spec/features/instructor_do_review_spec.rb
</pre>

== Rspec Test Cases ==
describe "check 'Begin review' showing up before due date and 'Assign grade' after due date" do
let(:team) { build(:assignment_team, id: 1, name: 'team1') }

it "Begin review" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "team_formation")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone .day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone + 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "team_formation").first, due_at: DateTime.now.in_time_zone .day)

questionnaire1 = create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit("/response/new?id=#{questionnaire1.id}&return=ta_review")
expect(page).to have_content("E2086")

fill_in "responses[0][comment]", with: "Excellent Work"
click_button "Submit Review"
expect(page).to have_content "Your response was successfully saved."

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("student6666")
expect(page).to have_content("https://www.expertiza.ncsu.edu")

visit('/impersonate/start')
expect(page).to have_content("Enter user account")
fill_in("user_name", with: student_test.name)
click_button("Impersonate")
expect(current_path).to eql("/student_task/list")
expect(page).to have_content("User: #{student_test.name}")
expect(page).to have_content("E2086")
click_link("E2086")
end

it "Assign grade" do
instructor6 = create(:instructor) #create instructor6
assignment_test = create(:assignment, name: 'E2086', course: nil) #create an assignment without course
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "submission").first, due_at: DateTime.now.in_time_zone - 10.day)
create(:assignment_due_date, deadline_type: DeadlineType.where(name: "review").first, due_at: DateTime.now.in_time_zone - 5.day)

create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first)
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)

expect(assignment_test.instructor_id).to eql(instructor6.id)
expect(assignment_test.course_id).to eql(nil)
student_test = create(:student, name: "student6666", email: "stu6666@ncsu.edu") #create a student for test

visit(root_path)
fill_in('login_name', with: 'instructor6')
fill_in('login_password', with: 'password')
click_button('Sign in')
expect(current_path).to eql("/tree_display/list")
expect(page).to have_content('Manage content')

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: instructor6.name)
click_button("Add", match: :first)
expect(page).to have_content(instructor6.name)
expect(page).to have_content(instructor6.email)
click_button("Submit", match: :first)

visit("/participants/list?id=#{assignment_test.id}&model=Assignment")
expect(page).to have_content("E2086")
fill_in("user_name", match: :first, with: student_test.name)
click_button("Add", match: :first)
expect(page).to have_content(student_test.name)
expect(page).to have_content(student_test.email)

user_id = User.find_by(name: 'student6666').id
participant_student = Participant.where(user_id: user_id)
participant_id = participant_student.first.id
parent_id = participant_student.first.parent_id
team_student = Team.where(parent_id: parent_id)
team_user = create(:team_user, user_id: user_id)

visit("/assignments/list_submissions?id=#{assignment_test.id}")
expect(page).to have_content("https://www.expertiza.ncsu.edu")
expect(page).to have_link('Assign Grade', exact:true)

end
end

== Reference & Links ==
=== Previous Implementation ===
This project was done by Team E1985 on Fall 2019 with the following work:

Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews

Github Pull Request: https://github.com/expertiza/expertiza/pull/1631

Github repository: https://github.com/Matrawick/expertiza

Youtube screencast: https://youtu.be/kLfZ22vlu30

=== Comments From Mentor ===
* Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).

* There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.

* One test has been removed because it broke the build, & was evid. unrelated to their functionality.

* The commit was too messy; if this had been merged, it would have required refactoring.

for more information about this project, please visit [https://docs.google.com/document/d/1qphGGe8imRNufw2EhTZRqgs-I6XiQX74_I3UiwpPs5M/edit# Project Lists]

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T16:25:30Z

Hzhang62: /* Running Tests */

CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews

2020-11-16T16:18:12Z

Hzhang62: /* Files Involved */