Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-16T02:50:59Z

Gfan: /* Problem Statement */

=='''Introduction to Expertise'''==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database(only instructor and TA roles which is acceptable currently but not when more other institutions try to user Expertiza).

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

=='''Problem Statement'''==
'''Overall Introduction'''

Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

===Detailed Requirements and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>

-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

'''3. The record retain after admin's approval/rejection and an email will be sent to remind'''<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Fix 1. Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they couldn't find one in the list, and save it into the table corresponding to the form it submits to.

- design a requested_user table to save all account requests

===Fix 2. Add new Page and Action===
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page

- create corresponding new controller with methods corresponding to actions like reject, approve and index.

[[File:Rel.jpg]]

===Fix 3. The record retains after admin's approval and email reminder ===
- redesign the view and model to retain the request record after super-admin or admin approves the request.

- add an email tag in the corresponding view, so there will be an email send to email address offered by requester after approval/rejection.

=='''Mockup Screens'''==

1. First of all, a new user need to click 'REQUEST ACCOUNT' to create a new account.

[[File:cs.png]]

2. In the 'request new' page, in the original version, the user can only choose an institution from the drop-down menu. After our modification, the user can choose the 'Not List' choice in the drop-down menu and type in an institution when (s)he is not able to find his(her) institution in the drop-down menu.

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

加一张改了之后的图

3. After log in as an admin/super admin, the user can see a drop-down item under 'Administration->Show requests' to see all the new account requests.

[[File:Administrator.png]] ‎

4. After clicking the 'Show requests', the admin can see a list of new account requests and the emails are clickable to send email to the requesting user. Also, after the admin approves the request, the record should retain in the view and an email informing the requestor will be sent to the requestors' given email address.

[[File:Requests.png]]

5. After clicking the email address, the email editor will pop up and admin can converse requestors.

[[File:Emails.png]]

=='''Design Pattern'''==

==='''1. MVC'''===
The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).

==='''2. Dry Principle'''===
We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Test Plan'''==
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

File:Rel.jpg

2017-11-16T02:50:36Z

Gfan:

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:52:11Z

Gfan: /* Introduction */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database(only instructor and TA roles which is acceptable currently but not when more other institutions try to user Expertiza).

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Fix 1. Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they couldn't find one in the list, and save it into the table corresponding to the form it submits to.

- design a requested_user table to save all account requests

===Fix 2. Add new Page and Action===
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page

- create corresponding new controller with methods corresponding to actions like reject, approve and index.

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:49:21Z

Gfan: /* Fix 1. Add institution */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database.

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Fix 1. Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they couldn't find one in the list, and save it into the table corresponding to the form it submits to.

- design a requested_user table to save all account requests

===Fix 2. Add new Page and Action===
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page

- create corresponding new controller with methods corresponding to actions like reject, approve and index.

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:48:55Z

Gfan: /* Fix 2. Add new Page and Action */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database.

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Fix 1. Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they could find one in the list, and save it into the table corresponding to the form it submits to.

- design a requested_user table to save all account requests

===Fix 2. Add new Page and Action===
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page

- create corresponding new controller with methods corresponding to actions like reject, approve and index.

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:48:49Z

Gfan: /* Fix 1. Add institution */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database.

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Fix 1. Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they could find one in the list, and save it into the table corresponding to the form it submits to.

- design a requested_user table to save all account requests

===Fix 2. Add new Page and Action===
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page
- create corresponding new controller with methods corresponding to actions like reject, approve and index.

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:48:39Z

Gfan: /* Fix 1.Add institution */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database.

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Fix 1. Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they could find one in the list, and save it into the table corresponding to the form it submits to.
- design a requested_user table to save all account requests

===Fix 2. Add new Page and Action===
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page
- create corresponding new controller with methods corresponding to actions like reject, approve and index.

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:48:29Z

Gfan: /* Add new Page and Action= */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database.

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Fix 1.Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they could find one in the list, and save it into the table corresponding to the form it submits to.
- design a requested_user table to save all account requests

===Fix 2. Add new Page and Action===
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page
- create corresponding new controller with methods corresponding to actions like reject, approve and index.

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:48:13Z

Gfan: /* Add institution */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database.

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Fix 1.Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they could find one in the list, and save it into the table corresponding to the form it submits to.
- design a requested_user table to save all account requests

===Add new Page and Action====
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page
- create corresponding new controller with methods corresponding to actions like reject, approve and index.

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:47:44Z

Gfan: /* Problem Statement */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database.

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

===Add institution ===
- redesign the view shown in the previous section to include a field named institution in the current form to allow user to submit their institution if they could find one in the list, and save it into the table corresponding to the form it submits to.
- design a requested_user table to save all account requests

===Add new Page and Action====
- to create an new view that can show all pending account requests and include actions like approve and reject to allow instructors to process requests on the same page
- create corresponding new controller with methods corresponding to actions like reject, approve and index.

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:38:34Z

Gfan: /* Introduction */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience, and all users are added into the database through command line operations in the database.

In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:35:59Z

Gfan: /* Introduction */

==Introduction==

Expertiza is a educational website that allows school users to submit peer reviews on assignments. To register to use this website, one needs to be either a course TA or Instructor and send a request to expertiza administrator to get approved. The request function only serves TAs and Instructors, so students won't be able to register. A student account is created by instructors or TAs. The whole purpose of this approval process is because students have no point of using this website without enrolling to an instructors course first, so they shouldn't request accounts from expertiza but from their instructors and TAs.

A pending request page that displays all the requests should also be able to perform actions like approve or reject with an note.

However, currently, all of these are done manually, which means no pending request page currently exists, no simple approve or reject action, and no user experience.
In addition, we also want users be able to add their institution if it does not show under the list provided by us.

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:21:47Z

Gfan: /* Introduction */

==Introduction==

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:21:00Z

Gfan: /* Task Specifications and Plan */

==Introduction==

===Problem Statement===
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>

-The new institution should be saved as a new record into the ''institution table''<br\>

-New account request should be saved to ''requested_users table'' with correct institution id.<br\>

'''2.superadmin, admin should be able to approve/decline requests'''<br\>

-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>

-make clickable user email address so a conversation is possible<br\>

-an email should be sent when a request is approved or declined<br\>

-all record should be kept on the page even it has been handled<br\>

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:20:34Z

Gfan: /* Introduction */

==Introduction==

===Problem Statement===
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>
-The new institution should be saved as a new record into the ''institution table''<br\>
-New account request should be saved to ''requested_users table'' with correct institution id.<br\>
'''2.superadmin, admin should be able to approve/decline requests'''<br\>
-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>
-make clickable user email address so a conversation is possible<br\>
-an email should be sent when a request is approved or declined<br\>
-all record should be kept on the page even it has been handled<br\>

=Test Plan=
Both manual and RSpec test will be performed on the following items.

1. a proper error message for improper information filled in, such as wrong email address format or existing account.

2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.

3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked

4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.

5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T02:19:29Z

Gfan: /* Introduction */

==Introduction==

===Problem Statement===
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications and Plan===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>
-The new institution should be saved as a new record into the ''institution table''<br\>
-New account request should be saved to ''requested_users table'' with correct institution id.<br\>
'''2.superadmin, admin should be able to approve/decline requests'''<br\>
-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>
-make clickable user email address so a conversation is possible<br\>
-an email should be sent when a request is approved or declined<br\>
-all record should be kept on the page even it has been handled<br\>

=Test Plan=
Both manual and RSpec test will be performed on the following items.
1. a proper error message for improper information filled in, such as wrong email address format or existing account.
2. When a pending account gets approved or rejected, an email will be sent to the submitted email address.
3. A new item "show" should be added under administration and direct instructor to pending requests page when clicked
4. pending requests will have an email column that is clickable which allows instructor to send emails to applicants before a decision is made.
5. when a request is processed, its record is still kept with the status of processed.

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T01:59:05Z

Gfan: /* Problem Statement */

==Introduction==

===Problem Statement===
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever requests for a new accounts can be approved by instructor clicking a button, and secondly, optimize the functionality to improve user experience.

[[File:cs.png]]

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

===Task Specifications===
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't find one. <br\>
-The new institution should be saved as a new record into the ''institution table''<br\>
-New account request should be saved to ''requested_users table'' with correct institution id.<br\>
'''2.superadmin, admin should be able to approve/decline requests'''<br\>
-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>
-make clickable user email address so a conversation is possible<br\>
-an email should be sent when a request is approved or declined<br\>
-all record should be kept on the page even it has been handled<br\>

== Team Informantion ==
Guiyang Fan(gfan@ncsu.edu)

Haoxu Ren(hren3@ncsu.edu)

Dongyu Wang(dwang32@ncsu.edu)

Yichi Zhang

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-10T01:54:54Z

Gfan: /* Problem Statement */

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-07T03:29:52Z

Gfan: /* Task Specifications */

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-07T03:22:40Z

Gfan:

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-07T03:18:55Z

Gfan: /* Problem Statement */

===Introduction===

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever request for a new accounts can be approved by instructor clicking an button and optimize the functionality to improve user experience.

[[File:Screen_Shot_2017-11-06_at_10.17.01_PM.png]]

==Task Specifications==
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't found one. <br\>
-The new institution should be saved as a new record into the ''institution table''<br\>
-New account request should be saved to ''requested_users table'' with correct institution id.<br\>
'''2.superadmin, admin should be able to approve/decline requests'''<br\>
-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>
-make clickable user email address so a conversation is possible<br\>
-an email should be sent when a request is approved or declined<br\>
-all record should be kept on the page even it has been handled<br\>

File:Screen Shot 2017-11-06 at 10.17.01 PM.png

2017-11-07T03:18:27Z

Gfan:

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-07T03:16:29Z

Gfan: /* Task Specifications */

===Introduction===

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever request for a new accounts can be approved by instructor clicking an button and optimize the functionality to improve user experience.

==Task Specifications==
'''1. Add institution''' <br\>
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't found one. <br\>
-The new institution should be saved as a new record into the ''institution table''<br\>
-New account request should be saved to ''requested_users table'' with correct institution id.<br\>
'''2.superadmin, admin should be able to approve/decline requests'''<br\>
-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled<br\>
-enable the "approve" function for admin and superadmin<br\>
-make clickable user email address so a conversation is possible<br\>
-an email should be sent when a request is approved or declined<br\>
-all record should be kept on the page even it has been handled<br\>

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-07T03:15:38Z

Gfan: /* introduction */

===Introduction===

==Problem Statement==
Request account function is currently not working properly. A new user who tries to request an expertiza account can do so, but the instructor can see yet has no power to approve any request. The approval process is currently done manually, which is cumbersome.
Our mission is to fix the request account functionality so that whoever request for a new accounts can be approved by instructor clicking an button and optimize the functionality to improve user experience.

==Task Specifications==
'''1. Add institution'''
-A registering user should be able to choose their institution from a drop-down menu, but they should also be able to add an institution if they couldn't found one.
-The new institution should be saved as a new record into the ''institution table''
-New account request should be saved to ''requested_users table'' with correct institution id.
'''2.superadmin, admin should be able to approve/decline requests'''
-add a new drop-down item under “Administration > Show…” so requests can be visually displayed and handled
-enable the "approve" function for admin and superadmin
-make clickable user email address so a conversation is possible
-an email should be sent when a request is approved or declined
-all record should be kept on the page even it has been handled

CSC/ECE 517 Fall 2017

2017-11-07T02:59:01Z

Gfan:

'''Design Project Documentation'''
*[[CSC/ECE 517 Fall 2017/E17A2 Lightweight Badging System]]
*[[CSC/ECE 517 Fall 2017/E17A8. Use a profiler to identify the problems / pages that take some time to load & fix them]]
*[[CSC/ECE 517 Fall 2017/E1793. Help students find teams to join]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment]]
*[[CSC/ECE 517 Fall 2017/E17A0 Team-based reviewing]]
*[[CSC/ECE 517 Fall 2017/E1793. Help students find teams to join_Team1964]]
*[[CSC/ECE 517 Fall 2017/E1791. Track the time that students look at the other submissions - logging improvement]]
*[[CSC/ECE 517 Fall 2017/E1799 Improve self-review Link peer review & self-review to derive grades]]
*[[CSC/ECE_517_Fall_2017/E1797_Timestamps_for_students_submissions]]
*[[CSC/ECE_517_Fall_2017/E17A1|CSC/ECE_517_Fall_2017/E17A1 - Let experts as well as students do reviews]]
*[[CSC/ECE 517 Fall 2017/M1754_Mutation_Testing]]
*[[CSC/ECE 517 Fall 2017/E1794. Student-generated questions added to rubric]]
*[[CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably]]

'''Writing Assignment 2'''
*[[CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team]]
*[[CSC/ECE_517_Fall_2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb]]
*[[CSC/ECE_517_Fall_2017/E1774 Metareview fixes and improvements.rb]]
*[[CSC/ECE_517_Fall_2017/E1788 OSS project Maroon Heatmap fixes]]
*[[CSC/ECE 517 Fall 2017/E1781 Topic Management]]
*[[CSC/ECE_517_Fall_2017/E1745_Refactor_response_controller.rb]]
*[[CSC/ECE_517_Fall_2017/E1752 Refactor assignments controller]]
*[[CSC/ECE_517_Fall_2017/E1776_Enhance_Imports]]
*[[CSC/ECE_517_Fall_2017/E1756 TLD Refactor response.rb]]
*[[CSC/ECE_517_Fall_2017/E1772_Refactor reputation_web_service_controller.rb]]
*[[CSC/ECE_517_Fall_2017/M1754_Mutation Testing on Servo]]
*[[CSC/ECE_517_Fall_2017/E1753 OSS project bidding tests]]
*[[CSC/ECE_517_Fall_2017/E1766_Test team functionality]]
*[[CSC/ECE 517 Fall 2017/E1767 Improve imports]]
*[[CSC/ECE_517_Fall_2017/E1786_OSS project Juniper Bookmark Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1787_OSS project Bronze Score calculations]]
*[[CSC/ECE_517_Fall_2017/E1763 Fix Staggered-Deadline Assignments]]
*[[CSC/ECE 517 Fall 2017/E1757 Introduce a Student View for instructors]]
*[[CSC/ECE 517 Fall 2017/E1769_Refactor assignment_form.rb]]
*[[CSC/ECE 517 Fall 2017/E1754_Feature_test_of_rubric_advice]]
*[[CSC/ECE 517 Fall 2017/E1782 OSS Project Red Assignment Directories]]
*[[CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list]]
*[[CSC/ECE 517 Fall 2017/E1761 Test First Development Refactor assignment.rb]]
*[[CSC/ECE_517_Fall_2017/E1780_OSS_Project_Teal_Email_Notification_Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1762 Test various kinds of response-map hierarchies]]
*[[CSC/ECE_517_Fall_2017/E1759 ]]
*[[CSC/ECE_517_Fall_2017/E1749_Test First Development Refactor questionnaire_controller.rb]]
*[[CSC/ECE 517 Fall 2017/E1777 Coherent specification of review requirements.rb]]
*[[CSC/ECE 517 Fall 2017/E1771_Refactor_team.rb]]

CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably

2017-11-07T02:58:01Z

Gfan: Created page with "===introduction==="

===introduction===

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-11-01T21:02:28Z

Gfan: /* Running the project Locally */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
====Problem Description:====
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

====Solution====
After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
==== Problem Description ====
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''

====Solution====
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===
====Problem====
Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

==== Solution ====
The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise an error. This error
is not necessarily a bug in the code, but rather a protection masochism. As said
before, it is a matter of choice to get rid of this error or not. Raising an exception
is the simplest way to stop the app when some behavior is not wanted.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

====Problem====
The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

====Solution====
Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary. Also, the solution is a matter of choice. The
simplest way to stop users to submit or post any new data into the data base is
to raise an exception which will stop the app. So we are merely making a suggestion
here.

== Test Plan ==
===Running the project Locally ===
First, follow the instructions given on [https://github.com/expertiza/expertiza Expertiza]. It's your choice to use virtual machine or set up your own environment.
Clone the repository which is also the submitted [https://github.com/expertiza/expertiza/pull/1031 Pull request].
In this project, we will mainly use airbrake to do testing.

===Setting up Airbrake===
Expertiza has already implemented the airbrake gem. You need an airbrake account to begin test.
In''' /config/initializers/airbrake.rb''' , change the following line

c.ignore_environments = %w(development test) => c.ignore_environments = %w(test)
c.project_id = 'your airbrake account id'
c.project_key = 'your airbrake project_key'

You will get your project id after you registered an airbrake account and created a new project on it. It is in your account profile.
where project key will be at the same location with your project id.

Once you have the right key and id pair, you can start testing the run-time exceptions.
==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]
#[https://airbrake.io Airbrake ]
#[https://github.com/expertiza/expertiza/pull/1031 Pull request]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-11-01T21:02:08Z

Gfan: /* Reference */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
====Problem Description:====
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

====Solution====
After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
==== Problem Description ====
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''

====Solution====
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===
====Problem====
Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

==== Solution ====
The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise an error. This error
is not necessarily a bug in the code, but rather a protection masochism. As said
before, it is a matter of choice to get rid of this error or not. Raising an exception
is the simplest way to stop the app when some behavior is not wanted.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

====Problem====
The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

====Solution====
Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary. Also, the solution is a matter of choice. The
simplest way to stop users to submit or post any new data into the data base is
to raise an exception which will stop the app. So we are merely making a suggestion
here.

== Test Plan ==
===Running the project Locally ===
First, follow the instructions given on [https://github.com/expertiza/expertiza Expertiza]. It's your choice to use virtual machine or set up your own environment.
Clone the repository which is also the submitted[https://github.com/expertiza/expertiza/pull/1031 Pull request].
In this project, we will mainly use airbrake to do testing.

===Setting up Airbrake===
Expertiza has already implemented the airbrake gem. You need an airbrake account to begin test.
In''' /config/initializers/airbrake.rb''' , change the following line

c.ignore_environments = %w(development test) => c.ignore_environments = %w(test)
c.project_id = 'your airbrake account id'
c.project_key = 'your airbrake project_key'

You will get your project id after you registered an airbrake account and created a new project on it. It is in your account profile.
where project key will be at the same location with your project id.

Once you have the right key and id pair, you can start testing the run-time exceptions.
==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]
#[https://airbrake.io Airbrake ]
#[https://github.com/expertiza/expertiza/pull/1031 Pull request]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-11-01T20:49:59Z

Gfan: /* Exception 4. RuntimeError: This topic has too many reviews; please select another one */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
====Problem Description:====
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

====Solution====
After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
==== Problem Description ====
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''

====Solution====
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===
====Problem====
Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

==== Solution ====
The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise an error. This error
is not necessarily a bug in the code, but rather a protection masochism. As said
before, it is a matter of choice to get rid of this error or not. Raising an exception
is the simplest way to stop the app when some behavior is not wanted.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

====Problem====
The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

====Solution====
Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary. Also, the solution is a matter of choice. The
simplest way to stop users to submit or post any new data into the data base is
to raise an exception which will stop the app. So we are merely making a suggestion
here.

==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]
#[https://airbrake.io Airbrake ]
#[https://github.com/expertiza/expertiza/pull/1031 Pull request]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-11-01T20:46:00Z

Gfan: /* Exception 3. ActionController::InvalidAuthenticityToken */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
====Problem Description:====
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

====Solution====
After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
==== Problem Description ====
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''

====Solution====
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===
====Problem====
Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

==== Solution ====
The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise an error. This error
is not necessarily a bug in the code, but rather a protection masochism. As said
before, it is a matter of choice to get rid of this error or not. Raising an exception
is the simplest way to stop the app when some behavior is not wanted.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary.

==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]
#[https://airbrake.io Airbrake ]
#[https://github.com/expertiza/expertiza/pull/1031 Pull request]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-11-01T20:43:13Z

Gfan: /* Exception 2. AbstractController::ActionNotFound */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
====Problem Description:====
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

====Solution====
After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
==== Problem Description ====
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''

====Solution====
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===

Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise error.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary.

==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]
#[https://airbrake.io Airbrake ]
#[https://github.com/expertiza/expertiza/pull/1031 Pull request]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-11-01T20:02:20Z

Gfan: /* Exception 1. NoMethodError: undefined method 'call' for nil:NilClass */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
====Problem Description:====
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

====Solution====
After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===

Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise error.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary.

==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]
#[https://airbrake.io Airbrake ]
#[https://github.com/expertiza/expertiza/pull/1031 Pull request]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-28T20:31:39Z

Gfan: /* Reference */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===

Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise error.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary.

==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]
#[https://airbrake.io Airbrake ]
#[https://github.com/expertiza/expertiza/pull/1031 Pull request]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-28T20:28:51Z

Gfan: /* Reference */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===

Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise error.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary.

==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]
#[https://airbrake.io Airbrake ]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-28T20:28:10Z

Gfan: /* Reference */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===

Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise error.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary.

==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-28T20:28:01Z

Gfan: /* Exception 4. RuntimeError: This topic has too many reviews; please select another one */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===

Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise error.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary.

==Reference ==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/Tylerfan/expertiza GitHub Project Repository Fork]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[https://github.com/phusion/passenger/issues/1730 Undefined method ' call' fix]

#Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-27T18:31:51Z

Gfan: /* Airbrake Run-time Exceptions and Fixes */

==Introduction==
===Background===
[http://expertiza.ncsu.edu/ Expertiza]is a open-source ruby-on-rails project on [https://github.com/expertiza/expertiza github]. It constructs a peer-review system by enabling interactions among users and instructors. Students can sign up for a class, view assignments, submit assignments and give peer reviews using expertiza. Instructors can publish assignments, surveys, and reviews, view statistical results and make announcements. The website is created and currently maintained mainly by the students and faculties from NCSU.

===Motivation===
[https://airbrake.io/ Airbrake] is a online debugging tool for rails projects that is currently incorporated in Expertiza. Thus, Expertiza production errors at run time are tracked and reported statistically to Airbrake for reviewing and debugging.
Our goal for this OSS project is to fix [https://upload.wikimedia.org/wikipedia/commons/9/9c/10errors.png the top 10 run time exceptions] ranked by occurrences reported to Airbrake. You can check the 10 most ranked exceptions by click on the previous hyperlink.

==Airbrake Run-time Exceptions and Fixes==
By investigating into the top 10 errors from airbrake, we can divide them into different categories by the root of their causes. 

'''1. NoMethodError: undefined method for nil:NilClass (4 out of 10) '''
'''2. AbstractController::ActionNotFound (4 out of 10) '''
'''3. ActionController::InvalidAuthenticityToken (1 out of 10) '''
'''4. ActiveRecord::RecordNotFound: Couldn't find Participant without an ID (1 out of 10) '''

As we have discovered, the same or similar fix can be used to fix all exceptions in the same different category, which is how we categorized these exceptions initially.

===Files Modified===

/config/routes.rb

===Exception 1. NoMethodError: undefined method 'call' for nil:NilClass ===
From the Airbrake issue page, we could find out that the problem is actually caused by a gem called passenger. 
Although we couldn't find any sign of passenger gem in the recent master branch, but there is a clear sign we
found during our review of other errors that some developers had used passenger. 
The gem might be under the production path `/home/rails/.rvm/gems/ruby-2.1.5/gems/passenger-5.0.16/'
So the solution might be just to remove the gem passenger from production environment. 
For more information, please check [https://github.com/phusion/passenger/issues/1730 here]

''' NoMethodError: undefined method 'role' for nil:NilClass is one similar error that occurs during run-time '''

[[File:Error1.png|thumb|left|600px|pic1]][[File:Error11.png|600px|pic2]]
 

After investigating this error by going to the error causing url,as shown in pic1, given by airbrake under development environment,
http://localhost:3000/response/view?id=91251, the error is verified does not appear again. The last time this error occurred was 5
months ago.
Note, the link is only accessible to super admin account. As you may have noticed, the picture on the right shows the passenger gem
is called and traced, which we couldn't find such a gem installed in the current gemfile.

''' NoMethodError: undefined method 'uniq' for nil:NilClass is one similar error that occurs during run-time '''

Similarly, by going to the error cause url(https://expertiza.ncsu.edu/sign_up_sheet/set_priority) again under development environment, there is no such page exist.

===Exception 2. AbstractController::ActionNotFound===
In most of the cases, the error is caused by an abusive use of RESTful routing provided in rails.
In the middle of somewhere of the app, an index or show action is considered "called" when the redirect url matches such an action which is undefined in the controller.

By thoroughly investigating the controller in trouble and its routes, we came up with a solution that to either reroute the url to an effective url or abort the RESTful route.

For one example, in '''app/controllers/auth_controller''', we found no show/index action defined or needed, but in '''/config/routes.rb''', we have the following:

'''=begin'''
resources :auth , :except=>[:show,:index,:create,:destroy,:update,:edit,:new] do
collection do
post :login
post :logout
end
end
'''=end'''
By using resources:auth, rails actually creates index and show actions by default. Somewhere in the app, a redirect is made available to the user to an index or show view page which does not exist. Thus, in order to save the trouble finding the redirect, we simply redirect anything points to those invalid pages to a valid page, which is the root.The modified code is below:

'''post '/auth/login' ,to:"auth#login"'''
'''post '/auth/logout' ,to:"auth#logout"'''
'''get '/auth/*path', to: redirect('/')'''

Following the same principle, we have modified '''/config/routes.rb''' for routes that have caused the most exceptions due to exposure of invalid url redirection to the user.
resources :response''', :except =>[:index]'''do
collection do
get :new_feedback
get :view
post :delete
get :remove_hyperlink
get :saving
get :redirection
get :show_calibration_results_for_student
post :custom_create
get :pending_surveys
'''get '/*path', to: redirect('/response/pending_surveys')'''
end
end

There are 10 similar errors in Top 40 errors involved 5 controllers, which are ResponseController, AuthController, AdminController, ImpersonateController and PublishingController. If a controller mentioned above never uses a method declared by resources, we delete the relevant resources and add the routes of method separately, otherwise we use except expression to exclude methods we don't use.

===Exception 3. ActionController::InvalidAuthenticityToken===

Error Message: You submitted a form with an outdated or missing authenticity token. Try reloading the page you just submitted and submit the form again.

The error was raised in '''config/initializers/request_forgery_protection_mod.rb'''

And the error actually happened in '''response#create'''

The background of this problem is that The authenticity token is a random value
generated in your view to prove a request is submitted from a form on your site,
not somewhere else. This protects against CSRF attacks.

The expertiza problem could be the user session expired and the solution can be
delete the code in the '''config/initializers/request_forgery_protection_mod.rb''',
and redirect or just refresh the page, which would not raise error.

===Exception 4. RuntimeError: This topic has too many reviews; please select another one===

The error was raised in '''app/models/review_assignment.rb:171'''

And the error actually happened in '''review_mapping#assign_reviewer_dynamically'''

The intuition is that the review to a topic should be assigned dynamically and
"too many reviews" problem should be handled by action '''revew_mapping#assign_reviewer_dynamically'''.
So we could add the below condition in the above controller action to handle this problem.

Instead of raising an error, we could simply handle this problem, which can make
"flash danger message" unnecessary.

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:33:06Z

Gfan: /* Exception 2. AbstractController::ActionNotFound */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:25:54Z

Gfan: /* Exception 2. AbstractController::ActionNotFound */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:25:16Z

Gfan: /* Exception 2. AbstractController::ActionNotFound */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:15:08Z

Gfan: /* Airbrake Run-time Exceptions and Fixes */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:05:27Z

Gfan: /* Exception 1. NoMethodError: undefined method 'call' for nil:NilClass */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:03:35Z

Gfan: /* Exception 1. NoMethodError: undefined method 'call' for nil:NilClass */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:02:51Z

Gfan: /* Exception 1. NoMethodError: undefined method 'call' for nil:NilClass */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:01:55Z

Gfan: /* Exception 1. NoMethodError: undefined method 'call' for nil:NilClass */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T02:00:12Z

Gfan: /* Exception 1. NoMethodError: undefined method 'call' for nil:NilClass */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T01:59:25Z

Gfan: /* Exception 1. NoMethodError: undefined method 'call' for nil:NilClass */

CSC/ECE 517 Fall 2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb

2017-10-26T01:54:17Z

Gfan: /* Airbrake Run-time Exceptions and Fixes */

File:Error11.png

2017-10-26T01:44:50Z

Gfan: uploaded a new version of "File:Error11.png"

File:Error11.png

2017-10-26T01:43:07Z

Gfan: