Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Spring 2023 - E2330. Reimplement Invitation Controller

2023-04-24T23:34:14Z

Dshah6: /* Controller Tests */

==Project Overview==

===Expertiza Background===

Expertiza is an online platform designed to facilitate peer review and submission of various types of academic work, including articles, codes, and websites. The application allows instructors to add assignments, grade them, and assign students to teams based on their topic preferences. The platform also enables students to provide feedback on each other's work through peer reviews, which can be helpful in improving the quality of their projects. Expertiza is backed by the National Science Foundation.

===Problem Statement===

The Invitation model and InvitationsController are responsible for managing invitations between users in a team-based assignment system. The system allows a student to invite another student to their team by creating a new Invitation record, which is associated with the inviting and invited students and the assignment they are working on. The invited user can accept, decline, or cancel the invitation, which updates the corresponding Invitation record and may trigger actions such as adding or removing users from teams. The InvitationsController includes methods for creating, accepting, declining, and canceling invitations, as well as checking the status of the user and team before sending or accepting invitations. The system also sends email notifications to invited users when a new invitation is sent. Overall, the Invitation model and InvitationsController are crucial for managing team membership and collaboration in a team-based assignment system. Instructor’s note: There is already a project to merge this controller with the join_team_requests_controller. You should start with the code they have written.

==Objectives==
1. Write RESTful endpoints of create, show, delete to invitations and approving new invitations, listing pending invitations, creating new invitations, and notifying students about new team formation invite.

2. Develop and implement methods in the InvitationsController that enable the following functionality:Create invitations, Accept invitations, Decline invitations, Cancel invitations, and Check user and team status before sending or accepting invitations.

3. To implement a user-invitation system that allows invited users to accept, decline, or cancel invitations, which will update the corresponding Invitation record and trigger actions such as adding or removing users from teams.

4. Implement an email notification system in the user-invitation system, which sends email notifications to invited users when a new invitation is sent.

5. Return proper status codes and proper validation for RESTful endpoints.

6. Write models and controllers such that they use modern approaches to writing Ruby code, including utilizing language features and adhering to best practices for object-oriented design.

7. Write proper Rspec tests for all APIs, models, controllers.

== Development Strategy ==

We have tried to follow a Test Driven Development approach to implement both the Invitation model and the Invitation Controller.
Firstly a failing test case was written and then the code was added such that the test which was failing will pass now.

Also, we have tried to follow the rails philosophy of "Fat models" We have tried to move as much business logic from the controller to the model as possible. This will also help keep the controller code clean and encourage code reusability.

==Project Design and Implementation==

===Use Case Diagram ===
[[File:Usecasediagram1.png|800px]]

===Class Diagram ===
[[File:dshah6_UML_Diagram.png|900px]]

===Functionality===
In this project, we aim to add the following functions:

1. Enable users to create a new team invitation.

2. Enable users to Accept or Reject invitations.

3. Enable users to Retract invitations.

4. Enable users to send email notifications to invited users.

5. Ensure that data is validated properly in all the above APIs.

6. Test cases for all the above.

==Screen Shots==
===1. Send an invite ===
[[File:Dshah6_send_invite.png|900px]]

[[File:Dshah6_send_invite_2.png|900px]]

[[File:Dshah6_send_invite_3.png|900px]]

===2. Accept an invite===
[[File:Dshah6_accept_1.png|900px]]

[[File:Dshah6_accept_2.png|900px]]

[[File:Dshah6_accept_3.png|900px]]

===3. Reject invite===
[[File:Dshah6_decline_1.png|900px]]

[[File:Dshah6_decline_2.png|900px]]

===4. Retract invite===
[[File:Dshah6_retract_1.png|900px]]

===5. We retracted invitation of angel and malka and added ofelia===

[[File:Dshah6_retract_2.png|900px]]

= Project Design =

===Model===
The file invitation.rb defines the Invitation model which is a subclass of ApplicationRecord. The Invitation model has three foreign keys. to_user represents the user to whom the inviations is sent. from_user represents the user who is creating the invitation. assignment represents which assignment the invitation belongs to. reply_status represents whether the invitation is accepted, rejected or waiting. The default reply_status is waiting 'W'. There are also multiple validations defined for the various fields in this model. One of the important validation is to_from_cant_be_same validation, which prevents users from creating invitations to themselves. Moreover there are multiple helper methods defined for Invitations. These methods help keep the controller code short and clean. We are following the rails philosophy of "Fat Models". For the scope of this project the helper methods are kept simple, however once the project advances these helper methods need to be updated.

filename: invitation.rb
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/invitation.rb GitHub file Link to invitation.rb]

<pre>
class Invitation < ApplicationRecord
after_initialize :set_defaults

ACCEPT_STATUS = 'A'.freeze
REJECT_STATUS = 'R'.freeze
WAITING_STATUS = 'W'.freeze

belongs_to :to_user, class_name: 'User', foreign_key: 'to_id', inverse_of: false
belongs_to :from_user, class_name: 'User', foreign_key: 'from_id', inverse_of: false
belongs_to :assignment, class_name: 'Assignment', foreign_key: 'assignment_id'
validates :reply_status, presence: true, length: { maximum: 1 }
validates_inclusion_of :reply_status, in: [ACCEPT_STATUS, REJECT_STATUS, WAITING_STATUS], allow_nil: false
validates :assignment_id, uniqueness: {
scope: %i[from_id to_id reply_status],
message: 'You cannot have duplicate invitations'
}
validate :to_from_cant_be_same

# validate if the to_id and from_id are same
def to_from_cant_be_same
return unless from_id == to_id

errors.add(:from_id, 'to and from users should be different')
end

# Return a new invitation
# params = :assignment_id, :to_id, :from_id, :reply_status
def self.invitation_factory(params)
Invitation.new(params)
end

# check if the user is invited
def self.invited?(from_id, to_id, assignment_id)
@invitations_count = Invitation.where(to_id:)
.where(from_id:)
.where(assignment_id:)
.where(reply_status: WAITING_STATUS)
.count
@invitations_count.positive?
end

# send invite email
def send_invite_email
InvitationSentMailer.with(invitation: self)
.send_invitation_email
.deliver_later
end

# After a users accepts an invite, the teams_users table needs to be updated.
# NOTE: Depends on TeamUser model, which is not implemented yet.
def update_users_topic_after_invite_accept(_inviter_user_id, _invited_user_id, _assignment_id); end

# This method handles all that needs to be done upon a user accepting an invitation.
# Expected functionality: First the users previous team is deleted if they were the only member of that
# team and topics that the old team signed up for will be deleted.
# Then invites the user that accepted the invite sent will be removed.
# Lastly the users team entry will be added to the TeamsUser table and their assigned topic is updated.
# NOTE: For now this method simply updates the invitation's reply_status.
def accept_invitation(_logged_in_user)
update(reply_status: ACCEPT_STATUS)
end

# This method handles all that needs to be done upon an user declining an invitation.
def decline_invitation(_logged_in_user)
update(reply_status: REJECT_STATUS)
end

# This method handles all that need to be done upon an invitation retraction.
def retract_invitation(_logged_in_user)
destroy
end

# This will override the default as_json method in the ApplicationRecord class and specify
def as_json(options = {})
super(options.merge({
only: %i[id reply_status created_at updated_at],
include: {
assignment: { only: %i[id name] },
from_user: { only: %i[id name fullname email] },
to_user: { only: %i[id name fullname email] }
}
})).tap do |hash|
end
end

def set_defaults
self.reply_status ||= WAITING_STATUS
end
end
</pre>

===Helper Methods in Invitation model.===

====to_from_cant_be_same:====
Validate if the to_id and from_id are same i.e a users cannot send invitations to themselves.

====self.invitation_factory(params):====
This helper method will help in creating new Invitation with the given parameters. Custom parameters can be passed to create specific Invitation.

====self.invited?(from_id, to_id, assignment_id):====
Check if the user is invited given the from_id, to_id, and assignment_id. This is a class method to make it more generic and can be used by other classes.

====send_invite_email:====
This method uses the InvitaionSentMailer to send invitation emails to the invited user.

====update_users_topic_after_invite_accept(inviter_user_id, invited_user_id, assignment_id) [Future work]:====
After a users accepts an invite, the teams_users table needs to be updated.
NOTE: Depends on TeamUser model, which is not implemented yet.

====accept_invitation:====
This method handles all that needs to be done upon a user accepting an invitation.

====decline_invitation:====
This method handles all that needs to be done upon an user decline an invitation.

====retract_invitation:====
This method handles all that need to be done upon an invitation retraction.

====as_json:====
This will override the default as_json method in the ApplicationRecord class and specify

====set_defaults:====
This will be used to set default parameters when creating new Invitation.

Changes in models/user.rb
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/user.rb GitHub Link to user.rb file]
 
A user can have many invitations therefore we added a has_many relationship in the user model. On the other hand in the invitation model we added belongs_to relationship with the user model.

<pre>
# added the following relations in the user.rb file.
has_many :invitations
</pre>
Changes in models/assignment.rb
 

[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/assignment.rb GitHub Link to assignment.rb file]
 
An assignment can have many invitations therefore we added a has_many relationship in the assignment model. On the other hand in the invitation model we added belongs_to relationship with the assignment model.

<pre>
# added the following relations in the assignment.rb file.
class Assignment < ApplicationRecord
has_many :invitations
end
</pre>

Schema
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/db/schema.rb GitHub Link to scheme.rb file]
 
The invitation schema has three foreign keys. The foreign keys are "assignment_id", "from_id", "to_id". from_id and to_id are foreign keys to user model.

<pre>
create_table "invitations", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
t.integer "assignment_id"
t.integer "from_id"
t.integer "to_id"
t.string "reply_status", limit: 1
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["assignment_id"], name: "fk_invitation_assignments"
t.index ["from_id"], name: "fk_invitationfrom_users"
t.index ["to_id"], name: "fk_invitationto_users"
end
</pre>

===Controllers===
We create a new controller at app/controllers/invitation_controller.rb with following methods:
[Implementation of the invitation controller[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/controllers/api/v1/invitations_controller.rb]]
===REST Route methods===
=====create:=====
This will create a new invitation record.
=====index:=====
This will give a list of all the invitations
=====show:=====
This will be used to show a particular invitation with given invitation_id.
=====update:=====
This will be used to update the status of the current invitation. Either accepted or rejected
=====destroy:=====
This will be used to delete the invitation that is already sent to another participant using particular invite_id.
=====invitations_for_user_assignment:=====
This will be used to get all the invitations for a particular assignment for a particular student.

=== Helper methods ===
=====check_team_before_accept [Future work]:=====
This method will check if the team meets the joining requirements when an invitation is being accepted for example check if the invite's team is still existing, and have available slot to add the invitee.

=====check_team_before_invitation [Future work]:=====
This method will check if the team meets the joining requirement before sending an invite.

=====check_participant_before_invitation [Future work]:=====
This method will check if the invited user is a participant in the assignment.

=====check_user_before_invitation [Future work]:=====
This method will check if the invited user exists. Additionally, this method will also check if the sender himself is participating in the given assignment before they can send an invitation.

==End point description==

===create===
<pre>
Description: This route will create a new invitation record with default reply_status: w. w stands for waiting.
REST VERB: POST
Path: /invitations/

Response:

Success:
Status code: 200

```
{
{
"id": 11,
"reply_status": "W",
"created_at": "2023-04-20T21:33:29.580Z",
"updated_at": "2023-04-20T21:33:29.580Z",
"assignment": {
"id": 2,
"name": "oodd program3"
},
"from_user": {
"id": 2,
"name": "jhon",
"fullname": "jhon carmen",
"email": "example1@gmail.com"
},
"to_user": {
"id": 1,
"name": "katy",
"fullname": "katy shah",
"email": "example2@gmail.com"
}
}

```

Failure:
Status code: 422

```
{
error: @invitation.errors
}

```

</pre>

===index===

<pre>
Description: Get a list of all the invitations in the database.
REST VERB: GET
Path: /invitations/
Request: NA

Success
Status Code: 200
```
[
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
},
{
"id": 2,
"reply_status": "W",
"created_at": "2023-04-18T15:52:44.543Z",
"updated_at": "2023-04-18T15:52:44.543Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
},
"to_user": {
"id": 3,
"name": "rebecca",
"fullname": "rebecca fiat",
"email": "reb@gmail.com"
}
}
]

```

</pre>

===show===
<pre>
Description: Get a particular invite with the invite_id.
REST VERB: GET
Path: /invitations/<invite_id>
Request: NA
Response:

success
status code: 200
```
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}

```

Error
Status code: 404

```
{
"error": "Couldn't find Invitation with 'id'=1021321"
}
```
</pre>

===update===
<pre>
Description: This route will modify the status of the invitation to be accepted or declined
REST VERB: PATCH
Path: /invitations/<invite_id>/
Request:
```
{
"reply_status": ["A"/"R"],
}

```
Response:

Success
Status Code: 200

```
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}
```

Error
Status Code: 404/422

```
{
"error": @invitation.errors
}
```

</pre>

===destroy===
<pre>
Description: Delete the invitation
REST VERB: DELETE
Path: /invitations/<invite_id>
Request: NA
Response:

Success
Status code: 204 :no_content
Response: NA

Error
Status Code: 404
Response
```

{
"error": @invitation.errors
}

```

</pre>

===invitations_for_user_assignment===
<pre>
Description: Get the invitations for the user with id: user_id for the given assignment with id: assignment_id.
REST VERB: GET
Path: /invitations/<user_id>/<assingment_id>
Request: NA
Response:

Success
Status Code: 200 :ok

```
[
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
},
{
"id": 2,
"reply_status": "W",
"created_at": "2023-04-18T15:52:44.543Z",
"updated_at": "2023-04-18T15:52:44.543Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}
]

```

Error
Status Code: 404 :not_found

```
{
"error": @invitations.errors
}

```
</pre>

== End point summary ==
{| class="wikitable" style="margin-left:40px"
|-
! Sr No !! Method !! Endpoint !! Request Body !! Description
|-
| 1 || create || POST /invitations/||{ "assignment_id": INT, "from_id": INT, "to_id": INT, "reply_status": CHAR } ||Create a new invitation record with default reply_status: w, w stands for waiting.
|-
| 2 || index || GET /invitations/ || ||Get a list of all the invitations.
|-
| 3 || show || GET /invitations/<assignment_id> || || Get a particular invite with the invite_id.
|-
| 4 || update || PATCH /invitations/<invite_id>/ || { "reply_status":["A"/"R"] } || Modify the status of the invitation to be accepted or declined.
|-
| 5 || destroy || DELETE /invitations/<invite_id> || || Delete the invitation.
|-
| 6 || invitations_for_user_assignment || GET /invitations/<assignment_id> || || Get the invitations for the user with id: user_id for the given assignment with id: assignment_id

|}

= Testing Plan =

We utilized RSpec as the testing framework for our system. We have used factoryBot along with Faker to create model objects for testing. The development process has followed Test Driven Development. The tests for the model and the controller are written in a comprehensive way.

====Controller Tests====

To run the controller tests:

1. git clone

2. cd reimplementation-back-end/

3. bundle install

4. bundle exec rspec spec/requests/api/v1/invitation_controller_spec.rb

File: [https://github.com/rohitgeddam/reimplementation-back-end/blob/main/spec/requests/api/v1/invitation_controller_spec.rb invitation_controller_spec.rb]

{| class="wikitable" style="margin-left:30px"
|-
! Sr No !! Test !! Description
|-
| 1 || Test to list all Invitations || This test verifies if the system can successfully retrieve a list of all invitations available in the system.
|-
| 2 || Test to create an invitation with valid parameters || This test verifies if the system can successfully create an invitation with valid parameters such as 'to' user, 'from' user, assignment, and reply status.
|-
| 3 || Test to create an invitation with invalid 'to' user parameters' || This test verifies if the system can handle and reject an invitation creation request with invalid 'to' user parameters.
|-
| 4 || Test to create an invitation with invalid 'from' user parameters || This test verifies if the system can handle and reject an invitation creation request with invalid 'from' user parameters.
|-
| 5 || Test to create an invitation with invalid assignment parameters || This test verifies if the system can handle and reject an invitation creation request with invalid assignment parameters.
|-
| 6 || Test to create an invitation with invalid reply_status parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid reply_status parameter.
|-
| 7 || Test to create an invitation with same to user and from user parameters' || This test verifies if the system can handle and reject an invitation creation request with the same 'to' and 'from' user parameters.
|-
| 8 || Test to show invitation with valid invitation id || This test verifies if the system can successfully retrieve an invitation with a valid invitation id.
|-
| 9 || Test to show invitation with invalid invitation id || This test verifies if the system can handle and reject a request to retrieve an invitation with an invalid invitation id.
|-
| 10 || Test to accept invite successfully || This test verifies if the system can successfully update an invitation's reply status to 'accepted.'
|-
| 11 || Test to reject invite successfully || This test verifies if the system can successfully update an invitation's reply status to 'rejected.'
|-
| 12 || Test to update invitation with invalid reply_status || This test verifies if the system can handle and reject a request to update an invitation with an invalid reply_status parameter.
|-
| 13 || Test to update status with invalid invitation_id || This test verifies if the system can handle and reject a request to update the status of an invitation with an invalid invitation id.
|-
| 14 || Test to delete invitation with valid invite id || This test verifies if the system can successfully delete an invitation with a valid invitation id.
|-
| 15 || Test to delete invitation with invalid invite id || his test verifies if the system can handle and reject a request to delete an invitation with an invalid invitation id.
|-
| 16 || Test to show all invitations for the user for an assignment || This test verifies if the system can successfully retrieve all invitations for a specific user for a specific assignment.
|-
| 17 || Test to show invitation with invalid user and assignment || This test verifies if the system can handle and reject a request to retrieve an invitation with an invalid user and assignment.
|-
| 18 || Test to Show invitation with user and invalid assignment || The function of the 'Test to show invitation with valid user and invalid assignment' test case is to verify that the API handles the scenario of attempting to retrieve an invitation with an invalid assignment ID but with a valid user ID, and returns an appropriate response.
|-
| 19 ||Test to show invitation with invalid user and invalid assignment || The function of the 'Test to show invitation with invalid user and invalid assignment' test case is to verify that the API handles the scenario of attempting to retrieve an invitation with invalid user ID and invalid assignment ID, and returns an appropriate response.
|}

Rspec tests screenshot.
 
[[File:Dshah6_rspec_tests.png|900px]]

====Model Tests====

To run the model tests:

1. git clone

2. cd reimplementation-back-end/

3. bundle install

4. bundle exec rspec spec/models/invitation_spec.rb

File: [https://github.com/rohitgeddam/reimplementation-back-end/blob/main/spec/models/invitation_spec.rb invitation_spec.rb]

{| class="wikitable" style="margin-left:30px"
|-
! Sr No !! Test !!Test Description
|-
| 1 || Test to create an invitation with valid parameters.|| This test verifies if the system can successfully create an invitation with valid parameters such as 'to' user, 'from' user, assignment, and reply status.
|-
| 2 || Test to create an invitation with the same "to" and "from" user. || This test verifies if the system can handle and reject an invitation creation request with the same 'to' and 'from' user parameters.
|-
| 3 || Test to create an invitation with the invalid "to" user parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid 'to' user parameter.
|-
| 4 || Test to create an invitation with the invalid "from" user parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid 'from' user parameter.
|-
| 5 || Test to create an invitation with a invalid assignment argument. || This test verifies if the system can handle and reject an invitation creation request with an invalid assignment parameter.
|-
| 6 || Test to create an invitation with an invalid reply_status argument. || This test verifies if the system can handle and reject an invitation creation request with an invalid reply_status parameter.
|-
| 7 || Test to check is_invited? is a true case. || This test verifies if the system can correctly identify if a user has been invited to an assignment.
|-
| 8 || Test to check is_invited? is a false case. || This test verifies if the system can correctly identify if a user has not been invited to an assignment.
|-
| 9 || Test to check if the default reply_status for a new invitation is WAITING('W'). || This test verifies if the system can correctly set the default reply status to 'waiting' for a new invitation.
|-
| 10|| Test to check if invitation_factory returns new invitation. || This test verifies if the system can correctly create a new invitation using the invitation_factory method.
|-
| 11|| Test to check if invitation email is sent properly. || This test verifies if the system can successfully send an email invitation to the 'to' user.
|-
| 12|| Test to check if accept_invitation changes reply_status to 'A'. || This test verifies if the system can successfully update an invitation's reply status to 'accepted' using the accept_invitation method.
|-
| 13|| Test to check if decline_invitation changes reply_status to 'R'. || This test verifies if the system can successfully update an invitation's reply status to 'rejected' using the decline_invitation method.
|-
| 14|| Test to check if retract_invitation destroys the invitation. || This test verifies if the system can successfully delete an invitation using the retract_invitation method.
|-
| 15|| Test to check if as_json formats invitation as required. || This test verifies if the 'as_json' method can correctly format an invitation as JSON with the required fields such as 'to_user', 'from_user', 'assignment', 'reply_status', and 'id'. The test case creates an invitation with valid parameters and expects the 'as_json' method to include the required fields.
|-
|}

Rspec tests screenshot.
 
[[File:ROHIT_GEDDAM_Invitation_spec.png|900px]]

Test Coverage Report for Invitation model.
 
Our tests covers 100% of the lines in the Invitation model.
[[File:ROHIT_GEDDAM_Invitation_test_coverage.png|900px]]

== Swagger UI Screenshot ==

Swagger is used to provide an easy to use API documentation for the users of the API. It also provides an easy to use interface to interact with the API in the browser itself. You can use the swagger page to test out our API by clicking on the "Try it out" button next to each route.

path: /api-docs/

[[File:Dshah6_swagger.png|900px]]

= Files modified/created =

[[File:ROHIT_GEDDAM_FILES_CHANGED_APP.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_CONFIG.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_DB.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_SPEC.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_SWAGGER.png|300px]]

=Future Work=

Implement methods in invitation_controller.rb and invitation.rb. Some of the methods were not implemented due to dependency on other models which are not implemented yet. The dependency models need to be implemented first and then these methods can be implemented. We have left out the placeholder in the source code for such methods and a small explaination of what is expected from the future implementation of the method.

Authentication system is required for the working of invitation feature. Before performing any action related to invitation, authorization of the request must be done to make sure the user is able to perform the action requested.

 

===== Future work in invitation_controller.rb =====
<pre>check_invited_user_before_invitation</pre>
This method will check if the invited user exists. Additionally, this method will also check if the sender himself is participating in the given assignment before they can send an invitation.

<pre>check_participant_before_invitation</pre>
This method will check if the invited user is a participant in the assignment.

<pre>check_team_before_invitation</pre>
This method will check if the team meets the joining requirement before sending an invite.

<pre>check_team_before_accept</pre>
This method will check if the team meets the joining requirements when an invitation is being accepted for example check if the invite's team is still existing, and have available slot to add the invitee.

===== Future work in invitation.rb =====
<pre>update_users_topic_after_invite_accept</pre>
After a users accepts an invite, the teams_users table needs to be updated.

<pre>accept_invitation</pre>
This method handles all that needs to be done upon a user accepting an invitation.
Expected functionality: First the users previous team is deleted if they were the only member of that
team and topics that the old team signed up for will be deleted.
Then invites the user that accepted the invite sent will be removed.
Lastly the users team entry will be added to the TeamsUser table and their assigned topic is updated.

=References=

* [https://github.com/rohitgeddam/reimplementation-back-end/ Github Link]

* [https://github.com/expertiza/reimplementation-back-end/pull/32 Github Pull Request]

* [http://152.7.178.119:8080/ VCL Image Link]

* [http://rspec.info/documentation/3.8/rspec-core/ Rspec Documentation]

* [http://152.7.178.119:8080/api-docs/ Swagger UI]

* [https://youtu.be/nSSuKuOaFWE Demo Video]

=Team Members=

* Saigirishwar Rohit Geddam [sgeddam2]
* Keerthana Telaprolu [ktelapr]
* Dhrumil Shah [dshah6]

=Mentor=
Ankur Mundra [amundra]

CSC/ECE 517 Spring 2023 - E2330. Reimplement Invitation Controller

2023-04-24T23:31:34Z

Dshah6: /* Controller Tests */

==Project Overview==

===Expertiza Background===

Expertiza is an online platform designed to facilitate peer review and submission of various types of academic work, including articles, codes, and websites. The application allows instructors to add assignments, grade them, and assign students to teams based on their topic preferences. The platform also enables students to provide feedback on each other's work through peer reviews, which can be helpful in improving the quality of their projects. Expertiza is backed by the National Science Foundation.

===Problem Statement===

The Invitation model and InvitationsController are responsible for managing invitations between users in a team-based assignment system. The system allows a student to invite another student to their team by creating a new Invitation record, which is associated with the inviting and invited students and the assignment they are working on. The invited user can accept, decline, or cancel the invitation, which updates the corresponding Invitation record and may trigger actions such as adding or removing users from teams. The InvitationsController includes methods for creating, accepting, declining, and canceling invitations, as well as checking the status of the user and team before sending or accepting invitations. The system also sends email notifications to invited users when a new invitation is sent. Overall, the Invitation model and InvitationsController are crucial for managing team membership and collaboration in a team-based assignment system. Instructor’s note: There is already a project to merge this controller with the join_team_requests_controller. You should start with the code they have written.

==Objectives==
1. Write RESTful endpoints of create, show, delete to invitations and approving new invitations, listing pending invitations, creating new invitations, and notifying students about new team formation invite.

2. Develop and implement methods in the InvitationsController that enable the following functionality:Create invitations, Accept invitations, Decline invitations, Cancel invitations, and Check user and team status before sending or accepting invitations.

3. To implement a user-invitation system that allows invited users to accept, decline, or cancel invitations, which will update the corresponding Invitation record and trigger actions such as adding or removing users from teams.

4. Implement an email notification system in the user-invitation system, which sends email notifications to invited users when a new invitation is sent.

5. Return proper status codes and proper validation for RESTful endpoints.

6. Write models and controllers such that they use modern approaches to writing Ruby code, including utilizing language features and adhering to best practices for object-oriented design.

7. Write proper Rspec tests for all APIs, models, controllers.

== Development Strategy ==

We have tried to follow a Test Driven Development approach to implement both the Invitation model and the Invitation Controller.
Firstly a failing test case was written and then the code was added such that the test which was failing will pass now.

Also, we have tried to follow the rails philosophy of "Fat models" We have tried to move as much business logic from the controller to the model as possible. This will also help keep the controller code clean and encourage code reusability.

==Project Design and Implementation==

===Use Case Diagram ===
[[File:Usecasediagram1.png|800px]]

===Class Diagram ===
[[File:dshah6_UML_Diagram.png|900px]]

===Functionality===
In this project, we aim to add the following functions:

1. Enable users to create a new team invitation.

2. Enable users to Accept or Reject invitations.

3. Enable users to Retract invitations.

4. Enable users to send email notifications to invited users.

5. Ensure that data is validated properly in all the above APIs.

6. Test cases for all the above.

==Screen Shots==
===1. Send an invite ===
[[File:Dshah6_send_invite.png|900px]]

[[File:Dshah6_send_invite_2.png|900px]]

[[File:Dshah6_send_invite_3.png|900px]]

===2. Accept an invite===
[[File:Dshah6_accept_1.png|900px]]

[[File:Dshah6_accept_2.png|900px]]

[[File:Dshah6_accept_3.png|900px]]

===3. Reject invite===
[[File:Dshah6_decline_1.png|900px]]

[[File:Dshah6_decline_2.png|900px]]

===4. Retract invite===
[[File:Dshah6_retract_1.png|900px]]

===5. We retracted invitation of angel and malka and added ofelia===

[[File:Dshah6_retract_2.png|900px]]

= Project Design =

===Model===
The file invitation.rb defines the Invitation model which is a subclass of ApplicationRecord. The Invitation model has three foreign keys. to_user represents the user to whom the inviations is sent. from_user represents the user who is creating the invitation. assignment represents which assignment the invitation belongs to. reply_status represents whether the invitation is accepted, rejected or waiting. The default reply_status is waiting 'W'. There are also multiple validations defined for the various fields in this model. One of the important validation is to_from_cant_be_same validation, which prevents users from creating invitations to themselves. Moreover there are multiple helper methods defined for Invitations. These methods help keep the controller code short and clean. We are following the rails philosophy of "Fat Models". For the scope of this project the helper methods are kept simple, however once the project advances these helper methods need to be updated.

filename: invitation.rb
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/invitation.rb GitHub file Link to invitation.rb]

<pre>
class Invitation < ApplicationRecord
after_initialize :set_defaults

ACCEPT_STATUS = 'A'.freeze
REJECT_STATUS = 'R'.freeze
WAITING_STATUS = 'W'.freeze

belongs_to :to_user, class_name: 'User', foreign_key: 'to_id', inverse_of: false
belongs_to :from_user, class_name: 'User', foreign_key: 'from_id', inverse_of: false
belongs_to :assignment, class_name: 'Assignment', foreign_key: 'assignment_id'
validates :reply_status, presence: true, length: { maximum: 1 }
validates_inclusion_of :reply_status, in: [ACCEPT_STATUS, REJECT_STATUS, WAITING_STATUS], allow_nil: false
validates :assignment_id, uniqueness: {
scope: %i[from_id to_id reply_status],
message: 'You cannot have duplicate invitations'
}
validate :to_from_cant_be_same

# validate if the to_id and from_id are same
def to_from_cant_be_same
return unless from_id == to_id

errors.add(:from_id, 'to and from users should be different')
end

# Return a new invitation
# params = :assignment_id, :to_id, :from_id, :reply_status
def self.invitation_factory(params)
Invitation.new(params)
end

# check if the user is invited
def self.invited?(from_id, to_id, assignment_id)
@invitations_count = Invitation.where(to_id:)
.where(from_id:)
.where(assignment_id:)
.where(reply_status: WAITING_STATUS)
.count
@invitations_count.positive?
end

# send invite email
def send_invite_email
InvitationSentMailer.with(invitation: self)
.send_invitation_email
.deliver_later
end

# After a users accepts an invite, the teams_users table needs to be updated.
# NOTE: Depends on TeamUser model, which is not implemented yet.
def update_users_topic_after_invite_accept(_inviter_user_id, _invited_user_id, _assignment_id); end

# This method handles all that needs to be done upon a user accepting an invitation.
# Expected functionality: First the users previous team is deleted if they were the only member of that
# team and topics that the old team signed up for will be deleted.
# Then invites the user that accepted the invite sent will be removed.
# Lastly the users team entry will be added to the TeamsUser table and their assigned topic is updated.
# NOTE: For now this method simply updates the invitation's reply_status.
def accept_invitation(_logged_in_user)
update(reply_status: ACCEPT_STATUS)
end

# This method handles all that needs to be done upon an user declining an invitation.
def decline_invitation(_logged_in_user)
update(reply_status: REJECT_STATUS)
end

# This method handles all that need to be done upon an invitation retraction.
def retract_invitation(_logged_in_user)
destroy
end

# This will override the default as_json method in the ApplicationRecord class and specify
def as_json(options = {})
super(options.merge({
only: %i[id reply_status created_at updated_at],
include: {
assignment: { only: %i[id name] },
from_user: { only: %i[id name fullname email] },
to_user: { only: %i[id name fullname email] }
}
})).tap do |hash|
end
end

def set_defaults
self.reply_status ||= WAITING_STATUS
end
end
</pre>

===Helper Methods in Invitation model.===

====to_from_cant_be_same:====
Validate if the to_id and from_id are same i.e a users cannot send invitations to themselves.

====self.invitation_factory(params):====
This helper method will help in creating new Invitation with the given parameters. Custom parameters can be passed to create specific Invitation.

====self.invited?(from_id, to_id, assignment_id):====
Check if the user is invited given the from_id, to_id, and assignment_id. This is a class method to make it more generic and can be used by other classes.

====send_invite_email:====
This method uses the InvitaionSentMailer to send invitation emails to the invited user.

====update_users_topic_after_invite_accept(inviter_user_id, invited_user_id, assignment_id) [Future work]:====
After a users accepts an invite, the teams_users table needs to be updated.
NOTE: Depends on TeamUser model, which is not implemented yet.

====accept_invitation:====
This method handles all that needs to be done upon a user accepting an invitation.

====decline_invitation:====
This method handles all that needs to be done upon an user decline an invitation.

====retract_invitation:====
This method handles all that need to be done upon an invitation retraction.

====as_json:====
This will override the default as_json method in the ApplicationRecord class and specify

====set_defaults:====
This will be used to set default parameters when creating new Invitation.

Changes in models/user.rb
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/user.rb GitHub Link to user.rb file]
 
A user can have many invitations therefore we added a has_many relationship in the user model. On the other hand in the invitation model we added belongs_to relationship with the user model.

<pre>
# added the following relations in the user.rb file.
has_many :invitations
</pre>
Changes in models/assignment.rb
 

[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/assignment.rb GitHub Link to assignment.rb file]
 
An assignment can have many invitations therefore we added a has_many relationship in the assignment model. On the other hand in the invitation model we added belongs_to relationship with the assignment model.

<pre>
# added the following relations in the assignment.rb file.
class Assignment < ApplicationRecord
has_many :invitations
end
</pre>

Schema
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/db/schema.rb GitHub Link to scheme.rb file]
 
The invitation schema has three foreign keys. The foreign keys are "assignment_id", "from_id", "to_id". from_id and to_id are foreign keys to user model.

<pre>
create_table "invitations", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
t.integer "assignment_id"
t.integer "from_id"
t.integer "to_id"
t.string "reply_status", limit: 1
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["assignment_id"], name: "fk_invitation_assignments"
t.index ["from_id"], name: "fk_invitationfrom_users"
t.index ["to_id"], name: "fk_invitationto_users"
end
</pre>

===Controllers===
We create a new controller at app/controllers/invitation_controller.rb with following methods:
[Implementation of the invitation controller[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/controllers/api/v1/invitations_controller.rb]]
===REST Route methods===
=====create:=====
This will create a new invitation record.
=====index:=====
This will give a list of all the invitations
=====show:=====
This will be used to show a particular invitation with given invitation_id.
=====update:=====
This will be used to update the status of the current invitation. Either accepted or rejected
=====destroy:=====
This will be used to delete the invitation that is already sent to another participant using particular invite_id.
=====invitations_for_user_assignment:=====
This will be used to get all the invitations for a particular assignment for a particular student.

=== Helper methods ===
=====check_team_before_accept [Future work]:=====
This method will check if the team meets the joining requirements when an invitation is being accepted for example check if the invite's team is still existing, and have available slot to add the invitee.

=====check_team_before_invitation [Future work]:=====
This method will check if the team meets the joining requirement before sending an invite.

=====check_participant_before_invitation [Future work]:=====
This method will check if the invited user is a participant in the assignment.

=====check_user_before_invitation [Future work]:=====
This method will check if the invited user exists. Additionally, this method will also check if the sender himself is participating in the given assignment before they can send an invitation.

==End point description==

===create===
<pre>
Description: This route will create a new invitation record with default reply_status: w. w stands for waiting.
REST VERB: POST
Path: /invitations/

Response:

Success:
Status code: 200

```
{
{
"id": 11,
"reply_status": "W",
"created_at": "2023-04-20T21:33:29.580Z",
"updated_at": "2023-04-20T21:33:29.580Z",
"assignment": {
"id": 2,
"name": "oodd program3"
},
"from_user": {
"id": 2,
"name": "jhon",
"fullname": "jhon carmen",
"email": "example1@gmail.com"
},
"to_user": {
"id": 1,
"name": "katy",
"fullname": "katy shah",
"email": "example2@gmail.com"
}
}

```

Failure:
Status code: 422

```
{
error: @invitation.errors
}

```

</pre>

===index===

<pre>
Description: Get a list of all the invitations in the database.
REST VERB: GET
Path: /invitations/
Request: NA

Success
Status Code: 200
```
[
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
},
{
"id": 2,
"reply_status": "W",
"created_at": "2023-04-18T15:52:44.543Z",
"updated_at": "2023-04-18T15:52:44.543Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
},
"to_user": {
"id": 3,
"name": "rebecca",
"fullname": "rebecca fiat",
"email": "reb@gmail.com"
}
}
]

```

</pre>

===show===
<pre>
Description: Get a particular invite with the invite_id.
REST VERB: GET
Path: /invitations/<invite_id>
Request: NA
Response:

success
status code: 200
```
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}

```

Error
Status code: 404

```
{
"error": "Couldn't find Invitation with 'id'=1021321"
}
```
</pre>

===update===
<pre>
Description: This route will modify the status of the invitation to be accepted or declined
REST VERB: PATCH
Path: /invitations/<invite_id>/
Request:
```
{
"reply_status": ["A"/"R"],
}

```
Response:

Success
Status Code: 200

```
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}
```

Error
Status Code: 404/422

```
{
"error": @invitation.errors
}
```

</pre>

===destroy===
<pre>
Description: Delete the invitation
REST VERB: DELETE
Path: /invitations/<invite_id>
Request: NA
Response:

Success
Status code: 204 :no_content
Response: NA

Error
Status Code: 404
Response
```

{
"error": @invitation.errors
}

```

</pre>

===invitations_for_user_assignment===
<pre>
Description: Get the invitations for the user with id: user_id for the given assignment with id: assignment_id.
REST VERB: GET
Path: /invitations/<user_id>/<assingment_id>
Request: NA
Response:

Success
Status Code: 200 :ok

```
[
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
},
{
"id": 2,
"reply_status": "W",
"created_at": "2023-04-18T15:52:44.543Z",
"updated_at": "2023-04-18T15:52:44.543Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}
]

```

Error
Status Code: 404 :not_found

```
{
"error": @invitations.errors
}

```
</pre>

== End point summary ==
{| class="wikitable" style="margin-left:40px"
|-
! Sr No !! Method !! Endpoint !! Request Body !! Description
|-
| 1 || create || POST /invitations/||{ "assignment_id": INT, "from_id": INT, "to_id": INT, "reply_status": CHAR } ||Create a new invitation record with default reply_status: w, w stands for waiting.
|-
| 2 || index || GET /invitations/ || ||Get a list of all the invitations.
|-
| 3 || show || GET /invitations/<assignment_id> || || Get a particular invite with the invite_id.
|-
| 4 || update || PATCH /invitations/<invite_id>/ || { "reply_status":["A"/"R"] } || Modify the status of the invitation to be accepted or declined.
|-
| 5 || destroy || DELETE /invitations/<invite_id> || || Delete the invitation.
|-
| 6 || invitations_for_user_assignment || GET /invitations/<assignment_id> || || Get the invitations for the user with id: user_id for the given assignment with id: assignment_id

|}

= Testing Plan =

We utilized RSpec as the testing framework for our system. We have used factoryBot along with Faker to create model objects for testing. The development process has followed Test Driven Development. The tests for the model and the controller are written in a comprehensive way.

====Controller Tests====

To run the controller tests:

1. git clone

2. cd reimplementation-back-end/

3. bundle install

4. bundle exec rspec spec/requests/api/v1/invitation_controller_spec.rb

File: [https://github.com/rohitgeddam/reimplementation-back-end/blob/main/spec/requests/api/v1/invitation_controller_spec.rb invitation_controller_spec.rb]

{| class="wikitable" style="margin-left:30px"
|-
! Sr No !! Test !! Description
|-
| 1 || Test to list all Invitations || This test verifies if the system can successfully retrieve a list of all invitations available in the system.
|-
| 2 || Test to create an invitation with valid parameters || This test verifies if the system can successfully create an invitation with valid parameters such as 'to' user, 'from' user, assignment, and reply status.
|-
| 3 || Test to create an invitation with invalid 'to' user parameters' || This test verifies if the system can handle and reject an invitation creation request with invalid 'to' user parameters.
|-
| 4 || Test to create an invitation with invalid 'from' user parameters || This test verifies if the system can handle and reject an invitation creation request with invalid 'from' user parameters.
|-
| 5 || Test to create an invitation with invalid assignment parameters || This test verifies if the system can handle and reject an invitation creation request with invalid assignment parameters.
|-
| 6 || Test to create an invitation with invalid reply_status parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid reply_status parameter.
|-
| 7 || Test to create an invitation with same to user and from user parameters' || This test verifies if the system can handle and reject an invitation creation request with the same 'to' and 'from' user parameters.
|-
| 8 || Test to show invitation with valid invitation id || This test verifies if the system can successfully retrieve an invitation with a valid invitation id.
|-
| 9 || Test to show invitation with invalid invitation id || This test verifies if the system can handle and reject a request to retrieve an invitation with an invalid invitation id.
|-
| 10 || Test to accept invite successfully || This test verifies if the system can successfully update an invitation's reply status to 'accepted.'
|-
| 11 || Test to reject invite successfully || This test verifies if the system can successfully update an invitation's reply status to 'rejected.'
|-
| 12 || Test to update invitation with invalid reply_status || This test verifies if the system can handle and reject a request to update an invitation with an invalid reply_status parameter.
|-
| 13 || Test to update status with invalid invitation_id || This test verifies if the system can handle and reject a request to update the status of an invitation with an invalid invitation id.
|-
| 14 || Test to delete invitation with valid invite id || This test verifies if the system can successfully delete an invitation with a valid invitation id.
|-
| 15 || Test to delete invitation with invalid invite id || his test verifies if the system can handle and reject a request to delete an invitation with an invalid invitation id.
|-
| 16 || Test to show all invitations for the user for an assignment || This test verifies if the system can successfully retrieve all invitations for a specific user for a specific assignment.
|-
| 17 || Test to show invitation with invalid user and assignment || This test verifies if the system can handle and reject a request to retrieve an invitation with an invalid user and assignment.
|-
| 18 || Test to Show invitation with user and invalid assignment || The function of the 'Test to Show invitation with user and invalid assignment' test case is to verify if the API can handle the scenario where a user attempts to retrieve an invitation with an invalid assignment ID. The test sets the user ID to a valid user's ID and an invalid assignment ID as the assignment ID. The test then sends a request to the server and expects it to respond accordingly. This test is designed to ensure that the API behaves correctly when presented with invalid input, and to ensure that the client application receives an appropriate response.
|-
| 19 ||Test to show invitation with invalid user and invalid assignment || The function of the 'Test to show invitation with invalid user and invalid assignment' test case is to verify if the API can handle the scenario where a user attempts to retrieve an invitation with both an invalid user ID and an invalid assignment ID. The test sets both the user ID and assignment ID to invalid values. The test then sends a request to the server and expects it to respond accordingly. This test is designed to ensure that the API correctly handles invalid input and returns an appropriate response in case of such scenarios.
|}

Rspec tests screenshot.
 
[[File:Dshah6_rspec_tests.png|900px]]

====Model Tests====

To run the model tests:

1. git clone

2. cd reimplementation-back-end/

3. bundle install

4. bundle exec rspec spec/models/invitation_spec.rb

File: [https://github.com/rohitgeddam/reimplementation-back-end/blob/main/spec/models/invitation_spec.rb invitation_spec.rb]

{| class="wikitable" style="margin-left:30px"
|-
! Sr No !! Test !!Test Description
|-
| 1 || Test to create an invitation with valid parameters.|| This test verifies if the system can successfully create an invitation with valid parameters such as 'to' user, 'from' user, assignment, and reply status.
|-
| 2 || Test to create an invitation with the same "to" and "from" user. || This test verifies if the system can handle and reject an invitation creation request with the same 'to' and 'from' user parameters.
|-
| 3 || Test to create an invitation with the invalid "to" user parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid 'to' user parameter.
|-
| 4 || Test to create an invitation with the invalid "from" user parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid 'from' user parameter.
|-
| 5 || Test to create an invitation with a invalid assignment argument. || This test verifies if the system can handle and reject an invitation creation request with an invalid assignment parameter.
|-
| 6 || Test to create an invitation with an invalid reply_status argument. || This test verifies if the system can handle and reject an invitation creation request with an invalid reply_status parameter.
|-
| 7 || Test to check is_invited? is a true case. || This test verifies if the system can correctly identify if a user has been invited to an assignment.
|-
| 8 || Test to check is_invited? is a false case. || This test verifies if the system can correctly identify if a user has not been invited to an assignment.
|-
| 9 || Test to check if the default reply_status for a new invitation is WAITING('W'). || This test verifies if the system can correctly set the default reply status to 'waiting' for a new invitation.
|-
| 10|| Test to check if invitation_factory returns new invitation. || This test verifies if the system can correctly create a new invitation using the invitation_factory method.
|-
| 11|| Test to check if invitation email is sent properly. || This test verifies if the system can successfully send an email invitation to the 'to' user.
|-
| 12|| Test to check if accept_invitation changes reply_status to 'A'. || This test verifies if the system can successfully update an invitation's reply status to 'accepted' using the accept_invitation method.
|-
| 13|| Test to check if decline_invitation changes reply_status to 'R'. || This test verifies if the system can successfully update an invitation's reply status to 'rejected' using the decline_invitation method.
|-
| 14|| Test to check if retract_invitation destroys the invitation. || This test verifies if the system can successfully delete an invitation using the retract_invitation method.
|-
| 15|| Test to check if as_json formats invitation as required. || This test verifies if the 'as_json' method can correctly format an invitation as JSON with the required fields such as 'to_user', 'from_user', 'assignment', 'reply_status', and 'id'. The test case creates an invitation with valid parameters and expects the 'as_json' method to include the required fields.
|-
|}

Rspec tests screenshot.
 
[[File:ROHIT_GEDDAM_Invitation_spec.png|900px]]

Test Coverage Report for Invitation model.
 
Our tests covers 100% of the lines in the Invitation model.
[[File:ROHIT_GEDDAM_Invitation_test_coverage.png|900px]]

== Swagger UI Screenshot ==

Swagger is used to provide an easy to use API documentation for the users of the API. It also provides an easy to use interface to interact with the API in the browser itself. You can use the swagger page to test out our API by clicking on the "Try it out" button next to each route.

path: /api-docs/

[[File:Dshah6_swagger.png|900px]]

= Files modified/created =

[[File:ROHIT_GEDDAM_FILES_CHANGED_APP.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_CONFIG.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_DB.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_SPEC.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_SWAGGER.png|300px]]

=Future Work=

Implement methods in invitation_controller.rb and invitation.rb. Some of the methods were not implemented due to dependency on other models which are not implemented yet. The dependency models need to be implemented first and then these methods can be implemented. We have left out the placeholder in the source code for such methods and a small explaination of what is expected from the future implementation of the method.

Authentication system is required for the working of invitation feature. Before performing any action related to invitation, authorization of the request must be done to make sure the user is able to perform the action requested.

 

===== Future work in invitation_controller.rb =====
<pre>check_invited_user_before_invitation</pre>
This method will check if the invited user exists. Additionally, this method will also check if the sender himself is participating in the given assignment before they can send an invitation.

<pre>check_participant_before_invitation</pre>
This method will check if the invited user is a participant in the assignment.

<pre>check_team_before_invitation</pre>
This method will check if the team meets the joining requirement before sending an invite.

<pre>check_team_before_accept</pre>
This method will check if the team meets the joining requirements when an invitation is being accepted for example check if the invite's team is still existing, and have available slot to add the invitee.

===== Future work in invitation.rb =====
<pre>update_users_topic_after_invite_accept</pre>
After a users accepts an invite, the teams_users table needs to be updated.

<pre>accept_invitation</pre>
This method handles all that needs to be done upon a user accepting an invitation.
Expected functionality: First the users previous team is deleted if they were the only member of that
team and topics that the old team signed up for will be deleted.
Then invites the user that accepted the invite sent will be removed.
Lastly the users team entry will be added to the TeamsUser table and their assigned topic is updated.

=References=

* [https://github.com/rohitgeddam/reimplementation-back-end/ Github Link]

* [https://github.com/expertiza/reimplementation-back-end/pull/32 Github Pull Request]

* [http://152.7.178.119:8080/ VCL Image Link]

* [http://rspec.info/documentation/3.8/rspec-core/ Rspec Documentation]

* [http://152.7.178.119:8080/api-docs/ Swagger UI]

* [https://youtu.be/nSSuKuOaFWE Demo Video]

=Team Members=

* Saigirishwar Rohit Geddam [sgeddam2]
* Keerthana Telaprolu [ktelapr]
* Dhrumil Shah [dshah6]

=Mentor=
Ankur Mundra [amundra]

CSC/ECE 517 Spring 2023 - E2330. Reimplement Invitation Controller

2023-04-24T23:23:23Z

Dshah6: /* Model Tests */

==Project Overview==

===Expertiza Background===

Expertiza is an online platform designed to facilitate peer review and submission of various types of academic work, including articles, codes, and websites. The application allows instructors to add assignments, grade them, and assign students to teams based on their topic preferences. The platform also enables students to provide feedback on each other's work through peer reviews, which can be helpful in improving the quality of their projects. Expertiza is backed by the National Science Foundation.

===Problem Statement===

The Invitation model and InvitationsController are responsible for managing invitations between users in a team-based assignment system. The system allows a student to invite another student to their team by creating a new Invitation record, which is associated with the inviting and invited students and the assignment they are working on. The invited user can accept, decline, or cancel the invitation, which updates the corresponding Invitation record and may trigger actions such as adding or removing users from teams. The InvitationsController includes methods for creating, accepting, declining, and canceling invitations, as well as checking the status of the user and team before sending or accepting invitations. The system also sends email notifications to invited users when a new invitation is sent. Overall, the Invitation model and InvitationsController are crucial for managing team membership and collaboration in a team-based assignment system. Instructor’s note: There is already a project to merge this controller with the join_team_requests_controller. You should start with the code they have written.

==Objectives==
1. Write RESTful endpoints of create, show, delete to invitations and approving new invitations, listing pending invitations, creating new invitations, and notifying students about new team formation invite.

2. Develop and implement methods in the InvitationsController that enable the following functionality:Create invitations, Accept invitations, Decline invitations, Cancel invitations, and Check user and team status before sending or accepting invitations.

3. To implement a user-invitation system that allows invited users to accept, decline, or cancel invitations, which will update the corresponding Invitation record and trigger actions such as adding or removing users from teams.

4. Implement an email notification system in the user-invitation system, which sends email notifications to invited users when a new invitation is sent.

5. Return proper status codes and proper validation for RESTful endpoints.

6. Write models and controllers such that they use modern approaches to writing Ruby code, including utilizing language features and adhering to best practices for object-oriented design.

7. Write proper Rspec tests for all APIs, models, controllers.

== Development Strategy ==

We have tried to follow a Test Driven Development approach to implement both the Invitation model and the Invitation Controller.
Firstly a failing test case was written and then the code was added such that the test which was failing will pass now.

Also, we have tried to follow the rails philosophy of "Fat models" We have tried to move as much business logic from the controller to the model as possible. This will also help keep the controller code clean and encourage code reusability.

==Project Design and Implementation==

===Use Case Diagram ===
[[File:Usecasediagram1.png|800px]]

===Class Diagram ===
[[File:dshah6_UML_Diagram.png|900px]]

===Functionality===
In this project, we aim to add the following functions:

1. Enable users to create a new team invitation.

2. Enable users to Accept or Reject invitations.

3. Enable users to Retract invitations.

4. Enable users to send email notifications to invited users.

5. Ensure that data is validated properly in all the above APIs.

6. Test cases for all the above.

==Screen Shots==
===1. Send an invite ===
[[File:Dshah6_send_invite.png|900px]]

[[File:Dshah6_send_invite_2.png|900px]]

[[File:Dshah6_send_invite_3.png|900px]]

===2. Accept an invite===
[[File:Dshah6_accept_1.png|900px]]

[[File:Dshah6_accept_2.png|900px]]

[[File:Dshah6_accept_3.png|900px]]

===3. Reject invite===
[[File:Dshah6_decline_1.png|900px]]

[[File:Dshah6_decline_2.png|900px]]

===4. Retract invite===
[[File:Dshah6_retract_1.png|900px]]

===5. We retracted invitation of angel and malka and added ofelia===

[[File:Dshah6_retract_2.png|900px]]

= Project Design =

===Model===
The file invitation.rb defines the Invitation model which is a subclass of ApplicationRecord. The Invitation model has three foreign keys. to_user represents the user to whom the inviations is sent. from_user represents the user who is creating the invitation. assignment represents which assignment the invitation belongs to. reply_status represents whether the invitation is accepted, rejected or waiting. The default reply_status is waiting 'W'. There are also multiple validations defined for the various fields in this model. One of the important validation is to_from_cant_be_same validation, which prevents users from creating invitations to themselves. Moreover there are multiple helper methods defined for Invitations. These methods help keep the controller code short and clean. We are following the rails philosophy of "Fat Models". For the scope of this project the helper methods are kept simple, however once the project advances these helper methods need to be updated.

filename: invitation.rb
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/invitation.rb GitHub file Link to invitation.rb]

<pre>
class Invitation < ApplicationRecord
after_initialize :set_defaults

ACCEPT_STATUS = 'A'.freeze
REJECT_STATUS = 'R'.freeze
WAITING_STATUS = 'W'.freeze

belongs_to :to_user, class_name: 'User', foreign_key: 'to_id', inverse_of: false
belongs_to :from_user, class_name: 'User', foreign_key: 'from_id', inverse_of: false
belongs_to :assignment, class_name: 'Assignment', foreign_key: 'assignment_id'
validates :reply_status, presence: true, length: { maximum: 1 }
validates_inclusion_of :reply_status, in: [ACCEPT_STATUS, REJECT_STATUS, WAITING_STATUS], allow_nil: false
validates :assignment_id, uniqueness: {
scope: %i[from_id to_id reply_status],
message: 'You cannot have duplicate invitations'
}
validate :to_from_cant_be_same

# validate if the to_id and from_id are same
def to_from_cant_be_same
return unless from_id == to_id

errors.add(:from_id, 'to and from users should be different')
end

# Return a new invitation
# params = :assignment_id, :to_id, :from_id, :reply_status
def self.invitation_factory(params)
Invitation.new(params)
end

# check if the user is invited
def self.invited?(from_id, to_id, assignment_id)
@invitations_count = Invitation.where(to_id:)
.where(from_id:)
.where(assignment_id:)
.where(reply_status: WAITING_STATUS)
.count
@invitations_count.positive?
end

# send invite email
def send_invite_email
InvitationSentMailer.with(invitation: self)
.send_invitation_email
.deliver_later
end

# After a users accepts an invite, the teams_users table needs to be updated.
# NOTE: Depends on TeamUser model, which is not implemented yet.
def update_users_topic_after_invite_accept(_inviter_user_id, _invited_user_id, _assignment_id); end

# This method handles all that needs to be done upon a user accepting an invitation.
# Expected functionality: First the users previous team is deleted if they were the only member of that
# team and topics that the old team signed up for will be deleted.
# Then invites the user that accepted the invite sent will be removed.
# Lastly the users team entry will be added to the TeamsUser table and their assigned topic is updated.
# NOTE: For now this method simply updates the invitation's reply_status.
def accept_invitation(_logged_in_user)
update(reply_status: ACCEPT_STATUS)
end

# This method handles all that needs to be done upon an user declining an invitation.
def decline_invitation(_logged_in_user)
update(reply_status: REJECT_STATUS)
end

# This method handles all that need to be done upon an invitation retraction.
def retract_invitation(_logged_in_user)
destroy
end

# This will override the default as_json method in the ApplicationRecord class and specify
def as_json(options = {})
super(options.merge({
only: %i[id reply_status created_at updated_at],
include: {
assignment: { only: %i[id name] },
from_user: { only: %i[id name fullname email] },
to_user: { only: %i[id name fullname email] }
}
})).tap do |hash|
end
end

def set_defaults
self.reply_status ||= WAITING_STATUS
end
end
</pre>

===Helper Methods in Invitation model.===

====to_from_cant_be_same:====
Validate if the to_id and from_id are same i.e a users cannot send invitations to themselves.

====self.invitation_factory(params):====
This helper method will help in creating new Invitation with the given parameters. Custom parameters can be passed to create specific Invitation.

====self.invited?(from_id, to_id, assignment_id):====
Check if the user is invited given the from_id, to_id, and assignment_id. This is a class method to make it more generic and can be used by other classes.

====send_invite_email:====
This method uses the InvitaionSentMailer to send invitation emails to the invited user.

====update_users_topic_after_invite_accept(inviter_user_id, invited_user_id, assignment_id) [Future work]:====
After a users accepts an invite, the teams_users table needs to be updated.
NOTE: Depends on TeamUser model, which is not implemented yet.

====accept_invitation:====
This method handles all that needs to be done upon a user accepting an invitation.

====decline_invitation:====
This method handles all that needs to be done upon an user decline an invitation.

====retract_invitation:====
This method handles all that need to be done upon an invitation retraction.

====as_json:====
This will override the default as_json method in the ApplicationRecord class and specify

====set_defaults:====
This will be used to set default parameters when creating new Invitation.

Changes in models/user.rb
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/user.rb GitHub Link to user.rb file]
 
A user can have many invitations therefore we added a has_many relationship in the user model. On the other hand in the invitation model we added belongs_to relationship with the user model.

<pre>
# added the following relations in the user.rb file.
has_many :invitations
</pre>
Changes in models/assignment.rb
 

[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/assignment.rb GitHub Link to assignment.rb file]
 
An assignment can have many invitations therefore we added a has_many relationship in the assignment model. On the other hand in the invitation model we added belongs_to relationship with the assignment model.

<pre>
# added the following relations in the assignment.rb file.
class Assignment < ApplicationRecord
has_many :invitations
end
</pre>

Schema
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/db/schema.rb GitHub Link to scheme.rb file]
 
The invitation schema has three foreign keys. The foreign keys are "assignment_id", "from_id", "to_id". from_id and to_id are foreign keys to user model.

<pre>
create_table "invitations", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
t.integer "assignment_id"
t.integer "from_id"
t.integer "to_id"
t.string "reply_status", limit: 1
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["assignment_id"], name: "fk_invitation_assignments"
t.index ["from_id"], name: "fk_invitationfrom_users"
t.index ["to_id"], name: "fk_invitationto_users"
end
</pre>

===Controllers===
We create a new controller at app/controllers/invitation_controller.rb with following methods:
[Implementation of the invitation controller[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/controllers/api/v1/invitations_controller.rb]]
===REST Route methods===
=====create:=====
This will create a new invitation record.
=====index:=====
This will give a list of all the invitations
=====show:=====
This will be used to show a particular invitation with given invitation_id.
=====update:=====
This will be used to update the status of the current invitation. Either accepted or rejected
=====destroy:=====
This will be used to delete the invitation that is already sent to another participant using particular invite_id.
=====invitations_for_user_assignment:=====
This will be used to get all the invitations for a particular assignment for a particular student.

=== Helper methods ===
=====check_team_before_accept [Future work]:=====
This method will check if the team meets the joining requirements when an invitation is being accepted for example check if the invite's team is still existing, and have available slot to add the invitee.

=====check_team_before_invitation [Future work]:=====
This method will check if the team meets the joining requirement before sending an invite.

=====check_participant_before_invitation [Future work]:=====
This method will check if the invited user is a participant in the assignment.

=====check_user_before_invitation [Future work]:=====
This method will check if the invited user exists. Additionally, this method will also check if the sender himself is participating in the given assignment before they can send an invitation.

==End point description==

===create===
<pre>
Description: This route will create a new invitation record with default reply_status: w. w stands for waiting.
REST VERB: POST
Path: /invitations/

Response:

Success:
Status code: 200

```
{
{
"id": 11,
"reply_status": "W",
"created_at": "2023-04-20T21:33:29.580Z",
"updated_at": "2023-04-20T21:33:29.580Z",
"assignment": {
"id": 2,
"name": "oodd program3"
},
"from_user": {
"id": 2,
"name": "jhon",
"fullname": "jhon carmen",
"email": "example1@gmail.com"
},
"to_user": {
"id": 1,
"name": "katy",
"fullname": "katy shah",
"email": "example2@gmail.com"
}
}

```

Failure:
Status code: 422

```
{
error: @invitation.errors
}

```

</pre>

===index===

<pre>
Description: Get a list of all the invitations in the database.
REST VERB: GET
Path: /invitations/
Request: NA

Success
Status Code: 200
```
[
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
},
{
"id": 2,
"reply_status": "W",
"created_at": "2023-04-18T15:52:44.543Z",
"updated_at": "2023-04-18T15:52:44.543Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
},
"to_user": {
"id": 3,
"name": "rebecca",
"fullname": "rebecca fiat",
"email": "reb@gmail.com"
}
}
]

```

</pre>

===show===
<pre>
Description: Get a particular invite with the invite_id.
REST VERB: GET
Path: /invitations/<invite_id>
Request: NA
Response:

success
status code: 200
```
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}

```

Error
Status code: 404

```
{
"error": "Couldn't find Invitation with 'id'=1021321"
}
```
</pre>

===update===
<pre>
Description: This route will modify the status of the invitation to be accepted or declined
REST VERB: PATCH
Path: /invitations/<invite_id>/
Request:
```
{
"reply_status": ["A"/"R"],
}

```
Response:

Success
Status Code: 200

```
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}
```

Error
Status Code: 404/422

```
{
"error": @invitation.errors
}
```

</pre>

===destroy===
<pre>
Description: Delete the invitation
REST VERB: DELETE
Path: /invitations/<invite_id>
Request: NA
Response:

Success
Status code: 204 :no_content
Response: NA

Error
Status Code: 404
Response
```

{
"error": @invitation.errors
}

```

</pre>

===invitations_for_user_assignment===
<pre>
Description: Get the invitations for the user with id: user_id for the given assignment with id: assignment_id.
REST VERB: GET
Path: /invitations/<user_id>/<assingment_id>
Request: NA
Response:

Success
Status Code: 200 :ok

```
[
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
},
{
"id": 2,
"reply_status": "W",
"created_at": "2023-04-18T15:52:44.543Z",
"updated_at": "2023-04-18T15:52:44.543Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}
]

```

Error
Status Code: 404 :not_found

```
{
"error": @invitations.errors
}

```
</pre>

== End point summary ==
{| class="wikitable" style="margin-left:40px"
|-
! Sr No !! Method !! Endpoint !! Request Body !! Description
|-
| 1 || create || POST /invitations/||{ "assignment_id": INT, "from_id": INT, "to_id": INT, "reply_status": CHAR } ||Create a new invitation record with default reply_status: w, w stands for waiting.
|-
| 2 || index || GET /invitations/ || ||Get a list of all the invitations.
|-
| 3 || show || GET /invitations/<assignment_id> || || Get a particular invite with the invite_id.
|-
| 4 || update || PATCH /invitations/<invite_id>/ || { "reply_status":["A"/"R"] } || Modify the status of the invitation to be accepted or declined.
|-
| 5 || destroy || DELETE /invitations/<invite_id> || || Delete the invitation.
|-
| 6 || invitations_for_user_assignment || GET /invitations/<assignment_id> || || Get the invitations for the user with id: user_id for the given assignment with id: assignment_id

|}

= Testing Plan =

We utilized RSpec as the testing framework for our system. We have used factoryBot along with Faker to create model objects for testing. The development process has followed Test Driven Development. The tests for the model and the controller are written in a comprehensive way.

====Controller Tests====

To run the controller tests:

1. git clone

2. cd reimplementation-back-end/

3. bundle install

4. bundle exec rspec spec/requests/api/v1/invitation_controller_spec.rb

File: [https://github.com/rohitgeddam/reimplementation-back-end/blob/main/spec/requests/api/v1/invitation_controller_spec.rb invitation_controller_spec.rb]

{| class="wikitable" style="margin-left:30px"
|-
! Sr No !! Test !! Description
|-
| 1 || Test to list all Invitations || This test verifies if the system can successfully retrieve a list of all invitations available in the system.
|-
| 2 || Test to create an invitation with valid parameters || This test verifies if the system can successfully create an invitation with valid parameters such as 'to' user, 'from' user, assignment, and reply status.
|-
| 3 || Test to create an invitation with invalid 'to' user parameters' || This test verifies if the system can handle and reject an invitation creation request with invalid 'to' user parameters.
|-
| 4 || Test to create an invitation with invalid 'from' user parameters || This test verifies if the system can handle and reject an invitation creation request with invalid 'from' user parameters.
|-
| 5 || Test to create an invitation with invalid assignment parameters || This test verifies if the system can handle and reject an invitation creation request with invalid assignment parameters.
|-
| 6 || Test to create an invitation with invalid reply_status parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid reply_status parameter.
|-
| 7 || Test to create an invitation with same to user and from user parameters' || This test verifies if the system can handle and reject an invitation creation request with the same 'to' and 'from' user parameters.
|-
| 8 || Test to show invitation with valid invitation id || This test verifies if the system can successfully retrieve an invitation with a valid invitation id.
|-
| 9 || Test to show invitation with invalid invitation id || This test verifies if the system can handle and reject a request to retrieve an invitation with an invalid invitation id.
|-
| 10 || Test to accept invite successfully || This test verifies if the system can successfully update an invitation's reply status to 'accepted.'
|-
| 11 || Test to reject invite successfully || This test verifies if the system can successfully update an invitation's reply status to 'rejected.'
|-
| 12 || Test to update invitation with invalid reply_status || This test verifies if the system can handle and reject a request to update an invitation with an invalid reply_status parameter.
|-
| 13 || Test to update status with invalid invitation_id || This test verifies if the system can handle and reject a request to update the status of an invitation with an invalid invitation id.
|-
| 14 || Test to delete invitation with valid invite id || This test verifies if the system can successfully delete an invitation with a valid invitation id.
|-
| 15 || Test to delete invitation with invalid invite id || his test verifies if the system can handle and reject a request to delete an invitation with an invalid invitation id.
|-
| 16 || Test to show all invitations for the user for an assignment || This test verifies if the system can successfully retrieve all invitations for a specific user for a specific assignment.
|-
| 17 || Test to show invitation with invalid user and assignment || This test verifies if the system can handle and reject a request to retrieve an invitation with an invalid user and assignment.
|-
| 18 || Test to delete invitation with invalid invite idTest to Show invitation with user and invalid assignment || This test verifies if the system can handle and reject a request to delete an invitation with an invalid invitation id.
|-
| 19 ||Test to show invitation with invalid user and invalid assignment || This test verifies if the system can handle and reject a request to retrieve an invitation with a valid user and an invalid assignment.
|}

Rspec tests screenshot.
 
[[File:Dshah6_rspec_tests.png|900px]]

====Model Tests====

To run the model tests:

1. git clone

2. cd reimplementation-back-end/

3. bundle install

4. bundle exec rspec spec/models/invitation_spec.rb

File: [https://github.com/rohitgeddam/reimplementation-back-end/blob/main/spec/models/invitation_spec.rb invitation_spec.rb]

{| class="wikitable" style="margin-left:30px"
|-
! Sr No !! Test !!Test Description
|-
| 1 || Test to create an invitation with valid parameters.|| This test verifies if the system can successfully create an invitation with valid parameters such as 'to' user, 'from' user, assignment, and reply status.
|-
| 2 || Test to create an invitation with the same "to" and "from" user. || This test verifies if the system can handle and reject an invitation creation request with the same 'to' and 'from' user parameters.
|-
| 3 || Test to create an invitation with the invalid "to" user parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid 'to' user parameter.
|-
| 4 || Test to create an invitation with the invalid "from" user parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid 'from' user parameter.
|-
| 5 || Test to create an invitation with a invalid assignment argument. || This test verifies if the system can handle and reject an invitation creation request with an invalid assignment parameter.
|-
| 6 || Test to create an invitation with an invalid reply_status argument. || This test verifies if the system can handle and reject an invitation creation request with an invalid reply_status parameter.
|-
| 7 || Test to check is_invited? is a true case. || This test verifies if the system can correctly identify if a user has been invited to an assignment.
|-
| 8 || Test to check is_invited? is a false case. || This test verifies if the system can correctly identify if a user has not been invited to an assignment.
|-
| 9 || Test to check if the default reply_status for a new invitation is WAITING('W'). || This test verifies if the system can correctly set the default reply status to 'waiting' for a new invitation.
|-
| 10|| Test to check if invitation_factory returns new invitation. || This test verifies if the system can correctly create a new invitation using the invitation_factory method.
|-
| 11|| Test to check if invitation email is sent properly. || This test verifies if the system can successfully send an email invitation to the 'to' user.
|-
| 12|| Test to check if accept_invitation changes reply_status to 'A'. || This test verifies if the system can successfully update an invitation's reply status to 'accepted' using the accept_invitation method.
|-
| 13|| Test to check if decline_invitation changes reply_status to 'R'. || This test verifies if the system can successfully update an invitation's reply status to 'rejected' using the decline_invitation method.
|-
| 14|| Test to check if retract_invitation destroys the invitation. || This test verifies if the system can successfully delete an invitation using the retract_invitation method.
|-
| 15|| Test to check if as_json formats invitation as required. || This test verifies if the 'as_json' method can correctly format an invitation as JSON with the required fields such as 'to_user', 'from_user', 'assignment', 'reply_status', and 'id'. The test case creates an invitation with valid parameters and expects the 'as_json' method to include the required fields.
|-
|}

Rspec tests screenshot.
 
[[File:ROHIT_GEDDAM_Invitation_spec.png|900px]]

Test Coverage Report for Invitation model.
 
Our tests covers 100% of the lines in the Invitation model.
[[File:ROHIT_GEDDAM_Invitation_test_coverage.png|900px]]

== Swagger UI Screenshot ==

Swagger is used to provide an easy to use API documentation for the users of the API. It also provides an easy to use interface to interact with the API in the browser itself. You can use the swagger page to test out our API by clicking on the "Try it out" button next to each route.

path: /api-docs/

[[File:Dshah6_swagger.png|900px]]

= Files modified/created =

[[File:ROHIT_GEDDAM_FILES_CHANGED_APP.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_CONFIG.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_DB.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_SPEC.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_SWAGGER.png|300px]]

=Future Work=

Implement methods in invitation_controller.rb and invitation.rb. Some of the methods were not implemented due to dependency on other models which are not implemented yet. The dependency models need to be implemented first and then these methods can be implemented. We have left out the placeholder in the source code for such methods and a small explaination of what is expected from the future implementation of the method.

Authentication system is required for the working of invitation feature. Before performing any action related to invitation, authorization of the request must be done to make sure the user is able to perform the action requested.

 

===== Future work in invitation_controller.rb =====
<pre>check_invited_user_before_invitation</pre>
This method will check if the invited user exists. Additionally, this method will also check if the sender himself is participating in the given assignment before they can send an invitation.

<pre>check_participant_before_invitation</pre>
This method will check if the invited user is a participant in the assignment.

<pre>check_team_before_invitation</pre>
This method will check if the team meets the joining requirement before sending an invite.

<pre>check_team_before_accept</pre>
This method will check if the team meets the joining requirements when an invitation is being accepted for example check if the invite's team is still existing, and have available slot to add the invitee.

===== Future work in invitation.rb =====
<pre>update_users_topic_after_invite_accept</pre>
After a users accepts an invite, the teams_users table needs to be updated.

<pre>accept_invitation</pre>
This method handles all that needs to be done upon a user accepting an invitation.
Expected functionality: First the users previous team is deleted if they were the only member of that
team and topics that the old team signed up for will be deleted.
Then invites the user that accepted the invite sent will be removed.
Lastly the users team entry will be added to the TeamsUser table and their assigned topic is updated.

=References=

* [https://github.com/rohitgeddam/reimplementation-back-end/ Github Link]

* [https://github.com/expertiza/reimplementation-back-end/pull/32 Github Pull Request]

* [http://152.7.178.119:8080/ VCL Image Link]

* [http://rspec.info/documentation/3.8/rspec-core/ Rspec Documentation]

* [http://152.7.178.119:8080/api-docs/ Swagger UI]

* [https://youtu.be/nSSuKuOaFWE Demo Video]

=Team Members=

* Saigirishwar Rohit Geddam [sgeddam2]
* Keerthana Telaprolu [ktelapr]
* Dhrumil Shah [dshah6]

=Mentor=
Ankur Mundra [amundra]

CSC/ECE 517 Spring 2023 - E2330. Reimplement Invitation Controller

2023-04-24T23:07:46Z

Dshah6: /* Controller Tests */

==Project Overview==

===Expertiza Background===

Expertiza is an online platform designed to facilitate peer review and submission of various types of academic work, including articles, codes, and websites. The application allows instructors to add assignments, grade them, and assign students to teams based on their topic preferences. The platform also enables students to provide feedback on each other's work through peer reviews, which can be helpful in improving the quality of their projects. Expertiza is backed by the National Science Foundation.

===Problem Statement===

The Invitation model and InvitationsController are responsible for managing invitations between users in a team-based assignment system. The system allows a student to invite another student to their team by creating a new Invitation record, which is associated with the inviting and invited students and the assignment they are working on. The invited user can accept, decline, or cancel the invitation, which updates the corresponding Invitation record and may trigger actions such as adding or removing users from teams. The InvitationsController includes methods for creating, accepting, declining, and canceling invitations, as well as checking the status of the user and team before sending or accepting invitations. The system also sends email notifications to invited users when a new invitation is sent. Overall, the Invitation model and InvitationsController are crucial for managing team membership and collaboration in a team-based assignment system. Instructor’s note: There is already a project to merge this controller with the join_team_requests_controller. You should start with the code they have written.

==Objectives==
1. Write RESTful endpoints of create, show, delete to invitations and approving new invitations, listing pending invitations, creating new invitations, and notifying students about new team formation invite.

2. Develop and implement methods in the InvitationsController that enable the following functionality:Create invitations, Accept invitations, Decline invitations, Cancel invitations, and Check user and team status before sending or accepting invitations.

3. To implement a user-invitation system that allows invited users to accept, decline, or cancel invitations, which will update the corresponding Invitation record and trigger actions such as adding or removing users from teams.

4. Implement an email notification system in the user-invitation system, which sends email notifications to invited users when a new invitation is sent.

5. Return proper status codes and proper validation for RESTful endpoints.

6. Write models and controllers such that they use modern approaches to writing Ruby code, including utilizing language features and adhering to best practices for object-oriented design.

7. Write proper Rspec tests for all APIs, models, controllers.

== Development Strategy ==

We have tried to follow a Test Driven Development approach to implement both the Invitation model and the Invitation Controller.
Firstly a failing test case was written and then the code was added such that the test which was failing will pass now.

Also, we have tried to follow the rails philosophy of "Fat models" We have tried to move as much business logic from the controller to the model as possible. This will also help keep the controller code clean and encourage code reusability.

==Project Design and Implementation==

===Use Case Diagram ===
[[File:Usecasediagram1.png|800px]]

===Class Diagram ===
[[File:dshah6_UML_Diagram.png|900px]]

===Functionality===
In this project, we aim to add the following functions:

1. Enable users to create a new team invitation.

2. Enable users to Accept or Reject invitations.

3. Enable users to Retract invitations.

4. Enable users to send email notifications to invited users.

5. Ensure that data is validated properly in all the above APIs.

6. Test cases for all the above.

==Screen Shots==
===1. Send an invite ===
[[File:Dshah6_send_invite.png|900px]]

[[File:Dshah6_send_invite_2.png|900px]]

[[File:Dshah6_send_invite_3.png|900px]]

===2. Accept an invite===
[[File:Dshah6_accept_1.png|900px]]

[[File:Dshah6_accept_2.png|900px]]

[[File:Dshah6_accept_3.png|900px]]

===3. Reject invite===
[[File:Dshah6_decline_1.png|900px]]

[[File:Dshah6_decline_2.png|900px]]

===4. Retract invite===
[[File:Dshah6_retract_1.png|900px]]

===5. We retracted invitation of angel and malka and added ofelia===

[[File:Dshah6_retract_2.png|900px]]

= Project Design =

===Model===
The file invitation.rb defines the Invitation model which is a subclass of ApplicationRecord. The Invitation model has three foreign keys. to_user represents the user to whom the inviations is sent. from_user represents the user who is creating the invitation. assignment represents which assignment the invitation belongs to. reply_status represents whether the invitation is accepted, rejected or waiting. The default reply_status is waiting 'W'. There are also multiple validations defined for the various fields in this model. One of the important validation is to_from_cant_be_same validation, which prevents users from creating invitations to themselves. Moreover there are multiple helper methods defined for Invitations. These methods help keep the controller code short and clean. We are following the rails philosophy of "Fat Models". For the scope of this project the helper methods are kept simple, however once the project advances these helper methods need to be updated.

filename: invitation.rb
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/invitation.rb GitHub file Link to invitation.rb]

<pre>
class Invitation < ApplicationRecord
after_initialize :set_defaults

ACCEPT_STATUS = 'A'.freeze
REJECT_STATUS = 'R'.freeze
WAITING_STATUS = 'W'.freeze

belongs_to :to_user, class_name: 'User', foreign_key: 'to_id', inverse_of: false
belongs_to :from_user, class_name: 'User', foreign_key: 'from_id', inverse_of: false
belongs_to :assignment, class_name: 'Assignment', foreign_key: 'assignment_id'
validates :reply_status, presence: true, length: { maximum: 1 }
validates_inclusion_of :reply_status, in: [ACCEPT_STATUS, REJECT_STATUS, WAITING_STATUS], allow_nil: false
validates :assignment_id, uniqueness: {
scope: %i[from_id to_id reply_status],
message: 'You cannot have duplicate invitations'
}
validate :to_from_cant_be_same

# validate if the to_id and from_id are same
def to_from_cant_be_same
return unless from_id == to_id

errors.add(:from_id, 'to and from users should be different')
end

# Return a new invitation
# params = :assignment_id, :to_id, :from_id, :reply_status
def self.invitation_factory(params)
Invitation.new(params)
end

# check if the user is invited
def self.invited?(from_id, to_id, assignment_id)
@invitations_count = Invitation.where(to_id:)
.where(from_id:)
.where(assignment_id:)
.where(reply_status: WAITING_STATUS)
.count
@invitations_count.positive?
end

# send invite email
def send_invite_email
InvitationSentMailer.with(invitation: self)
.send_invitation_email
.deliver_later
end

# After a users accepts an invite, the teams_users table needs to be updated.
# NOTE: Depends on TeamUser model, which is not implemented yet.
def update_users_topic_after_invite_accept(_inviter_user_id, _invited_user_id, _assignment_id); end

# This method handles all that needs to be done upon a user accepting an invitation.
# Expected functionality: First the users previous team is deleted if they were the only member of that
# team and topics that the old team signed up for will be deleted.
# Then invites the user that accepted the invite sent will be removed.
# Lastly the users team entry will be added to the TeamsUser table and their assigned topic is updated.
# NOTE: For now this method simply updates the invitation's reply_status.
def accept_invitation(_logged_in_user)
update(reply_status: ACCEPT_STATUS)
end

# This method handles all that needs to be done upon an user declining an invitation.
def decline_invitation(_logged_in_user)
update(reply_status: REJECT_STATUS)
end

# This method handles all that need to be done upon an invitation retraction.
def retract_invitation(_logged_in_user)
destroy
end

# This will override the default as_json method in the ApplicationRecord class and specify
def as_json(options = {})
super(options.merge({
only: %i[id reply_status created_at updated_at],
include: {
assignment: { only: %i[id name] },
from_user: { only: %i[id name fullname email] },
to_user: { only: %i[id name fullname email] }
}
})).tap do |hash|
end
end

def set_defaults
self.reply_status ||= WAITING_STATUS
end
end
</pre>

===Helper Methods in Invitation model.===

====to_from_cant_be_same:====
Validate if the to_id and from_id are same i.e a users cannot send invitations to themselves.

====self.invitation_factory(params):====
This helper method will help in creating new Invitation with the given parameters. Custom parameters can be passed to create specific Invitation.

====self.invited?(from_id, to_id, assignment_id):====
Check if the user is invited given the from_id, to_id, and assignment_id. This is a class method to make it more generic and can be used by other classes.

====send_invite_email:====
This method uses the InvitaionSentMailer to send invitation emails to the invited user.

====update_users_topic_after_invite_accept(inviter_user_id, invited_user_id, assignment_id) [Future work]:====
After a users accepts an invite, the teams_users table needs to be updated.
NOTE: Depends on TeamUser model, which is not implemented yet.

====accept_invitation:====
This method handles all that needs to be done upon a user accepting an invitation.

====decline_invitation:====
This method handles all that needs to be done upon an user decline an invitation.

====retract_invitation:====
This method handles all that need to be done upon an invitation retraction.

====as_json:====
This will override the default as_json method in the ApplicationRecord class and specify

====set_defaults:====
This will be used to set default parameters when creating new Invitation.

Changes in models/user.rb
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/user.rb GitHub Link to user.rb file]
 
A user can have many invitations therefore we added a has_many relationship in the user model. On the other hand in the invitation model we added belongs_to relationship with the user model.

<pre>
# added the following relations in the user.rb file.
has_many :invitations
</pre>
Changes in models/assignment.rb
 

[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/models/assignment.rb GitHub Link to assignment.rb file]
 
An assignment can have many invitations therefore we added a has_many relationship in the assignment model. On the other hand in the invitation model we added belongs_to relationship with the assignment model.

<pre>
# added the following relations in the assignment.rb file.
class Assignment < ApplicationRecord
has_many :invitations
end
</pre>

Schema
 
[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/db/schema.rb GitHub Link to scheme.rb file]
 
The invitation schema has three foreign keys. The foreign keys are "assignment_id", "from_id", "to_id". from_id and to_id are foreign keys to user model.

<pre>
create_table "invitations", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
t.integer "assignment_id"
t.integer "from_id"
t.integer "to_id"
t.string "reply_status", limit: 1
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["assignment_id"], name: "fk_invitation_assignments"
t.index ["from_id"], name: "fk_invitationfrom_users"
t.index ["to_id"], name: "fk_invitationto_users"
end
</pre>

===Controllers===
We create a new controller at app/controllers/invitation_controller.rb with following methods:
[Implementation of the invitation controller[https://github.com/rohitgeddam/reimplementation-back-end/blob/main/app/controllers/api/v1/invitations_controller.rb]]
===REST Route methods===
=====create:=====
This will create a new invitation record.
=====index:=====
This will give a list of all the invitations
=====show:=====
This will be used to show a particular invitation with given invitation_id.
=====update:=====
This will be used to update the status of the current invitation. Either accepted or rejected
=====destroy:=====
This will be used to delete the invitation that is already sent to another participant using particular invite_id.
=====invitations_for_user_assignment:=====
This will be used to get all the invitations for a particular assignment for a particular student.

=== Helper methods ===
=====check_team_before_accept [Future work]:=====
This method will check if the team meets the joining requirements when an invitation is being accepted for example check if the invite's team is still existing, and have available slot to add the invitee.

=====check_team_before_invitation [Future work]:=====
This method will check if the team meets the joining requirement before sending an invite.

=====check_participant_before_invitation [Future work]:=====
This method will check if the invited user is a participant in the assignment.

=====check_user_before_invitation [Future work]:=====
This method will check if the invited user exists. Additionally, this method will also check if the sender himself is participating in the given assignment before they can send an invitation.

==End point description==

===create===
<pre>
Description: This route will create a new invitation record with default reply_status: w. w stands for waiting.
REST VERB: POST
Path: /invitations/

Response:

Success:
Status code: 200

```
{
{
"id": 11,
"reply_status": "W",
"created_at": "2023-04-20T21:33:29.580Z",
"updated_at": "2023-04-20T21:33:29.580Z",
"assignment": {
"id": 2,
"name": "oodd program3"
},
"from_user": {
"id": 2,
"name": "jhon",
"fullname": "jhon carmen",
"email": "example1@gmail.com"
},
"to_user": {
"id": 1,
"name": "katy",
"fullname": "katy shah",
"email": "example2@gmail.com"
}
}

```

Failure:
Status code: 422

```
{
error: @invitation.errors
}

```

</pre>

===index===

<pre>
Description: Get a list of all the invitations in the database.
REST VERB: GET
Path: /invitations/
Request: NA

Success
Status Code: 200
```
[
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
},
{
"id": 2,
"reply_status": "W",
"created_at": "2023-04-18T15:52:44.543Z",
"updated_at": "2023-04-18T15:52:44.543Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
},
"to_user": {
"id": 3,
"name": "rebecca",
"fullname": "rebecca fiat",
"email": "reb@gmail.com"
}
}
]

```

</pre>

===show===
<pre>
Description: Get a particular invite with the invite_id.
REST VERB: GET
Path: /invitations/<invite_id>
Request: NA
Response:

success
status code: 200
```
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}

```

Error
Status code: 404

```
{
"error": "Couldn't find Invitation with 'id'=1021321"
}
```
</pre>

===update===
<pre>
Description: This route will modify the status of the invitation to be accepted or declined
REST VERB: PATCH
Path: /invitations/<invite_id>/
Request:
```
{
"reply_status": ["A"/"R"],
}

```
Response:

Success
Status Code: 200

```
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}
```

Error
Status Code: 404/422

```
{
"error": @invitation.errors
}
```

</pre>

===destroy===
<pre>
Description: Delete the invitation
REST VERB: DELETE
Path: /invitations/<invite_id>
Request: NA
Response:

Success
Status code: 204 :no_content
Response: NA

Error
Status Code: 404
Response
```

{
"error": @invitation.errors
}

```

</pre>

===invitations_for_user_assignment===
<pre>
Description: Get the invitations for the user with id: user_id for the given assignment with id: assignment_id.
REST VERB: GET
Path: /invitations/<user_id>/<assingment_id>
Request: NA
Response:

Success
Status Code: 200 :ok

```
[
{
"id": 1,
"reply_status": "A",
"created_at": "2023-04-13T17:22:09.805Z",
"updated_at": "2023-04-19T00:06:33.718Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 2,
"name": "katy",
"fullname": "katy kimson",
"email": "kt@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
},
{
"id": 2,
"reply_status": "W",
"created_at": "2023-04-18T15:52:44.543Z",
"updated_at": "2023-04-18T15:52:44.543Z",
"assignment": {
"id": 1,
"name": "program4"
},
"from_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
},
"to_user": {
"id": 1,
"name": "john",
"fullname": "john fella",
"email": "john@gmail.com"
}
}
]

```

Error
Status Code: 404 :not_found

```
{
"error": @invitations.errors
}

```
</pre>

== End point summary ==
{| class="wikitable" style="margin-left:40px"
|-
! Sr No !! Method !! Endpoint !! Request Body !! Description
|-
| 1 || create || POST /invitations/||{ "assignment_id": INT, "from_id": INT, "to_id": INT, "reply_status": CHAR } ||Create a new invitation record with default reply_status: w, w stands for waiting.
|-
| 2 || index || GET /invitations/ || ||Get a list of all the invitations.
|-
| 3 || show || GET /invitations/<assignment_id> || || Get a particular invite with the invite_id.
|-
| 4 || update || PATCH /invitations/<invite_id>/ || { "reply_status":["A"/"R"] } || Modify the status of the invitation to be accepted or declined.
|-
| 5 || destroy || DELETE /invitations/<invite_id> || || Delete the invitation.
|-
| 6 || invitations_for_user_assignment || GET /invitations/<assignment_id> || || Get the invitations for the user with id: user_id for the given assignment with id: assignment_id

|}

= Testing Plan =

We utilized RSpec as the testing framework for our system. We have used factoryBot along with Faker to create model objects for testing. The development process has followed Test Driven Development. The tests for the model and the controller are written in a comprehensive way.

====Controller Tests====

To run the controller tests:

1. git clone

2. cd reimplementation-back-end/

3. bundle install

4. bundle exec rspec spec/requests/api/v1/invitation_controller_spec.rb

File: [https://github.com/rohitgeddam/reimplementation-back-end/blob/main/spec/requests/api/v1/invitation_controller_spec.rb invitation_controller_spec.rb]

{| class="wikitable" style="margin-left:30px"
|-
! Sr No !! Test !! Description
|-
| 1 || Test to list all Invitations || This test verifies if the system can successfully retrieve a list of all invitations available in the system.
|-
| 2 || Test to create an invitation with valid parameters || This test verifies if the system can successfully create an invitation with valid parameters such as 'to' user, 'from' user, assignment, and reply status.
|-
| 3 || Test to create an invitation with invalid 'to' user parameters' || This test verifies if the system can handle and reject an invitation creation request with invalid 'to' user parameters.
|-
| 4 || Test to create an invitation with invalid 'from' user parameters || This test verifies if the system can handle and reject an invitation creation request with invalid 'from' user parameters.
|-
| 5 || Test to create an invitation with invalid assignment parameters || This test verifies if the system can handle and reject an invitation creation request with invalid assignment parameters.
|-
| 6 || Test to create an invitation with invalid reply_status parameter || This test verifies if the system can handle and reject an invitation creation request with an invalid reply_status parameter.
|-
| 7 || Test to create an invitation with same to user and from user parameters' || This test verifies if the system can handle and reject an invitation creation request with the same 'to' and 'from' user parameters.
|-
| 8 || Test to show invitation with valid invitation id || This test verifies if the system can successfully retrieve an invitation with a valid invitation id.
|-
| 9 || Test to show invitation with invalid invitation id || This test verifies if the system can handle and reject a request to retrieve an invitation with an invalid invitation id.
|-
| 10 || Test to accept invite successfully || This test verifies if the system can successfully update an invitation's reply status to 'accepted.'
|-
| 11 || Test to reject invite successfully || This test verifies if the system can successfully update an invitation's reply status to 'rejected.'
|-
| 12 || Test to update invitation with invalid reply_status || This test verifies if the system can handle and reject a request to update an invitation with an invalid reply_status parameter.
|-
| 13 || Test to update status with invalid invitation_id || This test verifies if the system can handle and reject a request to update the status of an invitation with an invalid invitation id.
|-
| 14 || Test to delete invitation with valid invite id || This test verifies if the system can successfully delete an invitation with a valid invitation id.
|-
| 15 || Test to delete invitation with invalid invite id || his test verifies if the system can handle and reject a request to delete an invitation with an invalid invitation id.
|-
| 16 || Test to show all invitations for the user for an assignment || This test verifies if the system can successfully retrieve all invitations for a specific user for a specific assignment.
|-
| 17 || Test to show invitation with invalid user and assignment || This test verifies if the system can handle and reject a request to retrieve an invitation with an invalid user and assignment.
|-
| 18 || Test to delete invitation with invalid invite idTest to Show invitation with user and invalid assignment || This test verifies if the system can handle and reject a request to delete an invitation with an invalid invitation id.
|-
| 19 ||Test to show invitation with invalid user and invalid assignment || This test verifies if the system can handle and reject a request to retrieve an invitation with a valid user and an invalid assignment.
|}

Rspec tests screenshot.
 
[[File:Dshah6_rspec_tests.png|900px]]

====Model Tests====

To run the model tests:

1. git clone

2. cd reimplementation-back-end/

3. bundle install

4. bundle exec rspec spec/models/invitation_spec.rb

File: [https://github.com/rohitgeddam/reimplementation-back-end/blob/main/spec/models/invitation_spec.rb invitation_spec.rb]

{| class="wikitable" style="margin-left:30px"
|-
! Sr No !! Test Description
|-
| 1 || Test to create an invitation with valid parameters.
|-
| 2 || Test to create an invitation with the same "to" and "from" user.
|-
| 3 || Test to create an invitation with the invalid "to" user parameter
|-
| 4 || Test to create an invitation with the invalid "from" user parameter
|-
| 5 || Test to create an invitation with a invalid assignment argument.
|-
| 6 || Test to create an invitation with an invalid reply_status argument.
|-
| 7 || Test to check is_invited? is a true case.
|-
| 8 || Test to check is_invited? is a false case.
|-
| 9 || Test to check if the default reply_status for a new invitation is WAITING('W').
|-
| 10|| Test to check if invitation_factory returns new invitation.
|-
| 11|| Test to check if invitation email is sent properly.
|-
| 12|| Test to check if accept_invitation changes reply_status to 'A'.
|-
| 13|| Test to check if decline_invitation changes reply_status to 'R'.
|-
| 14|| Test to check if retract_invitation destroys the invitation.
|-
| 15|| Test to check if as_json formats invitation as required.
|-
|}

Rspec tests screenshot.
 
[[File:ROHIT_GEDDAM_Invitation_spec.png|900px]]

Test Coverage Report for Invitation model.
 
Our tests covers 100% of the lines in the Invitation model.
[[File:ROHIT_GEDDAM_Invitation_test_coverage.png|900px]]

== Swagger UI Screenshot ==

Swagger is used to provide an easy to use API documentation for the users of the API. It also provides an easy to use interface to interact with the API in the browser itself. You can use the swagger page to test out our API by clicking on the "Try it out" button next to each route.

path: /api-docs/

[[File:Dshah6_swagger.png|900px]]

= Files modified/created =

[[File:ROHIT_GEDDAM_FILES_CHANGED_APP.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_CONFIG.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_DB.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_SPEC.png|300px]]

[[File:ROHIT_GEDDAM_FILES_CHANGED_SWAGGER.png|300px]]

=Future Work=

Implement methods in invitation_controller.rb and invitation.rb. Some of the methods were not implemented due to dependency on other models which are not implemented yet. The dependency models need to be implemented first and then these methods can be implemented. We have left out the placeholder in the source code for such methods and a small explaination of what is expected from the future implementation of the method.

Authentication system is required for the working of invitation feature. Before performing any action related to invitation, authorization of the request must be done to make sure the user is able to perform the action requested.

 

===== Future work in invitation_controller.rb =====
<pre>check_invited_user_before_invitation</pre>
This method will check if the invited user exists. Additionally, this method will also check if the sender himself is participating in the given assignment before they can send an invitation.

<pre>check_participant_before_invitation</pre>
This method will check if the invited user is a participant in the assignment.

<pre>check_team_before_invitation</pre>
This method will check if the team meets the joining requirement before sending an invite.

<pre>check_team_before_accept</pre>
This method will check if the team meets the joining requirements when an invitation is being accepted for example check if the invite's team is still existing, and have available slot to add the invitee.

===== Future work in invitation.rb =====
<pre>update_users_topic_after_invite_accept</pre>
After a users accepts an invite, the teams_users table needs to be updated.

<pre>accept_invitation</pre>
This method handles all that needs to be done upon a user accepting an invitation.
Expected functionality: First the users previous team is deleted if they were the only member of that
team and topics that the old team signed up for will be deleted.
Then invites the user that accepted the invite sent will be removed.
Lastly the users team entry will be added to the TeamsUser table and their assigned topic is updated.

=References=

* [https://github.com/rohitgeddam/reimplementation-back-end/ Github Link]

* [https://github.com/expertiza/reimplementation-back-end/pull/32 Github Pull Request]

* [http://152.7.178.119:8080/ VCL Image Link]

* [http://rspec.info/documentation/3.8/rspec-core/ Rspec Documentation]

* [http://152.7.178.119:8080/api-docs/ Swagger UI]

* [https://youtu.be/nSSuKuOaFWE Demo Video]

=Team Members=

* Saigirishwar Rohit Geddam [sgeddam2]
* Keerthana Telaprolu [ktelapr]
* Dhrumil Shah [dshah6]

=Mentor=
Ankur Mundra [amundra]

CSC/ECE 517 Spring 2023

2023-04-22T14:49:33Z

Dshah6: /* OSS Projects */

== OSS Projects ==

[[CSC/ECE 517 Spring_2023 -E2306. Refactor user_controller.rb, user.rb and its child classes]]

[[CSC/ECE 517 Spring_2023 - E2320. Reimplement the Question hierarchy]]

[[CSC/ECE 517 Spring_2023 - E2312 + E2313. Reimplement response.rb and responses_controller.rb]]

[[CSC/ECE 517 Spring_2023 - NTNX-1. Support provisioning MongoDb via NDB Kubernetes Operator]]

[[CSC/ECE 517 Spring_2023 - E2316. Reimplement sign_up_sheet_controller.rb]]

[[CSC/ECE 517 Spring_2023 - E2315. Reimplement signed_up_team.rb, sign_up_topic.rb, sign_up_sheet.rb]]

[[CSC/ECE 517 Spring_2023 - E2339. Reimplement signed_up_team.rb, sign_up_topic.rb, sign_up_sheet.rb (Project 4)]]

[[CSC/ECE 517 Spring_2023 - E2323. Refactor DueDate functionality from assignment.rb]]

[[CSC/ECE 517 Spring 2023 - E2317: Reimplement participant.rb]]

[[CSC/ECE 517 Spring 2023 - E2314. Reimplement the response map hierarchy]]

[[CSC/ECE 517 Spring 2023- NTNX-4. Extend NDB operator provision postregresql aws]]

[[CSC/ECE 517 Spring 2023 - E2321. Reimplement QuestionnairesController and QuestionsController]]

[[CSC/ECE 517 Spring 2023 - E2305. Grading audit trail]]

[[CSC/ECE 517 Spring 2023 - E2329. Grading audit trail(Project 4)]]

[[CSC/ECE 517 Spring 2023 - E2309. Refactor Node model and its subclasses]]

[[CSC/ECE 517 Spring 2023 - NTNX-2. Support provisioning mySQL databases via NDB Kubernetes Operator]]

[[CSC/ECE 517 Spring 2023 - E2300. Refactor E1858. Github metrics integration]]

[[CSC/ECE 517 Sping 2023 - E2322: Refactor Questionnaire View to display Bookmark Rating]]

[[CSC/ECE 517 Spring 2023 - NTNX-3. Refactor models to keep profiles (software, compute, network, etc) as optional and use default if not specified]]

[[CSC/ECE_517_Spring_2023_-_E2301._Refactor_review_maping_helper]]

[[CSC/ECE_517_Spring_2023_-_E2330._Reimplement_Invitation_Controller]]

[[CSC/ECE_517_Spring_2023_-_E2337._Reimplement_node_hierarchy]]

[[CSC/ECE_517_Spring_2023_-_E2338._Reimplement_the_response_map_hierarchy]]

[[CSC/ECE_517_Spring_2023_-E2339._Reimplement signed_up_teams_controller and sign_up_topics_controller.rb]]

[[CSC/ECE_517_Spring_2023_-_E2320._Reimplement the Question Hierarchy]]

[[CSC/ECE_517_Spring_2023 - E2341. UI for Participants.rb]]

[[CSC/ECE_517_Spring_2023_-_E2336._Reimplement_response.rb]]

[[CSC/ECE_517_Spring_2023_-_E2345._Reimplement_QuestionnairesController_and_QuestionsController]]

CSC/ECE 517 Spring 2023 - E2330. Reimplement Invitation Controller

2023-04-22T14:35:04Z

Dshah6:

File:Dshah6 swagger.png

2023-04-20T22:30:17Z

Dshah6:

File:Dshah6 rspec test2.png

2023-04-20T22:30:03Z

Dshah6:

File:Dshah6 rspec tests.png

2023-04-20T22:26:05Z

Dshah6:

File:Dshah6 UML Diagram.png

2023-04-20T21:06:48Z

Dshah6:

CSC/ECE 517 Spring 2023 - E2330. Reimplement Invitation Controller

2023-04-16T19:11:55Z

Dshah6: Blanked the page

File:Dshah6 decline 2.png

2023-04-07T19:19:42Z

Dshah6:

File:Dshah6 decline 1.png

2023-04-07T19:19:20Z

Dshah6:

File:Dshah6 retract 2.png

2023-04-07T18:16:17Z

Dshah6:

File:Dshah6 retract 1.png

2023-04-07T18:15:41Z

Dshah6:

File:Dshah6 decision ar.png

2023-04-07T18:04:47Z

Dshah6:

File:Dshah6 assignment created.png

2023-04-07T18:04:27Z

Dshah6:

File:Dshah6 accept 2.png

2023-04-07T18:04:11Z

Dshah6:

File:Dshah6 accept 1.png

2023-04-07T18:03:55Z

Dshah6:

File:Dshah6 send invite 2.png

2023-04-07T17:59:19Z

Dshah6:

File:Dshah6 send invite.png

2023-04-07T17:56:48Z

Dshah6:

File:Dshah6 Screenshot 2023-04-07 at 1.19.40 PM.png

2023-04-07T17:51:52Z

Dshah6:

File:Dshah6 Screenshot 2023-04-07 at 1.03.36 PM.png

2023-04-07T17:48:41Z

Dshah6:

File:Dshah6 Screenshot 2023-04-07 at 1.02.42 PM.png

2023-04-07T17:48:15Z

Dshah6:

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T03:48:30Z

Dshah6: /* Test Coverage */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>Since this is a refactoring project no new features were introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. The main objective of our task was to refactor the user-related methods so that the existing tests pass. New tests have been created, and they along with existing tests run successfully indicating that the code still functions properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
<be>

'''Tests for show_if_authorized: '''

Added additional tests for show_if_authorized function in user controller file. The test redirects to lists and sets a flash message if user doesn't exit
 
[[File:tests_pic_2.png| 1000px]]
<be>

==Test Coverage==

Test coverage has been increased by 39.5% as it can be seen in the PR.

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T03:48:03Z

Dshah6: /* Test Coverage */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>Since this is a refactoring project no new features were introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. The main objective of our task was to refactor the user-related methods so that the existing tests pass. New tests have been created, and they along with existing tests run successfully indicating that the code still functions properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
<be>

'''Tests for show_if_authorized: '''

Added additional tests for show_if_authorized function in user controller file. The test redirects to lists and sets a flash message if user doesn't exit
 
[[File:tests_pic_2.png| 1000px]]
<be>

==Test Coverage==

'''Test coverage: '''
Test coverage has been increased by 39.5% as it can be seen in the PR.

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T03:46:26Z

Dshah6: /* Test Coverage */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>Since this is a refactoring project no new features were introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. The main objective of our task was to refactor the user-related methods so that the existing tests pass. New tests have been created, and they along with existing tests run successfully indicating that the code still functions properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
<be>

'''Tests for show_if_authorized: '''

Added additional tests for show_if_authorized function in user controller file. The test redirects to lists and sets a flash message if user doesn't exit
 
[[File:tests_pic_2.png| 1000px]]
<be>

==Test Coverage==

'''Test coverage: '''

 
[[File:ssRohit.png| 1000px]]
 
Test coverage has been increased by 39.5% as it can be seen in the PR.

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T03:43:58Z

Dshah6: /* Test Plan */

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T03:42:58Z

Dshah6: /* Test Coverage */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>Since this is a refactoring project no new features were introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. New tests have been created, and they along with existing tests run successfully indicating that the code still functions properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
<be>

'''Tests for show_if_authorized: '''

Added additional tests for show_if_authorized function in user controller file. The test redirects to lists and sets a flash message if user doesn't exit
 
[[File:tests_pic_2.png| 1000px]]
<be>

==Test Coverage==

Test coverage has been increased by 39.5% as it can be seen in the PR.

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T03:41:28Z

Dshah6: /* Test Coverage */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>Since this is a refactoring project no new features were introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. New tests have been created, and they along with existing tests run successfully indicating that the code still functions properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
<be>

'''Tests for show_if_authorized: '''

Added additional tests for show_if_authorized function in user controller file. The test redirects to lists and sets a flash message if user doesn't exit
 
[[File:tests_pic_2.png| 1000px]]
<be>

==Test Coverage==
 
[[File:dshah6_photo33.png| 1000px]]
 
Test coverage has been increased by 30%

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T03:39:28Z

Dshah6:

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>Since this is a refactoring project no new features were introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. New tests have been created, and they along with existing tests run successfully indicating that the code still functions properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
<be>

'''Tests for show_if_authorized: '''

Added additional tests for show_if_authorized function in user controller file. The test redirects to lists and sets a flash message if user doesn't exit
 
[[File:tests_pic_2.png| 1000px]]
<be>

==Test Coverage==
 
[[File:test_coverage_rohit.png| 1000px]]
<be>
Test coverage has been increased by 30%

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T03:32:37Z

Dshah6: /* Test Plan */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>Since this is a refactoring project no new features were introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. New tests have been created, and they along with existing tests run successfully indicating that the code still functions properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
<be>

'''Tests for show_if_authorized: '''

Added additional tests for show_if_authorized function in user controller file. The test redirects to lists and sets a flash message if user doesn't exit
 
[[File:tests_pic_2.png| 1000px]]
 

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T02:10:25Z

Dshah6: /* Additional Tests Added */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
<be>

'''Tests for show_if_authorized: '''

Added additional tests for show_if_authorized function in user controller file. The test redirects to lists and sets a flash message if user doesn't exit
 
[[File:tests_pic_2.png| 1000px]]
 

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

File:Tests pic 2.png

2023-03-28T02:07:37Z

Dshah6:

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T01:56:23Z

Dshah6: /* Additional Tests Added */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

'''Tests added for yesorno method: '''

Added additional tests for yesorno function in User Helper file
 
[[File:tests_pic_1.png| 1000px]]
 

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

File:Tests pic 1.png

2023-03-28T01:54:45Z

Dshah6:

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T01:50:45Z

Dshah6: /* Description of the Refactored Changes */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-28T01:49:53Z

Dshah6:

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

== Additional Tests Added ==

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

==Relevant Links==
GitHub PR [[https://github.com/expertiza/expertiza/pull/2525]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-22T22:49:14Z

Dshah6: /* Description of the Refactored Changes */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes ==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
 

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-22T22:07:32Z

Dshah6: /* Description of the Refactored Changes: */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes:==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2_dshah6.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
 

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-22T19:10:04Z

Dshah6: /* Description of the Refactored Changes: */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes:==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:pic1_dshah6.png| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2_dshah6.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
<be>

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
<be>

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
<be>

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
<be>

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
<be>

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
<be>

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
<be>

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
<be>

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
<be>

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
<be>

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

File:Pic1 dshah6.png

2023-03-22T19:08:51Z

Dshah6:

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-22T19:06:20Z

Dshah6: /* Description of the Refactored Changes: */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes:==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.
 
[[File:e2306_get_role.PNG| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2_dshah6.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
<be>

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
<be>

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
<be>

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
<be>

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
<be>

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
<be>

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
<be>

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
<be>

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
<be>

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
<be>

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-22T19:05:32Z

Dshah6: /* Description of the Refactored Changes: */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes:==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.

 
[[File:e2306_get_role.PNG| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2_dshah6.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
<be>

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
<be>

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
<be>

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
<be>

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
<be>

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
<be>

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
<be>

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
<be>

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
<be>

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
<be>

'''refactor get_user_list method in instructor.rb '''
 
[[File:pic21_dshah6.png| 1000px]]
<be>

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

CSC/ECE 517 Spring 2023 -E2306. Refactor user controller.rb, user.rb and its child classes

2023-03-22T18:34:21Z

Dshah6: /* Description of the Refactored Changes: */

== Introduction ==

<nowiki>The User model is a crucial component of the Expertiza application, managing user data and authentication/authorization. It has 9 class methods, 23 instance methods, and is linked with other models for personalized user experience. The user controller is smaller but could benefit from refactoring and improved comments.</nowiki>

==Files Changes==
#app/models/user.rb
#app/models/instructor.rb
#app/models/ta.rb
#app/models/superadministrator.rb
#app/controller/user_controller.rb

== Test Plan==
<nowiki>There have been no new features introduced and any modifications made were focused on refactoring the code and eliminating redundant elements. No new tests have been created, but the existing ones have been verified to ensure they still function properly.</nowiki>

==Modifications made==
# Refactor can_impersonate? method in user.rb
# Refactor recursively_parent_of? method by shorting
# Refactor teaching_assistant_for? method by shorting
# Refactor validate methods in user.rb
# Removed unused method salt_first?
# Bug fix in teaching_assistant_for? method
# Remove unused method creator_of? in user.rb
# Refactor get_user_list method in instructor.rb
# Removed unused scope in user.rb
# Removed redundant delete calls in user_controller#destroy
# Removed params.permit! by passing required params in user_params
# Refactor user_controller#show_if_authorized
# Refactor user_controller#create method
# Extracted anonymized methods from user.rb to anonymized_helpers.rb
# Renamed get_available_users to get_visible_users_with_lesser_roles to
# Replace delegate methods in user.rb to follows same method style
# Refactor yesorno method in UserHelper method
# Rename method foreign to get_roles

== Description of the Refactored Changes:==
'''Rename method foreign to get_roles: '''

Renamed the method foreign in a precise manner so that it describes the functionality of the method, as the method foreign gets the role of the User.

 
[[File:e2306_get_role.PNG| 1000px]]
 

'''Refactor yesorno method in UserHelper method: '''
Removed redundant lines of code in the yesorno method and made changes in the code in such a way that the code looks cleaner and describable.
 
[[File:pic2_dshah6.png| 1000px]]
 
To make it more concise, we added a return statement for the functionality of the method.
 
[[File:pic3_dshah6.png| 1000px]]
 

'''Replace delegate methods in user.rb to follows same method style: '''
Replaced all the delegate methods in the user model to make every function of the model to be in the similar fashion. This change increases the code readability.
 
[[File:pic4_dshah6.png| 1000px]]
 

'''Renamed get_available_users to get_visible_users_with_lesser_roles to: '''
Replaced all the occurrences of the ‘get_available_users’ to ‘get_visible_users_with_lesser_roles’ as the method is obtaining results of the users with roles and not the available users. This change makes the function more descriptive on what the method is returning.
 
[[File:pic5_dshah6.png| 1000px]]
 

'''Extracted anonymized methods from user.rb to anonymized_helpers.rb: '''
Created a separate module named AnonymizedHelper with the details extracted from the anonymized view in the user model and then included the module in the user model for the extraction of the anonymized view from the model.
 
[[File:pic6_dshah6.png| 1000px]]
 

'''Refactor user_controller#show_if_authorized:'''
Refactored the user controller method by removing redundant statements.
 
[[File:pic7_dshah6.png| 1000px]]
 

'''Refactor user_controller#create method:'''
Refactored the create method in the user_controller by adding appropriate functions separately rather including many lines of code into the single functions and enhancing the readability of the method.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic8_dshah6.png| 1000px]]
 

'''Removed redundant delete calls in user_controller#destroy:'''
Removed all the redundant lines of code from the destroy method in the user controller.
 
[[File:pic9_dshah6.png| 1000px]]
 

'''Removed params.permit! by passing required params in user_params:'''
Removed the params.permit! statement and included them while passing the user_params.
 
[[File:pic10_dshah6.png| 1000px]]
 

'''Removed unused scope in user.rb:'''
Removed all the unused redundant scope variables from the user model.
 
[[File:pic11_dshah6.png| 1000px]]
 

'''Refactor can_impersonate? method in user.rb:'''
Removed all the extra lines of code and refactored it to a single line statement to determine the can_impersonate user function.
 
[[File:pic12_dshah6.png| 1000px]]
 

'''Refactor recursively_parent_of? method by shorting:'''
Removed and deduced the code present in the recursively_parent function into a single statement.
 
[[File:pic13_dshah6.png| 1000px]]
 

'''Refactor teaching_assistant_for? method by shorting:'''
Reduce the code size of teaching_assistant_for? Function by using an or operator to combine two separate return statements.
 
[[File:pic14_dshah6.png| 1000px]]
 

'''Refactor validate methods in user.rb'''
Reduced the code size by combining multiple validation attributes written separately into one line validation containing all attributes.
 
[[File:pic15_dshah6.png| 1000px]]
 

'''removed unused method salt_first? In user.rb and user_spec.rb'''
Removed salt_first? Function in user.rb and its tests in user_spec.rb as it doesn’t have any it is not used for any functionality of the app
 
[[File:pic16_dshah6.png| 1000px]]
 
 
[[File:pic17_dshah6.png| 1000px]]
 

'''bug fix in teaching_assistant_for? Method in user.rb'''
Bug cause by the code written by us was fixed in this commit
 
[[File:pic18_dshah6.png| 1000px]]
 

'''remove unused method creator_of? in user.rb'''
creator_of function is removed from user.rb as it doesn’t contribute to the functionality of app and its test in user_spec.rb are also deleted.
 
[[File:pic19_dshah6.png| 1000px]]
 
 
[[File:pic20_dshah6.png| 1000px]]
 

'''refactor get_user_list method in instructor.rb'''
 
[[File:pic21_dshah6.png| 1000px]]
 

==Project Mentor==
Ankur Mundra[[(amundra@ncsu.edu)]]

==Contributors to this project==

Dhrumil Jignesh Shah [[(dshah6@ncsu.edu)]]
Keerthana Telaprolu [[(ktelapr@ncsu.edu)]]
Saigirishwar Rohit Geddam [[(sgeddam2@ncsu.edu)]]

File:Pic21 dshah6.png

2023-03-22T18:08:06Z

Dshah6:

File:Pic20 dshah6.png

2023-03-22T18:07:52Z

Dshah6:

File:Pic19 dshah6.png

2023-03-22T18:07:40Z

Dshah6:

File:Pic18 dshah6.png

2023-03-22T18:07:29Z

Dshah6:

File:Pic17 dshah6.png

2023-03-22T18:07:18Z

Dshah6: