Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments

2020-10-28T02:27:53Z

Draghun: /* Proposed Design */

This wiki page describes the changes made under E2075, to ensure calibration submissions are copied along with calibration assignments for CSC/ECE 517, Fall 2020.

__TOC__

== About Expertiza ==
Expertiza is an open source project based on Ruby on Rails framework, created and maintained by the joint efforts of students and faculty at North Carolina State University.

It allows the instructors to create new assignments and customize new or existing assignments. Expertiza also allows an instructor to create a list of topics the students can sign up for. Students can form teams on the web application to work on various projects and assignments together. Additionally, students can peer review each other's submissions allowing them to improve upon their work. Expertiza supports submission across various document types, including the URLs and wiki pages.

= Introduction =

The Expertiza project allows "calibration assignments" to be performed where students are asked to review work that has also been reviewed by a member of the course staff. Calibration is the term used for rectifying, or checking or determining something. In the context of this project, a 'Calibrated review' is one which is performed by a student, so that (s)he can verify their work by comparing it with the instructor's response for the same assignment. If the student’s review “resembles” the staff-member’s review, then the student is presumed to be a competent reviewer. Since calibration reviews are meant as reference for better performance of peer reviews (which are performed later), they are not graded.

= Problem Statement =

== Goal ==
Calibration submissions should be copied along with calibration assignments.

== Issue in current implementation ==
On creating a copy of a previous assignment, say for example Design Exercise, <i>Fall '20</i> for the <i>Fall '21</i> semester - the calibration assignments associated with it are not copied over. The instructor is required to impersonate extra participants, and submit work on behalf of each of the extra participants. This is obviously extra trouble, and it would be a lot more convenient if an instructor didn’t have to resubmit the same calibration submissions over and over, every semester. <br><br>

'''The following steps were taken to test the aforementioned issues:'''

'''Step 1:''' On copying the Design exercise assignment<br><br>
[[File:copy_2075.png]] <br><br><br>

'''Step 2:''' The original file contains the following calibration reviews<br><br>
[[File:cali_a_2075.png]] <br><br><br>

'''Step 3:''' However, the copy doesn't contain any of the calibrated reviews<br><br>
[[File:cali_b_2075.png]] <br><br><br>

= Implementation =
== Proposed Design ==
The following must be added to the current implementation:

* The same extra participants in the assignment, which are used as calibration assignments are copied over to the newly copied directory
* The URLs and/or files that were submitted to the previous assignment must be copied over as well
* Test cases to check if the above-mentioned steps work as required

[More on the design pattern if any, ER/ UML diagrams to be updated as the project progresses]

== Files Involved ==
* '''submission_records_controller.rb'''
* '''index.html.erb''' in expertiza/app/views/submission_records

= Test Plan =

==== Manual Testing Plan ====
Manual test to check if:
* The UI is working as expected [No broken links]
* The submissions [Files and Hyperlinks] are copied when an assignment for calibration is copied.

==== Directions for Manual Testing ====
* Go to the testing server [VCL Instance] and log in with the credentials - username: 'instructor6'; password: 'password'
* Go to an existing assignment that you want to setup calibration for
** Hit on '''copy''' and toggle on calibration on the popup that appears
** Hit on submit
** On the calibrations tab the copied submissions [Files and URLs] must be present in the calibration tab

==== RSpec Testing Plan ====
RSpec test to check:
* Validation of the models
* Sanity and basic functionality of controllers
** This involves essentially checking if the copied calibration's corresponding model has entries for the submissions

==== Directions for RSpec Testing ====
* Run the following commands:
** For controllers: rspec spec/controllers/
** For models: rspec spec/models/

= Useful Links =
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]

= Team Information =
* Nischal Kashyap
* Mounika Bachu
* Akshay Podila
* Dhanraj Raghunathan

CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments

2020-10-28T02:27:04Z

Draghun:

This wiki page describes the changes made under E2075, to ensure calibration submissions are copied along with calibration assignments for CSC/ECE 517, Fall 2020.

__TOC__

== About Expertiza ==
Expertiza is an open source project based on Ruby on Rails framework, created and maintained by the joint efforts of students and faculty at North Carolina State University.

It allows the instructors to create new assignments and customize new or existing assignments. Expertiza also allows an instructor to create a list of topics the students can sign up for. Students can form teams on the web application to work on various projects and assignments together. Additionally, students can peer review each other's submissions allowing them to improve upon their work. Expertiza supports submission across various document types, including the URLs and wiki pages.

= Introduction =

The Expertiza project allows "calibration assignments" to be performed where students are asked to review work that has also been reviewed by a member of the course staff. Calibration is the term used for rectifying, or checking or determining something. In the context of this project, a 'Calibrated review' is one which is performed by a student, so that (s)he can verify their work by comparing it with the instructor's response for the same assignment. If the student’s review “resembles” the staff-member’s review, then the student is presumed to be a competent reviewer. Since calibration reviews are meant as reference for better performance of peer reviews (which are performed later), they are not graded.

= Problem Statement =

== Goal ==
Calibration submissions should be copied along with calibration assignments.

== Issue in current implementation ==
On creating a copy of a previous assignment, say for example Design Exercise, <i>Fall '20</i> for the <i>Fall '21</i> semester - the calibration assignments associated with it are not copied over. The instructor is required to impersonate extra participants, and submit work on behalf of each of the extra participants. This is obviously extra trouble, and it would be a lot more convenient if an instructor didn’t have to resubmit the same calibration submissions over and over, every semester. <br><br>

'''The following steps were taken to test the aforementioned issues:'''

'''Step 1:''' On copying the Design exercise assignment<br><br>
[[File:copy_2075.png]] <br><br><br>

'''Step 2:''' The original file contains the following calibration reviews<br><br>
[[File:cali_a_2075.png]] <br><br><br>

'''Step 3:''' However, the copy doesn't contain any of the calibrated reviews<br><br>
[[File:cali_b_2075.png]] <br><br><br>

= Implementation =
== Proposed Design ==
The following must be added to the current implementation:

* The same extra participants in the assignment, which are used as calibration assignments are copied over to the newly copied directory
* The URLs and/or files that were submitted to the previous assignment must be copied over as well
* Test cases to check if the above-mentioned steps work as required

== Files Involved ==
* '''submission_records_controller.rb'''
* '''index.html.erb''' in expertiza/app/views/submission_records

= Test Plan =

==== Manual Testing Plan ====
Manual test to check if:
* The UI is working as expected [No broken links]
* The submissions [Files and Hyperlinks] are copied when an assignment for calibration is copied.

==== Directions for Manual Testing ====
* Go to the testing server [VCL Instance] and log in with the credentials - username: 'instructor6'; password: 'password'
* Go to an existing assignment that you want to setup calibration for
** Hit on '''copy''' and toggle on calibration on the popup that appears
** Hit on submit
** On the calibrations tab the copied submissions [Files and URLs] must be present in the calibration tab

==== RSpec Testing Plan ====
RSpec test to check:
* Validation of the models
* Sanity and basic functionality of controllers
** This involves essentially checking if the copied calibration's corresponding model has entries for the submissions

==== Directions for RSpec Testing ====
* Run the following commands:
** For controllers: rspec spec/controllers/
** For models: rspec spec/models/

= Useful Links =
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]

= Team Information =
* Nischal Kashyap
* Mounika Bachu
* Akshay Podila
* Dhanraj Raghunathan

CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments

2020-10-28T02:04:44Z

Draghun: /* Test Plan */

This wiki page describes the changes made under E2075, to ensure calibration submissions are copied along with calibration assignments for CSC/ECE 517, Fall 2020.

__TOC__

== About Expertiza ==
Expertiza is an open source project based on Ruby on Rails framework, created and maintained by the joint efforts of students and faculty at North Carolina State University.

It allows the instructors to create new assignments and customize new or existing assignments. Expertiza also allows an instructor to create a list of topics the students can sign up for. Students can form teams on the web application to work on various projects and assignments together. Additionally, students can peer review each other's submissions allowing them to improve upon their work. Expertiza supports submission across various document types, including the URLs and wiki pages.

= Introduction =

The Expertiza project allows "calibration assignments" to be performed where students are asked to review work that has also been reviewed by a member of the course staff. Calibration is the term used for rectifying, or checking or determining something. In the context of this project, a 'Calibrated review' is one which is performed by a student, so that (s)he can verify their work by comparing it with the instructor's response for the same assignment. If the student’s review “resembles” the staff-member’s review, then the student is presumed to be a competent reviewer. Since calibration reviews are meant as reference for better performance of peer reviews (which are performed later), they are not graded.

= Problem Statement =

== Goal ==
Calibration submissions should be copied along with calibration assignments.

== Issue in current implementation ==
On creating a copy of a previous assignment, say for example Design Exercise, <i>Fall '20</i> for the <i>Fall '21</i> semester - the calibration assignments associated with it are not copied over. The instructor is required to impersonate extra participants, and submit work on behalf of each of the extra participants. This is obviously extra trouble, and it would be a lot more convenient if an instructor didn’t have to resubmit the same calibration submissions over and over, every semester. <br><br>

'''The following steps were taken to test the aforementioned issues:'''

'''Step 1:''' On copying the Design exercise assignment<br><br>
[[File:copy_2075.png]] <br><br><br>

'''Step 2:''' The original file contains the following calibration reviews<br><br>
[[File:cali_a_2075.png]] <br><br><br>

'''Step 3:''' However, the copy doesn't contain any of the calibrated reviews<br><br>
[[File:cali_b_2075.png]] <br><br><br>

= Implementation =
== Proposed Design ==
The following must be added to the current implementation:

* The same extra participants in the assignment, which are used as calibration assignments are copied over to the newly copied directory
* The URLs and/or files that were submitted to the previous assignment must be copied over as well
* Test cases to check if the above-mentioned steps work as required

== Files Involved ==
* '''submission_records_controller.rb'''
* '''index.html.erb''' in expertiza/app/views/submission_records

= Test Plan =

=== ''Manual Testing'' ===
Manual testing should be preformed on an Expertiza server. <br>

==== Manual Testing Plan ====
Manual testing should (''at a minimum''):
* test that the UI is implemented as expected
* test that a participant can bid on projects to review
** test that a participant can move projects into the bidding column
** test that a participant can reorder projects in the bidding column
** test that a participant's bidding preferences save

==== Directions for Manual Testing ====
:# Go to [http://152.7.99.70:8081/ testing server]
:# Log in as username: '''instructor6''' password: '''password'''
:# Go to '''Assignments'''
:# Two tasks should be listed in the main assignments box
:::a. Go to '''E2085 Manual Testing- Instructor6 Reviewer review'''
:::# This UI is based on the user being a ''reviewer'' (i.e. user was not in a team and did not submit anything)
:::# The UI should allow the user to bid on any project
:::b. Go to '''E2085 Manual Testing- Instructor6 Participant review'''
:::# This UI is based on the user being a ''participant'' (i.e. user was in a team and assigned a topic)
:::# The UI blocks user from bidding on their own project (instructor6 was assigned topic4)

==== Manual Testing Demo Video ====
Video demonstration of manual testing: [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2020_-_E2085._Allow_reviewers_to_bid_on_what_to_review link to be added]

=== ''Automatic/RSpec Testing '' ===
RSpec tests will need to be written to related controller(s) and model(s). <br>

==== RSpec Testing Plan ====
These RSpec tests should (''at a minimum''):
* test basic functionality of controller(s)
* test validation of the model(s)
* test the scenarios (basic case & edge cases) mentioned above

==== Directions for RSpec Testing ====
:# [https://docs.google.com/document/d/1tXmwju6R7KQbvycku-bdXxa6rXSUN4BMyvjY3ROmMSw/edit Set up Expertiza] on personal device using [https://github.com/uahamedncsu/expertiza forked repo]
:# Run the following commands:

# related controllers:
rspec spec/controllers/

# related models:
rspec spec/models/

= Useful Links =
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]

= Team Information =
* Nischal Kashyap
* Mounika Bachu
* Akshay Podila
* Dhanraj Raghunathan

CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments

2020-10-22T01:07:33Z

Draghun: /* Project Overview */

== Project Overview ==
=== Background ===
The Expertiza project allows "calibration assignments" to be performed where students are asked to review work that has also been reviewed by a member of the course staff. Accommodating an easier way to create calibrations will certainly deem useful.

=== Objective ===
Our objectives for this project are the following:

* Use the same extra participants as the assignment you are copying to creating the calibration used
* Add test cases to maintain coverage if SLOC increases

=== Team ===

* Nischal Kashyap
* Mounika Bachu
* Akshay Podila
* Dhanraj Raghunathan

== Design ==
== Implementation ==
== Test Plan ==
== Useful Links ==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]

CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments

2020-10-22T01:06:32Z

Draghun:

CSC/ECE 517 Fall 2020

2020-10-22T00:37:11Z

Draghun: /* Final Project Design Documents */

== Writing Assignments ==
* [[CSC/ECE 517 Fall 2020 - E2070. Refactor response_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2068. Refactor quiz_questionnaires_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2062. Add test cases to review_mapping_helper.rb]]
* [[CSC/ECE 517 Fall 2020 - E2063. Refactor tree-display.js and tree_display_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2064. Refactor reputation_web_service_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2065. Fix view in student_task/list page]]
* [[CSC/ECE 517 Fall 2020 - E2066. Refactor lottery controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2067. Refactor student_teams_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2073. Refactor course_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2057. Restrict TAs’ ability to change their own grade and limit file-size upload]]
* [[CSC/ECE 517 Fall 2020 - E2052. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2020 - E2052. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2020 - E2056 Account_Request_Controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2059. Email notification to reviewers and instructors.rb]]
* [[CSC/ECE 517 Fall 2020 - E2058. Two issues related to assignment management]]
* [[CSC/ECE 517 Fall 2020 - E2071. Improve assessment360_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2054. Auto generate submission directory names based on assignment names]]
* [[CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews]]

== Final Project Design Documents ==
* [[CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments]]
* [[CSC/ECE 517 Fall 2020 - E2078. Improve self-review Link peer review & self-review to derive grades]]
* [[CSC/ECE 517 Fall 2020 - E2083. Revision_planning_tool_E2016]]
* [[CSC/ECE 517 Fall 2020 - E2085. Allow reviewers to bid on what to review]]
* [[CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews]]
* [[CSC/ECE 517 Fall 2020 - SQLFE. Refactor Submission.java]]
* [[CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments]]

CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments

2020-10-22T00:29:49Z

Draghun:

A “calibration assignment” is an assignment where the students are asked to review work that has also been reviewed by a member of the course staff. If the student’s review “resembles” the staff-member’s review, then the student is presumed to be a competent reviewer. Here is a further description of calibration assignments.
To set up calibration, the instructor (or TA) adds a few extra participants to the assignment. The instructor (or TA) then impersonates the extra participants, and submits work on behalf of each of the extra participants. This is, obviously, extra trouble, and it would be nice if an instructor didn’t have to resubmit the same calibration submissions every semester. So this project asks you to write code that copies over the calibration submissions whenever a calibrated assignment is submitted.
My suggestion is that, when copying an assignment, you use the same extra participants as the assignment you are copying used. Then, copy the URLs and/or files that were submitted to the previous assignment, and submit them to this assignment as well.

CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments

2020-10-22T00:29:17Z

Draghun: Created page with "Placeholder"

Placeholder

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-18T17:08:33Z

Draghun: /* Test Plan */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Resultant View ===

* Expertiza on test VCL instance - http://152.7.98.76:8080/

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Rspec testing:

Added the following test to the ~/expertiza/spec/controllers/popup_controller_spec.rb

<pre>
describe '#team_users_popup' do
it "renders the page successfuly as Instructor" do
allow(Team).to receive(:find).and_return(team)
allow(Assignment).to receive(:find).and_return(assignment)
params = {id: team.id, assignment: assignment, reviewer_id: participant2.id}
session = {user: instructor}
result = get :team_users_popup, params, session
expect(result.status).to eq 200
end
end
</pre>

Since the modifications are mostly on a view, a simple test would suffice.

=== Important Links ===

* [https://github.com/lgdeloss/expertiza Forked Github repo]
* [https://github.com/expertiza/expertiza/pull/1805 Corresponding pull request]
* [https://www.youtube.com/watch?v=iaO2sowXTB0 Video showing the changes and the effect]

== Useful Links ==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:25:45Z

Draghun: /* Resultant View */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Resultant View ===

* Expertiza on test VCL instance - http://152.7.98.76:8080/

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===

* [https://github.com/lgdeloss/expertiza Forked Github repo]
* [https://github.com/expertiza/expertiza/pull/1805 Corresponding pull request]
* [https://www.youtube.com/watch?v=iaO2sowXTB0 Video showing the changes and the effect]

== Useful Links ==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:25:02Z

Draghun:

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Resultant View ===

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===

* [https://github.com/lgdeloss/expertiza Forked Github repo]
* [https://github.com/expertiza/expertiza/pull/1805 Corresponding pull request]
* [https://www.youtube.com/watch?v=iaO2sowXTB0 Video showing the changes and the effect]

== Useful Links ==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:24:24Z

Draghun:

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===

* [https://github.com/lgdeloss/expertiza Forked Github repo]
* [https://github.com/expertiza/expertiza/pull/1805 Corresponding pull request]
* [https://www.youtube.com/watch?v=iaO2sowXTB0 Video showing the changes and the effect]

== Useful Links ==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:23:57Z

Draghun: /* Important Links */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===

* [https://github.com/lgdeloss/expertiza Forked Github repo]
* [https://github.com/expertiza/expertiza/pull/1805 Corresponding pull request]
* [https://www.youtube.com/watch?v=iaO2sowXTB0 Video showing the changes and the effect]

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:22:14Z

Draghun:

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png| 1000px]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===
1. Github repo: https://github.com/lgdeloss/expertiza
2. Corresponding pull request: https://github.com/expertiza/expertiza/pull/1805
3. Video showing the changes and the effect: https://www.youtube.com/watch?v=iaO2sowXTB0

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:20:03Z

Draghun: /* Task */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File: Screen Shot 2020-10-16 at 12.13.44 PM.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===
1. Github repo: https://github.com/lgdeloss/expertiza
2. Corresponding pull request: https://github.com/expertiza/expertiza/pull/1805
3. Video showing the changes and the effect: https://www.youtube.com/watch?v=iaO2sowXTB0

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:18:46Z

Draghun: /* Task */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File: oss_e2060.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===
1. Github repo: https://github.com/lgdeloss/expertiza
2. Corresponding pull request: https://github.com/expertiza/expertiza/pull/1805
3. Video showing the changes and the effect: https://www.youtube.com/watch?v=iaO2sowXTB0

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:18:26Z

Draghun: /* Task */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File:oss_e2060.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===
1. Github repo: https://github.com/lgdeloss/expertiza
2. Corresponding pull request: https://github.com/expertiza/expertiza/pull/1805
3. Video showing the changes and the effect: https://www.youtube.com/watch?v=iaO2sowXTB0

File:Screen Shot 2020-10-16 at 12.13.44 PM.png

2020-10-16T16:14:21Z

Draghun:

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T16:13:23Z

Draghun: /* Test Plan */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File:Team user popup after.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment
** Click on any of the links from **Team reviewed**

Resultant view:

=== Important Links ===
1. Github repo: https://github.com/lgdeloss/expertiza
2. Corresponding pull request: https://github.com/expertiza/expertiza/pull/1805
3. Video showing the changes and the effect: https://www.youtube.com/watch?v=iaO2sowXTB0

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T15:48:38Z

Draghun: /* Test Plan */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File:Team user popup after.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:
# As we only change the layout of several views. We can only test them from UI testing.
# The existing templates view_my_score are also tested with UI, without any Rspec testing.

There are two test cases for UI testing.
* To Test UI for student View
** Log-in as Student.
** Go to Assignment
** Click Your scores
** Click show reviews

* To Test UI for instructor View
** Log-in as Instructor.
** Go to Manage Assignments
** Click on review report of a particular assignment

=== Important Links ===
1. Github repo: https://github.com/lgdeloss/expertiza
2. Corresponding pull request: https://github.com/expertiza/expertiza/pull/1805
3. Video showing the changes and the effect: https://www.youtube.com/watch?v=iaO2sowXTB0

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T15:48:19Z

Draghun: /* Implementation */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File:Team user popup after.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Test Plan ===

Our test plan are mostly manual. There are two reasons why we choose UI testing:

As we only change the layout of several views. We can only test them from UI testing.
The existing templates view_my_score are also tested with UI, without any Rspec testing.
There are two test cases for UI testing.

To Test UI for student View
Log-in as Student.
Go to Assignment
Click Your scores
Click show reviews
To Test UI for instructor View
Log-in as Instructor.
Go to Manage Assignments
Click on the review report of a particular assignment

=== Important Links ===
1. Github repo: https://github.com/lgdeloss/expertiza
2. Corresponding pull request: https://github.com/expertiza/expertiza/pull/1805
3. Video showing the changes and the effect: https://www.youtube.com/watch?v=iaO2sowXTB0

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T15:47:42Z

Draghun:

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File:Team user popup after.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Important Links ===
1. Github repo: https://github.com/lgdeloss/expertiza
2. Corresponding pull request: https://github.com/expertiza/expertiza/pull/1805
3. Video showing the changes and the effect: https://www.youtube.com/watch?v=iaO2sowXTB0

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-16T15:39:39Z

Draghun: /* Implementation */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File:Team user popup after.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

=== Vizualize the change [Video] ===

https://www.youtube.com/watch?v=iaO2sowXTB0

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-14T03:03:32Z

Draghun: /* Issues with previous pull: */

== Introduction ==

Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental learning. Students can submit learning objects such as articles, wiki pages, repository links and with the help of peer reviews, improve them. The project has been developed using the Ruby on Rails https://en.wikipedia.org/wiki/Ruby_on_Rails framework and is supported by the [http://www.nsf.gov National Science Foundation].

== Team members ==
# Luis Delossantos (ldeloss@ncsu.edu)
# Dhanraj Raghunathan (draghun@ncsu.edu)
# Mentor: Nisarg Chokshi (nmchoks2@ncsu.edu)

== Project Description ==

=== Purpose and Scope ===

Expertiza assignments are based on a peer review system where the instructor creates rubrics for an assignment through questionnaires which students use to review other students' submissions. The author of the submission is given an opportunity to provide feedback about these reviews. Expertiza displays reviews (i) to the team who was reviewed, and (ii) to the reviewer. A student user can see all the reviews of his/her team’s project. The instructor can see all the reviews of everyone’s project. The instructor also has access to a Review report, which shows, for each reviewer, all the reviews that (s)he wrote. The score report and review report use different code so UI is non-orthogonal, it would be great if we can follow same UI structure for score and review report which also reduce the DRY problems.

Exact issue on Github - https://tinyurl.com/y5xjj6ov

=== Task Description ===

==== Background ====
* Currently Review report uses its own code to display reviews. This a pretty basic view, and it does not interpret HTML codes. It should be changed so that it calls the usual code that is used for displaying reviews, that gives the circle with the score inside.

==== Task ====
Currently, if you pull up a review report, and then click on one of the teams reviewed, e.g., the first one, you get a report that looks like this:
[[File:Team user popup before.png]]

We need to change the views to existing templates in view_my_scores pages.

For student view the UI is consistent in displaying reviews they have done and reviews they have received but for instructor's view the review report follows different UI and have different code. To make the UI consistent we have decided to choose the UI design of student view as the base and modify the UI design for review report in instructor's view. This will allow us to use the same code in both views, thereby following DRY principle.

Updated View:

[[File:Team user popup after.png]]

=== Issues with previous pull: ===
* https://tinyurl.com/yyxkjsy3
* Code for displaying a review is essentially copied instead of parametrized and reused, violating the DRY principle.
* No new tests added although they do have a well detailed manual test plan.
* HTML codes [Breaks] are left visible in the view.

== Implementation ==

=== Files modified in this project ===
*app/view/pop_up/team_users_popup.html.haml
*app/view/pop_up/team_users_popup.html.erb
*app/controllers/popup_controller.rb [Hot Fix]

The previous implementation involved having a haml file with bare HTML. [app/view/pop_up/team_users_popup.html.haml]

<pre>
%div
%script{:src=>"/assets/team_users_popup.js"}

%h3
Members of #{@team.name}
%table{:width => "100%"}
- if @team_users.empty?
%tr No team members
- else
- @team_users.each do |t|
%tr
%td
\- #{User.find(t.user_id).fullname}
- (1..@assignment.num_review_rounds).each do |round|
- next if instance_variable_get('@response_round_' + round.to_s).nil?
- if instance_variable_get('@scores_round_' + round.to_s).nil?
%tr
%td{:align => "center"} No review done yet.
%br/
%tr
%th{:align => "left"} Reviewer score
%tr
%td{:align => "center"} --
%br/
- else
%h3{:style=>"display:inline-block"}= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})"
- response_id = instance_variable_get('@response_id_round_' + round.to_s).to_s
- response = Response.find(response_id)
- if response.visibility=='public'
%button{ :id=>"btn"+round.to_s, :onclick=>"publish_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Mark as Example
- elsif response.visibility=='published'
%button{ :id=>"btnun"+round.to_s, :onclick=>"suppress_example_review(this)", :data => { :response_id => response_id }, :style=>"float:right" } Unmark as Example

%table{:class => "general", :border => "1px solid #ccc"}
%tr
%th{:align => "left", :width => "50%"} Question
%th{:width => "5%"} Score
%th{:width => "45%"} Comments
- instance_variable_get('@scores_round_' + round.to_s).each do |answer|
%tr
%td{:align => "left"}
= answer.question.txt
- if answer.question.is_a?(ScoredQuestion)
%td{:align => "center"}
= answer.answer
\/#{instance_variable_get('@max_score_round_' + round.to_s)}
- elsif answer.question.is_a?(Checkbox)
%td{:align => "center"}
=answer.answer==0 ? image_tag("delete_icon.png"): image_tag("Check-icon.png")
-else
%td{:align => "center"}
=answer.answer
%td{:align => "left"}
= answer.comments
%tr
%th Reviewer Score (Σ weighted score/Σ weighted available score)
%td{:align => "center"}
= instance_variable_get('@sum_round_' + round.to_s)
\/#{instance_variable_get('@total_possible_round_' + round.to_s)}
%td{:align => "left"}
\= #{instance_variable_get('@total_percentage_round_' + round.to_s)}
%br/
%table{:class => "general",:width => "100%"}
%tr
%th Additional Comment
%tr
- additional_comment = Response.find(instance_variable_get('@response_id_round_' + round.to_s)).additional_comment
%td= additional_comment.nil? ? 'No Comments' : additional_comment.html_safe
%hr/
%br/

%div{:id=>"dialogConfirmMark",:class=>"col-md-12"}
%h5{:class=>"col-md-11"}
%strong Select the assignments for which you want to mark these reviews as samples:
%br/
%table{:class => "general",:width => "100%"}
%tr
%td
%th Assignments
- @similar_assignments.each do |assignment|
%tr
- @course_name = !assignment.course.nil? ? assignment.course.name : ""
%td= check_box_tag "published_assignments", assignment.id
%td= label_tag "#{@course_name} : #{assignment.name}"

%div{:id=>"dialogConfirmUnmark",:class=>"col-md-12"}
%div{:class=>"col-md-12",:id=>"similar_assignments_popup"}
%p
This will remove this review as example for all assignments. Continue?

.footer
= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id]
</pre>

We replaced this with an existing view following the DRY principle [app/view/pop_up/team_users_popup.html.erb]

<pre>
<div>
<h3>
Members of <%= @team.name %>
</h3>
<% (1..@assignment.num_review_rounds).each do |round| %>

<h3>
<%= "Reviewed by #{User.find(@reviewer_id).fullname} (Round #{round})" %>
</h3>

<% instance_variable_get('@scores_round_' + round.to_s).each do |answer| %>

<%= answer.response.display_as_html() %>
<% break %>
<% end %>

<% end %>

<br/>
<div class="footer">
<%= link_to 'Back', :controller=> 'review_mapping', :action=>'response_report', :id=>params[:assignment_id] %>
</div>
</div>

</pre>

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-11T18:07:33Z

Draghun: /* Issues with previous pull: */

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-11T18:07:02Z

Draghun: /* Issues with previous pull: https://tinyurl.com/yxkevycq */

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-11T18:05:59Z

Draghun:

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-11T18:02:29Z

Draghun:

CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews

2020-10-11T17:55:43Z

Draghun: Created page with "== Introduction == Expertiza https://expertiza.ncsu.edu/ is an open-source web application to create re-usable learning objects through peer-reviews to facilitate incremental..."