Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-05T17:22:12Z

Diddya: /* New files */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project. The value of the duty for that project team is stored in TeamUsers.
* AssignmentsDutyMapping stores the value for all duties applicable to a particular assignment, hence it is an aggregation of the duties for an assignment.
* AssignmentDutyQuestionnaireMapping adds the questionnaire_id for a particular AssignmentDutyMapping thus has a direct dependency to AssignmentDutyMapping and has an association with the Questionnaire table.
* StudentTeams uses the AssignmentDutyMapping to table to find available duties for a particular assignment to allow teammates to select. It then uses the Duty table to fetch the respective name of the found duty_id.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "Add Duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818_1.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.

[[File:student_4_1818.jpg]]

* A team member cannot change their role after the assignment submission deadline.

* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

* test/controllers/duties_controller_test.rb
'''In this file tests have been created to test the duties controller.'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
spec/features/assignment_creation_spec.rb
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
spec/features/student_duty_spec.rb
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [https://youtu.be/jMQCJUeqA1Q Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-05T17:20:48Z

Diddya: /* Test Plan */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project. The value of the duty for that project team is stored in TeamUsers.
* AssignmentsDutyMapping stores the value for all duties applicable to a particular assignment, hence it is an aggregation of the duties for an assignment.
* AssignmentDutyQuestionnaireMapping adds the questionnaire_id for a particular AssignmentDutyMapping thus has a direct dependency to AssignmentDutyMapping and has an association with the Questionnaire table.
* StudentTeams uses the AssignmentDutyMapping to table to find available duties for a particular assignment to allow teammates to select. It then uses the Duty table to fetch the respective name of the found duty_id.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "Add Duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818_1.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.

[[File:student_4_1818.jpg]]

* A team member cannot change their role after the assignment submission deadline.

* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
spec/features/assignment_creation_spec.rb
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
spec/features/student_duty_spec.rb
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [https://youtu.be/jMQCJUeqA1Q Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:57:28Z

Diddya: /* Student view changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project. The value of the duty for that project team is stored in TeamUsers.
* AssignmentsDutyMapping stores the value for all duties applicable to a particular assignment, hence it is an aggregation of the duties for an assignment.
* AssignmentDutyQuestionnaireMapping adds the questionnaire_id for a particular AssignmentDutyMapping thus has a direct dependency to AssignmentDutyMapping and has an association with the Questionnaire table.
* StudentTeams uses the AssignmentDutyMapping to table to find available duties for a particular assignment to allow teammates to select. It then uses the Duty table to fetch the respective name of the found duty_id.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "Add Duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818_1.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.

[[File:student_4_1818.jpg]]

* A team member cannot change their role after the assignment submission deadline.

* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [https://youtu.be/jMQCJUeqA1Q Youtube Screencast]

File:Student 5 1818.jpg

2018-05-04T15:56:54Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:56:39Z

Diddya: /* Student view changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project. The value of the duty for that project team is stored in TeamUsers.
* AssignmentsDutyMapping stores the value for all duties applicable to a particular assignment, hence it is an aggregation of the duties for an assignment.
* AssignmentDutyQuestionnaireMapping adds the questionnaire_id for a particular AssignmentDutyMapping thus has a direct dependency to AssignmentDutyMapping and has an association with the Questionnaire table.
* StudentTeams uses the AssignmentDutyMapping to table to find available duties for a particular assignment to allow teammates to select. It then uses the Duty table to fetch the respective name of the found duty_id.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "Add Duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818_1.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.

[[File:student_4_1818.jpg]]

* A team member cannot change their role after the assignment submission deadline.

[[File:student_5_1818.jpg]]

* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [https://youtu.be/jMQCJUeqA1Q Youtube Screencast]

File:Student 4 1818.jpg

2018-05-04T15:56:08Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:55:55Z

Diddya: /* Student view changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project. The value of the duty for that project team is stored in TeamUsers.
* AssignmentsDutyMapping stores the value for all duties applicable to a particular assignment, hence it is an aggregation of the duties for an assignment.
* AssignmentDutyQuestionnaireMapping adds the questionnaire_id for a particular AssignmentDutyMapping thus has a direct dependency to AssignmentDutyMapping and has an association with the Questionnaire table.
* StudentTeams uses the AssignmentDutyMapping to table to find available duties for a particular assignment to allow teammates to select. It then uses the Duty table to fetch the respective name of the found duty_id.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "Add Duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818_1.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
[[File:student_4_1818.jpg]]
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [https://youtu.be/jMQCJUeqA1Q Youtube Screencast]

File:Student 3 1818.jpg

2018-05-04T15:55:28Z

Diddya:

File:Student 2 1818.jpg

2018-05-04T15:54:20Z

Diddya:

File:Student 1 1818 1.jpg

2018-05-04T15:53:36Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:52:52Z

Diddya: /* Student view changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project. The value of the duty for that project team is stored in TeamUsers.
* AssignmentsDutyMapping stores the value for all duties applicable to a particular assignment, hence it is an aggregation of the duties for an assignment.
* AssignmentDutyQuestionnaireMapping adds the questionnaire_id for a particular AssignmentDutyMapping thus has a direct dependency to AssignmentDutyMapping and has an association with the Questionnaire table.
* StudentTeams uses the AssignmentDutyMapping to table to find available duties for a particular assignment to allow teammates to select. It then uses the Duty table to fetch the respective name of the found duty_id.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "Add Duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818_1.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [https://youtu.be/jMQCJUeqA1Q Youtube Screencast]

File:Student 1 1818.jpg

2018-05-04T15:52:30Z

Diddya:

File:Instructor 5 1818.png

2018-05-04T15:50:35Z

Diddya:

File:Instructor 4 1818.png

2018-05-04T15:49:31Z

Diddya:

File:Instructor 3 1818.png

2018-05-04T15:49:15Z

Diddya:

File:Instructor 2 1818.png

2018-05-04T15:48:57Z

Diddya:

File:Instructor 1 1818.png

2018-05-04T15:48:37Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:42:39Z

Diddya: /* Instructor view changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project. The value of the duty for that project team is stored in TeamUsers.
* AssignmentsDutyMapping stores the value for all duties applicable to a particular assignment, hence it is an aggregation of the duties for an assignment.
* AssignmentDutyQuestionnaireMapping adds the questionnaire_id for a particular AssignmentDutyMapping thus has a direct dependency to AssignmentDutyMapping and has an association with the Questionnaire table.
* StudentTeams uses the AssignmentDutyMapping to table to find available duties for a particular assignment to allow teammates to select. It then uses the Duty table to fetch the respective name of the found duty_id.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "Add Duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:40:01Z

Diddya: /* Instructor view changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project. The value of the duty for that project team is stored in TeamUsers.
* AssignmentsDutyMapping stores the value for all duties applicable to a particular assignment, hence it is an aggregation of the duties for an assignment.
* AssignmentDutyQuestionnaireMapping adds the questionnaire_id for a particular AssignmentDutyMapping thus has a direct dependency to AssignmentDutyMapping and has an association with the Questionnaire table.
* StudentTeams uses the AssignmentDutyMapping to table to find available duties for a particular assignment to allow teammates to select. It then uses the Duty table to fetch the respective name of the found duty_id.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "Add Duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Instructor_6_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:22:43Z

Diddya: /* Instructor view changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml 1818.png]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Instructor_6_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:18:43Z

Diddya: /* New files */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Instructor_6_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
'''In this file, a ''duties'' table is created with a name field
'''
* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
'''In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* db/migrate/add_duties_to_users.rb
'''In this file, a column named ''duties'' is added to the ''Users'' table'''

* db/migrate/add_multiple_duties_to_assignments.rb
'''In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
'''In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** While creating an assignment, in the Review Strategy tab, check the box for role based reviewing and expect the 'role_based_review' column of Assignments table to be true.
** Ability to add new duties from the Review Strategy tab. Click on 'Add Duty' and get redirected to a new page where there is the option of adding a name for duty in the text-box and click 'Create Duty'. This new added duty will now be displayed in the Review Strategy tab if the role-based-review option is selected.
** Select from already existing and newly added duties for a particular assignment. After saving, the changes should be reflected in the database 'AssignmentsDutyMapping' table.

* Student(team member) tests
** When a student visits 'Your Team' link, if the option of role based review is selected while creating the assignment, a link 'Select' should appear which enables the student to select the duty.
** In the 'Your Team' tab, after clicking the 'Select' link, the student should be able to select one duty (radio button). This selected duty should now be visible on the 'Your Team' page.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:10:26Z

Diddya: /* Migration changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Instructor_6_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* '''db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field'''

* '''db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* '''db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table'''

* ''' db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* '''db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:09:35Z

Diddya: /* Migration changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* ''' Create Duties table: This table stores all the duties created by any instructor.'''
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* ''' Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.'''
* id
* assignment_id
* duty_id

* ''' Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.'''
* id
* assignment_id
* duty_id
* questionnaire_id

* ''' Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.'''
* ''' Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.'''
* ''' Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.'''

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Instructor_6_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* '''db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field'''

* '''db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* '''db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table'''

* ''' db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* '''db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:08:44Z

Diddya: /* Instructor view changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
'''* Create Duties table: This table stores all the duties created by any instructor.'''
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

'''* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.'''
* id
* assignment_id
* duty_id

'''* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.'''
* id
* assignment_id
* duty_id
* questionnaire_id

'''* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.'''
'''* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.'''
'''* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.'''

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:Instructor_1_1818.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Instructor_2_1818.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:Instructor_3_1818.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Instructor_4_1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Instructor_5_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Instructor_6_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* '''db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field'''

* '''db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* '''db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table'''

* ''' db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* '''db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:06:40Z

Diddya: /* New files */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
'''* Create Duties table: This table stores all the duties created by any instructor.'''
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

'''* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.'''
* id
* assignment_id
* duty_id

'''* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.'''
* id
* assignment_id
* duty_id
* questionnaire_id

'''* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.'''
'''* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.'''
'''* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.'''

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* '''db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field'''

* '''db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.'''

* '''db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table'''

* ''' db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table'''

* '''db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''
'''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:05:14Z

Diddya: /* References */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
'''* Create Duties table: This table stores all the duties created by any instructor.'''
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

'''* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.'''
* id
* assignment_id
* duty_id

'''* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.'''
* id
* assignment_id
* duty_id
* questionnaire_id

'''* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.'''
'''* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.'''
'''* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.'''

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page Main Page Expertiza]
* [https://github.com/expertiza/expertiza/pull/1181 Github Pull Request]
* [http://www.example.com Youtube Screencast]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:03:58Z

Diddya: /* References */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
'''* Create Duties table: This table stores all the duties created by any instructor.'''
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

'''* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.'''
* id
* assignment_id
* duty_id

'''* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.'''
* id
* assignment_id
* duty_id
* questionnaire_id

'''* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.'''
'''* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.'''
'''* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.'''

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page] Main Page for Expertiza
* [https://github.com/expertiza/expertiza/pull/1181] Github Pull Request
* [http://www.example.com link title] Youtube Video

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T15:02:14Z

Diddya: /* Test Plan */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
'''* Create Duties table: This table stores all the duties created by any instructor.'''
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

'''* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.'''
* id
* assignment_id
* duty_id

'''* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.'''
* id
* assignment_id
* duty_id
* questionnaire_id

'''* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.'''
'''* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.'''
'''* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.'''

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

==References==
* [http://wiki.expertiza.ncsu.edu/index.php/Main_Page]
* [https://github.com/expertiza/expertiza/pull/1181]
* [http://www.example.com link title]

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-04T14:57:28Z

Diddya: /* Migration changes */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
'''* Create Duties table: This table stores all the duties created by any instructor.'''
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

'''* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.'''
* id
* assignment_id
* duty_id

'''* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.'''
* id
* assignment_id
* duty_id
* questionnaire_id

'''* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.'''
'''* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.'''
'''* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.'''

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T20:02:58Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T20:02:25Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties for teammate review from the duties for an assignment if role based reviewing is permitted or else the standard view is displayed.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

File:Student view 1 1818.png

2018-05-03T19:53:31Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T19:53:09Z

Diddya: /* Files to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files changes==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties and a dropdown for selecting a teammate review for the selected duties if role based reviewing is permitted or else display the standard view.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1_1818.png]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

File:Student view 1818.png

2018-05-03T19:51:43Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T19:51:11Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files to be modified==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties and a dropdown for selecting a teammate review for the selected duties if role based reviewing is permitted or else display the standard view.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''
[[File:Student_view_1818.jpg]]

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

File:Rubrics 1818.png

2018-05-03T19:45:44Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T19:45:31Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files to be modified==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties and a dropdown for selecting a teammate review for the selected duties if role based reviewing is permitted or else display the standard view.'''

[[File:rubrics_1818.png]]

* app/controllers/student_teams/student_teams_controller.rb
'''In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.'''

* app/views/student_teams/view.html.erb
''' In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.'''

* app/controllers/response_controller.rb
'''In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.'''

* app/questionnaire/new.html.erb
'''A new questionnaire will be created for each new duty created or the same questionnaire can be used.'''

* app/questionnaire/edit.html.erb
'''A newly created questionnaire for a particular duty can be edited.'''

* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

File:Hidden2 1818.png

2018-05-03T19:43:10Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T19:43:00Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files to be modified==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden2_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties and a dropdown for selecting a teammate review for the selected duties if role based reviewing is permitted or else display the standard view.'''

* app/controllers/student_teams/student_teams_controller.rb
In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.

* app/views/student_teams/view.html.erb
In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.
* app/controllers/response_controller.rb
In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.
* app/questionnaire/new.html.erb
A new questionnaire will be created for each new duty created or the same questionnaire can be used.
* app/questionnaire/edit.html.erb
A newly created questionnaire for a particular duty can be edited.
* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T19:42:19Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files to be modified==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties and a dropdown for selecting a teammate review for the selected duties if role based reviewing is permitted or else display the standard view.'''

* app/controllers/student_teams/student_teams_controller.rb
In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.

* app/views/student_teams/view.html.erb
In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.
* app/controllers/response_controller.rb
In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.
* app/questionnaire/new.html.erb
A new questionnaire will be created for each new duty created or the same questionnaire can be used.
* app/questionnaire/edit.html.erb
A newly created questionnaire for a particular duty can be edited.
* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

File:Hidden 1818.png

2018-05-03T19:41:05Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T19:40:51Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files to be modified==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

[[File:hidden_1818.png]]

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties and a dropdown for selecting a teammate review for the selected duties if role based reviewing is permitted or else display the standard view.'''

* app/controllers/student_teams/student_teams_controller.rb
In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.

* app/views/student_teams/view.html.erb
In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.
* app/controllers/response_controller.rb
In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.
* app/questionnaire/new.html.erb
A new questionnaire will be created for each new duty created or the same questionnaire can be used.
* app/questionnaire/edit.html.erb
A newly created questionnaire for a particular duty can be edited.
* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

File:Review strat 1818.png

2018-05-03T19:39:01Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T19:38:35Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files to be modified==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''
[[File:review_strat_1818.png]]

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties and a dropdown for selecting a teammate review for the selected duties if role based reviewing is permitted or else display the standard view.'''

* app/controllers/student_teams/student_teams_controller.rb
In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.

* app/views/student_teams/view.html.erb
In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.
* app/controllers/response_controller.rb
In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.
* app/questionnaire/new.html.erb
A new questionnaire will be created for each new duty created or the same questionnaire can be used.
* app/questionnaire/edit.html.erb
A newly created questionnaire for a particular duty can be edited.
* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

File:Duties 1818 1.png

2018-05-03T19:37:02Z

Diddya:

File:Duties 1818 1 final.png

2018-05-03T19:36:29Z

Diddya:

CSC/ECE 517 Spring 2018- Project E1818: Role-based reviewing

2018-05-03T19:35:48Z

Diddya: /* Files that have to be modified */

==Introduction==

===Problem Statement===

The project is created to enable role-based team-mate reviews. These roles can be better named as duties, corresponding to the duty of a team member in a particular project. Borrowing from different Agile methodologies like SCRUM, each team member has a particular role for example: architect,facilitator and implementer.A much more meaningful review can be done if the review rubric was duty-specific. Currently, there is a generic teammate review rubric for all assignments. This means that some review questions are not applicable for all team members. For instance, if there is a question “What percentage of the code was written by this member?” This may not be applicable for the team member who wrote tests or documentation.Similarly, design document specific questions may not be applicable to other members.The instructor should be able to use a different team-mate review rubrics for evaluating the contribution of students depending on their duty.

==UML Diagram==

[[File:Uml2.PNG]]

In a UML Class diagram, The relationships depicted above are as follows:

* Between the User and Duty class, there is a bidirectional association. The user table is used for both the instructor and the student.
** Each instructor can have multiple roles that he can choose from for a particular assignment/questionnaire.
** Each student can have 0 or 1 role for a particular project.
* For each Questionnaire instance, there are one or more Questions that can be stored, hence there is an aggregation relationship from Question to Questionnaire. This is for the grading rubric based on the role.
* The Question table and the Questionnaire table each will be using the the duty ID to sort out questions for a particular assignment.

==Implementation==

The project introduces changes from the instructor view and the student view. The changes are as follow:

===Migration changes===
* . Create Duties table: This table stores all the duties created by any instructor.
* id - The duty ID will be used by other tables like the questionnaire table and hence will be the primary key.
* assignment_id - An assignment has particular duties. Thus, the assignment number will be the foreign key for the Duties table.
* instructor_id - The Duties created by one Instructor should be visible and reusable by that instructor only. Thus, the instructor id will also be a foreign key in the Duties table.

* Create assignments_duty_mappings table: If an instructor wants to add multiple duties for an assignment, storing it in the duty table will cause the duty to be overwritten. Thus we have created a table which maps an assignment and all its duties.
* id
* assignment_id
* duty_id

* Create assignment_duty_questionnaire_mappings table : This table is created to store the questionnaire for team-mate review rubrics and the corresponding duty id.
* id
* assignment_id
* duty_id
* questionnaire_id

* Added a column entry named "role_based_assignment" in the assignments table which would be of type boolean. This field saves the status of the role based review check box.
* Added a column entry named "allow_multiple_duties" in the assignments table which would be of type boolean. This field saves the status of the check box for allowing multiple students with the same role.
* Added a column entry named "Duties" to the Users table of type string. This field saves the duty that a student would select if role based reviews are enabled.

===Instructor view changes===
* For a particular assignment, in the 'Review Strategy' tab of edit assignment, a check box called "Allow role based review?" is created. This allows an instructor to enable a role based team-mate review for a particular assignment.
[[File:e18181_3.png]]
* When the check box is ticked, the hidden fields become visible. This includes the duties that have been already added, displayed in a drop-down. Also, a button "New duty" pops up. This takes us to the create method of Duties controller where an instructor can add new duties.
[[File:Example_e18181.png]]

* In order to display the hidden fields, We call the java script function ''dutiesAssign()'' using the ''ischecked'' listener. The function queries the checkbox variable for ''role_based_review'' and depending its value(true or false), the hidden attributes i.e. ''allow_multiple_duties'' and ''duties_dropdown'' are displayed or kept hidden.
[[File:e18181_2.png]]
* The instructor can select from the dropdown of duties. We have allowed multiple duties to be selected at once.The duties created by an instructor are unique for that instructor and are not displayed for any other instructor.
[[File:Picture1_e1818.png]]
* An instructor can decide the number of duties for a particular assignment. We have included a field for ''Allow multiple duties'' but not used it as we have the default case that one duty can be taken by multiple students. Work can be done in the future to allow the instructor to choose if students can take multiple duties.
* When the assignment is saved, the duty_id is saved to the assignment_duty_mappings table and thus it is associated with that assignment.
* The instructor can create Team-mate review Questionnaires for the different duties he created or can use any from the existing list of questionnaires.
[[File:Example2_1818.png]]
* In order to do this, the instructor has to go to the Rubrics tab of edit assignment. There, if the assignment is role-based, a drop down menu displays the list of all the duties selected for an assignment.
[[File:Example23_1818.png]]
* When the assignment is saved, the questionnaire_id is stored in the assignment_duty_questionnaire_mappings table. This is later used while displaying team-mate review questionnaire to students.

===Student view changes===
* When a student goes to “Your team”, they can see the team members, their selected duties and the option to review if these are enabled. Students will either see "Review" link to start the teammate review or a message that says that "Teammate has not selected a duty."

[[File:student_1_1818.jpg]]

* The student can select their duty from a particular set of duties created by the instructor for that particular assignment. Upon clicking "Select" option in the Duty column, they are redirected to a new page where all the duties appear as radio-buttons and the student can select one of these. This occurs only if role based reviewing is permitted for that particular assignment. If not, the existing view will be displayed which does not give any such option.

[[File:student_2_1818.jpg]]

* The logic for this is implemented in the 'student_teams' controller and view. This is enclosed in a conditional which only appears if role based reviewing is permitted.

[[File:student_3_1818.jpg]]

* A student can only select one duty.
* A team member cannot change their role after the assignment submission deadline.
* When a student selects a particular duty , it is stored in the database table of that user. Thus when a team-mate reviews that student , they will see a questionnaire corresponding to the duty of that student. This would enable reviews of the teammates to be accurate and specific to their role in a project.
* After the teammate review questionnaire is opened once, 'View' and 'Edit' links are shown which redirect the user to view/edit the appropriate last saved response.

==Files to be modified==

===New files===
Some of the new migration files we have created are

* db/migrate/add_duties_table.rb
In this file, a ''duties'' table is created with a name field

* db/migrate/add_reference_of_instructor_and_assignment_to_duties.rb
In this file, we have adding foreign key reference of ''assignment id'' into ''duties table''.

* db/migrate/add_duties_to_users.rb
In this file, a column named ''duties'' is added to the ''Users'' table

* db/migrate/add_multiple_duties_to_assignments.rb
In this file, we have added a column ''allow_multiple_duties'' to ''assignments'' table

* db/migrate/create_assignment_duty_questionnaire_mapping.rb
In this file, we have created ''assignment_duty_questionnaire_mappings'' table and added columns for ''questionnaire_id'', ''assignment_id'' and ''duty_id''

===Files that have to be modified===

* app/views/assignments/edit/review_strategy.html.erb
'''In this file, a checkbox is added to permit role based review. A hidden checkbox is added to allow multiple students to have the same role and hidden fields for adding duties along with a dropdown box for selecting from existing duties.'''

'''A java script function is added which removes the hidden attributes from for the above stated entries once the checkbox is selected.'''

* app/views/assignments/edit/rubrics.html.erb
'''In this file , a conditional statement is added, which displays the dropdown for selecting duties and a dropdown for selecting a teammate review for the selected duties if role based reviewing is permitted or else display the standard view.'''

* app/controllers/student_teams/student_teams_controller.rb
In this file, a variable is set that extracts from Assignments table if the role based reviewing is enabled or not. This variable is then used as a condition to display the various duties available for selection and also to display the particular duty chosen by the student.

* app/views/student_teams/view.html.erb
In this file, a conditional statement is added which redirects to a new page and displays the radio buttons of all the available duties if role based reviewing is allowed. If not, the standard view is displayed.
* app/controllers/response_controller.rb
In this file, the new_feedback function will be edited to map the team-mate review questionnaires according to the duties created.
* app/questionnaire/new.html.erb
A new questionnaire will be created for each new duty created or the same questionnaire can be used.
* app/questionnaire/edit.html.erb
A newly created questionnaire for a particular duty can be edited.
* app/views/duties/_form.html.erb
'''In this file we are creating a new duty and saving the assignment id and instructor id to the Duty table'''
[[File:duties_1818_1.png]]

==Test Plan==

* Instructor tests
** Check the box for role based reviewing.
*** Display and select from already existing roles(duties) with option to create new roles(duties).
*** Should not be able to see roles(duties) from other instructors.
*** Select corresponding rubrics for a particular role(duty).
** If not, proceed with the default questions for the rubric for the assignment.

* Student(team member) tests
** Before submitting the project, all team members should select a role(duty) for themselves from the roles(duties) set by the instructor.
** Multiple students may have the role(duty) but 1 student cannot have multiple roles(duties).

* Reviewer tests
** For the teammate review, only the questions related to the role(duty) selected by the student should appear in the rubric.

File:Duties 1818.png

2018-05-03T19:34:44Z

Diddya: uploaded a new version of "File:Duties 1818.png"

File:Duties 1818.png

2018-05-03T19:33:45Z

Diddya: uploaded a new version of "File:Duties 1818.png"

File:Duties 1818.png

2018-05-03T19:32:37Z

Diddya: