Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2019

2019-11-11T04:18:07Z

Dbardha:

* [[CSC/ECE 517 Fall 2019 - Project E1947. Refactor quiz_questionnaire_controller.rb]]
* [[CSC/ECE 517 Fall 2019 - Project E1965. Review report should link to the usual view for reviews]]
* [[CSC/ECE 517 Fall 2019 - Project E1943. Refactor sign up sheet controller.rb]]
* [[CSC/ECE 517 Fall 2019 - E1972. OSS project J. Skellington: Accessing Assignment Rubrics]]
* [[CSC/ECE 517 Fall 2019 - E1961. Email notification to reviewers and instructors]]
* [[CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions]]
* [[CSC/ECE 517 Fall 2019 - E1953. Tagging report for student]]
* [[CSC/ECE 517 Fall 2019 - E1955.Write unit tests for student_task.rb]]
* [[CSC/ECE 517 Fall 2019 - E1954. Auto-generate submission directory names based on assignment names]]
* [[CSC/ECE 517 Fall 2019 - E1958. Two issues related to assignment management]]
* [[CSC/ECE 517 Fall 2019 - E1948. Refactor review_mapping_helper.rb]]
* [[CSC/ECE 517 Fall 2019 - E1959. Intelligent copying of assignments without topics]]
* [[CSC/ECE 517 Fall 2019 - E1968. Fixes for adding members to teams]]
* [[CSC/ECE 517 Fall 2019 - E1969. Fixes for reviews not being available]]
* [[CSC/ECE 517 Fall 2019 - E1951. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2019 - E1957. Time travel Not Allowed..!!! Restrict TAs’ ability to change their own grade + limit file-size upload]]
* [[CSC/ECE 517 Fall 2019 - E1963. Changing assignment participant role]]
* [[CSC/ECE 517 Fall 2019 - E1941. Issues related to topic deadlines]]
* [[CSC/ECE 517 Fall 2019 - E1966. Tabbed_reviews partial file refactor for displaying the alternate view of reviews]]
* [[CSC/ECE 517 Fall 2019 - E1962. Email notification upon account creation]]
* [[CSC/ECE 517 Fall 2019 - E1967. Fix glitches in author feedback]]
* [[CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link]]
* [[CSC/ECE 517 Fall 2019 - E1939. OSS Project Juniper: Bookmark enhancements]]
* [[CSC/ECE 517 Fall 2019 - M1950. Support Asynchronous Web Assembly Compilation]]
* [[CSC/ECE 517 Fall 2019 - E1938. OSS project Duke Blue: Fix import glitches]]
* [[CSC/ECE 517 Fall 2019 - E1985. Let course staff and students do reviews]]
* [[CSC/ECE 517 Fall 2019 - M1951. Implement missing OffscreenCanvas APIs]]
* [[CSC/ECE 517 Fall 2019 - E1940. Improving email notification]]
* [[CSC/ECE 517 Fall 2019 - E1956. There is no shortcut to get free review points: Review Assignment Bug]]
* [[CSC/ECE 517 Fall 2019 - E1942. Refactor stage deadlines in assignment.rb]]
* [[CSC/ECE 517 Fall 2019 - M1952. Missing DOM features project]]
* [[CSC/ECE 517 Fall 2019 - E1945. Refactor users_controller.rb]]
* [[CSC/ECE 517 Fall 2019 - E1964. Export review scores for projects]]
* [[CSC/ECE 517 Fall 2019 - E1949. Write Unit Tests for Importing assignment participants and import glitches]]
* [[CSC/ECE 517 Fall 2019 - E1944. Refactor review mapping controller]]
* [[CSC/ECE 517 Fall 2019 - E1946. Refactor Questionnaire controller]]
* [[CSC/ECE 517 Fall 2019 - E1982. Regulate changing of rubrics while projects are in progress]]
* [[CSC/ECE 517 Fall 2019 - E1989. Track the time students look at other submissions]]
* [[CSC/ECE 517 Fall 2019 - E1990. Integrate suggestion detection algorithm]]
* [[CSC/ECE 517 Fall 2019 - E1995. Tests for email functionality]]
* [[CSC/ECE 517 Fall 2019 - E1993 Track Time Between Successive Tag Assignments]]
* [[CSC/ECE 517 Fall 2019 - E1979. Completion/Progress view]]
* [[CSC/ECE 517 Fall 2019 - E1995. Weights in grade calculation]]
* [[CSC/ECE 517 Fall 2019 - E1980. Sort instructor reports by name, ID, score, etc.]]
* [[CSC/ECE 517 Fall 2019 - E1984. Improve self-review Link peer review & self-review to derive grades]]
* [[CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics]]
* [[CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing]]
* [[CSC/ECE 517 Fall 2019 - E1981. Student-generated questions added to rubric]]
* [[CSC/ECE 517 Fall 2019 - E1996. Enhancements to review grader]]
* [[CSC/ECE 517 Fall 2019 - E1987. Improving search facility in Expertiza]]
* [[CSC/ECE 517 Fall 2019 - E1978. Fix issues related to deadlines and late policies]]
* [[CSC/ECE 517 Fall 2019 - E1991. Improvements to anonymized view]]

CSC/ECE 517 Fall 2019 - E1991. Improvements to anonymized view

2019-11-11T04:16:49Z

Dbardha: Created page with "== ''' Introduction ''' == The [http://expertiza.ncsu.edu/ Expertiza] project takes advantage of peer-review among students to allow them to learn from each other. Tracking the t..."

== ''' Introduction ''' ==
The [http://expertiza.ncsu.edu/ Expertiza] project takes advantage of peer-review among students to allow them to learn from each other. Tracking the time that a student spends on each submitted resources is meaningful to instructors to study and improve the teaching experience. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors to submit external links to the submission (e.g. GitHub code / deployed application), which makes it difficult for the system to track the time that the reviewers spend on the submissions.

== ''' Problem Statement ''' ==

== ''' Proposed Solution ''' ==

=== ''' User Flowchart/Design ''' ===

== ''' Test Plan ''' ==

== ''' Team Information ''' ==
#Shubham Dilip Pampattiwar (sdpampat)
#Pranav Maruti Gaikwad (pmgaikwa)
#Omkar Sunil Kulkarni (oskulkar)
#Deepayan Bardhan (dbardha)

'''Mentor''': Sharique Khan (mkhan8)
 '''Professor''': Dr. Edward F. Gehringer (efg)

==References==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]

CSC/ECE 517 Fall 2019 - E1991 Improvements to anonymized view

2019-11-11T00:10:18Z

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-11-06T05:45:26Z

Dbardha:

__TOC__

== '''About Expertiza''' ==
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

== '''Abstract''' ==
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

== '''Problem Statement''' ==

The ''users_controller.rb'' file included the standard CRUD methods for a ''User'' model along with methods for other workflows. Most notably, the ''users_controller.rb'' file handled the creation and management of a ''RequestedUser'' object. The file also included a few methods which had a bad name or lack documentation. Thus it required to make the following changes to make the code more readable and change certain views.

The following tasks were required to be done for the project by our team:

* Separate all methods related to the workflow of a ''RequestedUser'' object
* Move below-mentioned methods to a new file named ''account_request_controller.rb''
# created_approved_user
# list_pending_requested
# request_new
# created_requested_user_record
# roles_for_request_sign_up
# Requested_user_params
* The ''RequestedUser'' model should be renamed to ''AccountRequest'' and it’s lifetime must be managed by the new ''AccountRequestController''
* The form that was currently displayed when the “Request Account” button is clicked from the Expertiza login page. It had to be edited with the following changes
** Only instructor accounts can be created, so the dropdown had to be removed
** All form labels had to be bold-faced
** The “Self Introduction” label should be re-named to “Self-Introduction”
** The textbox for the self-introduction field should include some hint (“Please include a link to your website”)
* Comments had to be written for the following methods
# get_role
# show_selection
# foreign
* The paginate_list method had to be invoked at the correct location (in the list method) so that it paginates the users list correctly. Presently all users being shown on a single page by default on clicking the user list.

== '''Our Work''' ==

=== Changing the Request Account Page ===

This is the page that was loading originally when '''request account''' button is clicked in the login page:

[[File:Newuser.png|center|frame|none]]

==== Removing Dropdown ====
Only the Instructor account can be created and not TA which is there as an option originally.
For this in the '''request_new.html.erb''' file, the selection tag has been changed to label tag in which the '''Instructor''' is put on the label

==== All form labels had to be bold-faced ====
For this in the individual forms inside the view are visited and bold tag has been added individually.

==== Renaming Self Introduction ====
Inside the '''_self_introduction.html.erb''' file the label is edited to the required one.

==== Adding hints in text-box ====
Initially, the text-box was blank and some hints had to be added. This was done by adding a place_holder attribute inside the text area inside the '''_self_introduction.html.erb''' file

This is the current page that gets loaded after fixing the above issues:

[[File:Expertiza.png|center|frame|none]]

=== Adding comments for methods ===
The following methods had comments written or renamed for better understanding of the working of the methods and to reflect their actual behaviour.
#get_role - The method was renamed to '''role''', a comment was added explaining that it finds the role of a given user object
#show_selection - The method was renamed to '''show_if_authorized''', as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
#foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

[[File:Foreign.png|center|caption]]

=== Invoking paginate_list method ===

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the '''list.html.erb''' page for navigating between the paginated list of users.

[[File:Paginate.png|center|]]

As it can be seen now that there are page numbers and not all the users are being showed on the same page as was the case beforehand.

== '''Results''' ==
The refactoring of the user_controller made the view for the account request more clearer and easy to understand for the user i.e. the UI was improved. Also, the code was made more cleaner and easy to read by for people who works on this later as the methods are segregated for performing their corresponding tasks and they comments are given for those which were not clear. Furthermore, the paginate users is now repaired and is working properly which lets the students list to be shown page wise instead of all the students in a single page which was not readable.

== '''Test Plan''' ==

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file ''account_request_spec.rb''. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

== '''Useful Links''' ==

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza

'''VCL Deployment Link:''' http://152.46.19.122:3000

'''Project Mentor:'''
 Ramya Vijayakumar

'''Project Members:''' 
Benjamin Fisher 
Deepayan Bardhan 
Sanket Pai

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-11-06T05:40:42Z

Dbardha:

__TOC__

== '''About Expertiza''' ==
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

== '''Abstract''' ==
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

== '''Problem Statement''' ==

The ''users_controller.rb'' file included the standard CRUD methods for a ''User'' model along with methods for other workflows. Most notably, the ''users_controller.rb'' file handled the creation and management of a ''RequestedUser'' object. The file also included a few methods which had a bad name or lack documentation. Thus it required to make the following changes to make the code more readable and change certain views.

The following tasks were required to be done for the project by our team:

* Separate all methods related to the workflow of a ''RequestedUser'' object
* Move below-mentioned methods to a new file named ''account_request_controller.rb''
# created_approved_user
# list_pending_requested
# request_new
# created_requested_user_record
# roles_for_request_sign_up
# Requested_user_params
* The ''RequestedUser'' model should be renamed to ''AccountRequest'' and it’s lifetime must be managed by the new ''AccountRequestController''
* The form that was currently displayed when the “Request Account” button is clicked from the Expertiza login page. It had to be edited with the following changes
** Only instructor accounts can be created, so the dropdown had to be removed
** All form labels had to be bold-faced
** The “Self Introduction” label should be re-named to “Self-Introduction”
** The textbox for the self-introduction field should include some hint (“Please include a link to your website”)
* Comments had to be written for the following methods
# get_role
# show_selection
# foreign
* The paginate_list method had to be invoked at the correct location (in the list method) so that it paginates the users list correctly. Presently all users being shown on a single page by default on clicking the user list.

== '''Our Work''' ==

=== Changing the Request Account Page ===

This is the page that was loading originally when '''request account''' button is clicked in the login page:

[[File:Newuser.png|center|frame|none]]

==== Removing Dropdown ====
Only the Instructor account can be created and not TA which is there as an option originally.
For this in the '''request_new.html.erb''' file, the selection tag has been changed to label tag in which the '''Instructor''' is put on the label

==== All form labels had to be bold-faced ====
For this in the individual forms inside the view are visited and bold tag has been added individually.

==== Renaming Self Introduction ====
Inside the '''_self_introduction.html.erb''' file the label is edited to the required one.

==== Adding hints in text-box ====
Initially, the text-box was blank and some hints had to be added. This was done by adding a place_holder attribute inside the text area inside the '''_self_introduction.html.erb''' file

This is the current page that gets loaded after fixing the above issues:

[[File:Expertiza.png|center|frame|none]]

=== Adding comments for methods ===
The following methods had comments written or renamed for better understanding of the working of the methods and to reflect their actual behaviour.
#get_role - The method was renamed to '''role''', a comment was added explaining that it finds the role of a given user object
#show_selection - The method was renamed to '''show_if_authorized''', as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
#foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

[[File:Foreign.png|center|caption]]

=== Invoking paginate_list method ===

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the '''list.html.erb''' page for navigating between the paginated list of users.

[[File:Paginate.png|center|]]

As it can be seen now that there are page numbers and not all the users are being showed on the same page as was the case beforehand.

== '''Test Plan''' ==

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file ''account_request_spec.rb''. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

== '''Useful Links''' ==

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza

'''VCL Deployment Link:''' http://152.46.19.122:3000

'''Project Mentor:'''
 Ramya Vijayakumar

'''Project Members:''' 
Benjamin Fisher 
Deepayan Bardhan 
Sanket Pai

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-11-06T05:31:00Z

Dbardha:

__TOC__

== '''About Expertiza''' ==
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

== '''Abstract''' ==
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

== '''Problem Statement''' ==

The ''users_controller.rb'' file included the standard CRUD methods for a ''User'' model along with methods for other workflows. Most notably, the ''users_controller.rb'' file handled the creation and management of a ''RequestedUser'' object. The file also included a few methods which had a bad name or lack documentation. Thus it required to make the following changes to make the code more readable and change certain views.

The following tasks were required to be done for the project by our team:

* Separate all methods related to the workflow of a ''RequestedUser'' object
* Move below-mentioned methods to a new file named ''account_request_controller.rb''
# created_approved_user
# list_pending_requested
# request_new
# created_requested_user_record
# roles_for_request_sign_up
# Requested_user_params
* The ''RequestedUser'' model should be renamed to ''AccountRequest'' and it’s lifetime must be managed by the new ''AccountRequestController''
* The form that was currently displayed when the “Request Account” button is clicked from the Expertiza login page. It had to be edited with the following changes
** Only instructor accounts can be created, so the dropdown had to be removed
** All form labels had to be bold-faced
** The “Self Introduction” label should be re-named to “Self-Introduction”
** The textbox for the self-introduction field should include some hint (“Please include a link to your website”)
* Comments had to be written for the following methods
# get_role
# show_selection
# foreign
* The paginate_list method had to be invoked at the correct location (in the list method) so that it paginates the users list correctly. Presently all users being shown on a single page by default on clicking the user list.

== '''Our Work''' ==

=== Changing the Request Account Page ===

This is the page that was loading originally when '''request account''' button is clicked in the login page:

[[File:Newuser.png|center|frame|none]]

==== Removing Dropdown ====
Only the Instructor account can be created and not TA which is there as an option originally.
For this in the '''request_new.html.erb''' file, the selection tag has been changed to label tag in which the '''Instructor''' is put on the label

==== All form labels had to be bold-faced ====
For this in the individual forms inside the view are visited and bold tag has been added individually.

==== Renaming Self Introduction ====
Inside the '''_self_introduction.html.erb''' file the label is edited to the required one.

==== Adding hints in text-box ====
Initially, the text-box was blank and some hints had to be added. This was done by adding a place_holder attribute inside the text area inside the '''_self_introduction.html.erb''' file

This is the current page that gets loaded after fixing the above issues:

[[File:Expertiza.png|center|frame|none]]

=== Adding comments for methods ===
The following methods had comments written or renamed for better understanding of the working of the methods and to reflect their actual behaviour.
#get_role - The method was renamed to '''role''', a comment was added explaining that it finds the role of a given user object
#show_selection - The method was renamed to '''show_if_authorized''', as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
#foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

[[File:Foreign.png|center|caption]]

=== Invoking paginate_list method ===

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the '''list.html.erb''' page for navigating between the paginated list of users.

[[File:Paginate.png|center|]]

As it can be seen now that there are page numbers and not all the users are being showed on the same page as was the case beforehand.

== '''Test''' ==

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file account_request_spec.rb. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza

'''VCL Deployment Link:''' http://152.46.19.122:3000

'''Project Mentor:'''
 Ramya Vijayakumar

'''Project Members:''' 
Benjamin Fisher 
Deepayan Bardhan 
Sanket Pai

File:Newuser.png

2019-11-06T03:48:16Z

Dbardha:

File:New user.png

2019-11-05T23:03:13Z

Dbardha:

File:New user.jpg

2019-11-05T22:23:25Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-11-05T03:48:57Z

Dbardha:

File:Expertiza.png

2019-11-05T03:29:27Z

Dbardha: uploaded a new version of "File:Expertiza.png"

File:Expertiza.png

2019-11-05T03:28:50Z

Dbardha: uploaded a new version of "File:Expertiza.png"

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-10-29T03:56:59Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor Users_controller.rb

===='''About Expertiza'''====
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

===='''Abstract'''====
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

===='''Problem Statement'''====
The following tasks were accomplished in the project by our team:

*Moved the following methods from UserController to AccountRequestController
#Methods affected:
##created_approved_user
##list_pending_requested
##request_new
##created_requested_user_record
##roles_for_request_sign_up
##Requested_user_params
#All the above mentioned methods have been moved to a new file named account_request_controller.rb
#The RequestedUser model has been renamed to AccountRequest. And is now managed by the AccountRequestController
#The form that is currently displayed when the “Request Account” button is clicked from the Expertiza login page has been edited with the following changes
##Only instructor accounts can be created, so the dropdown has been removed
##All form labels are now bold-faced
##The “Self Introduction” label has been re-named to “Self-Introduction”
##The textbox for the self-introduction field now includes some hint (“Please include a link to your website”)
This is the current page after fixing the issues that gets loaded after the “request Account” button is clicked

[[File:Expertiza.png]]

Comments were written or renamed for the following methods to get a clear understanding of the working of the methods and to reflect their actual behaviour.
get_role - The method was renamed to role, a comment was added explaining that it finds the role of a given user object
show_selection - The method was renamed to show_if_authorized, as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

[[File:Foreign.png]]

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the list.html.erb page for navigating between the paginated list of users.

[[File:Paginate.png]]

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file account_request_spec.rb. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza
'''VCL Deployment Link:''' http://152.46.19.122:3000

'''Project Mentor:'''
Ramya Vijayakumar

'''Project Members:'''
Benjamin Fisher,
Deepayan Bardhan,
Sanket Pai

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-10-29T03:54:31Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor Users_controller.rb

===='''About Expertiza'''====
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

===='''Abstract'''====
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

===='''Problem Statement'''====
The following tasks were accomplished in the project by our team:

*Moved the following methods from UserController to AccountRequestController
#Methods affected:
##created_approved_user
##list_pending_requested
##request_new
##created_requested_user_record
##roles_for_request_sign_up
##Requested_user_params
#All the above mentioned methods have been moved to a new file named account_request_controller.rb
#The RequestedUser model has been renamed to AccountRequest. And is now managed by the AccountRequestController
#The form that is currently displayed when the “Request Account” button is clicked from the Expertiza login page has been edited with the following changes
##Only instructor accounts can be created, so the dropdown has been removed
##All form labels are now bold-faced
##The “Self Introduction” label has been re-named to “Self-Introduction”
##The textbox for the self-introduction field now includes some hint (“Please include a link to your website”)
This is the current page after fixing the issues that gets loaded after the “request Account” button is clicked

[[File:Expertiza.png]]

Comments were written or renamed for the following methods to get a clear understanding of the working of the methods and to reflect their actual behaviour.
get_role - The method was renamed to role, a comment was added explaining that it finds the role of a given user object
show_selection - The method was renamed to show_if_authorized, as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

[[File:Foreign.png]]

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the list.html.erb page for navigating between the paginated list of users.

[[File:Paginate.png]]

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file account_request_spec.rb. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza

'''Project Mentor:'''
Ramya Vijayakumar

'''Project Members:'''
Benjamin Fisher
Deepayan Bardhan
Sanket Pai

File:Paginate.png

2019-10-29T03:53:59Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-10-29T03:50:12Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor Users_controller.rb

===='''About Expertiza'''====
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

===='''Abstract'''====
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

===='''Problem Statement'''====
The following tasks were accomplished in the project by our team:

*Moved the following methods from UserController to AccountRequestController
#Methods affected:
##created_approved_user
##list_pending_requested
##request_new
##created_requested_user_record
##roles_for_request_sign_up
##Requested_user_params
#All the above mentioned methods have been moved to a new file named account_request_controller.rb
#The RequestedUser model has been renamed to AccountRequest. And is now managed by the AccountRequestController
#The form that is currently displayed when the “Request Account” button is clicked from the Expertiza login page has been edited with the following changes
##Only instructor accounts can be created, so the dropdown has been removed
##All form labels are now bold-faced
##The “Self Introduction” label has been re-named to “Self-Introduction”
##The textbox for the self-introduction field now includes some hint (“Please include a link to your website”)
This is the current page after fixing the issues that gets loaded after the “request Account” button is clicked

[[File:Expertiza.png]]

Comments were written or renamed for the following methods to get a clear understanding of the working of the methods and to reflect their actual behaviour.
get_role - The method was renamed to role, a comment was added explaining that it finds the role of a given user object
show_selection - The method was renamed to show_if_authorized, as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

[[File:Foreign.png]]

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the list.html.erb page for navigating between the paginated list of users.

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file account_request_spec.rb. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza

'''Project Mentor:'''
Ramya Vijayakumar

'''Project Members:'''
Benjamin Fisher
Deepayan Bardhan
Sanket Pai

File:Foreign.png

2019-10-29T03:49:19Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-10-29T03:47:58Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor Users_controller.rb

===='''About Expertiza'''====
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

===='''Abstract'''====
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

===='''Problem Statement'''====
The following tasks were accomplished in the project by our team:

*Moved the following methods from UserController to AccountRequestController
#Methods affected:
##created_approved_user
##list_pending_requested
##request_new
##created_requested_user_record
##roles_for_request_sign_up
##Requested_user_params
#All the above mentioned methods have been moved to a new file named account_request_controller.rb
#The RequestedUser model has been renamed to AccountRequest. And is now managed by the AccountRequestController
#The form that is currently displayed when the “Request Account” button is clicked from the Expertiza login page has been edited with the following changes
##Only instructor accounts can be created, so the dropdown has been removed
##All form labels are now bold-faced
##The “Self Introduction” label has been re-named to “Self-Introduction”
##The textbox for the self-introduction field now includes some hint (“Please include a link to your website”)
This is the current page after fixing the issues that gets loaded after the “request Account” button is clicked

[[File:Expertiza.png]]

Comments were written or renamed for the following methods to get a clear understanding of the working of the methods and to reflect their actual behaviour.
get_role - The method was renamed to role, a comment was added explaining that it finds the role of a given user object
show_selection - The method was renamed to show_if_authorized, as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the list.html.erb page for navigating between the paginated list of users.

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file account_request_spec.rb. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza

'''Project Mentor:'''
Ramya Vijayakumar

'''Project Members:'''
Benjamin Fisher
Deepayan Bardhan
Sanket Pai

File:Expertiza.png

2019-10-29T03:44:09Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-10-29T03:39:18Z

Dbardha:

CSC/ECE 517 Fall 2019 - E1945. Refactor Users_controller.rb

==Contents:==

#About Expertiza
#Users Controller
#Problem Statement
##Documentation of methods
##Refactoring Methods to Account Controller
##Making AccountRequest Model
#What We did
##Refactoring Users controller
##Refactoring Tests

===='''About Expertiza'''====
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

===='''Abstract'''====
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

===='''Problem Statement'''====
The following tasks were accomplished in the project by our team:

*Moved the following methods from UserController to AccountRequestController
#Methods affected:
##created_approved_user
##list_pending_requested
##request_new
##created_requested_user_record
##roles_for_request_sign_up
##Requested_user_params
#All the above mentioned methods have been moved to a new file named account_request_controller.rb
#The RequestedUser model has been renamed to AccountRequest. And is now managed by the AccountRequestController
#The form that is currently displayed when the “Request Account” button is clicked from the Expertiza login page has been edited with the following changes
##Only instructor accounts can be created, so the dropdown has been removed
##All form labels are now bold-faced
##The “Self Introduction” label has been re-named to “Self-Introduction”
##The textbox for the self-introduction field now includes some hint (“Please include a link to your website”)
This is the current page after fixing the issues that gets loaded after the “request Account” button is clicked

[https://ibb.co/8YpnP74]

Comments were written or renamed for the following methods to get a clear understanding of the working of the methods and to reflect their actual behaviour.
get_role - The method was renamed to role, a comment was added explaining that it finds the role of a given user object
show_selection - The method was renamed to show_if_authorized, as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the list.html.erb page for navigating between the paginated list of users.

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file account_request_spec.rb. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza

'''Project Mentor:'''
Ramya Vijayakumar

'''Project Members:'''
Benjamin Fisher
Deepayan Bardhan
Sanket Pai

CSC/ECE 517 Fall 2019 - E1945. Refactor users controller.rb

2019-10-29T03:35:25Z

Dbardha: /* Contents: */

CSC/ECE 517 Fall 2019 - E1945. Refactor Users_controller.rb

==Contents:==

#About Expertiza
#Users Controller
#Problem Statement
##Documentation of methods
##Refactoring Methods to Account Controller
##Making AccountRequest Model
#What We did
##Refactoring Users controller
##Refactoring Tests

===='''About Expertiza'''====
Expertiza is an open-source project based on Ruby on Rails framework. It allows the instructor to create new assignments and customize new or existing assignments. The instructor is allowed to create a list of topics for the students to which they can sign up for. For working on different projects and assignments the students can form teams in Expertiza. Peer review is another feature where students can review other students' submissions. This feature is available in Expertiza. Furthermore, Expertiza supports submission across various document types, including URLs and wiki pages.

===='''Abstract'''====
The UserController is a controller used for managing the creation, modification, and destruction of users in the Expertiza system. Instructor users must be added by creating a request for a new account. A key part of our team’s work was moving methods associated with managing a new account request from the UserController to a new controller named AccountRequestController. This removed coupling between account requests and user objects. Furthermore, it allowed an account request to be properly associated with its own controller, model, and view. Additionally, the team refactored and documented some methods in the UserController.

===='''Problem Statement'''====
The following tasks were accomplished in the project by our team:

*Moved the following methods from UserController to AccountRequestController
#Methods affected:
##created_approved_user
##list_pending_requested
##request_new
##created_requested_user_record
##roles_for_request_sign_up
##Requested_user_params
#All the above mentioned methods have been moved to a new file named account_request_controller.rb
#The RequestedUser model has been renamed to AccountRequest. And is now managed by the AccountRequestController
#The form that is currently displayed when the “Request Account” button is clicked from the Expertiza login page has been edited with the following changes
##Only instructor accounts can be created, so the dropdown has been removed
##All form labels are now bold-faced
##The “Self Introduction” label has been re-named to “Self-Introduction”
##The textbox for the self-introduction field now includes some hint (“Please include a link to your website”)
This is the current page after fixing the issues that gets loaded after the “request Account” button is clicked

Comments were written or renamed for the following methods to get a clear understanding of the working of the methods and to reflect their actual behaviour.
get_role - The method was renamed to role, a comment was added explaining that it finds the role of a given user object
show_selection - The method was renamed to show_if_authorized, as this method should only display the users if the current user is authorized. Also changed it from a GET to a POST request since it more accurately reflects its working.
foreign - A comment was added for this method, explaining that it stores all roles possible and that it gets role id of the session’s user.

Invoked the paginate_list method at the correct location(in the list method) so that it paginates the users list correctly. The number of users per-page has currently been set to 100, which was showing all users in a single page by default. Also added a section at the bottom of the list.html.erb page for navigating between the paginated list of users.

Tests for UserController were updated to account for the fact that some methods now use the AccountRequestController. The tests for the methods that were moved to AccountRequestController were moved to a new spec in the file account_request_spec.rb. The team did this because it made sense to make a new spec for a new controller. Nevertheless, most test functionalities remained the same. The tests were also updated to not select the user role from the “User Role” dropdown. This was done because the dropdown was removed from the UI since only instructor accounts can be created.

'''Github Repo:''' https://github.com/deepayanbardhan/expertiza

'''Project Mentor:'''
Ramya Vijayakumar

'''Project Members:'''
Benjamin Fisher
Deepayan Bardhan
Sanket Pai