Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Spring 2021 - E2115. Mentor management for assignments without topics

2021-03-28T22:00:56Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Team Members ===
* Yi Qiu
* Ryan Smith
* Jose Molina Melendez
* Bahati Wanza
=== Problem Statement ===
Currently, Expertiza has no way to associate mentors with teams. For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.
=== The Plan ===
For assignments without topics, mentors should be assigned to teams. Assume that
things happen in the following order:
* An assignment without topics is created that requires teams of size of up to k.
* Students sign up for teams.
* When a team reaches a target size of greater than 50% of the maximum teammate capacity, then:
** A mentor will be assigned to this team and notified via email.
** Participants in an assignment will be identified as mentors via their participant permissions ([https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1963._Changing_assignment_participant_role see the E1963 documentation]). This adds a fourth, “mentor” permission to the existing three permissions (“submit”, “review”, and “take quiz”). Anyone with “mentor” permission for an assignment is eligible to be automatically assigned to mentor a team when a new team is formed.
=== What needs to be done ===
Develop a trigger that:
* Is activated when any team has been formed that has k members, where k is greater than 50% of the maximum team capacity
** ex: max members = 4, trigger activated when the team size reaches 3
* Assign a mentor to the team
** Mentors should be evenly assigned to teams, so a good strategy is to assign the mentor who has the fewest teams to mentor so far.
* Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members.
* Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here).

CSC/ECE 517 Spring 2021 - E2115. Mentor management for assignments without topics

2021-03-28T21:54:29Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Team Members ===
* Yi Qiu
* Ryan Smith
* Jose Molina Melendez
* Bahati Wanza
=== Problem Statement ===
Currently, Expertiza has no way to associate mentors with teams. For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.
=== The Plan ===
For assignments without topics, mentors should be assigned to teams. Assume that
things happen in the following order:
* An assignment without topics is created that requires teams of size of up to k.
* Students sign up for teams.
* When a team reaches a target size of greater than 50% of the maximum teammate capacity, then:
** A mentor will be assigned to this team and notified via email.
** Participants in an assignment will be identified as mentors via their participant permissions (see the E1963 documentation). This adds a fourth, “mentor” permission to the existing three permissions (“submit”, “review”, and “take quiz”). Anyone with “mentor” permission for an assignment is eligible to be automatically assigned to mentor a team when a new team is formed.
=== What needs to be done ===
Develop a trigger that:
* Is activated when any team has been formed that has k members, where k is greater than 50% of the maximum team capacity
** ex: max members = 4, trigger activated when the team size reaches 3
* Assign a mentor to the team
** Mentors should be evenly assigned to teams, so a good strategy is to assign the mentor who has the fewest teams to mentor so far.
* Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members.
* Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here).

CSC/ECE 517 Spring 2021 - E2115. Mentor management for assignments without topics

2021-03-28T21:51:35Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Team Members ===
* Yi Qiu
* Ryan Smith
* Jose Molina Melendez
* Bahati Wanza
=== Problem Statement ===
Currently, Expertiza has no way to associate mentors with teams. For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.
=== The Plan ===
For assignments without topics, mentors should be assigned to teams. Assume that
things happen in the following order:
* An assignment without topics is created that requires teams of size of up to k.
* Students sign up for teams.
* When a team reaches a target size of greater than 50% of the maximum teammate capacity, then:
** A mentor will be assigned to this team and notified via email.
** Participants in an assignment will be identified as mentors via their participant permissions (see the E1963 documentation). This adds a fourth, “mentor” permission to the existing three permissions (“submit”, “review”, and “take quiz”). Anyone with “mentor” permission for an assignment is eligible to be automatically assigned to mentor a team when a new team is formed.
=== What needs to be done ===
* Develop a trigger that:
** Is activated when any team has been formed that has k members, where k is
greater than 50% of the maximum team capacity
*** ex: max members = 4, trigger activated when the team size reaches 3
** Assign a mentor to the team
*** Mentors should be evenly assigned to teams, so a good strategy is to
assign the mentor who has the fewest teams to mentor so far.
** Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members.
** Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here).

CSC/ECE 517 Spring 2021 - E2115. Mentor management for assignments without topics

2021-03-28T21:44:44Z

Bwanza: Created page with "__TOC__ == ''' Introduction ''' == === Team Members === * Yi Qiu * Ryan Smith * Jose Molina Melendez * Bahati Wanza === Problem Statement === Currently, Expertiza has no way t..."

CSC/ECE 517 Spring 2021

2021-03-28T21:10:40Z

Bwanza:

== OSS Projects ==
* [[CSC/ECE 517 Spring 2021 - E2100. Tagging report for students]]
* [[CSC/ECE 517 Spring 2021 - E2101. Refactor questionnaires controller.rb]]
* [[CSC/ECE 517 Spring 2021 - E2106. Fix view in student_task/list page]]
* [[CSC/ECE 517 Spring 2021 - E2103. Refactor response_controller.rb]]
* [[CSC/ECE 517 Spring 2021 - E2107. Refactor grades_controller.rb]]
* [[CSC/ECE 517 Spring 2021 - E2102. Refactor quiz_questionnaires_controller.rb]]
* [[CSE/ECE 517 Spring 2021 - E2108. Impersonate_controller.rb]]
* [[CSE/ECE 517 Spring 2021 - E2105. Track the time students look at other submissions]]
* [[CSE/ECE 517 Spring 2021 - E2104. Email notification to reviewers and instructors]]

== Final Projects ==
* [[CSC/ECE 517 Spring 2021 - E2110. Regulate changing of rubrics while projects are in progress]]
* [[CSC/ECE 517 Spring 2021 - E2111. Refactor github metrics integration]]
* [[CSC/ECE 517 Spring 2021 - E2115. Mentor management for assignments without topics]]

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T23:39:21Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]
[[File: mean_a.PNG | 550px]]

Moved the ''calculate_average_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''vector''.

[[File: calculate_average_vector.PNG | 550px]]
[[File: calculate_average_vector_a.PNG | 550px]]

Moved the ''build_score_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''score_vector''.

[[File: build_score_vector.PNG | 550px]]
[[File: build_score_vector_a.PNG | 550px]]

Moved the ''Remove_negative_scores_and_build_charts'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''charts''.

[[File: remove_negative_scores.PNG | 550px]]
[[File: remove_negative_scores_a.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

[[File:Passed Test.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T23:36:16Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T23:35:50Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]
[[File: mean_a.PNG | 550px]]

Moved the ''calculate_average_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''vector''.

[[File: calculate_average_vector.PNG | 550px]]
[[File: calculate_average_vector_a.PNG | 550px]]

Moved the ''build_score_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''score_vector''.

[[File: build_score_vector.PNG | 550px]]
[[File: build_score_vector_a.PNG | 550px]]

Moved the ''Remove_negative_scores_and_build_charts'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''charts''.

[[File: remove_negative_scores.PNG | 550px]]
[[File: remove_negative_scores_a.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]
[[File:Passed Test.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T23:34:53Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]
[[File: mean_a.PNG | 550px]]

Moved the ''calculate_average_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''vector''.

[[File: calculate_average_vector.PNG | 550px]]
[[File: calculate_average_vector_a.PNG | 550px]]

Moved the ''build_score_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''score_vector''.

[[File: build_score_vector.PNG | 550px]]
[[File: build_score_vector_a.PNG | 550px]]

Moved the ''Remove_negative_scores_and_build_charts'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''charts''.

[[File: remove_negative_scores.PNG | 550px]]
[[File: remove_negative_scores_a.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]
[[File:Test Passed Test.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

File:Passed Test.PNG

2021-03-19T23:34:02Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T23:33:37Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]
[[File: mean_a.PNG | 550px]]

Moved the ''calculate_average_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''vector''.

[[File: calculate_average_vector.PNG | 550px]]
[[File: calculate_average_vector_a.PNG | 550px]]

Moved the ''build_score_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''score_vector''.

[[File: build_score_vector.PNG | 550px]]
[[File: build_score_vector_a.PNG | 550px]]

Moved the ''Remove_negative_scores_and_build_charts'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''charts''.

[[File: remove_negative_scores.PNG | 550px]]
[[File: remove_negative_scores_a.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]
[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T23:29:22Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]
[[File: mean_a.PNG | 550px]]

Moved the ''calculate_average_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''vector''.

[[File: calculate_average_vector.PNG | 550px]]
[[File: calculate_average_vector_a.PNG | 550px]]

Moved the ''build_score_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''score_vector''.

[[File: build_score_vector.PNG | 550px]]
[[File: build_score_vector_a.PNG | 550px]]

Moved the ''Remove_negative_scores_and_build_charts'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''charts''.

[[File: remove_negative_scores.PNG | 550px]]
[[File: remove_negative_scores_a.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T23:25:38Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]
[[File: mean_a.PNG | 550px]]

Moved the ''calculate_average_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''vector''.

[[File: calculate_average_vector.PNG | 550px]]
[[File: calculate_average_vector_a.PNG | 550px]]

Moved the ''build_score_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''score_vector''.

[[File: build_score_vector.PNG | 550px]]
[[File: build_score_vector_a.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T23:11:40Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]
[[File: mean_a.PNG | 550px]]

Moved the ''calculate_average_vector'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''vector''.

[[File: calculate_average_vector.PNG | 550px]]
[[File: calculate_average_vector_a.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

File:Remove negative scores a.PNG

2021-03-19T23:03:52Z

Bwanza:

File:Build score vector a.PNG

2021-03-19T23:02:12Z

Bwanza:

File:Calculate average vector a.PNG

2021-03-19T23:01:43Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T22:53:31Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]
[[File: mean_a.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

File:Mean a.PNG

2021-03-19T22:52:37Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T22:50:27Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside.

[[File: mean.PNG | 550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T22:49:08Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

Moved the ''mean'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and refactored the code inside the function.

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T03:15:36Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|550px]]
[[File: calcuate_penalties_attributes_c.PNG|550px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T03:14:57Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

[[File: calcuate_penalties_attributes_b.PNG|500px]]
[[File: calcuate_penalties_attributes_c.PNG|500px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

File:Calcuate penalties attributes c.PNG

2021-03-19T03:13:26Z

Bwanza:

File:Calcuate penalties attributes b.PNG

2021-03-19T03:13:12Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T03:11:27Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

Moved the ''calculate_penalty_attributes'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''attributes''.

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T03:06:42Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_b.PNG|500px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

File:Calculate all penalties b.PNG

2021-03-19T03:05:50Z

Bwanza:

File:Calculate all penalties a.PNG

2021-03-19T03:02:26Z

Bwanza: Bwanza uploaded a new version of File:Calculate all penalties a.PNG

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T02:58:36Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG|500px]]
[[File: calculate_all_penalties_a.PNG|500px]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

File:Calculate all penalties a.PNG

2021-03-19T02:54:38Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-19T02:54:22Z

Bwanza:

__TOC__
== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented in the '' grades_controller.rb '' file. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''
* The previous programmer used update_attribute, which is concerning, as validations are ignored (Line 153 and 219).
=== Refactoring Grades Controller ===
*Comment changed that was wrong ("head" into "heat")
[[File:Comment.PNG]]
*Line 102-107 (New Private Method made to encapsulate this)
[[File:102.PNG]]

The private method is called instead

[[File:New102.PNG]]

Private method details

[[File:populate view model.PNG]]

*Line 190-192
[[File:190.PNG]]
Simplify Logic
[[File:Change190.PNG]]

*Line 300
[[File:Line 300.PNG]]

Boolean expression clean up with variables
and white spaces/return statement removed

[[File: NewLine 300.PNG]]

*Lines 153/219
153 function removed
[[File: 153.PNG]]
[[File: New153.PNG]]

219 function removed
[[File: 219.PNG]]
[[File: New219.PNG]]

Moved the ''calculate_all_penalties'' function from ''grades_controller.rb'' to ''grades_helper.rb'' and renamed it ''penalties''.

[[File: calculate_all_penaltyies.PNG]]

=== Testing Code ===
To test this controller, run the following command to verify the changes do not break any core functions.
rspec spec/controllers/grades_controller_spec.rb

[[File:Test grades controller.PNG]]

When you run the program and get to login page. Use credentials below for instructor.

username: Instructor6
password: password

A good student to impersonate for testing is
student7366

Important views for using refactored functions

app/views/student_task/view.html.erb

app/views/grades/_teammate_reviews.html.erb

app/views/grades/_author_feedbacks.html.erb

app/views/grades/_tabbed_participant.html.erb

app/views/grades/_scores.html.erb

app/views/grades/_teammate.html.erb

app/views/grades/_reviews.html.erb

app/views/grades/_review_table.html.erb

app/views/grades/_metareviews.html.erb

app/views/grades/_participant.html.erb

app/views/grades/_tabbed_reviews.html.erb

app/views/grades/_submissions.html.erb

app/views/student_task/view.html.erb

app/views/grades/_view_heatgrid.html.erb

app/views/grades/view_team.html.erb

app/views/grades/_heat_grid_tab.html.erb

app/views/grades/_participant.html.erb

app/views/assignments/list_submissions.html.erb

File:Calculate all penaltyies.PNG

2021-03-19T02:44:32Z

Bwanza:

File:Remove negative scores.PNG

2021-03-19T00:30:55Z

Bwanza:

File:Mean.PNG

2021-03-19T00:30:45Z

Bwanza:

File:Calculate average vector.PNG

2021-03-19T00:30:33Z

Bwanza:

File:Calculate all penalty 1.PNG

2021-03-19T00:30:04Z

Bwanza:

File:Calcuate penalties attributes.PNG

2021-03-19T00:29:15Z

Bwanza:

File:Build score vector.PNG

2021-03-19T00:28:39Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-15T12:57:08Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-15T03:57:44Z

Bwanza:

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-15T03:50:18Z

Bwanza:

== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented with the '' grades_controller.rb ''. This controller currently violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-15T03:16:56Z

Bwanza:

== ''' Introduction ''' ==
=== Problem Statement ===
Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This functionality is implemented with the '' grades_controller.rb ''. This controller violates some essential Rails design principles including having too much calculation and having methods' names that violate Ruby naming convention.
=== Project Task ===
Here are the refactoring steps needed to be taken in order to fix the '' grades_controller.rb ''.
* Create a new private method to encapsulate the population of the view model for all the necessary data (lines 102-107).
* Simplify the logic surrounding the error flashing. The nested logic seems unnecessary (lines 190-192).
* In line 300:
** Increase readability by fixing whitespace according to the common Ruby Programming guidelines.
** Return is not needed here.
** Remove space between ‘!’ and its argument.
** Use meaningful variable names and break up the expression.
* Move these functions into '' grades_helper.rb '' and change their names to be more Ruby-like:
** '' calculate_all_penalties ''
** '' calculate_penalty_attributes ''
** '' mean '' (also cease the usage of the assignment)
** '' calculate_average_vector ''
** '' build_score_vector ''
** '' Remove_negative_scores_and_build_charts ''

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-15T02:38:57Z

Bwanza: /* = */

CSC/ECE 517 Spring 2021 - E2107. Refactor grades controller.rb

2021-03-15T02:38:00Z

Bwanza: Created page with "== ''' Introduction ''' == === Problem Statement === Expertiza has a functionality that allows students and instructors to receive and give grades, respectively. This function..."

CSC/ECE 517 Spring 2021

2021-03-15T02:15:58Z

Bwanza: /* OSS Projects */

== OSS Projects ==
* [[CSC/ECE 517 Spring 2021 - E2106. Fix view in student_task/list page]]
* [[CSC/ECE 517 Spring 2021 - E2107. Refactor grades_controller.rb]]

CSC/ECE 517 Spring 2020 - M2001. Implement charset prescanning for the HTML parser

2020-04-17T23:34:55Z

Bwanza: /* Implementation */

[https://servo.org/ Servo] is a modern, high-performance browser engine designed for both application and embedded use. Servo is written in the Rust language. It is currently developed on 64-bit macOS, 64-bit Linux, 64-bit Windows, and Android. As of February 17, 2020, Servo is not yet capable of charset parsing, a feature that all other browsers have. The goal of this project is to implement HTML charset parsing in the current version of Servo.
== '''Introduction''' ==
===Servo===
[https://en.wikipedia.org/wiki/Servo_(software) Servo] is an experimental browser engine developed to take advantage of the memory safety properties and concurrency features of the Rust programming language. The project was initiated by Mozilla Research with the effort from Samsung to port it to Android and ARM processors. The prototype seeks to create a highly parallel environment, in which many components (such as rendering, layout, HTML parsing, image decoding, etc.) are handled by fine-grained, isolated tasks.
===Rust===
[https://en.wikipedia.org/wiki/Rust_(programming_language) Rust] is a multi-paradigm programming language focused on performance and safety, especially safe concurrency. Rust is syntactically similar to C++ but provides memory safety without using garbage collection.
===DOM===
*The [https://www.w3schools.com/whatis/whatis_htmldom.asp HTML DOM] is an Object Model for HTML. It defines HTML elements as objects, properties for all HTML elements, methods for all HTML elements, events for all HTML elements.
*The [https://www.w3schools.com/whatis/whatis_htmldom.asp HTML DOM] is an API (Programming Interface) for JavaScript. JavaScript can add/change/remove HTML elements, add/change/remove HTML attributes, add/change/remove CSS styles etc.
[[File: Img_htmltree.gif | The HTML DOM Tree of Objects]]
== '''Setup''' ==
Setting up the local environment on our machines requires "rustup", an installer for the systems programming language Rust. The guide to set up the local environment for each operating system can be found [https://github.com/servo/servo/blob/master/README.md here].
== '''Final Project''' ==
===Problem Statement===
*Our main focus is to complete the initial steps listed on the [https://github.com/servo/servo/wiki/Implement-HTML-charset-parsing-project project page]. The goal here is to create a new Rust module in the html5ever repository and implement the byte stream prescanning algorithm.
*After completing the initial steps, we integrate the new prescan algorithm into Servo's HTML parser implementation following the encoding sniffing algorithm. Here, Rust package manager "Cargo" will be used.
===Design Pattern===
Design pattern will not be applied here since our main goal is to create a method that implements a byte stream prescanning algorithm.
===Implementation===

*Step 1: create a new prescan.rs module in the html5ever repository and implement the byte stream prescanning algorithm.

*Step 1a: add a new public function which accepts a &[u8] argument and returns Result<&'static Encoding, AbortReason> where AbortReason is an enum representing not enough bytes or no encoding detected within the first 1024 bytes.

*Step 1b: use Encoding::for_label to convert a named charset into an Encoding value

*Step 2: add unit tests that cover success and failure cases for the algorithm (use cargo test prescan to run tests defined in the new prescan.rs module)

*Step 3: Integrate the new prescan algorithm into Servo's HTML parser implementation following the encoding sniffing algorithm:

*Step 3a: add a Cargo override that uses the locally-modified version of html5ever in Servo's Cargo.toml

*Step 3b: modify components/script/dom/servoparser/mod.rs to create an enum with two states - Prescanning(Vec<u8>) and Detected(NetworkDecoder), and replace the network_decoder field with this enum

*Step 3c: in push_bytes_input_chunk, if the prescanning case is active then perform prescanning on any existing buffer along with the newest chunk, transitioning into the Detected phase if prescanning completes (and updating the associated Document's encoding with the detected encoding) (step 4)

*Step 3d: if prescanning does not complete, no parsing should occur in parse_bytes_chunk

*Step 3e: modify new_inherited to accept an Option<&'static Encoding> argument, which is used as an override that avoids prescanning any input (step 3)

*Step 3f: when prescanning completes with no detected encoding, check document's browsing context's parent's document's encoding (step 5)

*Step 3g: Verify the failing automated tests pass with the new parser changes

CSC/ECE 517 Spring 2020 - M2001. Implement charset prescanning for the HTML parser

2020-04-17T23:34:37Z

Bwanza: /* Implementation */

[https://servo.org/ Servo] is a modern, high-performance browser engine designed for both application and embedded use. Servo is written in the Rust language. It is currently developed on 64-bit macOS, 64-bit Linux, 64-bit Windows, and Android. As of February 17, 2020, Servo is not yet capable of charset parsing, a feature that all other browsers have. The goal of this project is to implement HTML charset parsing in the current version of Servo.
== '''Introduction''' ==
===Servo===
[https://en.wikipedia.org/wiki/Servo_(software) Servo] is an experimental browser engine developed to take advantage of the memory safety properties and concurrency features of the Rust programming language. The project was initiated by Mozilla Research with the effort from Samsung to port it to Android and ARM processors. The prototype seeks to create a highly parallel environment, in which many components (such as rendering, layout, HTML parsing, image decoding, etc.) are handled by fine-grained, isolated tasks.
===Rust===
[https://en.wikipedia.org/wiki/Rust_(programming_language) Rust] is a multi-paradigm programming language focused on performance and safety, especially safe concurrency. Rust is syntactically similar to C++ but provides memory safety without using garbage collection.
===DOM===
*The [https://www.w3schools.com/whatis/whatis_htmldom.asp HTML DOM] is an Object Model for HTML. It defines HTML elements as objects, properties for all HTML elements, methods for all HTML elements, events for all HTML elements.
*The [https://www.w3schools.com/whatis/whatis_htmldom.asp HTML DOM] is an API (Programming Interface) for JavaScript. JavaScript can add/change/remove HTML elements, add/change/remove HTML attributes, add/change/remove CSS styles etc.
[[File: Img_htmltree.gif | The HTML DOM Tree of Objects]]
== '''Setup''' ==
Setting up the local environment on our machines requires "rustup", an installer for the systems programming language Rust. The guide to set up the local environment for each operating system can be found [https://github.com/servo/servo/blob/master/README.md here].
== '''Final Project''' ==
===Problem Statement===
*Our main focus is to complete the initial steps listed on the [https://github.com/servo/servo/wiki/Implement-HTML-charset-parsing-project project page]. The goal here is to create a new Rust module in the html5ever repository and implement the byte stream prescanning algorithm.
*After completing the initial steps, we integrate the new prescan algorithm into Servo's HTML parser implementation following the encoding sniffing algorithm. Here, Rust package manager "Cargo" will be used.
===Design Pattern===
Design pattern will not be applied here since our main goal is to create a method that implements a byte stream prescanning algorithm.
===Implementation===

*Step 1: create a new prescan.rs module in the html5ever repository and implement the byte stream prescanning algorithm.

*Step 1a: add a new public function which accepts a &[u8] argument and returns Result<&'static Encoding, AbortReason> where AbortReason is an enum representing not enough bytes or no encoding detected within the first 1024 bytes.

*Step 1b: use Encoding::for_label to convert a named charset into an Encoding value

*Step 2: add unit tests that cover success and failure cases for the algorithm (use cargo test prescan to run tests defined in the new prescan.rs module)

*Step 3: Integrate the new prescan algorithm into Servo's HTML parser implementation following the encoding sniffing algorithm:

*Step 3a: add a Cargo override that uses the locally-modified version of html5ever in Servo's Cargo.toml

*Step 3b: modify components/script/dom/servoparser/mod.rs to create an enum with two states - Prescanning(Vec<u8>) and Detected(NetworkDecoder), and replace the network_decoder field with this enum

*Step 3c: in push_bytes_input_chunk, if the prescanning case is active then perform prescanning on any existing buffer along with the newest chunk, transitioning into the Detected phase if prescanning completes (and updating the associated Document's encoding with the detected encoding) (step 4)

*Step 3d: if prescanning does not complete, no parsing should occur in parse_bytes_chunk

*Step 3e: modify new_inherited to accept an Option<&'static Encoding> argument, which is used as an override that avoids prescanning any input (step 3)

Step 3f: when prescanning completes with no detected encoding, check document's browsing context's parent's document's encoding (step 5)

Step 3g: Verify the failing automated tests pass with the new parser changes

CSC/ECE 517 Spring 2020 - M2001. Implement charset prescanning for the HTML parser

2020-04-13T23:20:21Z

Bwanza:

File:Img htmltree.gif

2020-04-13T23:17:42Z

Bwanza: Bwanza uploaded a new version of File:Img htmltree.gif