Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-27T19:52:25Z

Brbhatt: /* Test Execution */

== About Expertiza==

[http://expertiza.ncsu.edu/ Expertiza] is the software benefits for both instructors and students by supporting various types of submissions and providing reusable objects for peer review. It is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. It allows the instructors not only to create and customize new or existing assignments but also to create a list of topics the students can sign up for. Students can form teams to work on various projects and assignments. Expertiza also lets students peer-review other students' submissions, enabling them to work together to improve others' learning experiences.

== Description about project ==
This page is a description of Expertiza OSS project E2211 which is testing for summary_helper.rb

=== Mentor ===

* Vinay Deshmukh

=== Team Members ===

* Saswat Priyadarshan
* Rachel Son
* Bhuwan Bhatt
=== Files Involved ===

* summary_helper.rb
* summary_helper_spec.rb

=== Running Tests ===
To successfully run summary_helper_test in local machine, please run the redis server first, then run rspec.
<pre>
redis-server
rspec ./spec/helper/summary_helper_spec.rb
</pre>

=== Requirement ===

summary_helper class had methods which were not tested. Our job was to test all the methods so that we can verify summary_helper class is working fine.

=== Test Plan ===

After going through all the methods in the class, we figured out there were some methods that were never being called. So, we removed all the redundant methods that are not being called. Now we had only 9 methods in the class that we need to test. Nine methods in summary_helper class that needed to be tested were:-
* summarize_reviews_by_reviewee
* summarize_reviews_by_reviewee_question
* get_max_score_for_question
* summarize_sentences
* get_sentences
To test this method we mocked an answer object and checked if number sentences are equal to number of comments provided in the answer.

Code Snippet:
<pre>
describe '#get_sentences' do
context 'when the answer is nil' do
it 'returns a nil object' do
expect(@summary.get_sentences(nil)).to eq(nil)
end
end
context 'when the comment is two sentences' do
it 'returns an array of two sentences' do
sentences = @summary.get_sentences(answer)
expect(sentences.length).to be(2)
end
end
end

</pre>
* break_up_comments_to_sentences
This methods question answer array and breaks them into comments.
In our testing we provided the question_answer array of length 2 and see if the number of comments is equal to 2.
Code Snippet:
<pre>
describe '#break_up_comments_to_sentences' do
context 'when the question_answers is not nil' do
it 'add the comment to an array to be converted as a json request' do
comments = @summary.break_up_comments_to_sentences([answer])
expect(comments.length).to be(2)
end
end
context 'when the question_answers is nil' do
it 'returns an empty array' do
comments = @summary.break_up_comments_to_sentences([])
expect(comments.length).to be(0)
end
end
end
</pre>
* calculate_avg_score_by_criterion
<pre>
context 'when q_max_score = 0' do
it 'gives pure question_score' do
expect(@summary.calculate_avg_score_by_criterion([answer,answer1], 0)).to eq(3.0)
end
end
end
</pre>
* calculate_round_score
<pre>
describe '#calculate_round_score' do
context 'when criteria not available' do
it 'returns 0.0 since round_score = 0.0' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, nil)).to eq(0.to_f)
end
end
</pre>

<pre>
context 'when criteria not nil' do
it 'get 2 round_score ' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, question)).to be_within(0.01).of(2.345)
end
end
end
</pre>

* calculate_avg_score_by_round
<pre>
describe '#calculate_avg_score_by_round'do
context 'when avg_scores_by_criterion available' do
it 'gives 2 round value' do
expect(@summary.calculate_avg_score_by_round(avg_scores_by_criterion, question)).to eq(2.35)
end
end
end
</pre>

=== Test Execution ===
We divided the work among the teammates and started tackling the problems. We stubbed the data using factory and mocked the method calls which were being done internally to get the desired output from the methods that were calling other methods internally.

=== Test Coverage ===

=== Conclusion ===
While we tried to test all the methods in the summary_helper.rb class, we faced some blockers. All the blockers are described below:-
* summarize_sentences method

summary_webservice_url: 'http://peerlogic.csc.ncsu.edu/sum/v1.0/summary/8/lsa'
This URL is being used in the summary_helper.rb file and we were not able to mock it. It's giving us bad gateway error while we try to hit that url.

* summarize_reviews_by_reviewee method

In this method we found out in the loop, questions[round] is not the correct way of passing the individual question since questions is an array and use 0 based indexing. Whereas in the above logic it is being treated as a hash.

* summarize_reviews_by_reviewee_question method

We were not able to write test cases for this method. This method uses the instance variables from a different method(summarize_reviews_by_reviewee) which are not being passed as arguments to this method. Hence we were not able to initialize those variables and it always gives nil value.

We tested all other remaining methods in the summary_helper.rb class. All the unit tests passed and the methods were working as expected. We tried to cover corner cases but I think there is room for some improvement.

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-27T19:43:03Z

Brbhatt: /* Test Plan */

== About Expertiza==

[http://expertiza.ncsu.edu/ Expertiza] is the software benefits for both instructors and students by supporting various types of submissions and providing reusable objects for peer review. It is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. It allows the instructors not only to create and customize new or existing assignments but also to create a list of topics the students can sign up for. Students can form teams to work on various projects and assignments. Expertiza also lets students peer-review other students' submissions, enabling them to work together to improve others' learning experiences.

== Description about project ==
This page is a description of Expertiza OSS project E2211 which is testing for summary_helper.rb

=== Mentor ===

* Vinay Deshmukh

=== Team Members ===

* Saswat Priyadarshan
* Rachel Son
* Bhuwan Bhatt
=== Files Involved ===

* summary_helper.rb
* summary_helper_spec.rb

=== Running Tests ===
To successfully run summary_helper_test in local machine, please run the redis server first, then run rspec.
<pre>
redis-server
rspec ./spec/helper/summary_helper_spec.rb
</pre>

=== Requirement ===

summary_helper class had methods which were not tested. Our job was to test all the methods so that we can verify summary_helper class is working fine.

=== Test Plan ===

After going through all the methods in the class, we figured out there were some methods that were never being called. So, we removed all the redundant methods that are not being called. Now we had only 9 methods in the class that we need to test. Nine methods in summary_helper class that needed to be tested were:-
* summarize_reviews_by_reviewee
* summarize_reviews_by_reviewee_question
* get_max_score_for_question
* summarize_sentences
* get_sentences
To test this method we mocked an answer object and checked if number sentences are equal to number of comments provided in the answer.

Code Snippet:
<pre>
describe '#get_sentences' do
context 'when the answer is nil' do
it 'returns a nil object' do
expect(@summary.get_sentences(nil)).to eq(nil)
end
end
context 'when the comment is two sentences' do
it 'returns an array of two sentences' do
sentences = @summary.get_sentences(answer)
expect(sentences.length).to be(2)
end
end
end

</pre>
* break_up_comments_to_sentences
This methods question answer array and breaks them into comments.
In our testing we provided the question_answer array of length 2 and see if the number of comments is equal to 2.
Code Snippet:
<pre>
describe '#break_up_comments_to_sentences' do
context 'when the question_answers is not nil' do
it 'add the comment to an array to be converted as a json request' do
comments = @summary.break_up_comments_to_sentences([answer])
expect(comments.length).to be(2)
end
end
context 'when the question_answers is nil' do
it 'returns an empty array' do
comments = @summary.break_up_comments_to_sentences([])
expect(comments.length).to be(0)
end
end
end
</pre>
* calculate_avg_score_by_criterion
<pre>
context 'when q_max_score = 0' do
it 'gives pure question_score' do
expect(@summary.calculate_avg_score_by_criterion([answer,answer1], 0)).to eq(3.0)
end
end
end
</pre>
* calculate_round_score
<pre>
describe '#calculate_round_score' do
context 'when criteria not available' do
it 'returns 0.0 since round_score = 0.0' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, nil)).to eq(0.to_f)
end
end
</pre>

<pre>
context 'when criteria not nil' do
it 'get 2 round_score ' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, question)).to be_within(0.01).of(2.345)
end
end
end
</pre>

* calculate_avg_score_by_round
<pre>
describe '#calculate_avg_score_by_round'do
context 'when avg_scores_by_criterion available' do
it 'gives 2 round value' do
expect(@summary.calculate_avg_score_by_round(avg_scores_by_criterion, question)).to eq(2.35)
end
end
end
</pre>

=== Test Execution ===
We divided the work among the teammates and started tackling the problems. We stubbed the data using factory to get the desired output from the methods that were calling other methods internally.

=== Test Coverage ===

=== Conclusion ===
While we tried to test all the methods in the summary_helper.rb class, we faced some blockers. All the blockers are described below:-
* summarize_sentences method

summary_webservice_url: 'http://peerlogic.csc.ncsu.edu/sum/v1.0/summary/8/lsa'
This URL is being used in the summary_helper.rb file and we were not able to mock it. It's giving us bad gateway error while we try to hit that url.

* summarize_reviews_by_reviewee method

In this method we found out in the loop, questions[round] is not the correct way of passing the individual question since questions is an array and use 0 based indexing. Whereas in the above logic it is being treated as a hash.

* summarize_reviews_by_reviewee_question method

We were not able to write test cases for this method. This method uses the instance variables from a different method(summarize_reviews_by_reviewee) which are not being passed as arguments to this method. Hence we were not able to initialize those variables and it always gives nil value.

We tested all other remaining methods in the summary_helper.rb class. All the unit tests passed and the methods were working as expected. We tried to cover corner cases but I think there is room for some improvement.

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-27T19:39:56Z

Brbhatt: /* Test Plan */

== About Expertiza==

[http://expertiza.ncsu.edu/ Expertiza] is the software benefits for both instructors and students by supporting various types of submissions and providing reusable objects for peer review. It is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. It allows the instructors not only to create and customize new or existing assignments but also to create a list of topics the students can sign up for. Students can form teams to work on various projects and assignments. Expertiza also lets students peer-review other students' submissions, enabling them to work together to improve others' learning experiences.

== Description about project ==
This page is a description of Expertiza OSS project E2211 which is testing for summary_helper.rb

=== Mentor ===

* Vinay Deshmukh

=== Team Members ===

* Saswat Priyadarshan
* Rachel Son
* Bhuwan Bhatt
=== Files Involved ===

* summary_helper.rb
* summary_helper_spec.rb

=== Running Tests ===
To successfully run summary_helper_test in local machine, please run the redis server first, then run rspec.
<pre>
redis-server
rspec ./spec/helper/summary_helper_spec.rb
</pre>

=== Requirement ===

summary_helper class had methods which were not tested. Our job was to test all the methods so that we can verify summary_helper class is working fine.

=== Test Plan ===

After going through all the methods in the class, we figured out there were some methods that were never being called. So, we removed all the redundant methods that are not being called. Now we had only 9 methods in the class that we need to test. Nine methods in summary_helper class that needed to be tested were:-
* summarize_reviews_by_reviewee
* summarize_reviews_by_reviewee_question
* get_max_score_for_question
* summarize_sentences
* get_sentences
* break_up_comments_to_sentences
This methods question answer array and breaks them into comments.
In our testing we provided the question_answer array of length 2 and see if the number of comments is equal to 2.
Code Snippet:
<pre>
describe '#break_up_comments_to_sentences' do
context 'when the question_answers is not nil' do
it 'add the comment to an array to be converted as a json request' do
comments = @summary.break_up_comments_to_sentences([answer])
expect(comments.length).to be(2)
end
end
context 'when the question_answers is nil' do
it 'returns an empty array' do
comments = @summary.break_up_comments_to_sentences([])
expect(comments.length).to be(0)
end
end
end
</pre>
* calculate_avg_score_by_criterion
<pre>
context 'when q_max_score = 0' do
it 'gives pure question_score' do
expect(@summary.calculate_avg_score_by_criterion([answer,answer1], 0)).to eq(3.0)
end
end
end
</pre>
* calculate_round_score
<pre>
describe '#calculate_round_score' do
context 'when criteria not available' do
it 'returns 0.0 since round_score = 0.0' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, nil)).to eq(0.to_f)
end
end
</pre>

<pre>
context 'when criteria not nil' do
it 'get 2 round_score ' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, question)).to be_within(0.01).of(2.345)
end
end
end
</pre>

* calculate_avg_score_by_round
<pre>
describe '#calculate_avg_score_by_round'do
context 'when avg_scores_by_criterion available' do
it 'gives 2 round value' do
expect(@summary.calculate_avg_score_by_round(avg_scores_by_criterion, question)).to eq(2.35)
end
end
end
</pre>

=== Test Execution ===
We divided the work among the teammates and started tackling the problems. We stubbed the data using factory to get the desired output from the methods that were calling other methods internally.

=== Test Coverage ===

=== Conclusion ===
While we tried to test all the methods in the summary_helper.rb class, we faced some blockers. All the blockers are described below:-
* summarize_sentences method

summary_webservice_url: 'http://peerlogic.csc.ncsu.edu/sum/v1.0/summary/8/lsa'
This URL is being used in the summary_helper.rb file and we were not able to mock it. It's giving us bad gateway error while we try to hit that url.

* summarize_reviews_by_reviewee method

In this method we found out in the loop, questions[round] is not the correct way of passing the individual question since questions is an array and use 0 based indexing. Whereas in the above logic it is being treated as a hash.

* summarize_reviews_by_reviewee_question method

We were not able to write test cases for this method. This method uses the instance variables from a different method(summarize_reviews_by_reviewee) which are not being passed as arguments to this method. Hence we were not able to initialize those variables and it always gives nil value.

We tested all other remaining methods in the summary_helper.rb class. All the unit tests passed and the methods were working as expected. We tried to cover corner cases but I think there is room for some improvement.

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-27T19:39:16Z

Brbhatt: /* Test Plan */

== About Expertiza==

[http://expertiza.ncsu.edu/ Expertiza] is the software benefits for both instructors and students by supporting various types of submissions and providing reusable objects for peer review. It is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. It allows the instructors not only to create and customize new or existing assignments but also to create a list of topics the students can sign up for. Students can form teams to work on various projects and assignments. Expertiza also lets students peer-review other students' submissions, enabling them to work together to improve others' learning experiences.

== Description about project ==
This page is a description of Expertiza OSS project E2211 which is testing for summary_helper.rb

=== Mentor ===

* Vinay Deshmukh

=== Team Members ===

* Saswat Priyadarshan
* Rachel Son
* Bhuwan Bhatt
=== Files Involved ===

* summary_helper.rb
* summary_helper_spec.rb

=== Running Tests ===
To successfully run summary_helper_test in local machine, please run the redis server first, then run rspec.
<pre>
redis-server
rspec ./spec/helper/summary_helper_spec.rb
</pre>

=== Requirement ===

summary_helper class had methods which were not tested. Our job was to test all the methods so that we can verify summary_helper class is working fine.

=== Test Plan ===

After going through all the methods in the class, we figured out there were some methods that were never being called. So, we removed all the redundant methods that are not being called. Now we had only 9 methods in the class that we need to test. Nine methods in summary_helper class that needed to be tested were:-
* summarize_reviews_by_reviewee
* summarize_reviews_by_reviewee_question
* get_max_score_for_question
* summarize_sentences
* get_sentences
* break_up_comments_to_sentences
This methods question answer array and breaks them into comments. In our testing we provided the question_answer array of length 2 and see if the number of comments is equal to 2.
Code Snippet:
<pre>
describe '#break_up_comments_to_sentences' do
context 'when the question_answers is not nil' do
it 'add the comment to an array to be converted as a json request' do
comments = @summary.break_up_comments_to_sentences([answer])
expect(comments.length).to be(2)
end
end
context 'when the question_answers is nil' do
it 'returns an empty array' do
comments = @summary.break_up_comments_to_sentences([])
expect(comments.length).to be(0)
end
end
end
</pre>
* calculate_avg_score_by_criterion
<pre>
context 'when q_max_score = 0' do
it 'gives pure question_score' do
expect(@summary.calculate_avg_score_by_criterion([answer,answer1], 0)).to eq(3.0)
end
end
end
</pre>
* calculate_round_score
<pre>
describe '#calculate_round_score' do
context 'when criteria not available' do
it 'returns 0.0 since round_score = 0.0' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, nil)).to eq(0.to_f)
end
end
</pre>

<pre>
context 'when criteria not nil' do
it 'get 2 round_score ' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, question)).to be_within(0.01).of(2.345)
end
end
end
</pre>

* calculate_avg_score_by_round
<pre>
describe '#calculate_avg_score_by_round'do
context 'when avg_scores_by_criterion available' do
it 'gives 2 round value' do
expect(@summary.calculate_avg_score_by_round(avg_scores_by_criterion, question)).to eq(2.35)
end
end
end
</pre>

=== Test Execution ===
We divided the work among the teammates and started tackling the problems. We stubbed the data using factory to get the desired output from the methods that were calling other methods internally.

=== Test Coverage ===

=== Conclusion ===
While we tried to test all the methods in the summary_helper.rb class, we faced some blockers. All the blockers are described below:-
* summarize_sentences method

summary_webservice_url: 'http://peerlogic.csc.ncsu.edu/sum/v1.0/summary/8/lsa'
This URL is being used in the summary_helper.rb file and we were not able to mock it. It's giving us bad gateway error while we try to hit that url.

* summarize_reviews_by_reviewee method

In this method we found out in the loop, questions[round] is not the correct way of passing the individual question since questions is an array and use 0 based indexing. Whereas in the above logic it is being treated as a hash.

* summarize_reviews_by_reviewee_question method

We were not able to write test cases for this method. This method uses the instance variables from a different method(summarize_reviews_by_reviewee) which are not being passed as arguments to this method. Hence we were not able to initialize those variables and it always gives nil value.

We tested all other remaining methods in the summary_helper.rb class. All the unit tests passed and the methods were working as expected. We tried to cover corner cases but I think there is room for some improvement.

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-27T19:38:26Z

Brbhatt: /* Test Plan */

== About Expertiza==

[http://expertiza.ncsu.edu/ Expertiza] is the software benefits for both instructors and students by supporting various types of submissions and providing reusable objects for peer review. It is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. It allows the instructors not only to create and customize new or existing assignments but also to create a list of topics the students can sign up for. Students can form teams to work on various projects and assignments. Expertiza also lets students peer-review other students' submissions, enabling them to work together to improve others' learning experiences.

== Description about project ==
This page is a description of Expertiza OSS project E2211 which is testing for summary_helper.rb

=== Mentor ===

* Vinay Deshmukh

=== Team Members ===

* Saswat Priyadarshan
* Rachel Son
* Bhuwan Bhatt
=== Files Involved ===

* summary_helper.rb
* summary_helper_spec.rb

=== Running Tests ===
To successfully run summary_helper_test in local machine, please run the redis server first, then run rspec.
<pre>
redis-server
rspec ./spec/helper/summary_helper_spec.rb
</pre>

=== Requirement ===

summary_helper class had methods which were not tested. Our job was to test all the methods so that we can verify summary_helper class is working fine.

=== Test Plan ===

After going through all the methods in the class, we figured out there were some methods that were never being called. So, we removed all the redundant methods that are not being called. Now we had only 9 methods in the class that we need to test. Nine methods in summary_helper class that needed to be tested were:-
* summarize_reviews_by_reviewee
* summarize_reviews_by_reviewee_question
* get_max_score_for_question
* summarize_sentences
* get_sentences
* break_up_comments_to_sentences
This methods question answer array and breaks them into comments. In our testing we provided the question_answer array of length 2 and see if the number of comments is equal to 2.
<pre>
describe '#break_up_comments_to_sentences' do
context 'when the question_answers is not nil' do
it 'add the comment to an array to be converted as a json request' do
comments = @summary.break_up_comments_to_sentences([answer])
expect(comments.length).to be(2)
end
end
context 'when the question_answers is nil' do
it 'returns an empty array' do
comments = @summary.break_up_comments_to_sentences([])
expect(comments.length).to be(0)
end
end
end
</pre>
* calculate_avg_score_by_criterion
<pre>
context 'when q_max_score = 0' do
it 'gives pure question_score' do
expect(@summary.calculate_avg_score_by_criterion([answer,answer1], 0)).to eq(3.0)
end
end
end
</pre>
* calculate_round_score
<pre>
describe '#calculate_round_score' do
context 'when criteria not available' do
it 'returns 0.0 since round_score = 0.0' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, nil)).to eq(0.to_f)
end
end
</pre>

<pre>
context 'when criteria not nil' do
it 'get 2 round_score ' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, question)).to be_within(0.01).of(2.345)
end
end
end
</pre>

* calculate_avg_score_by_round
<pre>
describe '#calculate_avg_score_by_round'do
context 'when avg_scores_by_criterion available' do
it 'gives 2 round value' do
expect(@summary.calculate_avg_score_by_round(avg_scores_by_criterion, question)).to eq(2.35)
end
end
end
</pre>

=== Test Execution ===
We divided the work among the teammates and started tackling the problems. We stubbed the data using factory to get the desired output from the methods that were calling other methods internally.

=== Test Coverage ===

=== Conclusion ===
While we tried to test all the methods in the summary_helper.rb class, we faced some blockers. All the blockers are described below:-
* summarize_sentences method

summary_webservice_url: 'http://peerlogic.csc.ncsu.edu/sum/v1.0/summary/8/lsa'
This URL is being used in the summary_helper.rb file and we were not able to mock it. It's giving us bad gateway error while we try to hit that url.

* summarize_reviews_by_reviewee method

In this method we found out in the loop, questions[round] is not the correct way of passing the individual question since questions is an array and use 0 based indexing. Whereas in the above logic it is being treated as a hash.

* summarize_reviews_by_reviewee_question method

We were not able to write test cases for this method. This method uses the instance variables from a different method(summarize_reviews_by_reviewee) which are not being passed as arguments to this method. Hence we were not able to initialize those variables and it always gives nil value.

We tested all other remaining methods in the summary_helper.rb class. All the unit tests passed and the methods were working as expected. We tried to cover corner cases but I think there is room for some improvement.

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-27T19:15:20Z

Brbhatt:

== About Expertiza==

[http://expertiza.ncsu.edu/ Expertiza] is the software benefits for both instructors and students by supporting various types of submissions and providing reusable objects for peer review. It is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. It allows the instructors not only to create and customize new or existing assignments but also to create a list of topics the students can sign up for. Students can form teams to work on various projects and assignments. Expertiza also lets students peer-review other students' submissions, enabling them to work together to improve others' learning experiences.

== Description about project ==
This page is a description of Expertiza OSS project E2211 which is testing for summary_helper.rb

=== Mentor ===

* Vinay Deshmukh

=== Team Members ===

* Saswat Priyadarshan
* Rachel Son
* Bhuwan Bhatt
=== Files Involved ===

* summary_helper.rb
* summary_helper_spec.rb

=== Running Tests ===
To successfully run summary_helper_test in local machine, please run the redis server first, then run rspec.
<pre>
redis-server
rspec ./spec/helper/summary_helper_spec.rb
</pre>

=== Requirement ===

summary_helper class had methods which were not tested. Our job was to test all the methods so that we can verify summary_helper class is working fine.

=== Test Plan ===

After going through all the methods in the class, we figured out there were some methods that were never being called. So, we removed all the redundant methods that are not being called. Now we had only 9 methods in the class that we need to test. Nine methods in summary_helper class that needed to be tested were:-
* summarize_reviews_by_reviewee
* summarize_reviews_by_reviewee_question
* get_max_score_for_question
* summarize_sentences
* get_sentences
* break_up_comments_to_sentences
* calculate_avg_score_by_criterion
<pre>
context 'when q_max_score = 0' do
it 'gives pure question_score' do
expect(@summary.calculate_avg_score_by_criterion([answer,answer1], 0)).to eq(3.0)
end
end
end
</pre>
* calculate_round_score
<pre>
describe '#calculate_round_score' do
context 'when criteria not available' do
it 'returns 0.0 since round_score = 0.0' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, nil)).to eq(0.to_f)
end
end
</pre>

<pre>
context 'when criteria not nil' do
it 'get 2 round_score ' do
expect(@summary.calculate_round_score(avg_scores_by_criterion, question)).to be_within(0.01).of(2.345)
end
end
end
</pre>

* calculate_avg_score_by_round
<pre>
describe '#calculate_avg_score_by_round'do
context 'when avg_scores_by_criterion available' do
it 'gives 2 round value' do
expect(@summary.calculate_avg_score_by_round(avg_scores_by_criterion, question)).to eq(2.35)
end
end
end
</pre>

=== Test Execution ===
We divided the work among the teammates and started tackling the problems. We stubbed the data using factory to get the desired output from the methods that were calling other methods internally.

=== Test Coverage ===

=== Conclusion ===
While we tried to test all the methods in the summary_helper.rb class, we faced some blockers. All the blockers are described below:-
* summarize_sentences method

summary_webservice_url: 'http://peerlogic.csc.ncsu.edu/sum/v1.0/summary/8/lsa'
This URL is being used in the summary_helper.rb file and we were not able to mock it. It's giving us bad gateway error while we try to hit that url.

* summarize_reviews_by_reviewee method

In this method we found out in the loop, questions[round] is not the correct way of passing the individual question since questions is an array and use 0 based indexing. Whereas in the above logic it is being treated as a hash.

* summarize_reviews_by_reviewee_question method

We were not able to write test cases for this method. This method uses the instance variables from a different method(summarize_reviews_by_reviewee) which are not being passed as arguments to this method. Hence we were not able to initialize those variables and it always gives nil value.

We tested all other remaining methods in the summary_helper.rb class. All the unit tests passed and the methods were working as expected. We tried to cover corner cases but I think there is room for some improvement.

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-21T20:29:45Z

Brbhatt: /* Conclusion */

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-20T22:11:29Z

Brbhatt:

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-20T22:05:48Z

Brbhatt: /* Test Execution */

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-20T22:05:20Z

Brbhatt:

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-20T21:53:41Z

Brbhatt:

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-20T21:53:12Z

Brbhatt:

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-20T21:50:35Z

Brbhatt:

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-20T21:37:42Z

Brbhatt:

CSC/ECE 517 Spring 2022 - E2211: Testing for summary helper

2022-03-20T21:35:21Z

Brbhatt: Created page with "== About Expertiza== [http://expertiza.ncsu.edu/ Expertiza] is the software benefits for both instructors and students by supporting various types of submissions and providin..."

CSC/ECE 517 Spring 2022

2022-03-20T21:32:30Z

Brbhatt: /* OSS Projects */

== OSS Projects ==

* [[CSC/ECE 517 Spring 2022 - E2203: Adding tests for courses_controller, eula_controller]]
* [[CSC/ECE 517 Spring 2022 - E2204: Adding tests for markup_styles_controller, lock_controller]]
* [[CSC/ECE 517 Spring 2022 - E2217: Refactor questionnaires_controller]]
* [[CSC/ECE 517 Spring 2022 - E2216: Refactor late_policies_controller]]
* [[CSC/ECE 517 Spring 2022 - E2215: Refactor student_quizzes_controller]]
* [[CSC/ECE 517 Spring 2022 - E2214: Refactor teams_controller]]
* [[CSC/ECE 517 Spring 2022 - E2219: Improve assessment360_controller.rb]]
* [[CSC/ECE 517 Spring 2022 - E2211: Testing for summary_helper]]

== Final Projects ==