Expertiza_Wiki - User contributions [en]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T17:30:27Z

Atripat6: /* Grade history for a given team */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===

==== The list submission page with the new "grade history" option====
[[Image: E1869-Screenshot-1.jpg|50]]

==== The review report page with the new "grade history" option====
[[File:E1869-Screenshot-2.jpg]]

==== Grade history for a given team====
[[File:E1869-Screenshot-3.jpg]]

===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Testing Plan'''==

Functional testing:

1. Test if SubmissionGradeHistory.create is being called when a submission grade is changed.
spec/controllers/grades_controller_spec.rb https://bit.ly/2EpJaGS

2. Test if ReviewGradeHistory.create is being called when a submission grade is changed.
spec/controllers/review_mapping_controller_spec.rb https://bit.ly/2LjM4OF

3. Test if GradeHistory.where is being called when grading history button is clicked.
spec/controllers/grading_histories_controller_test.rb https://bit.ly/2PFLknz

=='''Actual Implementation'''==
===Actual View===
== The list submission page with the new "grade history" option==
[[File:E1869-Actual-1.JPG]]

== The Review Report page with the new "grade history" option==
[[File:E1869-Actual-3.png]]

== Grade history page for a given team(submission grade history)==
[[File:E1869-Actual-2.JPG]]

== Grade history for a given student(review grade history)==
[[File:E1869-Actual-4.png]]

===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T17:30:00Z

Atripat6: /* The review report page with the new "grade history" option */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===

==== The list submission page with the new "grade history" option====
[[Image: E1869-Screenshot-1.jpg|50]]

==== The review report page with the new "grade history" option====
[[File:E1869-Screenshot-2.jpg]]

== Grade history for a given team==
[[File:E1869-Screenshot-3.jpg]]

===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Testing Plan'''==

Functional testing:

1. Test if SubmissionGradeHistory.create is being called when a submission grade is changed.
spec/controllers/grades_controller_spec.rb https://bit.ly/2EpJaGS

2. Test if ReviewGradeHistory.create is being called when a submission grade is changed.
spec/controllers/review_mapping_controller_spec.rb https://bit.ly/2LjM4OF

3. Test if GradeHistory.where is being called when grading history button is clicked.
spec/controllers/grading_histories_controller_test.rb https://bit.ly/2PFLknz

=='''Actual Implementation'''==
===Actual View===
== The list submission page with the new "grade history" option==
[[File:E1869-Actual-1.JPG]]

== The Review Report page with the new "grade history" option==
[[File:E1869-Actual-3.png]]

== Grade history page for a given team(submission grade history)==
[[File:E1869-Actual-2.JPG]]

== Grade history for a given student(review grade history)==
[[File:E1869-Actual-4.png]]

===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T17:29:40Z

Atripat6: /* The list submission page with the new "grade history" option */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===

==== The list submission page with the new "grade history" option====
[[Image: E1869-Screenshot-1.jpg|50]]

== The review report page with the new "grade history" option==
[[File:E1869-Screenshot-2.jpg]]

== Grade history for a given team==
[[File:E1869-Screenshot-3.jpg]]

===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Testing Plan'''==

Functional testing:

1. Test if SubmissionGradeHistory.create is being called when a submission grade is changed.
spec/controllers/grades_controller_spec.rb https://bit.ly/2EpJaGS

2. Test if ReviewGradeHistory.create is being called when a submission grade is changed.
spec/controllers/review_mapping_controller_spec.rb https://bit.ly/2LjM4OF

3. Test if GradeHistory.where is being called when grading history button is clicked.
spec/controllers/grading_histories_controller_test.rb https://bit.ly/2PFLknz

=='''Actual Implementation'''==
===Actual View===
== The list submission page with the new "grade history" option==
[[File:E1869-Actual-1.JPG]]

== The Review Report page with the new "grade history" option==
[[File:E1869-Actual-3.png]]

== Grade history page for a given team(submission grade history)==
[[File:E1869-Actual-2.JPG]]

== Grade history for a given student(review grade history)==
[[File:E1869-Actual-4.png]]

===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T06:03:58Z

Atripat6: /* The Review Report page with the new "grade history" option */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===

== The list submission page with the new "grade history" option==
[[Image: E1869-Screenshot-1.jpg|50]]

== The review report page with the new "grade history" option==
[[File:E1869-Screenshot-2.jpg]]

== Grade history for a given team==
[[File:E1869-Screenshot-3.jpg]]

===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Testing Plan'''==

Functional testing:

1. Test if SubmissionGradeHistory.create is being called when a submission grade is changed.
spec/controllers/grades_controller_spec.rb https://bit.ly/2EpJaGS

2. Test if ReviewGradeHistory.create is being called when a submission grade is changed.
spec/controllers/review_mapping_controller_spec.rb https://bit.ly/2LjM4OF

3. Test if GradeHistory.where is being called when grading history button is clicked.
spec/controllers/grading_histories_controller_test.rb https://bit.ly/2PFLknz

=='''Actual Implementation'''==
===Actual View===
== The list submission page with the new "grade history" option==
[[File:E1869-Actual-1.JPG]]

== The Review Report page with the new "grade history" option==
[[File:E1869-Actual-3.png]]

== Grade history page for a given team(submission grade history)==
[[File:E1869-Actual-2.JPG]]

== Grade history for a given student(review grade history)==
[[File:E1869-Actual-4.png]]

===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T06:02:25Z

Atripat6: /* Actual View */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===

== The list submission page with the new "grade history" option==
[[Image: E1869-Screenshot-1.jpg|50]]

== The review report page with the new "grade history" option==
[[File:E1869-Screenshot-2.jpg]]

== Grade history for a given team==
[[File:E1869-Screenshot-3.jpg]]

===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Testing Plan'''==

Functional testing:

1. Test if SubmissionGradeHistory.create is being called when a submission grade is changed.
spec/controllers/grades_controller_spec.rb https://bit.ly/2EpJaGS

2. Test if ReviewGradeHistory.create is being called when a submission grade is changed.
spec/controllers/review_mapping_controller_spec.rb https://bit.ly/2LjM4OF

3. Test if GradeHistory.where is being called when grading history button is clicked.
spec/controllers/grading_histories_controller_test.rb https://bit.ly/2PFLknz

=='''Actual Implementation'''==
===Actual View===
== The list submission page with the new "grade history" option==
[[File:E1869-Actual-1.JPG]]

== The Review Report page with the new "grade history" option==
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]

===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T06:00:49Z

Atripat6: /* Expected View */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===

== The list submission page with the new "grade history" option==
[[Image: E1869-Screenshot-1.jpg|50]]

== The review report page with the new "grade history" option==
[[File:E1869-Screenshot-2.jpg]]

== Grade history for a given team==
[[File:E1869-Screenshot-3.jpg]]

===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Testing Plan'''==

Functional testing:

1. Test if SubmissionGradeHistory.create is being called when a submission grade is changed.
spec/controllers/grades_controller_spec.rb https://bit.ly/2EpJaGS

2. Test if ReviewGradeHistory.create is being called when a submission grade is changed.
spec/controllers/review_mapping_controller_spec.rb https://bit.ly/2LjM4OF

3. Test if GradeHistory.where is being called when grading history button is clicked.
spec/controllers/grading_histories_controller_test.rb https://bit.ly/2PFLknz

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T05:53:09Z

Atripat6: /* Testing Plan */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Testing Plan'''==

Functional testing:

1. Test if SubmissionGradeHistory.create is being called when a submission grade is changed.
spec/controllers/grades_controller_spec.rb https://bit.ly/2EpJaGS

2. Test if ReviewGradeHistory.create is being called when a submission grade is changed.
spec/controllers/review_mapping_controller_spec.rb https://bit.ly/2LjM4OF

3. Test if GradeHistory.where is being called when grading history button is clicked.
spec/controllers/grading_histories_controller_test.rb https://bit.ly/2PFLknz

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T05:46:29Z

Atripat6: /* Files Changed */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as an instructor

2.Navigate to Manage -> Assignments

3. Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as an instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T05:46:12Z

Atripat6: /* Actual Code Change */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as an instructor

2.Navigate to Manage -> Assignments

3. Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as an instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Code Changes===

==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T05:45:52Z

Atripat6: /* Files Modified */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as an instructor

2.Navigate to Manage -> Assignments

3. Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as an instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

* app/views/assignments/list_submissions.html.erb https://bit.ly/2UHNRkO
'''
Add code to support view changes for Grade Record
'''

* app/views/review_mapping/_review_report.html.erb https://bit.ly/2GfTqUj
'''
Add code to support view changes for Grade Record
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T05:43:31Z

Atripat6: /* Files Added */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as an instructor

2.Navigate to Manage -> Assignments

3. Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as an instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

*app/views/grading_history/index_html.erb https://bit.ly/2rDiZF1

'''
This is a view for grading audit trail, it will display all grading histories of a submission/review
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T05:40:59Z

Atripat6: /* Files Added */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as an instructor

2.Navigate to Manage -> Assignments

3. Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as an instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Modified==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

==Files Added==

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-15T20:56:15Z

Atripat6: /* Solutions Implemented and Delivered */

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team in app/views/grades/_author_feedback_tab.html.erb :

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view(app/views/grades/_reviews.html.erb).
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback(app/helpers/grades_helper.rb).
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map(app/controllers/response_controller.rb).

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment(app/models/response_map.rb).

[[File:response_map.jpg]]

====Output====
'''Issue #622'''
Assuming a team of two students student559 and student567, and that they have gotten a review from student563.
1. Click Manage-Impersonate User, type username “student559”, then click impersonate.

2. Choose assignment Test Test, go to Your score, and click Review 1, like the screenshot shows, there is an option for giving feedback
[[File:Give Feedback.PNG]]
3. Now, impersonate user “student567”, choose assignment Test Test, go to Your score, and click Review 1, you can see the same feedback commit "TESTING Feedback". with an option to Edit Feedback
[[File:Edit feedback.PNG]]
[[File:Response-view-2.png]]

'''Issue#895'''

1. Login as an instructor and Click Manage-Assignment, under assignment Test Test, click view scores.

2. Choose Team 1, and click Author Feedback, you can see the feedback is given by the team, not individual student.
[[File:Grades-view.png]]

'''Issue#1191'''
In the above screenshot, you can see that the top row of heat grid is fixed to show the name of Student to whom the feedback is given(in this case to student563). And the link will take you to the review

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====Tests====

Context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end

describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-15T05:08:15Z

Atripat6: /* Output */

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

====Output====
'''Issue #622'''
Assuming a team of two students student559 and student567, and that they have gotten a review from student563.
1. Click Manage-Impersonate User, type username “student559”, then click impersonate.

2. Choose assignment Test Test, go to Your score, and click Review 1, like the screenshot shows, there is an option for giving feedback
[[File:Give Feedback.PNG]]
3. Now, impersonate user “student567”, choose assignment Test Test, go to Your score, and click Review 1, you can see the same feedback commit "TESTING Feedback". with an option to Edit Feedback
[[File:Edit feedback.PNG]]
[[File:Response-view-2.png]]

'''Issue#895'''

1. Login as an instructor and Click Manage-Assignment, under assignment Test Test, click view scores.

2. Choose Team 1, and click Author Feedback, you can see the feedback is given by the team, not individual student.
[[File:Grades-view.png]]

'''Issue#1191'''
In the above screenshot, you can see that the top row of heat grid is fixed to show the name of Student to whom the feedback is given(in this case to student563). And the link will take you to the review

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====Tests====

Context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end

describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end

File:Edit feedback.PNG

2018-11-15T04:57:55Z

Atripat6: Edit feedback option available for other at review page

Edit feedback option available for other at review page

File:Give Feedback.PNG

2018-11-15T04:56:43Z

Atripat6: give_feedback option in the review page

give_feedback option in the review page

CSC/ECE 517 Fall 2018

2018-11-15T04:45:12Z

Atripat6:

* [[CSC/ECE 517 Fall 2018- Project E1846. OSS Project Navy: Character Issues]]
* [[CSC/ECE 517 Fall 2018/OSS E1848 Write unit tests for assignment team.rb]]
* [http://wiki.expertiza.ncsu.edu/index.php/E1839_Review_Requirements_and_Thresholds CSC/ECE 517 Fall 2018 E1839 Review Requirements and Thresholds]
* [http://wiki.expertiza.ncsu.edu/index.php/E1848_Write_unit_tests_for_assignment_team CSC/ECE 517 Fall 2018 E1848 Write unit tests for assignment_team]
* [http://wiki.expertiza.ncsu.edu/index.php/E1835_Refactor_delayed_mailer_and_scheduled_task CSC/ECE 517 Fall 2018 E1835_Refactor_delayed_mailer_and_scheduled_task]
* [http://wiki.expertiza.ncsu.edu/index.php/E1829_OSS_project_Duke_Blue_Fix_import_glitches CSC/ECE 517 Fall 2018 E1829 OSS project Duke Blue: Fix import glitches]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1853_Write_unit_tests_for_menu.rb CSC/ECE 517 Fall 2018 E1853 Write unit tests for menu.rb]
* [http://wiki.expertiza.ncsu.edu/index.php/E1853_write_unit_tests_for_menu CSC/ECE517 Fall 2018 E1853 Write Unit Tests For menu.rb]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018_-_Project_E1852_Write_unit_tests_for_participant.rb CSC/ECE 517 Fall 2018 E1852 Write unit tests for participant.rb]
* [http://wiki.expertiza.ncsu.edu/index.php/E1844_Issues_related_to_names CSC/ECE 517 Fall 2018 E1844 Issues related to names]
* [http://wiki.expertiza.ncsu.edu/index.php/User_talk:Rshakya CSC/ECE 517 Fall 2018/E1852 Unit Test for Participant Model]
* [http://wiki.expertiza.ncsu.edu/index.php/E1850_Write_unit_tests_for_review_response_map CSC/ECE 517 Fall 2018 Write unit tests for review-response_map.rb]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1849_Write_Unit_Tests_for_vm_question_response.rb CSC/ECE 517 Fall 2018/E1849 Write Unit Tests for vm_question_response.rb]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1866_Expertiza_Internationalization CSC/ECE 517 Fall 2018/E1866 Expertiza Internationalization]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1879_Student_Generated_Questions_Added_To_Rubric CSC/ECE 517 Fall 2018/E1879 Student Generated Questions Added To Rubric]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1856_Allow_reviewers_to_bid_on_what_to_review CSC/ECE 517 Fall 2018/E1856 Allow]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1876_Completion/Progress_view CSC/ECE 517 Fall 2018 E1876_Completion/Progress_view]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1872_Track_Time_Students_Look_At_Other_Submissions CSC/ECE 517 Fall 2018/E1872 Track Time Students Look At Other Submissions]
* [[CSC/ECE 517 Fall 2018- Project E1865. Conflict Notification]]
* [[CSC/ECE 517 Fall 2018- Project E1861. Improving search facility in Expertiza]]
* [[CSC/ECE 517 Fall 2018- Project E1858. Github metrics integration]]
* [[CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements]]

CSC 517 Fall 2018/oss E1832

2018-11-15T04:44:35Z

Atripat6: moved CSC 517 Fall 2018/oss E1832 to CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements: Incomplete name

#REDIRECT [[CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements]]

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-15T04:44:35Z

Atripat6: moved CSC 517 Fall 2018/oss E1832 to CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements: Incomplete name

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

====Output====
'''Issue #622'''

1. Click Manage-Impersonate User, type username “student559”, then click impersonate.

2. Choose assignment Test Test, go to Your score, and click Review 1, like the screenshot show, the feedback commit shows "TESTING Feedback".
[[File:Response-view-1.png]]
3. Now, impersonate user “student567”, choose assignment Test Test, go to Your score, and click Review 1, you can see the same feedback commit "TESTING Feedback".
[[File:Response-view-2.png]]

'''Issue#895'''

1. Click Manage-Assignment, under assignment Test Test, click view scores.

2. Choose Team 1, and click Author Feedback, you can see the feedback is given by the team, not individual student.
[[File:Grades-view.png]]

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====Tests====

Context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end

describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end

CSC/ECE 517 Fall 2018

2018-11-15T04:40:30Z

Atripat6:

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-15T04:39:50Z

Atripat6:

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

====Output====
'''Issue #622'''

1. Click Manage-Impersonate User, type username “student559”, then click impersonate.

2. Choose assignment Test Test, go to Your score, and click Review 1, like the screenshot show, the feedback commit shows "TESTING Feedback".
[[File:Response-view-1.png]]
3. Now, impersonate user “student567”, choose assignment Test Test, go to Your score, and click Review 1, you can see the same feedback commit "TESTING Feedback".
[[File:Response-view-2.png]]

'''Issue#895'''

1. Click Manage-Assignment, under assignment Test Test, click view scores.

2. Choose Team 1, and click Author Feedback, you can see the feedback is given by the team, not individual student.
[[File:Grades-view.png]]

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====Tests====

Context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end

describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-15T04:39:29Z

Atripat6:

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

====Changes====
'''Issue #622'''

1. Click Manage-Impersonate User, type username “student559”, then click impersonate.

2. Choose assignment Test Test, go to Your score, and click Review 1, like the screenshot show, the feedback commit shows "TESTING Feedback".
[[File:Response-view-1.png]]
3. Now, impersonate user “student567”, choose assignment Test Test, go to Your score, and click Review 1, you can see the same feedback commit "TESTING Feedback".
[[File:Response-view-2.png]]

'''Issue#895'''

1. Click Manage-Assignment, under assignment Test Test, click view scores.

2. Choose Team 1, and click Author Feedback, you can see the feedback is given by the team, not individual student.
[[File:Grades-view.png]]

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====Tests====

Context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end

describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-06T03:09:46Z

Atripat6: /* Testing */

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-06T03:07:46Z

Atripat6: /* Tasks Identified */

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-06T03:07:15Z

Atripat6: /* Background */