Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:35:02Z

Achirasa: /* Improved Tests */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> if (@map.is_a? ReviewResponseMap) && (was_submitted == false && @response.is_submitted) && @response.significant_difference?
@response.notify_instructor_on_difference
@response.notify_instructor_on_difference(request.base_url)
@response.email
end
</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range, and all other background color will be green.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever a new review is significantly different from other people's review, who has the same submission team (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).
The graph showing below is the previous team email UI.

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts. We added a link for review_conflict_report_url, which will let instructor to access the review conflict report page by the email he received.

[[File:E2087 Conflict Notification.png|1000px]]

Chart before improvements.
<br>

[[File:Chart before.png|1000px]]

Chart after improvements.

<br>
<br>
[[File:Chart after.png|1000px]]

The improved chart has the student name on the y-axis, scaled chart sizes, and more intuitive highlighting with red bars indicating an out of limits score. This is a great improvement to the previous implementation where only the student name was highlighted to indicate an out of limit score.

=== Improved Tests ===

Added additional tests to cover the average and standard deviation calculations.

File: spec/helpers/review_mapping_helper_spec.rb

<pre>
describe '#average_of_round' do

it 'should return correct average' do
question_answer = {'a'=> 1, 'b'=>2, 'c'=>3}
expect(helper.average_of_round(question_answer)).to eq(2)
end
end

describe '#std_of_round' do

it 'should return correct standard deviation' do
question_answer = {'a'=> 1, 'b'=>2, 'c'=>3}
expect(helper.std_of_round(2, question_answer)).to eq(0.82)
end
end
</pre>

File: spec/controllers/reports_controller_spec.rb

Improved tests for conflict report controller. Tests now check for correct values rather than just null or empty.

<pre>
describe '#review_conflict_response_map' do
context 'when type is ReviewConflictResponseMap' do
it 'renders response_report page with corresponding data' do
allow(Team).to receive(:where).with(parent_id: '1').and_return([test]).ordered
params = {
id: 1,
report: {type: 'ReviewConflictResponseMap'},
user: 'no one'
}
get :response_report, params
expect(response).to render_template(:response_report)
end
end
end

describe 'reviewers_name_id_by_reviewee_and_assignment' do
before(:each) do
@assignment_id = 1
@reviewee_id = 1
end
it 'returns reviewers name from Answer by reviewee and assignment id from db which is not empty' do
allow(User).to receive(:where).with(@reviewee_id, @assignment_id).and_return([user1])
expect(User.where(@reviewee_id, @assignment_id)).to eq([user1])
end
end
</pre>

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:34:03Z

Achirasa: /* Improved Tests */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> if (@map.is_a? ReviewResponseMap) && (was_submitted == false && @response.is_submitted) && @response.significant_difference?
@response.notify_instructor_on_difference
@response.notify_instructor_on_difference(request.base_url)
@response.email
end
</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range, and all other background color will be green.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever a new review is significantly different from other people's review, who has the same submission team (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).
The graph showing below is the previous team email UI.

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts. We added a link for review_conflict_report_url, which will let instructor to access the review conflict report page by the email he received.

[[File:E2087 Conflict Notification.png|1000px]]

Chart before improvements.
<br>

[[File:Chart before.png|1000px]]

Chart after improvements.

<br>
<br>
[[File:Chart after.png|1000px]]

The improved chart has the student name on the y-axis, scaled chart sizes, and more intuitive highlighting with red bars indicating an out of limits score. This is a great improvement to the previous implementation where only the student name was highlighted to indicate an out of limit score.

=== Improved Tests ===

Added additional tests to cover the average and standard deviation calculations.

File: spec/helpers/review_mapping_helper_spec.rb

<pre>
describe '#average_of_round' do

it 'should return correct average' do
question_answer = {'a'=> 1, 'b'=>2, 'c'=>3}
expect(helper.average_of_round(question_answer)).to eq(2)
end
end

describe '#std_of_round' do

it 'should return correct standard deviation' do
question_answer = {'a'=> 1, 'b'=>2, 'c'=>3}
expect(helper.std_of_round(2, question_answer)).to eq(0.82)
end
end
</pre>

File: spec/controllers/reports_controller_spec.rb

Improved tests for conflict report controller.

<pre>
describe '#review_conflict_response_map' do
context 'when type is ReviewConflictResponseMap' do
it 'renders response_report page with corresponding data' do
allow(Team).to receive(:where).with(parent_id: '1').and_return([test]).ordered
params = {
id: 1,
report: {type: 'ReviewConflictResponseMap'},
user: 'no one'
}
get :response_report, params
expect(response).to render_template(:response_report)
end
end
end

describe 'reviewers_name_id_by_reviewee_and_assignment' do
before(:each) do
@assignment_id = 1
@reviewee_id = 1
end
it 'returns reviewers name from Answer by reviewee and assignment id from db which is not empty' do
allow(User).to receive(:where).with(@reviewee_id, @assignment_id).and_return([user1])
expect(User.where(@reviewee_id, @assignment_id)).to eq([user1])
end
end
</pre>

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:31:39Z

Achirasa: /* Implemented Solution */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> if (@map.is_a? ReviewResponseMap) && (was_submitted == false && @response.is_submitted) && @response.significant_difference?
@response.notify_instructor_on_difference
@response.notify_instructor_on_difference(request.base_url)
@response.email
end
</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range, and all other background color will be green.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever a new review is significantly different from other people's review, who has the same submission team (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).
The graph showing below is the previous team email UI.

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts. We added a link for review_conflict_report_url, which will let instructor to access the review conflict report page by the email he received.

[[File:E2087 Conflict Notification.png|1000px]]

Chart before improvements.
<br>

[[File:Chart before.png|1000px]]

Chart after improvements.

<br>
<br>
[[File:Chart after.png|1000px]]

The improved chart has the student name on the y-axis, scaled chart sizes, and more intuitive highlighting with red bars indicating an out of limits score. This is a great improvement to the previous implementation where only the student name was highlighted to indicate an out of limit score.

=== Improved Tests ===

Added additional tests to cover the average and standard deviation calculations.

File: spec/helpers/review_mapping_helper_spec.rb

<pre>
describe '#average_of_round' do

it 'should return correct average' do
question_answer = {'a'=> 1, 'b'=>2, 'c'=>3}
expect(helper.average_of_round(question_answer)).to eq(2)
end
end

describe '#std_of_round' do

it 'should return correct standard deviation' do
question_answer = {'a'=> 1, 'b'=>2, 'c'=>3}
expect(helper.std_of_round(2, question_answer)).to eq(0.82)
end
end
</pre>

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:08:05Z

Achirasa: /* UI Improvements */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== UI Changes ==

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever two reviews for the same submission differ "significantly" on their scoring (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts.

[[File:E2087 Score Report.png|1000px]]
[[File:E2087 Conflict Notification.png|1000px]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> if (@map.is_a? ReviewResponseMap) && (was_submitted == false && @response.is_submitted) && @response.significant_difference?
@response.notify_instructor_on_difference
@response.notify_instructor_on_difference(request.base_url)
@response.email
end
</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== Conflict Report Chart Improvements ===

[[File:Chart before.png|1000px]]

Chart before improvements.

<br>
<br>
[[File:Chart after.png|1000px]]

Chart after improvements.

The improved chart has the student name on the y-axis, scaled chart sizes, and more intuitive highlighting with red bars indicating an out of limits score. This is a great improvement to the previous implementation where only the student name was highlighted to indicate an out of limit score.

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:04:05Z

Achirasa: /* UI Improvements */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== UI Changes ==

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever two reviews for the same submission differ "significantly" on their scoring (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts.

[[File:E2087 Score Report.png|1000px]]
[[File:E2087 Conflict Notification.png|1000px]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> @response.notify_instructor_on_difference(request.base_url)</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

[[File:Chart before.png|1000px]]

UI before improvements.

<br>
<br>
[[File:Chart after.png|1000px]]

UI after improvements.

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:03:37Z

Achirasa: /* UI Improvements */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== UI Changes ==

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever two reviews for the same submission differ "significantly" on their scoring (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts.

[[File:E2087 Score Report.png|1000px]]
[[File:E2087 Conflict Notification.png|1000px]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> @response.notify_instructor_on_difference(request.base_url)</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

[[File:Chart before.png|1000px]]

UI before improvements.

</br>
</br>
[[File:Chart after.png|1000px]]

UI after improvements.

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:03:14Z

Achirasa: /* UI Improvements */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== UI Changes ==

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever two reviews for the same submission differ "significantly" on their scoring (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts.

[[File:E2087 Score Report.png|1000px]]
[[File:E2087 Conflict Notification.png|1000px]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> @response.notify_instructor_on_difference(request.base_url)</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

[[File:Chart before.png|1000px]]

UI before improvements.

[[File:Chart after.png|1000px]]

UI after improvements.

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:02:44Z

Achirasa: /* Implemented Solution */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== UI Changes ==

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever two reviews for the same submission differ "significantly" on their scoring (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts.

[[File:E2087 Score Report.png|1000px]]
[[File:E2087 Conflict Notification.png|1000px]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> @response.notify_instructor_on_difference(request.base_url)</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

[[File:Chart before.png|1000px]]
[[File:Chart after.png|1000px]]

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

File:Chart after.png

2020-11-17T04:00:42Z

Achirasa: Conflict chart after

Conflict chart after

File:Chart before.png

2020-11-17T04:00:21Z

Achirasa: conflict chart before

conflict chart before

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T03:13:40Z

Achirasa: /* New Implementation */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-15T02:32:47Z

Achirasa: /* Implemented Solution */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-15T02:18:55Z

Achirasa: /* References / Previous Implementation */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-15T02:18:09Z

Achirasa:

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T22:31:33Z

Achirasa:

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T22:30:54Z

Achirasa: /* Functionality Changes */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T22:28:31Z

Achirasa:

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T22:27:02Z

Achirasa: /* UI Changes */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T22:23:03Z

Achirasa: /* UI Changes */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:58:04Z

Achirasa: /* Test Plan */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:29:21Z

Achirasa: /* Proposed Solution */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:09:39Z

Achirasa: /* Test */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:09:29Z

Achirasa: /* Test */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:07:07Z

Achirasa: /* Test */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:06:51Z

Achirasa: /* References */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:02:19Z

Achirasa:

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:01:45Z

Achirasa: /* Improved Tests */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:59:39Z

Achirasa: /* Proposed Solution */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:56:13Z

Achirasa: /* Proposed Solution */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:39:14Z

Achirasa: /* Issues with previous submission */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:38:26Z

Achirasa:

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:37:32Z

Achirasa: /* Introduction */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:31:03Z

Achirasa:

== Introduction ==
test

== Proposed Solution ==
test

== Test ==

== Test ==

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:30:54Z

Achirasa:

== Introduction ==
test

== Proposed Solution ==
test

== Test ==

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:29:02Z

Achirasa: /* Proposed Solution */

== Introduction ==
test

== Proposed Solution ==
test

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:28:54Z

Achirasa: /* Introduction */

== Introduction ==
test

== Proposed Solution ==

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:28:43Z

Achirasa: /* Introduction */

== Introduction ==
== Proposed Solution ==

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:28:31Z

Achirasa: Created page with "== Introduction =="

== Introduction ==

CSC/ECE 517 Fall 2020

2020-10-22T18:28:20Z

Achirasa: /* Final Project Design Documents */

== Writing Assignments ==
* [[CSC/ECE 517 Fall 2020 - E2070. Refactor response_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2068. Refactor quiz_questionnaires_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2062. Add test cases to review_mapping_helper.rb]]
* [[CSC/ECE 517 Fall 2020 - E2063. Refactor tree-display.js and tree_display_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2064. Refactor reputation_web_service_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2065. Fix view in student_task/list page]]
* [[CSC/ECE 517 Fall 2020 - E2066. Refactor lottery controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2067. Refactor student_teams_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2073. Refactor course_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2057. Restrict TAs’ ability to change their own grade and limit file-size upload]]
* [[CSC/ECE 517 Fall 2020 - E2052. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2020 - E2052. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2020 - E2056 Account_Request_Controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2059. Email notification to reviewers and instructors.rb]]
* [[CSC/ECE 517 Fall 2020 - E2058. Two issues related to assignment management]]
* [[CSC/ECE 517 Fall 2020 - E2071. Improve assessment360_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2054. Auto generate submission directory names based on assignment names]]
* [[CSC/ECE 517 Fall 2020 - E2060. Review report should link to the usual view for reviews]]

== Final Project Design Documents ==
* [[CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments]]
* [[CSC/ECE 517 Fall 2020 - E2078. Improve self-review Link peer review & self-review to derive grades]]
* [[CSC/ECE 517 Fall 2020 - E2083. Revision_planning_tool_E2016]]
* [[CSC/ECE 517 Fall 2020 - E2085. Allow reviewers to bid on what to review]]
* [[CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews]]
* [[CSC/ECE 517 Fall 2020 - SQLFE. Refactor Submission.java]]
* [[CSC/ECE 517 Fall 2020 - E2075. calibration submissions should be copied along with calibration assignments]]
* [[CSC/ECE 517 Fall 2020 - E2076. Allow users to create an account and submit work to an "assignment" (e.g., for conference reviewing)]]
* [[CSC/ECE 517 Fall 2020 - E2080. Track the time students look at other submissions]]
* [[CSC/ECE 517 Fall 2020 - E2079. Improve Search Facility In Expertiza]]
* [[CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza]]

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T01:00:23Z

Achirasa: /* Repository */

This wiki page is for the description of E2071. Improve assessment360 controller.
=='''Introduction'''==
The Expertiza project is software to create reusable learning objects through peer review. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages.

=='''Problem Statement'''==
As an instructor, you are able to view tables with information on student performance across the various courses they are taking and their assignments. Currently, these tables always show the same information and you are not able to specify if you only want to see certain data. Furthermore, the source code has some variables names that are not clear to what their purpose is in the code.
===To fix the problem:===
1.There should be a dialog that appears before navigating to the pages where the table views are that contain a list of checkboxes to allow the user to choose which columns they would like to see.
====Course Grade Summary====
Selectable columns:
*Instructor Assigned Scores
*Peer Grades
*Topics
====View Aggregated Teammates and Meta Reviews====
Selectable columns:
*Teammate Review Scores
*Meta Review Scores
*Number Of Teammates

=='''Solution'''==

===1.Modify View===
File: app/views/tree_display/_dialog.html.erb

This file is a ruby view partial that contains the html for the checkbox dialogs.

<pre>
<div id="dialog_course_summary" title="Select Columns" hidden="true">
<%= form_tag('/assessment360/course_student_grade_summary', method: :get) do %>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('InstructorAssignedScores', "Instuctor Assigned Scores") %>
<%= check_box_tag 'fields[]', 'InstructorAssignedScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('PeerGrades', "Peer Grades") %>
<%= check_box_tag 'fields[]', 'PeerGrades'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('Topics', "Topics") %>
<%= check_box_tag 'fields[]', 'Topics'%>
</div>
<%= hidden_field_tag('course_id', '', :id => 'course_summary_course_id')%>
<%= submit_tag("Submit") %>
<button type="button" id='closeCourseSummaryDialog'>Close</button>
<% end %>
</div>
<div id="dialog" title="Select Columns" hidden="true">
<%= form_tag('/assessment360/all_students_all_reviews', method: :get) do %>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('TeammateReviewScores', "Teammate Review Scores") %>
<%= check_box_tag 'fields[]', 'TeammateReviewScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('MetaReviewScores', "Meta-Review Scores") %>
<%= check_box_tag 'fields[]', 'MetaReviewScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('NumberOfTeammates', "Number Of Teammates") %>
<%= check_box_tag 'fields[]', 'NumberOfTeammates'%>
</div>
<%= hidden_field_tag 'course_id'%>
<%= submit_tag("Submit") %>
<button type="button" id='closeDialog'>Close</button>
<% end %>
</div>
</pre>

File: app/assets/javascripts/tree_display.jsx

Added functions to toggle dialog.
<pre>

if (document.getElementById('closeDialog')) {
document.getElementById('closeDialog').onclick = () => {jQuery('#dialog').dialog('close')};
}
if (document.getElementById('closeCourseSummaryDialog')) {
document.getElementById('closeCourseSummaryDialog').onclick = () => {jQuery('#dialog_course_summary').dialog('close')};
}

toggleModal: function() {
jQuery( "#dialog" ).dialog();
document.getElementById('course_id').value = parseInt(this.props.id/2).toString();
}
toggleCourseSummaryModal: function() {
jQuery( "#dialog_course_summary" ).dialog();
document.getElementById('course_summary_course_id').value = parseInt(this.props.id/2).toString();
}

</pre>

Added buttons to replace links that trigged dialog popups.

<pre>

<button title="View grade summary by student" onClick={this.toggleCourseSummaryModal}
style={{"padding": "0px", "margin": "0px", "border": "0px", "width": "24px", "height": "24px", "top": "8px"}} >
<img src="/assets/tree_view/360-dashboard-24.png" />
</button>

<button title="View aggregated teammate & meta reviews" onClick={this.toggleModal}
style={{"padding": "0px", "margin": "0px", "border": "0px", "width": "24px", "height": "24px", "top": "8px"}} >
<span style={{"fontSize": "22px", "top": "8px"}} className="glyphicon glyphicon-list-alt"></span>
</button>

</pre>

File: app/views/assessment360/all_students_all_reviews.html.erb, app/views/assessment360/course_student_grade_summary.html.erb

Added conditionals to show selected columns for the html tables

<pre>
<% if @show_meta_reviews%><% total_meta_review_count = @overall_meta_review_count.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_meta_reviews%><td><%= "#{total_meta_review_grade / total_meta_review_count}%" %></td> <%end%>
<% if @show_teammate_reviews%><% total_teammate_review_grade = @overall_teammate_review_grades.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_teammate_reviews%><% total_teammate_review_count = @overall_teammate_review_count.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_teammate_reviews%> <td><%= "#{total_teammate_review_grade / total_teammate_review_count}%" %></td> <%end%>
</pre>

===2.Modify Controller===
File: app/controllers/assessment360_controller.rb

Added Variables to check if corresponding columns should be shown.
<pre>
fields = params[:fields]
@show_meta_reviews = fields.include? 'MetaReviewScores'
@show_teammate_reviews = fields.include? 'TeammateReviewScores'
@show_teammate_count = fields.include? 'NumberOfTeammates'
@colspan_count = 2
if !@show_teammate_reviews
@colspan_count -= 1
end
if !@show_meta_reviews
@colspan_count -= 1
end
</pre>

===3.'Updated Variable Names===
File: app/controllers/assessment360_controller.rb

Renamed @teamed_count to @total_unique_teammates

<pre>

@total_unique_teammates = {}

</pre>

====Modify course_student_grade_summary ====

File: app/controllers/assessment360_controller.rb

Added ability to calculate average peer review score for each student in a course.

<pre>
@average_peer_review_score = {}
</pre>

<pre>
...
next if peer_review_score.nil?
next if peer_review_score[:total_score].nil?
@average_peer_review_score[cp.id] += peer_review_score[:total_score].round(2)
end
if @assignments.count > 0
@average_peer_review_score[cp.id] = (@average_peer_review_score[cp.id] / @assignments.count()).round(2)
end
</pre>

=='''Result'''==

Before navigating to aggregated teammate and meta reviews, a dialog shows to allow the user select which columns they would like to see.

[[File:Aggregated_teammate_meta_reviews.png]]

Similarly, before navigating to course grade summary, another dialog shows to allow the user select their columns.

[[File:Course_grade_summary.png]]

== Team Information ==
'''Project Mentor:'''
<br>Dr. Gehringer

'''Project Members:'''<br>
Javier Sanchez<br>
Jack Macdonald<br>
Andrew Hirasawa<br>

== Repository ==
[https://github.com/salmonandrew/expertiza GitHub Repo]

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T01:00:01Z

Achirasa:

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T00:58:20Z

Achirasa:

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T00:55:59Z

Achirasa: /* Result */

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T00:54:28Z

Achirasa:

This wiki page is for the description of E2071. Improve assessment360 controller.
=='''Introduction'''==
The Expertiza project is software to create reusable learning objects through peer review. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages.

=='''Problem Statement'''==
As an instructor, you are able to view tables with information on student performance across the various courses they are taking and their assignments. Currently, these tables always show the same information and you are not able to specify if you only want to see certain data. Furthermore, the source code has some variables names that are not clear to what their purpose is in the code.
===To fix the problem:===
1.There should be a dialog that appears before navigating to the pages where the table views are that contain a list of checkboxes to allow the user to choose which columns they would like to see.
====Course Grade Summary====
Selectable columns:
*Instructor Assigned Scores
*Peer Grades
*Topics
====View Aggregated Teammates and Meta Reviews====
Selectable columns:
*Teammate Review Scores
*Meta Review Scores
*Number Of Teammates

=='''Solution'''==

===1.Modify View===
File: app/views/tree_display/_dialog.html.erb

This file is a ruby view partial that contains the html for the checkbox dialogs.

<pre>
<div id="dialog_course_summary" title="Select Columns" hidden="true">
<%= form_tag('/assessment360/course_student_grade_summary', method: :get) do %>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('InstructorAssignedScores', "Instuctor Assigned Scores") %>
<%= check_box_tag 'fields[]', 'InstructorAssignedScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('PeerGrades', "Peer Grades") %>
<%= check_box_tag 'fields[]', 'PeerGrades'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('Topics', "Topics") %>
<%= check_box_tag 'fields[]', 'Topics'%>
</div>
<%= hidden_field_tag('course_id', '', :id => 'course_summary_course_id')%>
<%= submit_tag("Submit") %>
<button type="button" id='closeCourseSummaryDialog'>Close</button>
<% end %>
</div>
<div id="dialog" title="Select Columns" hidden="true">
<%= form_tag('/assessment360/all_students_all_reviews', method: :get) do %>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('TeammateReviewScores', "Teammate Review Scores") %>
<%= check_box_tag 'fields[]', 'TeammateReviewScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('MetaReviewScores', "Meta-Review Scores") %>
<%= check_box_tag 'fields[]', 'MetaReviewScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('NumberOfTeammates', "Number Of Teammates") %>
<%= check_box_tag 'fields[]', 'NumberOfTeammates'%>
</div>
<%= hidden_field_tag 'course_id'%>
<%= submit_tag("Submit") %>
<button type="button" id='closeDialog'>Close</button>
<% end %>
</div>
</pre>

File: app/assets/javascripts/tree_display.jsx

Added functions to toggle dialog.
<pre>

if (document.getElementById('closeDialog')) {
document.getElementById('closeDialog').onclick = () => {jQuery('#dialog').dialog('close')};
}
if (document.getElementById('closeCourseSummaryDialog')) {
document.getElementById('closeCourseSummaryDialog').onclick = () => {jQuery('#dialog_course_summary').dialog('close')};
}

toggleModal: function() {
jQuery( "#dialog" ).dialog();
document.getElementById('course_id').value = parseInt(this.props.id/2).toString();
}
toggleCourseSummaryModal: function() {
jQuery( "#dialog_course_summary" ).dialog();
document.getElementById('course_summary_course_id').value = parseInt(this.props.id/2).toString();
}

</pre>

Added buttons to replace links that trigged dialog popups.

<pre>

<button title="View grade summary by student" onClick={this.toggleCourseSummaryModal}
style={{"padding": "0px", "margin": "0px", "border": "0px", "width": "24px", "height": "24px", "top": "8px"}} >
<img src="/assets/tree_view/360-dashboard-24.png" />
</button>

<button title="View aggregated teammate & meta reviews" onClick={this.toggleModal}
style={{"padding": "0px", "margin": "0px", "border": "0px", "width": "24px", "height": "24px", "top": "8px"}} >
<span style={{"fontSize": "22px", "top": "8px"}} className="glyphicon glyphicon-list-alt"></span>
</button>

</pre>

File: app/views/assessment360/all_students_all_reviews.html.erb, app/views/assessment360/course_student_grade_summary.html.erb

Added conditionals to show selected columns for the html tables

<pre>
<% if @show_meta_reviews%><% total_meta_review_count = @overall_meta_review_count.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_meta_reviews%><td><%= "#{total_meta_review_grade / total_meta_review_count}%" %></td> <%end%>
<% if @show_teammate_reviews%><% total_teammate_review_grade = @overall_teammate_review_grades.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_teammate_reviews%><% total_teammate_review_count = @overall_teammate_review_count.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_teammate_reviews%> <td><%= "#{total_teammate_review_grade / total_teammate_review_count}%" %></td> <%end%>
</pre>

===2.Modify Controller===
File: app/controllers/assessment360_controller.rb

Added Variables to check if corresponding columns should be shown.
<pre>
fields = params[:fields]
@show_meta_reviews = fields.include? 'MetaReviewScores'
@show_teammate_reviews = fields.include? 'TeammateReviewScores'
@show_teammate_count = fields.include? 'NumberOfTeammates'
@colspan_count = 2
if !@show_teammate_reviews
@colspan_count -= 1
end
if !@show_meta_reviews
@colspan_count -= 1
end
</pre>

===3.'Updated Variable Names===
File: app/controllers/assessment360_controller.rb

Renamed @teamed_count to @total_unique_teammates

<pre>

@total_unique_teammates = {}

</pre>

====Modify course_student_grade_summary ====

File: app/controllers/assessment360_controller.rb

Added ability to calculate average peer review score for each student in a course.

<pre>
@average_peer_review_score = {}
</pre>

<pre>
...
next if peer_review_score.nil?
next if peer_review_score[:total_score].nil?
@average_peer_review_score[cp.id] += peer_review_score[:total_score].round(2)
end
if @assignments.count > 0
@average_peer_review_score[cp.id] = (@average_peer_review_score[cp.id] / @assignments.count()).round(2)
end
</pre>

=='''Result'''==

[[File:Aggregated_teammate_meta_reviews.png]]

[[File:Course_grade_summary.png]]

File:Aggregated teammate meta reviews.png

2020-10-14T00:53:50Z

Achirasa:

File:Course grade summary.png

2020-10-14T00:53:31Z

Achirasa:

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T00:51:53Z

Achirasa: /* Result */

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T00:50:15Z

Achirasa: /* Problem Statement */

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T00:48:59Z

Achirasa:

This wiki page is for the description of E2071. Improve assessment360 controller.
=='''Introduction'''==
The Expertiza project is software to create reusable learning objects through peer review. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages.

=='''Problem Statement'''==
As an instructor, you are able to view tables with information on student performance across the various courses they are taking and their assignments. Currently, these tables always show the same information and you are not able to specify if you only want to see certain data. Furthermore, the source code has some variables names that are not clear to what their purpose is in the code.

===To fix the problem:===
1.There should be a dialog that appears before navigating to the pages where the table views are that contain a list of checkboxes to allow the user to choose which columns they would like to see.
====Course Grade Summary====
Selectable columns:
*Instructor Assigned Scores
*Peer Grades
*Topics
====View Aggregated Teammates and Meta Reviews====
Selectable columns:
*Teammate Review Scores
*Meta Review Scores
*Number Of Teammates

=='''Solution'''==

===1.Modify View===
File: app/views/tree_display/_dialog.html.erb

This file is a ruby view partial that contains the html for the checkbox dialogs.

<pre>
<div id="dialog_course_summary" title="Select Columns" hidden="true">
<%= form_tag('/assessment360/course_student_grade_summary', method: :get) do %>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('InstructorAssignedScores', "Instuctor Assigned Scores") %>
<%= check_box_tag 'fields[]', 'InstructorAssignedScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('PeerGrades', "Peer Grades") %>
<%= check_box_tag 'fields[]', 'PeerGrades'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('Topics', "Topics") %>
<%= check_box_tag 'fields[]', 'Topics'%>
</div>
<%= hidden_field_tag('course_id', '', :id => 'course_summary_course_id')%>
<%= submit_tag("Submit") %>
<button type="button" id='closeCourseSummaryDialog'>Close</button>
<% end %>
</div>
<div id="dialog" title="Select Columns" hidden="true">
<%= form_tag('/assessment360/all_students_all_reviews', method: :get) do %>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('TeammateReviewScores', "Teammate Review Scores") %>
<%= check_box_tag 'fields[]', 'TeammateReviewScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('MetaReviewScores', "Meta-Review Scores") %>
<%= check_box_tag 'fields[]', 'MetaReviewScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('NumberOfTeammates', "Number Of Teammates") %>
<%= check_box_tag 'fields[]', 'NumberOfTeammates'%>
</div>
<%= hidden_field_tag 'course_id'%>
<%= submit_tag("Submit") %>
<button type="button" id='closeDialog'>Close</button>
<% end %>
</div>
</pre>

File: app/assets/javascripts/tree_display.jsx

Added functions to toggle dialog.
<pre>

if (document.getElementById('closeDialog')) {
document.getElementById('closeDialog').onclick = () => {jQuery('#dialog').dialog('close')};
}
if (document.getElementById('closeCourseSummaryDialog')) {
document.getElementById('closeCourseSummaryDialog').onclick = () => {jQuery('#dialog_course_summary').dialog('close')};
}

toggleModal: function() {
jQuery( "#dialog" ).dialog();
document.getElementById('course_id').value = parseInt(this.props.id/2).toString();
}
toggleCourseSummaryModal: function() {
jQuery( "#dialog_course_summary" ).dialog();
document.getElementById('course_summary_course_id').value = parseInt(this.props.id/2).toString();
}

</pre>

Added buttons to replace links that trigged dialog popups.

<pre>

<button title="View grade summary by student" onClick={this.toggleCourseSummaryModal}
style={{"padding": "0px", "margin": "0px", "border": "0px", "width": "24px", "height": "24px", "top": "8px"}} >
<img src="/assets/tree_view/360-dashboard-24.png" />
</button>

<button title="View aggregated teammate & meta reviews" onClick={this.toggleModal}
style={{"padding": "0px", "margin": "0px", "border": "0px", "width": "24px", "height": "24px", "top": "8px"}} >
<span style={{"fontSize": "22px", "top": "8px"}} className="glyphicon glyphicon-list-alt"></span>
</button>

</pre>

File: app/views/assessment360/all_students_all_reviews.html.erb, app/views/assessment360/course_student_grade_summary.html.erb

Added conditionals to show selected columns for the html tables

<pre>
<% if @show_meta_reviews%><% total_meta_review_count = @overall_meta_review_count.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_meta_reviews%><td><%= "#{total_meta_review_grade / total_meta_review_count}%" %></td> <%end%>
<% if @show_teammate_reviews%><% total_teammate_review_grade = @overall_teammate_review_grades.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_teammate_reviews%><% total_teammate_review_count = @overall_teammate_review_count.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_teammate_reviews%> <td><%= "#{total_teammate_review_grade / total_teammate_review_count}%" %></td> <%end%>
</pre>

===2.Modify Controller===
File: app/controllers/assessment360_controller.rb

Added Variables to check if corresponding columns should be shown.
<pre>
fields = params[:fields]
@show_meta_reviews = fields.include? 'MetaReviewScores'
@show_teammate_reviews = fields.include? 'TeammateReviewScores'
@show_teammate_count = fields.include? 'NumberOfTeammates'
@colspan_count = 2
if !@show_teammate_reviews
@colspan_count -= 1
end
if !@show_meta_reviews
@colspan_count -= 1
end
</pre>

===3.'Updated Variable Names===
File: app/controllers/assessment360_controller.rb

Renamed @teamed_count to @total_unique_teammates

<pre>

@total_unique_teammates = {}

</pre>

====Modify course_student_grade_summary ====

File: app/controllers/assessment360_controller.rb

Added ability to calculate average peer review score for each student in a course.

<pre>
@average_peer_review_score = {}
</pre>

<pre>
...
next if peer_review_score.nil?
next if peer_review_score[:total_score].nil?
@average_peer_review_score[cp.id] += peer_review_score[:total_score].round(2)
end
if @assignments.count > 0
@average_peer_review_score[cp.id] = (@average_peer_review_score[cp.id] / @assignments.count()).round(2)
end
</pre>

=='''Result'''==

CSC/ECE 517 Fall 2020 - E2071. Improve assessment360 controller.rb

2020-10-14T00:48:49Z

Achirasa: /* Result */

This wiki page is for the description of E2071. Improve assessment360 controller.
=='''Introduction'''==
The Expertiza project is software to create reusable learning objects through peer review. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages.

=='''Problem Statement'''==
As an instructor, you are able to view tables with information on student performance across the various courses they are taking and their assignments. Currently, these tables always show the same information and you are not able to specify if you only want to see certain data. Furthermore, the source code has some variables names that are not clear to what their purpose is in the code.

===To fix the problem:===
1.There should be a dialog that appears before navigating to the pages where the table views are that contain a list of checkboxes to allow the user to choose which columns they would like to see.
====Course Grade Summary====
Selectable columns:
*Instructor Assigned Scores
*Peer Grades
*Topics
====View Aggregated Teammates and Meta Reviews====
Selectable columns:
*Teammate Review Scores
*Meta Review Scores
*Number Of Teammates

=='''Solution'''==

===1.Modify View===
File: app/views/tree_display/_dialog.html.erb

This file is a ruby view partial that contains the html for the checkbox dialogs.

<pre>
<div id="dialog_course_summary" title="Select Columns" hidden="true">
<%= form_tag('/assessment360/course_student_grade_summary', method: :get) do %>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('InstructorAssignedScores', "Instuctor Assigned Scores") %>
<%= check_box_tag 'fields[]', 'InstructorAssignedScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('PeerGrades', "Peer Grades") %>
<%= check_box_tag 'fields[]', 'PeerGrades'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('Topics', "Topics") %>
<%= check_box_tag 'fields[]', 'Topics'%>
</div>
<%= hidden_field_tag('course_id', '', :id => 'course_summary_course_id')%>
<%= submit_tag("Submit") %>
<button type="button" id='closeCourseSummaryDialog'>Close</button>
<% end %>
</div>
<div id="dialog" title="Select Columns" hidden="true">
<%= form_tag('/assessment360/all_students_all_reviews', method: :get) do %>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('TeammateReviewScores', "Teammate Review Scores") %>
<%= check_box_tag 'fields[]', 'TeammateReviewScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('MetaReviewScores', "Meta-Review Scores") %>
<%= check_box_tag 'fields[]', 'MetaReviewScores'%>
</div>
<div class="form-group row" style="margin-bottom: 0px !important;">
<%= label_tag('NumberOfTeammates', "Number Of Teammates") %>
<%= check_box_tag 'fields[]', 'NumberOfTeammates'%>
</div>
<%= hidden_field_tag 'course_id'%>
<%= submit_tag("Submit") %>
<button type="button" id='closeDialog'>Close</button>
<% end %>
</div>
</pre>

File: app/assets/javascripts/tree_display.jsx

Added functions to toggle dialog.
<pre>

if (document.getElementById('closeDialog')) {
document.getElementById('closeDialog').onclick = () => {jQuery('#dialog').dialog('close')};
}
if (document.getElementById('closeCourseSummaryDialog')) {
document.getElementById('closeCourseSummaryDialog').onclick = () => {jQuery('#dialog_course_summary').dialog('close')};
}

toggleModal: function() {
jQuery( "#dialog" ).dialog();
document.getElementById('course_id').value = parseInt(this.props.id/2).toString();
}
toggleCourseSummaryModal: function() {
jQuery( "#dialog_course_summary" ).dialog();
document.getElementById('course_summary_course_id').value = parseInt(this.props.id/2).toString();
}

</pre>

Added buttons to replace links that trigged dialog popups.

<pre>

<button title="View grade summary by student" onClick={this.toggleCourseSummaryModal}
style={{"padding": "0px", "margin": "0px", "border": "0px", "width": "24px", "height": "24px", "top": "8px"}} >
<img src="/assets/tree_view/360-dashboard-24.png" />
</button>

<button title="View aggregated teammate & meta reviews" onClick={this.toggleModal}
style={{"padding": "0px", "margin": "0px", "border": "0px", "width": "24px", "height": "24px", "top": "8px"}} >
<span style={{"fontSize": "22px", "top": "8px"}} className="glyphicon glyphicon-list-alt"></span>
</button>

</pre>

File: app/views/assessment360/all_students_all_reviews.html.erb, app/views/assessment360/course_student_grade_summary.html.erb

Added conditionals to show selected columns for the html tables

<pre>
<% if @show_meta_reviews%><% total_meta_review_count = @overall_meta_review_count.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_meta_reviews%><td><%= "#{total_meta_review_grade / total_meta_review_count}%" %></td> <%end%>
<% if @show_teammate_reviews%><% total_teammate_review_grade = @overall_teammate_review_grades.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_teammate_reviews%><% total_teammate_review_count = @overall_teammate_review_count.inject(0) {|sum, (k, v)| sum + v } %><%end%>
<% if @show_teammate_reviews%> <td><%= "#{total_teammate_review_grade / total_teammate_review_count}%" %></td> <%end%>
</pre>

===2.Modify Controller===
File: app/controllers/assessment360_controller.rb

Added Variables to check if corresponding columns should be shown.
<pre>
fields = params[:fields]
@show_meta_reviews = fields.include? 'MetaReviewScores'
@show_teammate_reviews = fields.include? 'TeammateReviewScores'
@show_teammate_count = fields.include? 'NumberOfTeammates'
@colspan_count = 2
if !@show_teammate_reviews
@colspan_count -= 1
end
if !@show_meta_reviews
@colspan_count -= 1
end
</pre>

===3.'Updated Variable Names===
File: app/controllers/assessment360_controller.rb

Renamed @teamed_count to @total_unique_teammates

<pre>

@total_unique_teammates = {}

</pre>

====Modify course_student_grade_summary ====

File: app/controllers/assessment360_controller.rb

Added ability to calculate average peer review score for each student in a course.

<pre>
@average_peer_review_score = {}
</pre>

<pre>
...
next if peer_review_score.nil?
next if peer_review_score[:total_score].nil?
@average_peer_review_score[cp.id] += peer_review_score[:total_score].round(2)
end
if @assignments.count > 0
@average_peer_review_score[cp.id] = (@average_peer_review_score[cp.id] / @assignments.count()).round(2)
end
</pre>

=='''Result'''==

=='''Test'''==
File: spec/controllers/sign_up_sheet_controller_spec.rb

Select assignment with id '834' and topic with id ['E1732'] as params. Post params to delete_all_selected_topics. Expect success flash with 'All selected topics have been deleted successfully.' and redirect to '/assignments/834/edit#tabs-2'.
<pre>
describe '#delete_all_selected_topics' do
it 'delete_all_selected_topics and redirects to edit assignment page' do
allow(SignUpTopic).to receive(:find).with(assignment_id: '834',topic_identifier: ['E1732']).and_return(topic)
params = {assignment_id: 834, idents: ['E1732']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
expect(response).to redirect_to('/assignments/834/edit#tabs-2')
end
end
</pre>