Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Spring 2019

2019-04-20T15:12:43Z

Aarya: added link to E1931 Wiki Page

*[[CSC/ECE 517 Spring 2019 - Project E1930. Improving Search Facility in Expertiza]]
*[[CSC/ECE 517 Spring 2019 - Project E1905. Refactor questionnaires_controller.rb]]
*[[CSC/ECE 517 Spring 2019 - Project E1916. Fix Code Climate issues in controllers with names beginning with A through N]]
*[[CSC/ECE 517 Spring 2019 - Project E1906. Refactor stage deadlines in Assignment.rb]]
*[[CSC/ECE 517 Spring 2019 - Project M1901 Implement missing WebAudio automation support]]
*[[CSC/ECE 517 Spring 2019 - Project E1917. Fix Code Climate issues in controllers with names beginning with P through Z]]
*[[CSC/ECE 517 Spring 2019 - Project E1921. Write tests for popup controller.rb]]
*[[CSC/ECE 517 Spring 2019 - M1902 Refactor bluetooth support for better maintainability]]
*[[CSC/ECE 517 Spring 2019 - E1922. Write tests for assessment360 controller.rb]]
*[[CSC/ECE 517 Spring 2019 - Project E1907 Refactor response controller]]
*[[CSC/ECE_517_Spring_2019_-_Project_E1903._Create_quiz_questionnaires_controller.rb]]
*[[CSC/ECE_517_Spring_2019_-_Project_E1913. Refactor_review_mapping_helper.rb]]
*[[CSC/ECE_517_Spring_2019_-_E1919_CodeClimate_Issues]]
*[[CSC/ECE_517_Spring_2019_-_Project_E1912. Export_Tagged_Comments]]
*[[CSC/ECE_517_Spring_2019/E1927_Let_Course_Staff_as_Well_as_Students_Do_Reviews]]
*[[E1911_Refactor_Criterion]]
*[[E1934 - Grading Audit Trail]]
*[[CSC/ECE 517 Spring 2019 - Project E1925. Refactor E1858. Github metrics integration]]
*[[CSC/ECE_517_Spring_2019_-_Project_E1931._Conflict_notification]]

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-19T14:59:40Z

Aarya: /* Files to be changed in this Project */

This wiki page is for the description of changes made under ECE517 SPRING 2019 PROJECT E1931 CONFLICT NOTIFICATIONS

=Problem Statement=

Current conflict notification sends an email to the instructor whenever two reviews for the same submission differ “significantly” on their scoring (the threshold is specified in the “Notification limit” on the Rubrics tab of assignment creation). Right now an email is sent at any such time one of these conflicts happen, and it links to the review or submission which initiated the notification. It gives the link in raw HTML, but it should give it as a link associated with text, such as the text “this new review” linking to the page that shows the review.

=Existing Feature Description=

Currently, this feature works as follows:

[[File:Flowwork.PNG|center]]

Whenever a new review is submitted, it is compared with the average of the previously submitted reviews. If the difference between the new submission and existing average is more than the threshold limit set, then a mail is sent to the instructor.
With every review submitted for an assignment of a particular student, the average is updated.

==Flaws with the existing Implementation==

===No view exists to analyze the conflict report===
Currently whenever the conflict happens,a summary link is sent to the instructor which contains the score of all the reviews but there is no view where the instructor can see all the conflicts and analyze them.

===Incorrect email message links===
The existing email body uses hardcoded URLs mentioned in models/response.rb file in the method notify_instructor_on_difference. Being hardcoded, these links wouldn't work on other servers where Expertiza is running. For Example, if the setup is done on localhost, the links will not be functional.

[[File:EMAIL.png|center]]

*Conflicting Review which triggered the mail
[[File:Score conflicting.png|center]]

*Summary of all the reviews
[[File:SUMMARY.png|center]]

=What needs to be done=
The scope of this project is to send an email notification to instructor which will contain links to the conflicting review, summary link, and a link to report which can be used for analyzing. The new report will have the information like the Team(having conflicts), the standard deviation for the team review score and pictorial representation of all the review scores. 

The email sent to the instructor should contain the following data on each of the reviews done on this team:
* The name of the team.
* The members (user-IDs and/or names)

One line for each review received. In this line would be
* The name of the person (or team) that submitted the review, which would be hyperlinked to the review itself,
* The score given for the review,
* A bar chart showing pictorial view
* The average score received from reviewers.
* The standard deviation of the score received from reviewers.
* Review scores that are outside some “tolerance” limit would be highlighted, e.g., boldfaced or shown in a different color. Probably the tolerance should be, perhaps, one or two standard deviations from the mean.

=Implementation=

*'''Feature 1:''' New view to show the conflict report
A new view of the report which will have the following information:- 
* The name of the team.
* The members (user-IDs and/or names)
* The name of the person (or team) that submitted the review, which would be hyperlinked to the review itself,
* The score given for the review,
* A bar chart showing pictorial view
* The average score received from reviewers.
* The standard deviation of the score received from reviewers.

This view will have a report of all the teams on one page.
This report link will be added to the mail that is already being sent whenever some conflict happens.
This report will be also accessible from the reports dropdown for the instructor.
*Sample view of the new report (The view will contain all the columns as mentioned above)-
[[File: Capture.PNG|center]]
 
*'''Feature 2:''' No hardcoded URLs
Hardcoded URLs will be managed by the config file in order to make these links functional on every server running Expertiza and raw URLs will be given some meaningful names

=Files to be changed in this Project=
* [https://github.com/expertiza/expertiza/blob/master/app/mailers/mailer.rb mailer.rb]
* [https://github.com/expertiza/expertiza/tree/master/config Config File]
* [https://github.com/expertiza/expertiza/blob/master/app/models/response.rb response.rb]
* [https://github.com/expertiza/expertiza/blob/master/app/controllers/reports_controller.rb Response Controller]
* [https://github.com/expertiza/expertiza/blob/master/app/helpers/report_formatter_helper.rb Report Format Helper]
* [https://github.com/expertiza/expertiza/tree/master/app/views/reports/ Reports View]
* [https://github.com/expertiza/expertiza/blob/master/app/models/review_response_map.rb review_response_map.rb]
* [https://github.com/expertiza/expertiza/blob/master/app/helpers/review_mapping_helper.rb review_mapping_helper.rb]
A new option will be added to view the conflict report in the _searchbox.html.erb.A new view will be added to the same. 
A new view partial _review_conflict_report.html.erb will be added in report views.

=Test Plan=

To test code implementation and correctness of the modified feature, we plan to do the following tests:-

*Run and pass existing RSpec Tests
*Develop New RSpec Tests for the new code
*UI testing on the deployed project

==Rspec Testing==
Rspec test files to be updated -
*[https://github.com/expertiza/expertiza/blob/master/spec/controllers/reports_controller_spec.rb Reports Controller Spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/controllers/response_controller_spec.rb Response Controller Spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/models/response_spec.rb Response spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/models/mailer_spec.rb mailer spec]

[Screenshots to be populated after coding is complete]

==UI Testing==
[Screenshots/video to be populated after coding is complete]

=References=
* [https://github.com/expertiza/expertiza expertiza]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification Previous Work]
* [https://github.com/expertiza/expertiza/pull/1329 Previous Pull Request]
* [https://rubygems.org/gems/standard-deviation/versions/0.1.1 Standard-Deviation gem]
* [https://github.com/jtescher/descriptive-statistics descriptive-statistics gem]

=Team=

[mailto:aarya@ncsu.edu Abhishek Arya] 
[mailto:bbdeshpa@ncsu.edu Bhargav Deshpande] 
[mailto:rkaur@ncsu.edu Ramandeep Kaur] 
[mailto:uschatto@ncsu.edu Udita Chattopadhyay]

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-19T14:59:23Z

Aarya: /* Files to be changed in this Project */

This wiki page is for the description of changes made under ECE517 SPRING 2019 PROJECT E1931 CONFLICT NOTIFICATIONS

=Problem Statement=

Current conflict notification sends an email to the instructor whenever two reviews for the same submission differ “significantly” on their scoring (the threshold is specified in the “Notification limit” on the Rubrics tab of assignment creation). Right now an email is sent at any such time one of these conflicts happen, and it links to the review or submission which initiated the notification. It gives the link in raw HTML, but it should give it as a link associated with text, such as the text “this new review” linking to the page that shows the review.

=Existing Feature Description=

Currently, this feature works as follows:

[[File:Flowwork.PNG|center]]

Whenever a new review is submitted, it is compared with the average of the previously submitted reviews. If the difference between the new submission and existing average is more than the threshold limit set, then a mail is sent to the instructor.
With every review submitted for an assignment of a particular student, the average is updated.

==Flaws with the existing Implementation==

===No view exists to analyze the conflict report===
Currently whenever the conflict happens,a summary link is sent to the instructor which contains the score of all the reviews but there is no view where the instructor can see all the conflicts and analyze them.

===Incorrect email message links===
The existing email body uses hardcoded URLs mentioned in models/response.rb file in the method notify_instructor_on_difference. Being hardcoded, these links wouldn't work on other servers where Expertiza is running. For Example, if the setup is done on localhost, the links will not be functional.

[[File:EMAIL.png|center]]

*Conflicting Review which triggered the mail
[[File:Score conflicting.png|center]]

*Summary of all the reviews
[[File:SUMMARY.png|center]]

=What needs to be done=
The scope of this project is to send an email notification to instructor which will contain links to the conflicting review, summary link, and a link to report which can be used for analyzing. The new report will have the information like the Team(having conflicts), the standard deviation for the team review score and pictorial representation of all the review scores. 

The email sent to the instructor should contain the following data on each of the reviews done on this team:
* The name of the team.
* The members (user-IDs and/or names)

One line for each review received. In this line would be
* The name of the person (or team) that submitted the review, which would be hyperlinked to the review itself,
* The score given for the review,
* A bar chart showing pictorial view
* The average score received from reviewers.
* The standard deviation of the score received from reviewers.
* Review scores that are outside some “tolerance” limit would be highlighted, e.g., boldfaced or shown in a different color. Probably the tolerance should be, perhaps, one or two standard deviations from the mean.

=Implementation=

*'''Feature 1:''' New view to show the conflict report
A new view of the report which will have the following information:- 
* The name of the team.
* The members (user-IDs and/or names)
* The name of the person (or team) that submitted the review, which would be hyperlinked to the review itself,
* The score given for the review,
* A bar chart showing pictorial view
* The average score received from reviewers.
* The standard deviation of the score received from reviewers.

This view will have a report of all the teams on one page.
This report link will be added to the mail that is already being sent whenever some conflict happens.
This report will be also accessible from the reports dropdown for the instructor.
*Sample view of the new report (The view will contain all the columns as mentioned above)-
[[File: Capture.PNG|center]]
 
*'''Feature 2:''' No hardcoded URLs
Hardcoded URLs will be managed by the config file in order to make these links functional on every server running Expertiza and raw URLs will be given some meaningful names

=Files to be changed in this Project=
* [https://github.com/expertiza/expertiza/blob/master/app/mailers/mailer.rb mailer.rb]
* [https://github.com/expertiza/expertiza/tree/master/config Config File]
* [https://github.com/expertiza/expertiza/blob/master/app/models/response.rb response.rb]
* [https://github.com/expertiza/expertiza/blob/master/app/controllers/reports_controller.rb Response Controller]
* [https://github.com/expertiza/expertiza/blob/master/app/helpers/report_formatter_helper.rb Report Format Helper]
* [https://github.com/expertiza/expertiza/tree/master/app/views/reports/ Reports View]
* [https://github.com/expertiza/expertiza/tree/master/app/views/reports/
* [https://github.com/expertiza/expertiza/blob/master/app/models/review_response_map.rb review_response_map.rb]
* [https://github.com/expertiza/expertiza/blob/master/app/helpers/review_mapping_helper.rb review_mapping_helper.rb]
A new option will be added to view the conflict report in the _searchbox.html.erb.A new view will be added to the same. 
A new view partial _review_conflict_report.html.erb will be added in report views.

=Test Plan=

To test code implementation and correctness of the modified feature, we plan to do the following tests:-

*Run and pass existing RSpec Tests
*Develop New RSpec Tests for the new code
*UI testing on the deployed project

==Rspec Testing==
Rspec test files to be updated -
*[https://github.com/expertiza/expertiza/blob/master/spec/controllers/reports_controller_spec.rb Reports Controller Spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/controllers/response_controller_spec.rb Response Controller Spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/models/response_spec.rb Response spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/models/mailer_spec.rb mailer spec]

[Screenshots to be populated after coding is complete]

==UI Testing==
[Screenshots/video to be populated after coding is complete]

=References=
* [https://github.com/expertiza/expertiza expertiza]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification Previous Work]
* [https://github.com/expertiza/expertiza/pull/1329 Previous Pull Request]
* [https://rubygems.org/gems/standard-deviation/versions/0.1.1 Standard-Deviation gem]
* [https://github.com/jtescher/descriptive-statistics descriptive-statistics gem]

=Team=

[mailto:aarya@ncsu.edu Abhishek Arya] 
[mailto:bbdeshpa@ncsu.edu Bhargav Deshpande] 
[mailto:rkaur@ncsu.edu Ramandeep Kaur] 
[mailto:uschatto@ncsu.edu Udita Chattopadhyay]

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-12T23:36:26Z

Aarya: /* UI Testing */

This wiki page is for the description of changes made under ECE517 SPRING 2019 PROJECT E1931 CONFLICT NOTIFICATIONS

=Problem Statement=

Current conflict notification sends an email to the instructor whenever two reviews for the same submission differ "significantly" on their scoring (the threshold is specified in the "Notification limit" on the Rubrics tab of assignment creation). Right now an email is sent at any such time one of these conflicts happen, however, it does not link to the particular review or submission which initiated the notification.

=Existing Feature Description=

Currently, this feature works as follows:

[[File:Flowwork.PNG|center]]

Whenever a new review is submitted, it is compared with the average of the previously submitted reviews. If the difference between the new submission and existing average is more than the threshold limit set, then a mail is sent to the instructor.
With every review submitted for an assignment of a particular student, the average is updated.

==Flaws with the existing Implementation==

===No view exists to analyze the conflict report===
Currently whenever the conflict happens,a summary link is sent to the instructor which contains the score of all the reviews but there is no view where the instructor can see all the conflicts and analyze them.

===Incorrect email message links===
The existing email body uses hardcoded URLs mentioned in models/response.rb file in the method notify_instructor_on_difference. Being hardcoded, these links wouldn't work on other servers where Expertiza is running. For Example, if the setup is done on localhost, the links will not be functional.

[[File:EMAIL.png|center]]

*Conflicting Review which triggered the mail
[[File:Score conflicting.png|center]]

*Summary of all the reviews
[[File:SUMMARY.png|center]]

=What needs to be done=
The scope of this project is to send an email notification to instructor which will contain links to the conflicting review, summary link, and a link to report which can be used for analyzing. The new report will have the information like the Team(having conflicts), the standard deviation for the team review score and pictorial representation of all the review scores.

=Implementation=

*'''Feature 1:''' No hardcoded URLs
Hardcoded URLs will be managed by the config file in order to make these links functional on every server running Expertiza

*'''Feature 2:''' New view to show the conflict report
A new view of the report which will have the following information:- 
*Name of the team 
*Standard deviation 
*Graph showing a plot of the review scores vs the team name 

This view will have a report of all the teams on one page.
This report link will be added to the mail that is already being sent whenever some conflict happens.
*Sample view of the new report -
[[File: Capture.PNG|center]]

=Files to be changed in this Project=
* [https://github.com/expertiza/expertiza/blob/master/app/mailers/mailer.rb mailer.rb]
* [https://github.com/expertiza/expertiza/tree/master/config Config File]
* [https://github.com/expertiza/expertiza/blob/master/app/models/response.rb response.rb]
* [https://github.com/expertiza/expertiza/blob/master/app/controllers/reports_controller.rb Response Controller]
* [https://github.com/expertiza/expertiza/blob/master/app/helpers/report_formatter_helper.rb Report Format Helper]
* [https://github.com/expertiza/expertiza/tree/master/app/views/reports Reports View]
A new option will be added to view the conflict report in the _searchbox.html.erb.A new view will be added for the same.

=Test Plan=

To test code implementation and correctness of the modified feature, we plan to do the following tests:-

*Run and pass existing RSpec Tests
*Develop New RSpec Tests for the new code
*UI testing on the deployed project

==Rspec Testing==
Rspec test files to be updated -
*[https://github.com/expertiza/expertiza/blob/master/spec/controllers/reports_controller_spec.rb Reports Controller Spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/controllers/response_controller_spec.rb Response Controller Spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/models/response_spec.rb Response spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/models/mailer_spec.rb mailer spec]

[Screenshots to be populated after coding is complete]

==UI Testing==
[Screenshots/video to be populated after coding is complete]

=References=
* [https://github.com/expertiza/expertiza expertiza]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification Previous Work]
* [https://github.com/expertiza/expertiza/pull/1329 Previous Pull Request]
* [https://rubygems.org/gems/standard-deviation/versions/0.1.1 Standard-Deviation gem]
* [https://github.com/jtescher/descriptive-statistics descriptive-statistics gem]

=Team=

[mailto:aarya@ncsu.edu Abhishek Arya] 
[mailto:bbdeshpa@ncsu.edu Bhargav Deshpande] 
[mailto:rkaur@ncsu.edu Ramandeep Kaur] 
[mailto:uschatto@ncsu.edu Udita Chattopadhyay]

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-12T23:35:21Z

Aarya: /* References */

This wiki page is for the description of changes made under ECE517 SPRING 2019 PROJECT E1931 CONFLICT NOTIFICATIONS

=Problem Statement=

Current conflict notification sends an email to the instructor whenever two reviews for the same submission differ "significantly" on their scoring (the threshold is specified in the "Notification limit" on the Rubrics tab of assignment creation). Right now an email is sent at any such time one of these conflicts happen, however, it does not link to the particular review or submission which initiated the notification.

=Existing Feature Description=

Currently, this feature works as follows:

[[File:Flowwork.PNG|center]]

Whenever a new review is submitted, it is compared with the average of the previously submitted reviews. If the difference between the new submission and existing average is more than the threshold limit set, then a mail is sent to the instructor.
With every review submitted for an assignment of a particular student, the average is updated.

==Flaws with the existing Implementation==

===No view exists to analyze the conflict report===
Currently whenever the conflict happens,a summary link is sent to the instructor which contains the score of all the reviews but there is no view where the instructor can see all the conflicts and analyze them.

===Incorrect email message links===
The existing email body uses hardcoded URLs mentioned in models/response.rb file in the method notify_instructor_on_difference. Being hardcoded, these links wouldn't work on other servers where Expertiza is running. For Example, if the setup is done on localhost, the links will not be functional.

[[File:EMAIL.png|center]]

*Conflicting Review which triggered the mail
[[File:Score conflicting.png|center]]

*Summary of all the reviews
[[File:SUMMARY.png|center]]

=What needs to be done=
The scope of this project is to send an email notification to instructor which will contain links to the conflicting review, summary link, and a link to report which can be used for analyzing. The new report will have the information like the Team(having conflicts), the standard deviation for the team review score and pictorial representation of all the review scores.

=Implementation=

*'''Feature 1:''' No hardcoded URLs
Hardcoded URLs will be managed by the config file in order to make these links functional on every server running Expertiza

*'''Feature 2:''' New view to show the conflict report
A new view of the report which will have the following information:- 
*Name of the team 
*Standard deviation 
*Graph showing a plot of the review scores vs the team name 

This view will have a report of all the teams on one page.
This report link will be added to the mail that is already being sent whenever some conflict happens.
*Sample view of the new report -
[[File: Capture.PNG|center]]

=Files to be changed in this Project=
* [https://github.com/expertiza/expertiza/blob/master/app/mailers/mailer.rb mailer.rb]
* [https://github.com/expertiza/expertiza/tree/master/config Config File]
* [https://github.com/expertiza/expertiza/blob/master/app/models/response.rb response.rb]
* [https://github.com/expertiza/expertiza/blob/master/app/controllers/reports_controller.rb Response Controller]
* [https://github.com/expertiza/expertiza/blob/master/app/helpers/report_formatter_helper.rb Report Format Helper]
* [https://github.com/expertiza/expertiza/tree/master/app/views/reports Reports View]
A new option will be added to view the conflict report in the _searchbox.html.erb.A new view will be added for the same.

=Test Plan=

To test code implementation and correctness of the modified feature, we plan to do the following tests:-

*Run and pass existing RSpec Tests
*Develop New RSpec Tests for the new code
*UI testing on the deployed project

==Rspec Testing==
Rspec test files to be updated -
*[https://github.com/expertiza/expertiza/blob/master/spec/controllers/reports_controller_spec.rb Reports Controller Spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/controllers/response_controller_spec.rb Response Controller Spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/models/response_spec.rb Response spec]
*[https://github.com/expertiza/expertiza/blob/master/spec/models/mailer_spec.rb mailer spec]

[Screenshots to be populated after coding is complete]

==UI Testing==
[to be populated after coding is complete]

=References=
* [https://github.com/expertiza/expertiza expertiza]
* [http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification Previous Work]
* [https://github.com/expertiza/expertiza/pull/1329 Previous Pull Request]
* [https://rubygems.org/gems/standard-deviation/versions/0.1.1 Standard-Deviation gem]
* [https://github.com/jtescher/descriptive-statistics descriptive-statistics gem]

=Team=

[mailto:aarya@ncsu.edu Abhishek Arya] 
[mailto:bbdeshpa@ncsu.edu Bhargav Deshpande] 
[mailto:rkaur@ncsu.edu Ramandeep Kaur] 
[mailto:uschatto@ncsu.edu Udita Chattopadhyay]

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-12T23:30:33Z

Aarya: /* Rspec Testing */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-12T23:29:59Z

Aarya: /* Rspec Testing */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-12T23:22:29Z

Aarya: /* Implementation */

File:Capture.PNG

2019-04-12T23:18:34Z

Aarya: uploaded a new version of "File:Capture.PNG"

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-12T23:04:02Z

Aarya: /* Implementation */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-12T23:03:24Z

Aarya: /* Implementation */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-12T23:02:26Z

Aarya:

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T21:56:24Z

Aarya: /* Implementation */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T21:52:28Z

Aarya:

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T21:37:34Z

Aarya: /* Flaws with the Implementation */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T21:37:09Z

Aarya: /* Existing Feature Description */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T21:36:47Z

Aarya: /* Existing Feature Description */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T21:35:29Z

Aarya:

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T20:59:56Z

Aarya: /* What needs to be done */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T20:57:20Z

Aarya: /* Existing Feature Description */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T20:47:31Z

Aarya: /* What needs to be done */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T20:47:14Z

Aarya: /* Problem Statement */

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T19:10:01Z

Aarya:

='''Problem Statement'''=
Current conflict notification sends an email to the instructor whenever two reviews for the same submission differ “significantly” on their scoring (the threshold is specified in the “Notification limit” on the Rubrics tab of assignment creation). Right now an email is sent at any such time one of these conflicts happen, however, it does not link to the particular review or submission which initiated the notification. The scope of this project is to send an email notification to instructor which contains links to two reviews (one of which is the newly submitted review) that differ by more than the notification limit where such a conflict has occurred. The email should state that a new conflicting review has been made.

='''Design'''=

CSC/ECE 517 Spring 2019 - Project E1931. Conflict notification

2019-04-06T19:07:45Z

Aarya: Created page with "='''Problem Statement'''= Current conflict notification sends an email to the instructor whenever two reviews for the same submission differ “significantly” on their scoring ..."

CSC/ECE 517 Spring 2019 - Project E1903. Create quiz questionnaires controller.rb

2019-03-25T19:44:55Z

Aarya: /* Changes made to current Implementation */

== Problem Statement ==

1. The questionnaires_controller.rb has multiple methods to handle quizzes. Some of these methods cater only to quizzes. The controller has to be refactored into 2 controllers by moving the functions related to quizzes and the dependencies into a new controller called quiz_questionnaire_controller.rb.

2. Some methods in the questionnaires_controller.rb are long or have hardcoded parameters. These methods have to be refactored into shorter functions rid of hardcoded parameters.

==Changes made to current Implementation==

1. Creation of new controller 
to be filled

2. Creation of Rspec file for new controller 
to be filled

3. Refactoring current controller 
to be filled

4. Creation of new route for quiz_questionnaire_controller and updated the affected links in views 
Created a new route quiz_questionnaire for quiz_questionnaire_controller in "routs.rb" and moved the custom created "get/post" routes for quizzes from questionnaires route to it.
<pre>
resources :quiz_questionnaire, only: %i[new create edit update] do
collection do
get :new_quiz
post :create_quiz_questionnaire
get :edit_quiz
post :update_quiz
end
end
</pre>
Then changed the controller name and route in all the following views which are accessing quiz_questionnaire_controller while keeping the application flow intact -

/app/views/questionnaire/view.html.erb 
<pre>
<% if @questionnaire.type == "QuizQuestionnaire" %>
<%= link_to 'Edit', :controller => :quiz_questionnaire, :action => :edit_quiz, :id =>
@questionnaire.id, :pid => @participant.id %>|
</pre>

/app/views/questionnaire/new_quiz.erb 
<pre>
<%= form_tag :controller => 'quiz_questionnaire', :action => 'create_quiz_questionnaire',
:pid => @participant_id, :aid => @assignment_id do %>
<% $disp_flag = 1 %>
<%= render :partial => 'quiz_questionnaire' %>
<% $disp_flag = 0 %>

<%= render :partial => 'new_question_template' %>

 
<%= submit_tag "Create Quiz", :name=>"save" %>
<% end %>
</pre>

/app/views/questionnaire/edit.html.erb 
<pre>
<%= form_tag({:controller=>'quiz_questionnaire', :action=>'update_quiz', :id=>@questionnaire.id, :pid => params[:pid]}, :multipart => true) do %>
</pre>
/app/views/submitted_content/_main.html.erb 
<pre>
<% if !t_id.nil? && questionnaire = QuizQuestionnaire.where(["instructor_id = ?", t_id]).first %>
<%= link_to 'View quiz', :controller => :quiz_questionnaire, :action => :view_quiz, :id => questionnaire.id, :pid => participant.id %>
 
<% if !questionnaire.taken_by_anyone?%>
<%= link_to 'Edit quiz', :controller => :quiz_questionnaire, :action => :edit_quiz, :id => questionnaire.id, :pid => participant.id %>
<% end %>
 

<% else %>
 
<%= link_to 'Create a quiz', :controller => :quiz_questionnaire, :action => :new_quiz, :model => "QuizQuestionnaire", :private => 0, :aid => @assignment.id, :pid => participant.id %>
 
<% end %>
</pre>

==Files affected==

The following files were created or refactored
1. /app/controllers/questionnaires_controller.rb 
2. /app/controllers/quiz_questionnaire_controller.rb 
3. /app/views/questionnaire/view.html.erb 
4. /app/views/questionnaire/new_quiz.erb 
5. /app/views/questionnaire/edit.html.erb 
6. /app/views/submitted_content/_main.html.erb 
7. /config/routes.rb 
8. /spec/controllers/questionnaires_controller_spec.rb 
9. /spec/controllers/quiz_questionnaire_controller_spec.rb

==Team members==
1. Abhishek Arya (aarya@ncsu.edu) 
2. Nitin Nataraj Kuncham (nkuncha@ncsu.edu) 
3. Suraj Siddharudh (ssiddha@ncsu.edu) 

==References==
#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://www.rubyguides.com/2018/07/rspec-tutorial/ rpec tutorial]
#[https://www.stackoverflow.com/ Stackoverflow]