https://wiki.expertiza.ncsu.edu/api.php?action=feedcontributions&feedformat=atom&user=AarnavExpertiza_Wiki - User contributions [en]2026-06-02T10:30:23ZUser contributionsMediaWiki 1.41.0https://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=119030E1827 Topic management2018-11-09T05:59:55Z<p>Aarnav: /* UI Testing */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link: https://www.youtube.com/watch?v=_0UU0r4IOf4&feature=youtu.be<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
* app/views/suggestion/list.html.erb<br />
* app/controllers/suggestion_controller.rb<br />
* db/schema.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
* db/migrate/20181027001119_add_feedback_to_suggestion.rb<br />
<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
===== Topics table after changes =====<br />
<br />
[[File:topic_4.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
On the file '''app/views/suggestion/list.html.erb''',added an additional editable textbox and a submit button. On click of the button the feedback provided in the text box is saved to the database in a table name suggestions, column name feedback.<br />
<br />
<pre style="color: black; border:1px;"><br />
<table class="general" cellpadding=5 width=100% border=1><br />
<tr><br />
<th>Title</th><br />
<th>Status</th><br />
<th>Submitter's user name</th><br />
<th>Action</th><br />
<th>Feedback</th><br />
<th>Save</th><br />
</tr><br />
<br />
<% for suggestion in @suggestions %><br />
<tr class="listingRow"><br />
<%= form_for :suggestion, :url => update_feedback_suggestion_index_path(:suggestion_id => suggestion.id, :id => params[:id], :type => params[:type]) do |f| %><br />
<td style="max-width: 200px"><%=h suggestion.title %></td><br />
<td align="center"><%=h suggestion.status %></td><br />
<td align="center"><%=h suggestion.unityID %></td><br />
<td align="center"><%= link_to 'View', :action => 'show', :id => suggestion %></td><br />
<td align="center"><%= f.text_field :feedback %></td><br />
<td align="center"><%= f.submit 'Save Feedback' %></td><br />
<% end %><br />
</tr><br />
<% end %><br />
</table><br />
</pre><br />
<br />
On the file '''app/controllers/suggestion_controller.rb''' ,added an additional method to save the changes in the feedback text box to database.<br />
<br />
<pre style="color: black; border:1px;"><br />
def update_feedback<br />
Suggestion.find(params[:suggestion_id]).update_attributes(feedback: params[:suggestion][:feedback])<br />
redirect_to list_suggestion_index_path(:id => params[:id], :type => params[:type])<br />
end<br />
</pre><br />
<br />
On the file '''db/migrate/20181027001119_add_feedback_to_suggestion.rb''' ,added migration scripts. Script is adding a column name "feedback" in the suggestions table.<br />
<br />
<pre style="color: black; border:1px;"><br />
class AddFeedbackToSuggestion < ActiveRecord::Migration<br />
def change<br />
add_column :suggestions, :feedback, :string<br />
end<br />
end<br />
</pre><br />
<br />
On the file '''expertiza/db/schema.rb''' ,schema changes as effect of adding column in table suggestions.<br />
<br />
<pre style="color: black; border:1px;"><br />
create_table "suggestions", force: :cascade do |t|<br />
t.integer "assignment_id", limit: 4<br />
t.string "title", limit: 255<br />
t.text "description", limit: 65535<br />
t.string "status", limit: 255<br />
t.string "unityID", limit: 255<br />
t.string "signup_preference", limit: 255<br />
t.string "feedback", limit: 255<br />
end<br />
</pre><br />
<br />
===== Suggestions list page before changes =====<br />
<br />
[[File:BeforeFeedbackPage.png]]<br />
<br />
===== Suggestions list page after changes =====<br />
<br />
[[File:AfterFeedbackPage.png]]<br />
<br />
== Testing Plan ==<br />
=== UI Testing ===<br />
<br />
===== Issue #971: Change create topic UI into AJAX =====<br />
# Login as an instructor.<br />
# Click Assignments tab next to Courses<br />
# Select the assignment for which a new topic has to be added<br />
# Click the edit icon for the assignment and go to Topics tab<br />
# You will be able to see the topics list in a table format. Click on add icon on the right side corner of the table header<br />
# Fill in the details and click save topic<br />
<br />
If a user tries to set number of slots as zero, a warning pops up and prohibits the user from doing so.<br />
===== Warning message when max_choosers is set to zero =====<br />
<br />
[[File:topic_5.png]]</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=119029E1827 Topic management2018-11-09T05:59:24Z<p>Aarnav: /* UI Testing */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link: https://www.youtube.com/watch?v=_0UU0r4IOf4&feature=youtu.be<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
* app/views/suggestion/list.html.erb<br />
* app/controllers/suggestion_controller.rb<br />
* db/schema.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
* db/migrate/20181027001119_add_feedback_to_suggestion.rb<br />
<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
===== Topics table after changes =====<br />
<br />
[[File:topic_4.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
On the file '''app/views/suggestion/list.html.erb''',added an additional editable textbox and a submit button. On click of the button the feedback provided in the text box is saved to the database in a table name suggestions, column name feedback.<br />
<br />
<pre style="color: black; border:1px;"><br />
<table class="general" cellpadding=5 width=100% border=1><br />
<tr><br />
<th>Title</th><br />
<th>Status</th><br />
<th>Submitter's user name</th><br />
<th>Action</th><br />
<th>Feedback</th><br />
<th>Save</th><br />
</tr><br />
<br />
<% for suggestion in @suggestions %><br />
<tr class="listingRow"><br />
<%= form_for :suggestion, :url => update_feedback_suggestion_index_path(:suggestion_id => suggestion.id, :id => params[:id], :type => params[:type]) do |f| %><br />
<td style="max-width: 200px"><%=h suggestion.title %></td><br />
<td align="center"><%=h suggestion.status %></td><br />
<td align="center"><%=h suggestion.unityID %></td><br />
<td align="center"><%= link_to 'View', :action => 'show', :id => suggestion %></td><br />
<td align="center"><%= f.text_field :feedback %></td><br />
<td align="center"><%= f.submit 'Save Feedback' %></td><br />
<% end %><br />
</tr><br />
<% end %><br />
</table><br />
</pre><br />
<br />
On the file '''app/controllers/suggestion_controller.rb''' ,added an additional method to save the changes in the feedback text box to database.<br />
<br />
<pre style="color: black; border:1px;"><br />
def update_feedback<br />
Suggestion.find(params[:suggestion_id]).update_attributes(feedback: params[:suggestion][:feedback])<br />
redirect_to list_suggestion_index_path(:id => params[:id], :type => params[:type])<br />
end<br />
</pre><br />
<br />
On the file '''db/migrate/20181027001119_add_feedback_to_suggestion.rb''' ,added migration scripts. Script is adding a column name "feedback" in the suggestions table.<br />
<br />
<pre style="color: black; border:1px;"><br />
class AddFeedbackToSuggestion < ActiveRecord::Migration<br />
def change<br />
add_column :suggestions, :feedback, :string<br />
end<br />
end<br />
</pre><br />
<br />
On the file '''expertiza/db/schema.rb''' ,schema changes as effect of adding column in table suggestions.<br />
<br />
<pre style="color: black; border:1px;"><br />
create_table "suggestions", force: :cascade do |t|<br />
t.integer "assignment_id", limit: 4<br />
t.string "title", limit: 255<br />
t.text "description", limit: 65535<br />
t.string "status", limit: 255<br />
t.string "unityID", limit: 255<br />
t.string "signup_preference", limit: 255<br />
t.string "feedback", limit: 255<br />
end<br />
</pre><br />
<br />
===== Suggestions list page before changes =====<br />
<br />
[[File:BeforeFeedbackPage.png]]<br />
<br />
===== Suggestions list page after changes =====<br />
<br />
[[File:AfterFeedbackPage.png]]<br />
<br />
== Testing Plan ==<br />
=== UI Testing ===<br />
<br />
Issue #971: Change create topic UI into AJAX<br />
# Login as an instructor.<br />
# Click Assignments tab next to Courses<br />
# Select the assignment for which a new topic has to be added<br />
# Click the edit icon for the assignment and go to Topics tab<br />
# You will be able to see the topics list in a table format. Click on add icon on the right side corner of the table header<br />
# Fill in the details and click save topic<br />
<br />
If a user tries to set number of slots as zero, a warning pops up and prohibits the user from doing so.<br />
===== Warning message when max_choosers is set to zero =====<br />
<br />
[[File:topic_5.png]]</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=119028E1827 Topic management2018-11-09T05:58:53Z<p>Aarnav: /* Warning message when max_choosers is set to zero */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link: https://www.youtube.com/watch?v=_0UU0r4IOf4&feature=youtu.be<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
* app/views/suggestion/list.html.erb<br />
* app/controllers/suggestion_controller.rb<br />
* db/schema.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
* db/migrate/20181027001119_add_feedback_to_suggestion.rb<br />
<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
===== Topics table after changes =====<br />
<br />
[[File:topic_4.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
On the file '''app/views/suggestion/list.html.erb''',added an additional editable textbox and a submit button. On click of the button the feedback provided in the text box is saved to the database in a table name suggestions, column name feedback.<br />
<br />
<pre style="color: black; border:1px;"><br />
<table class="general" cellpadding=5 width=100% border=1><br />
<tr><br />
<th>Title</th><br />
<th>Status</th><br />
<th>Submitter's user name</th><br />
<th>Action</th><br />
<th>Feedback</th><br />
<th>Save</th><br />
</tr><br />
<br />
<% for suggestion in @suggestions %><br />
<tr class="listingRow"><br />
<%= form_for :suggestion, :url => update_feedback_suggestion_index_path(:suggestion_id => suggestion.id, :id => params[:id], :type => params[:type]) do |f| %><br />
<td style="max-width: 200px"><%=h suggestion.title %></td><br />
<td align="center"><%=h suggestion.status %></td><br />
<td align="center"><%=h suggestion.unityID %></td><br />
<td align="center"><%= link_to 'View', :action => 'show', :id => suggestion %></td><br />
<td align="center"><%= f.text_field :feedback %></td><br />
<td align="center"><%= f.submit 'Save Feedback' %></td><br />
<% end %><br />
</tr><br />
<% end %><br />
</table><br />
</pre><br />
<br />
On the file '''app/controllers/suggestion_controller.rb''' ,added an additional method to save the changes in the feedback text box to database.<br />
<br />
<pre style="color: black; border:1px;"><br />
def update_feedback<br />
Suggestion.find(params[:suggestion_id]).update_attributes(feedback: params[:suggestion][:feedback])<br />
redirect_to list_suggestion_index_path(:id => params[:id], :type => params[:type])<br />
end<br />
</pre><br />
<br />
On the file '''db/migrate/20181027001119_add_feedback_to_suggestion.rb''' ,added migration scripts. Script is adding a column name "feedback" in the suggestions table.<br />
<br />
<pre style="color: black; border:1px;"><br />
class AddFeedbackToSuggestion < ActiveRecord::Migration<br />
def change<br />
add_column :suggestions, :feedback, :string<br />
end<br />
end<br />
</pre><br />
<br />
On the file '''expertiza/db/schema.rb''' ,schema changes as effect of adding column in table suggestions.<br />
<br />
<pre style="color: black; border:1px;"><br />
create_table "suggestions", force: :cascade do |t|<br />
t.integer "assignment_id", limit: 4<br />
t.string "title", limit: 255<br />
t.text "description", limit: 65535<br />
t.string "status", limit: 255<br />
t.string "unityID", limit: 255<br />
t.string "signup_preference", limit: 255<br />
t.string "feedback", limit: 255<br />
end<br />
</pre><br />
<br />
===== Suggestions list page before changes =====<br />
<br />
[[File:BeforeFeedbackPage.png]]<br />
<br />
===== Suggestions list page after changes =====<br />
<br />
[[File:AfterFeedbackPage.png]]<br />
<br />
== Testing Plan ==<br />
=== UI Testing ===<br />
<br />
Issue #971: Change create topic UI into AJAX<br />
# Login as an instructor.<br />
# Click Assignments tab next to Courses<br />
# Select the assignment for which a new topic has to be added<br />
# Click the edit icon for the assignment and go to Topics tab<br />
# You will be able to see the topics list in a table format. Click on add icon on the right side corner of the table header<br />
# Fill in the details and click save topic<br />
<br />
If a user tries to set number of slots as zero, a warning pops up and prohibits the user from doing so.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=119027E1827 Topic management2018-11-09T05:58:33Z<p>Aarnav: /* UI Testing */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link: https://www.youtube.com/watch?v=_0UU0r4IOf4&feature=youtu.be<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
* app/views/suggestion/list.html.erb<br />
* app/controllers/suggestion_controller.rb<br />
* db/schema.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
* db/migrate/20181027001119_add_feedback_to_suggestion.rb<br />
<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
===== Topics table after changes =====<br />
<br />
[[File:topic_4.png]]<br />
<br />
===== Warning message when max_choosers is set to zero =====<br />
<br />
[[File:topic_5.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
On the file '''app/views/suggestion/list.html.erb''',added an additional editable textbox and a submit button. On click of the button the feedback provided in the text box is saved to the database in a table name suggestions, column name feedback.<br />
<br />
<pre style="color: black; border:1px;"><br />
<table class="general" cellpadding=5 width=100% border=1><br />
<tr><br />
<th>Title</th><br />
<th>Status</th><br />
<th>Submitter's user name</th><br />
<th>Action</th><br />
<th>Feedback</th><br />
<th>Save</th><br />
</tr><br />
<br />
<% for suggestion in @suggestions %><br />
<tr class="listingRow"><br />
<%= form_for :suggestion, :url => update_feedback_suggestion_index_path(:suggestion_id => suggestion.id, :id => params[:id], :type => params[:type]) do |f| %><br />
<td style="max-width: 200px"><%=h suggestion.title %></td><br />
<td align="center"><%=h suggestion.status %></td><br />
<td align="center"><%=h suggestion.unityID %></td><br />
<td align="center"><%= link_to 'View', :action => 'show', :id => suggestion %></td><br />
<td align="center"><%= f.text_field :feedback %></td><br />
<td align="center"><%= f.submit 'Save Feedback' %></td><br />
<% end %><br />
</tr><br />
<% end %><br />
</table><br />
</pre><br />
<br />
On the file '''app/controllers/suggestion_controller.rb''' ,added an additional method to save the changes in the feedback text box to database.<br />
<br />
<pre style="color: black; border:1px;"><br />
def update_feedback<br />
Suggestion.find(params[:suggestion_id]).update_attributes(feedback: params[:suggestion][:feedback])<br />
redirect_to list_suggestion_index_path(:id => params[:id], :type => params[:type])<br />
end<br />
</pre><br />
<br />
On the file '''db/migrate/20181027001119_add_feedback_to_suggestion.rb''' ,added migration scripts. Script is adding a column name "feedback" in the suggestions table.<br />
<br />
<pre style="color: black; border:1px;"><br />
class AddFeedbackToSuggestion < ActiveRecord::Migration<br />
def change<br />
add_column :suggestions, :feedback, :string<br />
end<br />
end<br />
</pre><br />
<br />
On the file '''expertiza/db/schema.rb''' ,schema changes as effect of adding column in table suggestions.<br />
<br />
<pre style="color: black; border:1px;"><br />
create_table "suggestions", force: :cascade do |t|<br />
t.integer "assignment_id", limit: 4<br />
t.string "title", limit: 255<br />
t.text "description", limit: 65535<br />
t.string "status", limit: 255<br />
t.string "unityID", limit: 255<br />
t.string "signup_preference", limit: 255<br />
t.string "feedback", limit: 255<br />
end<br />
</pre><br />
<br />
===== Suggestions list page before changes =====<br />
<br />
[[File:BeforeFeedbackPage.png]]<br />
<br />
===== Suggestions list page after changes =====<br />
<br />
[[File:AfterFeedbackPage.png]]<br />
<br />
== Testing Plan ==<br />
=== UI Testing ===<br />
<br />
Issue #971: Change create topic UI into AJAX<br />
# Login as an instructor.<br />
# Click Assignments tab next to Courses<br />
# Select the assignment for which a new topic has to be added<br />
# Click the edit icon for the assignment and go to Topics tab<br />
# You will be able to see the topics list in a table format. Click on add icon on the right side corner of the table header<br />
# Fill in the details and click save topic<br />
<br />
If a user tries to set number of slots as zero, a warning pops up and prohibits the user from doing so.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=119026E1827 Topic management2018-11-09T05:54:22Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link: https://www.youtube.com/watch?v=_0UU0r4IOf4&feature=youtu.be<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
* app/views/suggestion/list.html.erb<br />
* app/controllers/suggestion_controller.rb<br />
* db/schema.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
* db/migrate/20181027001119_add_feedback_to_suggestion.rb<br />
<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
===== Topics table after changes =====<br />
<br />
[[File:topic_4.png]]<br />
<br />
===== Warning message when max_choosers is set to zero =====<br />
<br />
[[File:topic_5.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
On the file '''app/views/suggestion/list.html.erb''',added an additional editable textbox and a submit button. On click of the button the feedback provided in the text box is saved to the database in a table name suggestions, column name feedback.<br />
<br />
<pre style="color: black; border:1px;"><br />
<table class="general" cellpadding=5 width=100% border=1><br />
<tr><br />
<th>Title</th><br />
<th>Status</th><br />
<th>Submitter's user name</th><br />
<th>Action</th><br />
<th>Feedback</th><br />
<th>Save</th><br />
</tr><br />
<br />
<% for suggestion in @suggestions %><br />
<tr class="listingRow"><br />
<%= form_for :suggestion, :url => update_feedback_suggestion_index_path(:suggestion_id => suggestion.id, :id => params[:id], :type => params[:type]) do |f| %><br />
<td style="max-width: 200px"><%=h suggestion.title %></td><br />
<td align="center"><%=h suggestion.status %></td><br />
<td align="center"><%=h suggestion.unityID %></td><br />
<td align="center"><%= link_to 'View', :action => 'show', :id => suggestion %></td><br />
<td align="center"><%= f.text_field :feedback %></td><br />
<td align="center"><%= f.submit 'Save Feedback' %></td><br />
<% end %><br />
</tr><br />
<% end %><br />
</table><br />
</pre><br />
<br />
On the file '''app/controllers/suggestion_controller.rb''' ,added an additional method to save the changes in the feedback text box to database.<br />
<br />
<pre style="color: black; border:1px;"><br />
def update_feedback<br />
Suggestion.find(params[:suggestion_id]).update_attributes(feedback: params[:suggestion][:feedback])<br />
redirect_to list_suggestion_index_path(:id => params[:id], :type => params[:type])<br />
end<br />
</pre><br />
<br />
On the file '''db/migrate/20181027001119_add_feedback_to_suggestion.rb''' ,added migration scripts. Script is adding a column name "feedback" in the suggestions table.<br />
<br />
<pre style="color: black; border:1px;"><br />
class AddFeedbackToSuggestion < ActiveRecord::Migration<br />
def change<br />
add_column :suggestions, :feedback, :string<br />
end<br />
end<br />
</pre><br />
<br />
On the file '''expertiza/db/schema.rb''' ,schema changes as effect of adding column in table suggestions.<br />
<br />
<pre style="color: black; border:1px;"><br />
create_table "suggestions", force: :cascade do |t|<br />
t.integer "assignment_id", limit: 4<br />
t.string "title", limit: 255<br />
t.text "description", limit: 65535<br />
t.string "status", limit: 255<br />
t.string "unityID", limit: 255<br />
t.string "signup_preference", limit: 255<br />
t.string "feedback", limit: 255<br />
end<br />
</pre><br />
<br />
===== Suggestions list page before changes =====<br />
<br />
[[File:BeforeFeedbackPage.png]]<br />
<br />
===== Suggestions list page after changes =====<br />
<br />
[[File:AfterFeedbackPage.png]]<br />
<br />
== Testing Plan ==<br />
=== UI Testing ===<br />
<br />
* Issue #971: Change create topic UI into AJAX<br />
Login as an instructor. It will automatically go to the manage courses page<br />
Click Assignments tab next to Courses<br />
Select the assignment for which a new topic has to be added<br />
Click the edit icon for the assignment and go to Topics tab<br />
You will be able to see the topics list in a grid format. Click on add icon on the right side corner of the grid<br />
You can also edit an existing entry by just clicking on that row in the grid without being redirected to a new page</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=119025E1827 Topic management2018-11-09T05:51:08Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link: https://www.youtube.com/watch?v=_0UU0r4IOf4&feature=youtu.be<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
* app/views/suggestion/list.html.erb<br />
* app/controllers/suggestion_controller.rb<br />
* db/schema.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
* db/migrate/20181027001119_add_feedback_to_suggestion.rb<br />
<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
===== Topics table after changes =====<br />
<br />
[[File:topic_4.png]]<br />
<br />
===== Warning message when max_choosers is set to zero =====<br />
<br />
[[File:topic_5.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
On the file '''app/views/suggestion/list.html.erb''',added an additional editable textbox and a submit button. On click of the button the feedback provided in the text box is saved to the database in a table name suggestions, column name feedback.<br />
<br />
<pre style="color: black; border:1px;"><br />
<table class="general" cellpadding=5 width=100% border=1><br />
<tr><br />
<th>Title</th><br />
<th>Status</th><br />
<th>Submitter's user name</th><br />
<th>Action</th><br />
<th>Feedback</th><br />
<th>Save</th><br />
</tr><br />
<br />
<% for suggestion in @suggestions %><br />
<tr class="listingRow"><br />
<%= form_for :suggestion, :url => update_feedback_suggestion_index_path(:suggestion_id => suggestion.id, :id => params[:id], :type => params[:type]) do |f| %><br />
<td style="max-width: 200px"><%=h suggestion.title %></td><br />
<td align="center"><%=h suggestion.status %></td><br />
<td align="center"><%=h suggestion.unityID %></td><br />
<td align="center"><%= link_to 'View', :action => 'show', :id => suggestion %></td><br />
<td align="center"><%= f.text_field :feedback %></td><br />
<td align="center"><%= f.submit 'Save Feedback' %></td><br />
<% end %><br />
</tr><br />
<% end %><br />
</table><br />
</pre><br />
<br />
On the file '''app/controllers/suggestion_controller.rb''' ,added an additional method to save the changes in the feedback text box to database.<br />
<br />
<pre style="color: black; border:1px;"><br />
def update_feedback<br />
Suggestion.find(params[:suggestion_id]).update_attributes(feedback: params[:suggestion][:feedback])<br />
redirect_to list_suggestion_index_path(:id => params[:id], :type => params[:type])<br />
end<br />
</pre><br />
<br />
On the file '''db/migrate/20181027001119_add_feedback_to_suggestion.rb''' ,added migration scripts. Script is adding a column name "feedback" in the suggestions table.<br />
<br />
<pre style="color: black; border:1px;"><br />
class AddFeedbackToSuggestion < ActiveRecord::Migration<br />
def change<br />
add_column :suggestions, :feedback, :string<br />
end<br />
end<br />
</pre><br />
<br />
On the file '''expertiza/db/schema.rb''' ,schema changes as effect of adding column in table suggestions.<br />
<br />
<pre style="color: black; border:1px;"><br />
create_table "suggestions", force: :cascade do |t|<br />
t.integer "assignment_id", limit: 4<br />
t.string "title", limit: 255<br />
t.text "description", limit: 65535<br />
t.string "status", limit: 255<br />
t.string "unityID", limit: 255<br />
t.string "signup_preference", limit: 255<br />
t.string "feedback", limit: 255<br />
end<br />
</pre><br />
<br />
===== Suggestions list page before changes =====<br />
<br />
[[File:BeforeFeedbackPage.png]]<br />
<br />
===== Suggestions list page after changes =====<br />
<br />
[[File:AfterFeedbackPage.png]]<br />
<br />
== Testing Plan ==<br />
The following credentials are recommended for testing the changes:</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118112E1827 Topic management2018-11-02T20:17:00Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
===== Topics table after changes =====<br />
<br />
[[File:topic_4.png]]<br />
<br />
===== Warning message when max_choosers is set to zero =====<br />
<br />
[[File:topic_5.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=File:Topic_5.png&diff=118111File:Topic 5.png2018-11-02T20:15:59Z<p>Aarnav: </p>
<hr />
<div></div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118110E1827 Topic management2018-11-02T20:14:14Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
===== Topics table after changes =====<br />
<br />
[[File:topic_4.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=File:Topic_4.png&diff=118109File:Topic 4.png2018-11-02T20:13:25Z<p>Aarnav: </p>
<hr />
<div></div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118108E1827 Topic management2018-11-02T20:10:55Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
===== Topics table before changes =====<br />
<br />
[[File:topic_3.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118107E1827 Topic management2018-11-02T20:09:03Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:topic_3.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=File:Topic_3.png&diff=118106File:Topic 3.png2018-11-02T20:08:47Z<p>Aarnav: </p>
<hr />
<div></div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118104E1827 Topic management2018-11-02T20:08:03Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:topic_2.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=File:Topic_2.png&diff=118103File:Topic 2.png2018-11-02T20:07:46Z<p>Aarnav: </p>
<hr />
<div></div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118102E1827 Topic management2018-11-02T20:06:21Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:topic_1.png]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-<br />
<pre><br />
<script><br />
$(function () {<br />
/*Function for sorting the table */<br />
$(".sortable").tablesorter({<br />
sortList: [[0,0]] //sort First Column by default when page loads<br />
});<br />
});<br />
</script><br />
</pre><br />
<br />
And made this change to the current table in html:-<br />
<pre><br />
<table class="table table-striped sortable"><br />
<thead><br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr> <br />
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr><br />
</thead><br />
</pre><br />
<br />
Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-<br />
<pre><br />
<th class="sorter-true" width="5%">Topic #</th><br />
</pre><br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=File:Topic_1.png&diff=118101File:Topic 1.png2018-11-02T20:05:28Z<p>Aarnav: </p>
<hr />
<div></div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118095E1827 Topic management2018-11-02T19:53:31Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
<div style="display:inline;width: 220px;><br />
[[Image:Topic1.PNG|800px|Image: 800 pixels]]<br />
</div><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118094E1827 Topic management2018-11-02T19:53:09Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
<div style="display:inline;width: 220px;><br />
[[Image:Topic1.PNG|400px|Image: 400 pixels]]<br />
</div><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118093E1827 Topic management2018-11-02T19:52:20Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
<div style="display:inline;width: 220px;><br />
[[Image:Topic1.PNG|200px|Image: 200 pixels]]<br />
</div><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118092E1827 Topic management2018-11-02T19:52:00Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
<div style="display:inline;width: 220px;><br />
[[File:Topic1.PNG|200px|Image: 200 pixels]]<br />
</div><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118091E1827 Topic management2018-11-02T19:50:26Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
<div style="display:inline;width: 220px;><br />
[[File:Topic1.PNG]]<br />
</div><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118090E1827 Topic management2018-11-02T19:49:49Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
<div style="width: 220px;><br />
[[File:Topic1.PNG]]<br />
</div><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118089E1827 Topic management2018-11-02T19:49:27Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
<div style="display: inline; width: 220px; float: right;"><br />
[[File:Topic1.PNG]]<br />
</div><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118088E1827 Topic management2018-11-02T19:48:40Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:Topic1.PNG]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118087E1827 Topic management2018-11-02T19:47:30Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:Topic1.PNG|250 px|]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118086E1827 Topic management2018-11-02T19:47:07Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:Topic1.PNG|50 px|]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118085E1827 Topic management2018-11-02T19:45:55Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:Topic1.PNG]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118084E1827 Topic management2018-11-02T19:45:19Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:Topic1.jpg]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
'''Sorting in ascending order''':-<br />
[[File:Edit_ascending.png]]<br />
<br />
<br />
'''Sorting in descending order''':-<br />
[[File:Edit_descending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=File:Topic1.PNG&diff=118081File:Topic1.PNG2018-11-02T19:44:32Z<p>Aarnav: </p>
<hr />
<div></div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118075E1827 Topic management2018-11-02T19:39:01Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[File:Capture.jpg]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
Sorting in ascending order<br />
[[File:Edit_ascending.png]]<br />
Sorting in decending order:-<br />
[[File:Edit_descending]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118072E1827 Topic management2018-11-02T19:36:28Z<p>Aarnav: /* Issue #971 Change create topic UI into AJAX */</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
[[Capture.PNG]]<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
Sorting in ascending order<br />
[[File:Edit_ascending.png]]<br />
Sorting in decending order:-<br />
[[File:Edit_decending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=File:Capture.PNG&diff=118071File:Capture.PNG2018-11-02T19:35:27Z<p>Aarnav: uploaded a new version of &quot;File:Capture.PNG&quot;</p>
<hr />
<div></div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118068E1827 Topic management2018-11-02T19:27:43Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118063E1827 Topic management2018-11-02T19:21:03Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.<br />
<pre style="color: black; border:1px;"><br />
<% @sign_up_topic = SignUpTopic.new %><br />
<% @topic = @sign_up_topic %><br />
<% @topic.max_choosers=1 %><br />
</pre><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
The task is to sort the Topics according to the topic number. This functionality is taken care by Js-Grid by itself, where clicking the topic# will toggle the topics in the ascending/descending order.<br />
[[File:ascending.png]]<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118060E1827 Topic management2018-11-02T19:17:31Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.<br />
<pre style="color: black; border:1px;"><br />
<th width="3%" align="center"><a id="myLink" title="Add"<br />
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th><br />
</pre><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118057E1827 Topic management2018-11-02T19:13:03Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118056E1827 Topic management2018-11-02T19:12:03Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
----<br />
<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118055E1827 Topic management2018-11-02T19:11:24Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
----<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
----<br />
<br />
== Files Added ==<br />
----<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.<br />
It submits a ajax request when the 'save topic button is clicked'<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118054E1827 Topic management2018-11-02T19:06:26Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
----<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
----<br />
<br />
== Files Added ==<br />
----<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
<pre style="color: black; border:1px;"><br />
<div><br />
<table class="table table-striped"><br />
<br />
<tr id="add_topic" style="display:none;"><br />
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %><br />
<td><%= f.text_field :topic_identifier %></td><br />
<td><%= f.text_field :topic_name %></td><br />
<td><%= f.number_field :max_choosers, min: 0 %></td><br />
<td></td><br />
<td></td><br />
<td></td><br />
<td><%= f.submit %></td><br />
<% end %><br />
</tr><br />
<br />
</table><br />
</div><br />
<script><br />
function showZeroSlotWarning(){<br />
if ($('#topic_max_choosers').val() == 0){<br />
alert("If you create a topic with 0 slots, students cannot assign this topic.");<br />
return false;<br />
}<br />
};<br />
function addCreateTopicSection(){<br />
$("#topic_table_header").after($("#add_topic"));<br />
$("#add_topic").toggle();<br />
};<br />
</script><br />
<br />
</pre><br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118053E1827 Topic management2018-11-02T18:51:17Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
----<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
* app/controllers/assignments_controller.rb<br />
----<br />
<br />
== Files Added ==<br />
----<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118052E1827 Topic management2018-11-02T18:43:56Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
----<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
* app/views/assignments/edit.html.erb<br />
----<br />
<br />
== Files Added ==<br />
----<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118051E1827 Topic management2018-11-02T18:42:31Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
----<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
* app/views/sign_up_sheet/_table_line.html.erb<br />
* app/controllers/sign_up_sheet_controller.rb<br />
----<br />
<br />
== Files Added ==<br />
----<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118050E1827 Topic management2018-11-02T18:40:27Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
<br />
== Files modified ==<br />
----<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
*app/views/sign_up_sheet/_table_line.html.erb<br />
*app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
*app/views/sign_up_sheet/_table_header.html.erb<br />
----<br />
<br />
== Files Added ==<br />
----<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118048E1827 Topic management2018-11-02T18:39:25Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
----<br />
== Files modified ==<br />
The following files were modified<br />
* app/views/sign_up_sheet/_add_signup_topics.html.erb<br />
* app/views/sign_up_sheet/_table_header.html.erb<br />
*app/views/sign_up_sheet/_table_line.html.erb<br />
----<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118043E1827 Topic management2018-11-02T18:26:53Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.<br />
----<br />
== Files modified ==<br />
The following files were modified<br />
*<br />
*<br />
*<br />
----<br />
== Files Added ==<br />
The following files were added<br />
*<br />
*<br />
*<br />
----<br />
== Solutions Implemented ==<br />
=== Issue #971 Change create topic UI into AJAX ===<br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
<br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===<br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
=== We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===<br />
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118041E1827 Topic management2018-11-02T18:15:27Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX.<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118040E1827 Topic management2018-11-02T18:13:46Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
The following credentials are recommended for testing the changes:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:<br />
----<br />
== Introduction ==<br />
=== Background ===<br />
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.<br />
<br />
=== Problem Statement ===<br />
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.<br />
<br />
===== What needs to be done?: =====<br />
<br />
* Issue #971 Change create topic UI into AJAX <br />
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form. <br />
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).<br />
<br />
* Issue #926 We need a way to sort topics by topic number in assignment#edit page. <br />
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.<br />
<br />
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.<br />
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118039E1827 Topic management2018-11-02T18:07:33Z<p>Aarnav: </p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.<br />
----<br />
== Peer Review Information ==<br />
For testing the changes made, the following credentials are recommended:<br />
<br />
* Instructor Login: username: instructor6 password: password<br />
* Youtube link:</div>Aarnavhttps://wiki.expertiza.ncsu.edu/index.php?title=E1827_Topic_management&diff=118036E1827 Topic management2018-11-02T18:02:30Z<p>Aarnav: Created page with "This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018."</p>
<hr />
<div>This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.</div>Aarnav