E1936 Specialized Rubrics: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
Line 73: Line 73:
*** This suggestion would allow the rubric to vary by topic but NOT by round of assignment
*** This suggestion would allow the rubric to vary by topic but NOT by round of assignment
*** As the current implementation supports rubric varying by round of assignment, we should keep this support
*** As the current implementation supports rubric varying by round of assignment, we should keep this support
** The previous submission for this feature added a new table "topic_questionnaires"
*** This is not necessary as we already have a table which associates questionnaires with assignments and rounds
*** We are better off associating questionnaires with topics in this existing table to limit code changes and enhance code readability


===How to Add a New Rubric===
===How to Add a New Rubric===

Revision as of 17:36, 2 April 2019

E1936. Specialized Rubrics for Different Topic Types

This page provides a description of an Expertiza OSS project.

Problem Statement

In CSC/ECE 517, there are several types of topics that could be covered in a single class assignment.

  • Code base
    • Expertiza
    • Mozilla
    • etc.
  • Goal
    • Refactoring
    • Testing
    • etc.

However, currently we can only specify one kind of rubric for an assignment. This means that teams working on different topics will be evaluated using the same rubric. With this setup, it's not possible to fine-tune rubrics for different topics - rubrics tend to be overly general.

What Needs to be Done

  • In assignment#edit page "Rubrics" tab, add a checkbox to specify whether rubric should vary by topic.
  • In assignment#edit page "Topics" tab, add a dropdown next to each topic to specify which rubric is associated with the topic.
    • This dropdown should appear only if rubric should vary by topic, per the Rubrics tab.
    • By default, the rubric for each course project will be the one specified in “Rubrics” tab.
    • The dropdown value can overwrite the default rubric.
  • Be careful when making changes to the code
    • The signup_sheet_controller should have as little to do as possible with the selection of rubrics.
    • Anything not germane to selecting topics should be in another controller or (more probably) a helper.
  • Create a DB migration to allow rubric to vary by topic as well as by round.

Our Plan

  • app/views/assignments/edit/_rubrics.html.erb
    • Add a new checkbox for whether or not rubrics vary by topic
  • app/views/assignments/edit.html.erb
    • Break out code dealing with topics into app/views/assignments/edit/_topics.html.erb
  • app/views/assignments/edit/_topics.html.erb
    • Add a new column in the topics table for choosing rubric(s)
      • New column only visible if rubrics vary by topic, per Rubrics tab
      • New column has multiple rounds per topic only if rubrics vary by round, per Rubrics tab
    • Default value for any rubric is that rubric which is shown on Rubrics tab
    • Use the code in app/views/assignments/edit/_rubrics.html.erb for inspiration only
      • Break as much actual work as possible out into helper methods that are simply called from this view
      • Views are not intended to do heavy lifting
      • Use as little JavaScript as possible
      • This is a Ruby On Rails project, not a JS project
  • app/helpers/assignment_helper.rb
    • Improve readability of assignment_questionnaire method
      • Add comment block at the top describing the purpose and basic strategy of the method
      • Rename 'number' parameter to clarify the purpose of the parameter
    • Expand functionality of assignment_questionnaire method
      • Add ability to get assignment questionnaires by topic as well as by round
      • Like round, topic parameter should be optional
  • spec/helpers
    • Add spec/helpers/assignment_helper_spec.rb file
      • Thoroughly test app/helpers/assignment_helper.rb assignment_questionnaire method
    • Add tests for any newly created helpers or helper methods
  • db/migrate
    • Create a new migration to link topics to rubrics
      • This migration will add a column to the table "assignment_questionnaires"
      • This table keeps track of which questionnaires are used for which assignments
        • questionnaire_id links to a questionnaire
        • assignment_id links to an assignment
        • used_in_round links to a particular round of an assignment
        • the migration will add "topic_id" to link also to a particular topic within an assignment
    • The original suggestion was to "add questionnaire_id in sign_up_topics table"
      • This suggestion would allow the rubric to vary by topic but NOT by round of assignment
      • As the current implementation supports rubric varying by round of assignment, we should keep this support
    • The previous submission for this feature added a new table "topic_questionnaires"
      • This is not necessary as we already have a table which associates questionnaires with assignments and rounds
      • We are better off associating questionnaires with topics in this existing table to limit code changes and enhance code readability

How to Add a New Rubric

  • [to be populated after coding is complete]

How to Select a Rubric for a Topic

  • [to be populated after coding is complete]

Automated Testing with RSPEC

Our strategy for gaining confidence that our code changes did not break anything was as follows:

  • Run all existing RSpec tests on any changed files, after our changes, to ensure that we have not introduced any failures.
  • The commands and results are shown below.
  [to be populated after coding is complete]
  • Write new comprehensive RSpec tests, for all new methods.
  • Run these tests, to ensure that the new code works as intended.
  • The commands and results are shown below.
  [to be populated after coding is complete]
  • The test suite for a single new method is below.
  • There are many such suites in (TODO add filename(s)).
  • This example illustrates our general strategy:
    • test missing input
    • test bad input
    • test various acceptable forms of input
    • test scenarios that lead to "true" and to "false" return values
  [to be populated after coding is complete]

Team Members

  • Aurora Tiffany-Davis
  • Ginger Balmat
  • Joe Hutchinson
  • Nikolay Titov

Links (Our Work)

  1. Project Repository Fork
  2. [(add link here) Pull Request]
  3. [(add link here) Video Demonstration of Specialized Rubrics]

Links (Previous Attempt by another Team)

  1. Pull Request
  2. Wiki Page
  3. Video Demonstration of Specialized Rubrics

Links (General References)

  1. Expertiza on GitHub
  2. The live Expertiza website
  3. Expertiza project documentation wiki
  4. Rspec Documentation