E1867 allow reviewer to say review can be shown to class as an example: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
Line 29: Line 29:
== Current status of Development ==
== Current status of Development ==
In progress
In progress
== Sample Submissions View ==
1. The first screenshot of the application is taken when the deadline for the current assignment has not crossed and the instructor also has not given any sample assignment for this assignment.
[[Image:Assignments not made public.PNG]]
2. The second screenshot of the application is taken when the deadline for the current assignment has not crossed but the instructor has selected a sample assignment for viewing against this assignment.
[[Image:Assignment submission date not passed.PNG]]
3. The third screenshot of the application is taken when both the deadline for the current assignment has crossed and the instructor has selected a sample assignment for viewing.
[[Image:Assignments available.PNG]]


== Test Plan ==
== Test Plan ==

Revision as of 03:35, 14 November 2018

Introduction

Expertiza is a web based open source peer reviewing tool developed and maintained by current and past students of North Carolina State University. Peer review is a great way for a student to learn how to approach a project and get ideas for their own projects. Currently, there is no way for a student to view another student's work, unless they are reviewing the other student's work.

Problem Statement

The objective of this project is to:

  1. Add a feature for students to make their reviews 'public', that is, allow other students to view them.
  2. Add a feature for TA to select a subset of 'public' reviews, and make those reviews visible as sample reviews of the particular assignment.
  3. Add a feature for Instructor to select a subset of 'public' reviews and make those reviews visible as sample reviews of any of his/her assignments in the course.
  4. Create a view where the student can see a list of sample reviews of the assignment and have a detailed view of each.
  5. Allow the student to toggle the visibility of a review he/she has submitted.

Proposed Flow

During each review, there will be a checkbox that says "I agree to share this review anonymously as an example to the entire class", and students can decide to check this box or not just before they submit reviews. Behind the scenes, we need to set a "status" field to “public”of the Response object.

Project Tasks

The tasks that need to be completed as part of this project can be listed as follows:

  1. Add checkbox against each assignment in student_tasks/list view to allow student to publish their work
  2. Add column make_public to table teams for storing user permission (published or not) for each project.
  3. Add controller for Sample submissions and implement corresponding methods.
  4. Add views for sample submissions
  5. Make changes to page student_task/view which would have link to sample submissions for each project.
  6. Add drop down in assignments/edit/_general view.
  7. Add controller code for the drop down.
  8. Add column sample_assignment_id to table assignment.
  9. Add test scripts for all the functionality.

Current status of Development

In progress

Test Plan

Many of our changes are reflected on views (user interface). So we build tests with rspec/capybara. Following is the list of tests that conduct:

  1. it "is able to make an assignment public"
  2. it "is able to view sample submissions page"
  3. it "should not see current assignment submissions if deadline is not met"
  4. it "should see current assignment submissions if deadline is met"
  5. it "should not see instructor selected submissions if instructor has not selected them"
  6. it "should see instructor selected submissions if instructor has selected them"
def create_assignment_team(assignment_name, parent_id)
  assignment_team = AssignmentTeam.new
  assignment_team.name = assignment_name
  assignment_team.parent_id = parent_id
  assignment_team.save!
end

def init_test
  # create assignment and topic
  assignment = build(Assignment)
  course = Course.new
  course.name = "SampleSubmissionTestCourse"
  course.save
  assignment.course_id = course.id
  assignment.save

  create_assignemnt_team("ss_assignment_team_1", assignment.id)
  create_assignemnt_team("ss_assignment_team_2", assignment.id)
end

def visit_sample_submissions_page
  visit '/student_task/list'
  click_on "Example Assignment"
  click_on "Sample Submissions"
end

describe "sample submission test" do
  before(:each) { init_test }

  it "is able to make an assignment public" do
    visit '/student_task/list'
    find(:css, "#makeSubPublic[teamid='6050']").trigger("click")
    click_button 'OK'
    expect(page).to have_http_status(200)
  end

  it "should not see current assignment submissions if deadline is not met" do # Set deadline after current time.
    visit_sample_submissions_page
    expect(page).to have_content "No sample submissions from current assignment made public yet"
  end

  it "should see current assignment submissions if deadline is met" do # Set deadline before current time.
    visit_sample_submissions_page
    expect(page).to_not have_content "No sample submissions from current assignment made public yet"
  end

  it "should not see instructor selected submissions if instructor has not selected them" do
    visit_sample_submissions_page
    expect(page).to have_content "No sample submissions from previous assignment made available yet"
  end

  it "should see instructor selected submissions if instructor has selected them" do # Instructor makes submission available.
    visit_sample_submissions_page
    expect(page).to_not have_content "No sample submissions from previous assignment made available yet"
  end
end

Future Scope

  1. Publishing sample reviews made by students: This feature will require students to allow their review to be published as a sample review. This can then be made available to future students.

External Links

  1. link to forked repository [1]
  2. link to the git pull request [2]
  3. link to the deployed application [3]

References

  1. Link to expertiza website: [4]