CSC/ECE 517 Spring 2019/E1927 Let Course Staff as Well as Students Do Reviews: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
No edit summary
No edit summary
Line 3: Line 3:


='''Current Functionality'''=
='''Current Functionality'''=
In the current Expertiza, instructors and TAs are able to leave a review on a submission only if they are a participant of the assignment.  Also, there is not an easy way for instructors to leave a review at any time.  Instructors typically need to leave a review during the established review window.  Once a instructor leaves a review of a submission, the student does not know if the review was left by an instructor or by another student.
In the current Expertiza, instructors and TAs are able to leave a review for a submission only if they are a participant of the assignment.  Also, there is not an easy way for instructors to leave a review at any time.  Instructors typically need to leave a review during the established review window.  Once an instructor leaves a review of a submission, the student does not know if the review was left by an instructor or by another student.


='''Project Tasks'''=
='''Project Tasks'''=
Line 12: Line 12:
'''Problem:'''
'''Problem:'''


Each submission on the submissions page should link to "perform review" instead of "assign grade" if the due date has not passed.  If the due date has passed, the link should change to "assign_grade".  The goal is to reduce the number of links in the  
Each submission on the submissions page should link to "perform review" instead of "assign grade" if the due date has not passed.  If the due date has passed, the link should change to "assign_grade".  The goal is to reduce the number of links in the shown on the page on the instructor side.




'''Solution:'''
'''Solution:'''
list_submissions_html.erb should be modified to change the link as noted above. TBD if controller changes in assignment_controler are needed to get due date information and participant information to the view.
The list_submissions_html.erb should be modified to incorporate the changes as described. The following images illustrate the desired appearance for the View_Submissions page.
 
Current View:
 
 
 
 
 
 
Revised View (Before Assignment Due Date):
 
 
 
 
 


==Task 2:==
==Task 2:==
'''Problem:'''
'''Problem:'''


The instructor should have the ability to create a review for any submission at any time.  The instructor of the course should not be required to be a participant to leave a review.
The instructor should have the ability to create a review for any submission at any time.  The instructor of the course should not be required to be a participant to leave a review.  The link to leave a review should always be available on the View Scores page.


'''Solution:'''
'''Solution:'''


Check response.html.erb to make sure there aren't any restrictions preventing instructor/ta from submitting reviews if they meet the criteria above. Existing logic may assume all reviewers are student. TBD if any modifications to response_controller is necessary to enable this functionality.
The response.html.erb file needs to be checked to make sure there are no restrictions preventing instructor or TA from submitting reviews. Modifications will be needed to the files associated with the View Scores view. The images below show the current and desired apperence of this page.
 
Current View:
 
 
Updated View with Review Link for the Instructor:
 
 


==Task 3:==
==Task 3:==
'''Problem:'''
'''Problem:'''


An instructor icon should be used to indicate an instructor review and this icon should be seen on the review page read by the student.
An instructor icon should be used to indicate an instructor review and this icon should be seen on the review page read by the student.  The instrustor review, if completed, should appear as the first column in the reviews for the assignment on the student side.  When the student reads an instructor review, it should have the same icon present on the review so the student knows it was completed by an instructor.




'''Solution:'''
'''Solution:'''


Modify response.html.erb to distinguish reviews done by the instructor. TBD if the response controller needs modification to deliver this information to the view. Modify the add-ta-128.png icon file to look more like an instructor and add it to the view next to the reviews done by the instructor.
Modify response.html.erb to distinguish reviews done by the instructor. The existing add-ta-128.png icon file will be used for the instructor icon by removing the green plus ("+") symbol in the image.  The logic that is used to build the table of completed reviews will need to check if the review was completed by an instructor.  To distinguish an instructor review from a student review, a table will need to be created to track the review_id numbers that are associated with instructor reviews.  This option was chosen to avoid modifications to the existing Response database object schema.  See the Response page for Expertiza as listed in the references section for more details.
 





Revision as of 00:03, 13 April 2019

Problem Summary

In Expertiza, students are able to perform reviews on other students work by filling out a review form on Expertiza. Instructors and TAs for the course should be able to submit a review in the same manner as a student. Only instructors or TAs who are participants in the assignment should be allowed to leave reviews. However, the instructor and TA reviews should be distinguished from other student reviews so the student knows the review was written by the instructor.

Current Functionality

In the current Expertiza, instructors and TAs are able to leave a review for a submission only if they are a participant of the assignment. Also, there is not an easy way for instructors to leave a review at any time. Instructors typically need to leave a review during the established review window. Once an instructor leaves a review of a submission, the student does not know if the review was left by an instructor or by another student.

Project Tasks

Task 1:

Problem:

Each submission on the submissions page should link to "perform review" instead of "assign grade" if the due date has not passed. If the due date has passed, the link should change to "assign_grade". The goal is to reduce the number of links in the shown on the page on the instructor side.


Solution: The list_submissions_html.erb should be modified to incorporate the changes as described. The following images illustrate the desired appearance for the View_Submissions page.

Current View:




Revised View (Before Assignment Due Date):




Task 2:

Problem:

The instructor should have the ability to create a review for any submission at any time. The instructor of the course should not be required to be a participant to leave a review. The link to leave a review should always be available on the View Scores page.

Solution:

The response.html.erb file needs to be checked to make sure there are no restrictions preventing instructor or TA from submitting reviews. Modifications will be needed to the files associated with the View Scores view. The images below show the current and desired apperence of this page.

Current View:


Updated View with Review Link for the Instructor:


Task 3:

Problem:

An instructor icon should be used to indicate an instructor review and this icon should be seen on the review page read by the student. The instrustor review, if completed, should appear as the first column in the reviews for the assignment on the student side. When the student reads an instructor review, it should have the same icon present on the review so the student knows it was completed by an instructor.


Solution:

Modify response.html.erb to distinguish reviews done by the instructor. The existing add-ta-128.png icon file will be used for the instructor icon by removing the green plus ("+") symbol in the image. The logic that is used to build the table of completed reviews will need to check if the review was completed by an instructor. To distinguish an instructor review from a student review, a table will need to be created to track the review_id numbers that are associated with instructor reviews. This option was chosen to avoid modifications to the existing Response database object schema. See the Response page for Expertiza as listed in the references section for more details.


Current Add TA Icon:

Add a TA
Existing Add a TA icon



The icon for Instructor Reviews:

Instructor Review Icon
New Instructor Review Icon









Task 4: (OPTIONAL)

Problem:

Similar to the calibration report from the Design Exercise assignment, create a view that would allow the student reviewers differ from the reviews completed by the course staff.


Solution: Review the code from the Design Exercise calibration assignment. Discuss ideas with the professor (as advised from previous mentor meetings) to form a plan on how to address this task. From the assignment page student_task/view.html.erb add a new link reviewers to the calibration report _calibration_report.html.erb IF they have submitted a review and the instructor has submitted a review to the same assignment.

Test Plan

The following shall be tested:

For a given assignment, If instructor/ta is a participant and the last due date is not past then the submission list should link to "perform review"

For a given assignment, If instructor/ta is a participant and the last due date is past then the submission list should link to "assign grade"

For a given assignment, If instructor/ta is not a participant and the last due date is past then the submission list should link to "assign grade"

For a given assignment, If instructor/ta is not a participant and the last due date is not past then the submission list should link to "assign grade"

A review submitted by an instructor/ta should be accepted like any other review so long as they are a participant and the last submission due date has not passed

Optional: Test optional functionality

References

1. Project Document: https://docs.google.com/document/d/1Ozw2Bj2u_LyeKUdDqAyQtz1stEIKrxkmRnwmNyUgmzw/edit#heading=h.bumi2mscmmgf

2. Github Repo: https://github.com/mblewallncsu/expertiza

3. Previous Work, Project E1824: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Spring_2018-_Project_E1824:_Let_course_staff_as_well_as_students_do_reviews

4. Previous Work, Project E1855: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1855_let_course_staff_as_well_as_students_do_reviews

5. Projected hosted at: http://final.flazzle.com

Team Members

1. Jimmy Boykin

2. Srikara Krishna

3. Michael Lewallen