CSC/ECE 517 Spring 2019/E1927 Let Course Staff as Well as Students Do Reviews: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
No edit summary
No edit summary
Line 37: Line 37:
Modify response.html.erb to distinguish reviews done by the instructor. TBD if the response controller needs modification to deliver this information to the view. Modify the add-ta-128.png icon file to look more like an instructor and add it to the view next to the reviews done by the instructor.
Modify response.html.erb to distinguish reviews done by the instructor. TBD if the response controller needs modification to deliver this information to the view. Modify the add-ta-128.png icon file to look more like an instructor and add it to the view next to the reviews done by the instructor.


[[File:E1927_Add-ta-128.png|alt=Add a TA]] 




<pre>
Current Add TA Icon:
Current Add TA Icon:
[[File:E1927_Add-ta-128.png|alt=Add a TA]]   
[[File:E1927_Add-ta-128.png|alt=Add a TA|Existing Add a TA icon]]   


New Instructor Review Icon:
New Instructor Review Icon:
[[File:E1927_Instructor_Review.png|alt=Instructor Review Icon]]
[[File:E1927_Instructor_Review.png|alt=Instructor Review Icon|]]
</pre>
 


==Task 4: (OPTIONAL)==
==Task 4: (OPTIONAL)==

Revision as of 20:55, 12 April 2019

Problem Summary

In Expertiza, students are able to perform reviews on other students work by filling out a review form on Expertiza. Instructors and TAs for the course should be able to submit a review in the same manner as a student. Only instructors or TAs who are participants in the assignment should be allowed to leave reviews. However, the instructor and TA reviews should be distinguished from other student reviews so the student knows the review was written by the instructor.

Current Functionality

Project Tasks

Task 1:

Problem:

Each submission on the submissions page should link to "perform review" instead of "assign grade" iff [the instructor/ta is a participant of the assignment and the last due date for the assignment has not passed]


Solution: list_submissions_html.erb should be modified to change the link as noted above. TBD if controller changes in assignment_controler are needed to get due date information and participant information to the view.

Task 2:

Problem:

Review page should allow instructor/TA to submit review if they are a participant of the assignment and the last due date hasn't passed

Solution:

Check response.html.erb to make sure there aren't any restrictions preventing instructor/ta from submitting reviews if they meet the criteria above. Existing logic may assume all reviewers are student. TBD if any modifications to response_controller is necessary to enable this functionality.

Task 3:

Problem:

An instructor icon should be used to indicate an instructor review and this icon should be seen on the review page read by the student.


Solution:

Modify response.html.erb to distinguish reviews done by the instructor. TBD if the response controller needs modification to deliver this information to the view. Modify the add-ta-128.png icon file to look more like an instructor and add it to the view next to the reviews done by the instructor.


Current Add TA Icon: Add a TA

New Instructor Review Icon: Instructor Review Icon


Task 4: (OPTIONAL)

Problem:

Similar to the calibration report from the Design Exercise assignment, create a view that would allow the student reviewers differ from the reviews completed by the course staff.


Solution: Review the code from the Design Exercise calibration assignment. Discuss ideas with the professor (as advised from previous mentor meetings) to form a plan on how to address this task. From the assignment page student_task/view.html.erb add a new link reviewers to the calibration report _calibration_report.html.erb IF they have submitted a review and the instructor has submitted a review to the same assignment.

Test Plan

The following shall be tested:

For a given assignment, If instructor/ta is a participant and the last due date is not past then the submission list should link to "perform review"

For a given assignment, If instructor/ta is a participant and the last due date is past then the submission list should link to "assign grade"

For a given assignment, If instructor/ta is not a participant and the last due date is past then the submission list should link to "assign grade"

For a given assignment, If instructor/ta is not a participant and the last due date is not past then the submission list should link to "assign grade"

A review submitted by an instructor/ta should be accepted like any other review so long as they are a participant and the last submission due date has not passed

Optional: Test optional functionality

References

1. Project Document: https://docs.google.com/document/d/1Ozw2Bj2u_LyeKUdDqAyQtz1stEIKrxkmRnwmNyUgmzw/edit#heading=h.bumi2mscmmgf

2. Github Repo: https://github.com/mblewallncsu/expertiza

3. Previous Work, Project E1824: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Spring_2018-_Project_E1824:_Let_course_staff_as_well_as_students_do_reviews

4. Previous Work, Project E1855: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2018/E1855_let_course_staff_as_well_as_students_do_reviews

5. Projected hosted at: http://final.flazzle.com

Team Members

1. Jimmy Boykin

2. Srikara Krishna

3. Michael Lewallen