CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
Line 15: Line 15:


===Tasks Identified===
===Tasks Identified===
* Refactor edit and update method
* Remove irrelevant comments from the create action.
* associate_assignment_with_course and remove_assignment_from_course logic should be moved to model.
* Change to new redirect method rather using controller and action explicitly.
* Refactor the update_due_dates from Assignment Form. using the DRY principle
* Refactor code to follow the ruby style guide and Rails4 syntax.


* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.

Revision as of 03:07, 6 November 2018

Introduction

Background

Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

Motivation

In current system the author feedback is send by individual team members. It would be better if one team send one single rejoinder to the review and all members could see and edit it. Also there are real usability issues with regards to how students can even navigate to the place where feedback can be given to reviewers. The UI needs to be more user friendly.

In Summary report for assignment for instructors, the author feedback section lists feedback from all team members. You should change this to list the team’s collective feedback to its reviewers to a particular assignment

Tasks Identified

  • Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
  • Refactor all the actions in response controllers to pass the participant id.
  • Refactor author feedback tab in summary report view for the instructor.
  • Change in the summary report of assignment for the instructor to display teams feedbacks.
  • In the author-feedback tab on the heat grid, fixed reviewers names on top row.
  • Summary reports navigation to the page where feedbacks are given to reviewers.


Classes

1.Team rejoinder.

  • controllers/response_controller.rb
  • views/grades/_reviews.html.erb
  • views/response/response.html.erb
  • models/vm_question_response.rb
  • models/assignment_participant.rb

2.Navigation Issue fixes

  • views/response/view.html.erb

3.Author feedback tab of summary report:

  • models/response_map.rb
  • models/team.rb
  • helpers/grades_helper.rb
  • views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:

  • views/grades/_view_heatgrid.html.erb

Solutions Implemented and Delivered

  • Changed per participant feedback display author feedback view to per team:

  • Added "give feedback" and edit feedback functionality in the review view.

  • Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.

  • Refactored new_feedback method to add team ID as the reviewer Id in the response map.

  • Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.

So added a new method which will return a feedback assessment.

Testing

Fixed the existed test cases for the fixes we made.

Retrieved from "https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Fall_2018_E1832._OSS_Project_Orange:_Author_feedback_(rejoinder)_enhancements&oldid=118700"