CSC/ECE 517 Fall 2014/oss E1456 akk: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
Line 6: Line 6:
Questionnaire Controller interacts with the user to create and edit questionnaires such as review rubrics, teammate-feedback rubrics, quizzes, and surveys. This page provides a detailed description of Open Source Project on Expertiza for refactoring the questionnaire controller.
Questionnaire Controller interacts with the user to create and edit questionnaires such as review rubrics, teammate-feedback rubrics, quizzes, and surveys. This page provides a detailed description of Open Source Project on Expertiza for refactoring the questionnaire controller.


=Description=
=Project Overview=
 
==Classes involved==
questionnaire_controller.rb
questionnaire_helper.rb
 
==Changes made==
*Functionality moved to quiz_questionnaire.rb.
*edit_advice method was not being used, so it was removed.
*save_advice moved to the advice_controller.
*copy, update_quiz, valid_quiz methods were long and have been broken up.  clone_questionnaire_details was also broken up and renamed.
*Added comments to select_questionnaire_type
*Debug output (print statements) have been removed.
*Changed code to follow the global rules.
*save_new_questions, delete_questions, save_questions have been moved to a separate class.

Revision as of 18:48, 26 October 2014

Refactoring Questionnaire Controller

Introduction

Questionnaire Controller interacts with the user to create and edit questionnaires such as review rubrics, teammate-feedback rubrics, quizzes, and surveys. This page provides a detailed description of Open Source Project on Expertiza for refactoring the questionnaire controller.

Project Overview

Classes involved

questionnaire_controller.rb questionnaire_helper.rb

Changes made

  • Functionality moved to quiz_questionnaire.rb.
  • edit_advice method was not being used, so it was removed.
  • save_advice moved to the advice_controller.
  • copy, update_quiz, valid_quiz methods were long and have been broken up. clone_questionnaire_details was also broken up and renamed.
  • Added comments to select_questionnaire_type
  • Debug output (print statements) have been removed.
  • Changed code to follow the global rules.
  • save_new_questions, delete_questions, save_questions have been moved to a separate class.