CSC/ECE 517 Fall 2013/oss E814 vd: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
Line 5: Line 5:
*[https://codeclimate.com/github/vermavikrant/expertiza/GraphGenerator Code Climate analysis of refactored file]
*[https://codeclimate.com/github/vermavikrant/expertiza/GraphGenerator Code Climate analysis of refactored file]
*[https://codeclimate.com/github/expertiza/expertiza/GraphGenerator Code Climate analysis of original file]
*[https://codeclimate.com/github/expertiza/expertiza/GraphGenerator Code Climate analysis of original file]
*[https://github.com/vermavikrant/expertiza Github repository for refactored project]
*[http://152.46.18.78:3000/ VCL location]
==Changes by Method==
==Changes by Method==
===generate_graph===
===generate_graph===

Revision as of 21:05, 30 October 2013

Expertiza is a web application that supports peer-review for a variety of entities. As it is still evolving, expertiza has several areas that require work. Among these include areas that require refactoring existing code to improve code quality. The graph_generator.rb file is one such area. This write-up describes our refactoring decisions for this file.

Background

Resources

Changes by Method

generate_graph

tagged_token_check

The first change that can be seen within this method is the extracting of code that adds on to a previous vertex or creates a new one, all based upon the part of speech defined of the tokens encountered while parsing the review. We called our extracted method tagged_token_check. BY extracting this method, we were able to reduce duplication (since such similar code occurred four times in the method for tokens that are nouns, adjectives, adverbs, and verbs. Since the code contained nested if statements, we also were able to reduce the complexity of the method. Screenshots of the code before and after refactoring are included below. The top picture is the code before refactoring, the middle is the code after, and the bottom is the code within the extracted method.









update_pos_property

The next change in generate_graph








pos_edge_processing









add_nonexisting_edge




remove_redundant_edges

find_redundant_edges

search_edges

search_edges_to_set_null

print_graph

find_parents

set_semantic_labels_for_edges

Results







Appendix

Issues

References