CSC/ECE 517 Fall 2013/oss E811 syn: Difference between revisions
Jump to navigation
Jump to search
(Created page with " == E811. Refactor & test submitted_content_controller & submitted_content_helper ==") |
|||
| Line 1: | Line 1: | ||
== E811. Refactor & test submitted_content_controller & submitted_content_helper == | == E811. Refactor & test submitted_content_controller & submitted_content_helper == | ||
Classes: submitted_content_controller.rb (250 lines) | |||
submitted_content_helper.rb (98 lines) | |||
What they do: Allow users to submit files and links to Expertiza. | |||
What needs to be done: The methods are long and complex, and contain a lot of duplicated code. In particular, there are two different ways of submitting files: as a homework submission, and uploading a review file requested by a review rubric. These should use common code as much as possible. The approach to deleting submitted links and submitted files should be analogous. There have been bugs in deleting hyperlinks, so be sure to test the code thoroughly. | |||
Revision as of 03:46, 30 October 2013
E811. Refactor & test submitted_content_controller & submitted_content_helper
Classes: submitted_content_controller.rb (250 lines) submitted_content_helper.rb (98 lines) What they do: Allow users to submit files and links to Expertiza. What needs to be done: The methods are long and complex, and contain a lot of duplicated code. In particular, there are two different ways of submitting files: as a homework submission, and uploading a review file requested by a review rubric. These should use common code as much as possible. The approach to deleting submitted links and submitted files should be analogous. There have been bugs in deleting hyperlinks, so be sure to test the code thoroughly.