CSC/ECE 517 Fall 2021 - E2140. Create new late policy successfully and fix Bank link
E2140. Create new late policy successfully and fix "Back" link
This page provides a description of the Expertiza based OSS project, E1240.
About Expertiza
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the instructor to create new assignments and customize new or existing assignments. It also allows the instructor to create a list of topics the students can sign up for. Students can form teams in Expertiza to work on various projects and assignments. Students can also peer review other students' submissions. Expertiza supports submission across various document types, including the URLs and wiki pages.
Problem Statement
Create new late policy successfull and fix "Back" link.
Fixes performed
- Fix back link on "New late policy" page.
- Fix incorrect flash message on the screen when new late policy is created
- Add controller unit tests for create actions for late_policies_controller
- Add functional test for late policy creation
- Add functional test for back button on new late policy page
- Improve flow of late_policies_controller#edit action for better tests
- Fix late_policies_controller#edit action when it displayed two contradictory flashes
- TODO: SQL stack trace shows up when long string is entered in policy name
- View was checked after a controller test to ensure that the correct message is shown to the user.
- TODO: model was also checked to ensure the database is in a correct state
About Late Policies Controller
This controller can be accessed by editing an assignment, going on "Due Dates" page and clicking on "New late policy".
Files modified in current project
1. app/controllers/late_policies_controller.rb
2. app/views/late_policies/new.html.erb
3. spec/factories/factories.rb
Files added for tests=
1. spec/controllers/late_policies_controller_spec.rb
2. spec/features/late_policy_creation_spec.rb
3. spec/features/late_policy_back_button_spec.rb
Current Implementation
- There were no tests present in beta branch, so tests for the CRUD operations were added.
- Edit action for late_policies_controller is complex to reason about, with booleans deciding whether there are errors.
- Back button does not lead to the assignment from which the new late policy page was created.
Functionality
1.
Drawbacks and Solutions
- Problem 1: Back button was taking user to index of late_policies, and not assignment due dates page
- The back button was performing it's default action of going back to index page of late_policies, but it needs to send user to the assginment page.
Before:
<%= link_to 'Back', :action => 'index' %>
After:
<%= link_to 'Back', edit_assignment_path(session[:edit_assignment]) %>
- Solution: The link_to function is called with the page previous to current page, so it will go to assginment page.
- Use edit_assignment_path(session[:edit_assignment]) to go back to the previous page
- Problem 2: Creating new policy with blank fields does not give a proper error
- The existing code just shows a blank error, without specifying what has gone wrong. Hence, user will not know what is wrong when they created a new policy.
- Solution: The existing error handling code was changed to show the ActiveRecord::Invalid errors to user. And in case, a different exception occurs, a "something went wrong" message is shown, as this exception shouldn't be visible to users.
Before:
rescue StandardError
flash[:error] = "The following error occurred while saving the penalty policy: "
After:
rescue ActiveRecord::RecordInvalid => exception
flash[:error] = exception.record.errors.full_messages.join("<br />").html_safe
redirect_to action: 'new'
rescue StandardError => exception
# In case it's some error, this error should not be shown to users
flash[:error] = "Something went wrong"
- Problem 3: The paginate method can be moved to a helper class.
- VersionsController is not the only component which require to paginate items. There are other components too. For instance, the UsersController has to paginate the list of users. Hence the Paginate method can be moved to a helper class which can be accessed by other components as well.
- Solution: The filtering options has also been enhanced. The current user can now choose as part of the version search filter any user from a list of users if the current user is authorized to see the versions created by that user.
New Implementation
text
- text
- text
Code improvements
- text
- text
Automated Testing using RSPEC
TODO: add this section The current version of expertiza did not have any test for LatePoliciesController. Using the test driven development(TDD) approach, we have added an exhaustive set of RSPEC tests for LatePoliciesController, to test all the modifications we have done to the code of the controller class. The tests use double and stub features of rspec-rails gem, to fake the log in by different users - Administrator, Instructor, Student etc. The tests can be executed "rpec spec" command as shown below.
TODO:: Add execution trace for tests, with time taken, etc