CSC/ECE 517 Fall 2019 - E1996. Enhancements to review grader

From Expertiza_Wiki
Revision as of 22:40, 11 November 2019 by Yshi23 (talk | contribs)
Jump to navigation Jump to search

Background

Problem Statement

The Main review-grader Page

Issue Description

  1. The "Score awarded/average sore" column is supposed to report the score by the current student reviewer in the first round, the average score by all reviewers in the first round, and ditto for the second round. If the number of rounds ≠ 2, then the number of scores should be adjusted appropriately.Fix this problem so that it is populated with the correct numbers.
  2. Those scores would also be displayed with bar graphs, like in the “Metrics” column. It should be modified without making the column much wider, since this page needs to display a lot of information horizontally.
  3. Column width should be adjusted intelligently. In the view shown, “Reviewer”, “Reviews done”, and “Team reviewed” are too wide, whereas “Assign grade and write comments” is too narrow.
  4. Number the rows of the table (e.g., “2. Student 8370”) so it is easy to count the lines. This will help us assign each TA (and the instructor) an equal number of reviews to grade.
  5. Replace the team names with an anonymized version of them. This will help the grader not be biased if (s)he recognizes the team name as belonging to specific students.


Design Strategy

  1. The score which user can see on the website is "-----", which is in the get_each_round_score_awarded_for_review_report function in the review_mapping helper file. The problem is that the review_scores[reviewer_ID] doesn't exist, which should be calculated in the file on_the_fly_calc.rb. The methods in the on_the_fly_calc.rb forget to assign the value to review scores after calculating.
  2. In the _review_report.html.erb file, use method "each_with_index" instead of "each" to get the index of each loop. Then, add "index+1" before the reviewer name since the index starts from 0.
  3. In the _review_report.html.erb file, replace the "team_reviewed_link_name" with randomly generated team names.

Files to be modified

/app/models/on_the_fly_calc.rb
/app/views/reports/_review_report.html.erb

Test Plan

The summary Page

Issue Description

  1. Replace the reviewer name and team names with an anonymized version of them, as done on the main review-grader page.
  2. Checkbox items take up far too much space. Remove duplicated header lines and show just columns of checkboxes to the right of the “questions.” Also, it is unnecessary to prefix each by “[Question]”.
  3. Adjust column width intelligently. The “Reviewee” and “Score” columns are much wider than necessary. The “Comments” column is also too wide for easy reading. So consider how the page might be reorganized to take better advantage of the available space. One option might be to show the comments vertically, astride each other, rather than horizontally, above and below each other. Mock up your proposal and discuss it with your mentor.
  4. Get rid of “Review: Round1”. It should be, “Review Round 1”

Design Strategy

  1. For the reviewer name, replace the "Participant.find(@reviewer_id).fullname" with "Participant.find(@reviewer_id).name" in the view_review_scores_popup.html.erb file.

            For the team names, replace the "team.name" with randomly generated team names.

  1. To get rid of the duplicated header lines, we will modify view_review_scores_popup.html.erb. Change the view so that only the checks are presented to the right of the questions. Also delete the “[Question]” before each questions.
  2. To adjust column width intelligently, we will change the preset width in view_review_scores_popup.heml.erb. 10% for "Reviewee", 5% for "Score" may be reasonable. Also we will try two conmments on same role or show the comments vertically and see which way is better.
  3. We located the "Review Round" header in review_response_map.rb.

Files to be modified

/app/views/popup/view_review_scores_popup.html.erb view_review_scores_popup.html.erb review_response_map.rb

Test Plan