CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

From Expertiza_Wiki
Jump to navigation Jump to search

Problem statement

Issue1

Issue Description

When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

Design strategy

Test Plan

  • Log in as instructor6, click on manage...-> Assignments
  • Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
  • Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
  • Navigate back to Assignment Tree View and click on "Add participant"
  • Add couple of students(say student1 and student2) to the assignment
  • Impersonate/login as student1 and make a submission
  • Impersonate/login as student2 and Request for a new review under others work, submit the review
  • Impersonate/login back as student1 and Request for a new meta review
  • When Begin is clicked following will be displayed
  • A template must be added to fix the broken link

    Files to be modified

    response.html.erb

    Issue2

    Issue Description

    The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

    Design strategy

    Test Plan

  • Log in as instructor6, click on mange...-> Assignments
  • Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
  • Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
  • Navigate back to Assignment Tree View and click on "Add participant"
  • Add couple of students(say student1 and student2) to the assignment
  • Impersonate/login as student1 and make a submission
  • Impersonate/login as student2 and Request for a new review under others work, submit the review
  • Impersonate/login back as student1 and Request for a new meta review
  • When Begin is clicked, the meta-review count should be decremented

    Files to be modified

  • List.html.erb
    alt text

    Issue3

    Issue Description

    For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

    As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

    Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

    Design strategy

    A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

    This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

    In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

    Pictorial representation of above explanation

    Test Plan

    1. Ensure that when an assignment is created, the number of meta reviews is set to null. 2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

    Files to be modified

    1. _review_strategy.html.erb Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

    2. _due_dates.html.erb Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

    3. assignments_controller.rb Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

    • Retrieved from "https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Fall_2019_-_E1997._Issues_related_to_meta-reviewing&oldid=128754"